drm_atomic.c 50.8 KB
Newer Older
D
Daniel Vetter 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30
/*
 * Copyright (C) 2014 Red Hat
 * Copyright (C) 2014 Intel Corp.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
 * OTHER DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 * Rob Clark <robdclark@gmail.com>
 * Daniel Vetter <daniel.vetter@ffwll.ch>
 */


#include <drm/drmP.h>
#include <drm/drm_atomic.h>
31
#include <drm/drm_mode.h>
D
Daniel Vetter 已提交
32 33
#include <drm/drm_plane_helper.h>

34 35
#include "drm_crtc_internal.h"

36 37 38 39 40 41 42 43 44 45 46 47 48 49
static void crtc_commit_free(struct kref *kref)
{
	struct drm_crtc_commit *commit =
		container_of(kref, struct drm_crtc_commit, ref);

	kfree(commit);
}

void drm_crtc_commit_put(struct drm_crtc_commit *commit)
{
	kref_put(&commit->ref, crtc_commit_free);
}
EXPORT_SYMBOL(drm_crtc_commit_put);

50 51 52 53 54 55 56 57 58
/**
 * drm_atomic_state_default_release -
 * release memory initialized by drm_atomic_state_init
 * @state: atomic state
 *
 * Free all the memory allocated by drm_atomic_state_init.
 * This is useful for drivers that subclass the atomic state.
 */
void drm_atomic_state_default_release(struct drm_atomic_state *state)
D
Daniel Vetter 已提交
59 60 61 62 63
{
	kfree(state->connectors);
	kfree(state->crtcs);
	kfree(state->planes);
}
64
EXPORT_SYMBOL(drm_atomic_state_default_release);
D
Daniel Vetter 已提交
65 66

/**
67
 * drm_atomic_state_init - init new atomic state
D
Daniel Vetter 已提交
68
 * @dev: DRM device
69
 * @state: atomic state
D
Daniel Vetter 已提交
70
 *
71 72
 * Default implementation for filling in a new atomic state.
 * This is useful for drivers that subclass the atomic state.
D
Daniel Vetter 已提交
73
 */
74 75
int
drm_atomic_state_init(struct drm_device *dev, struct drm_atomic_state *state)
D
Daniel Vetter 已提交
76
{
R
Rob Clark 已提交
77 78 79 80 81
	/* TODO legacy paths should maybe do a better job about
	 * setting this appropriately?
	 */
	state->allow_modeset = true;

D
Daniel Vetter 已提交
82 83 84 85 86 87 88 89 90 91 92
	state->crtcs = kcalloc(dev->mode_config.num_crtc,
			       sizeof(*state->crtcs), GFP_KERNEL);
	if (!state->crtcs)
		goto fail;
	state->planes = kcalloc(dev->mode_config.num_total_plane,
				sizeof(*state->planes), GFP_KERNEL);
	if (!state->planes)
		goto fail;

	state->dev = dev;

93
	DRM_DEBUG_ATOMIC("Allocated atomic state %p\n", state);
D
Daniel Vetter 已提交
94

95
	return 0;
D
Daniel Vetter 已提交
96
fail:
97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123
	drm_atomic_state_default_release(state);
	return -ENOMEM;
}
EXPORT_SYMBOL(drm_atomic_state_init);

/**
 * drm_atomic_state_alloc - allocate atomic state
 * @dev: DRM device
 *
 * This allocates an empty atomic state to track updates.
 */
struct drm_atomic_state *
drm_atomic_state_alloc(struct drm_device *dev)
{
	struct drm_mode_config *config = &dev->mode_config;
	struct drm_atomic_state *state;

	if (!config->funcs->atomic_state_alloc) {
		state = kzalloc(sizeof(*state), GFP_KERNEL);
		if (!state)
			return NULL;
		if (drm_atomic_state_init(dev, state) < 0) {
			kfree(state);
			return NULL;
		}
		return state;
	}
D
Daniel Vetter 已提交
124

125
	return config->funcs->atomic_state_alloc(dev);
D
Daniel Vetter 已提交
126 127 128 129
}
EXPORT_SYMBOL(drm_atomic_state_alloc);

/**
130
 * drm_atomic_state_default_clear - clear base atomic state
D
Daniel Vetter 已提交
131 132
 * @state: atomic state
 *
133 134
 * Default implementation for clearing atomic state.
 * This is useful for drivers that subclass the atomic state.
D
Daniel Vetter 已提交
135
 */
136
void drm_atomic_state_default_clear(struct drm_atomic_state *state)
D
Daniel Vetter 已提交
137 138
{
	struct drm_device *dev = state->dev;
139
	struct drm_mode_config *config = &dev->mode_config;
D
Daniel Vetter 已提交
140 141
	int i;

D
Daniel Vetter 已提交
142
	DRM_DEBUG_ATOMIC("Clearing atomic state %p\n", state);
D
Daniel Vetter 已提交
143

144
	for (i = 0; i < state->num_connector; i++) {
145
		struct drm_connector *connector = state->connectors[i].ptr;
D
Daniel Vetter 已提交
146 147 148 149

		if (!connector)
			continue;

150
		connector->funcs->atomic_destroy_state(connector,
151 152 153
						       state->connectors[i].state);
		state->connectors[i].ptr = NULL;
		state->connectors[i].state = NULL;
154
		drm_connector_unreference(connector);
D
Daniel Vetter 已提交
155 156
	}

157
	for (i = 0; i < config->num_crtc; i++) {
158
		struct drm_crtc *crtc = state->crtcs[i].ptr;
D
Daniel Vetter 已提交
159 160 161 162 163

		if (!crtc)
			continue;

		crtc->funcs->atomic_destroy_state(crtc,
164
						  state->crtcs[i].state);
165 166 167 168 169 170 171 172

		if (state->crtcs[i].commit) {
			kfree(state->crtcs[i].commit->event);
			state->crtcs[i].commit->event = NULL;
			drm_crtc_commit_put(state->crtcs[i].commit);
		}

		state->crtcs[i].commit = NULL;
173 174
		state->crtcs[i].ptr = NULL;
		state->crtcs[i].state = NULL;
D
Daniel Vetter 已提交
175 176
	}

177
	for (i = 0; i < config->num_total_plane; i++) {
178
		struct drm_plane *plane = state->planes[i].ptr;
D
Daniel Vetter 已提交
179 180 181 182 183

		if (!plane)
			continue;

		plane->funcs->atomic_destroy_state(plane,
184 185 186
						   state->planes[i].state);
		state->planes[i].ptr = NULL;
		state->planes[i].state = NULL;
D
Daniel Vetter 已提交
187 188
	}
}
189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214
EXPORT_SYMBOL(drm_atomic_state_default_clear);

/**
 * drm_atomic_state_clear - clear state object
 * @state: atomic state
 *
 * When the w/w mutex algorithm detects a deadlock we need to back off and drop
 * all locks. So someone else could sneak in and change the current modeset
 * configuration. Which means that all the state assembled in @state is no
 * longer an atomic update to the current state, but to some arbitrary earlier
 * state. Which could break assumptions the driver's ->atomic_check likely
 * relies on.
 *
 * Hence we must clear all cached state and completely start over, using this
 * function.
 */
void drm_atomic_state_clear(struct drm_atomic_state *state)
{
	struct drm_device *dev = state->dev;
	struct drm_mode_config *config = &dev->mode_config;

	if (config->funcs->atomic_state_clear)
		config->funcs->atomic_state_clear(state);
	else
		drm_atomic_state_default_clear(state);
}
D
Daniel Vetter 已提交
215 216 217 218 219 220 221 222 223 224 225
EXPORT_SYMBOL(drm_atomic_state_clear);

/**
 * drm_atomic_state_free - free all memory for an atomic state
 * @state: atomic state to deallocate
 *
 * This frees all memory associated with an atomic state, including all the
 * per-object state for planes, crtcs and connectors.
 */
void drm_atomic_state_free(struct drm_atomic_state *state)
{
226 227 228
	struct drm_device *dev;
	struct drm_mode_config *config;

229 230 231
	if (!state)
		return;

232 233 234
	dev = state->dev;
	config = &dev->mode_config;

D
Daniel Vetter 已提交
235 236
	drm_atomic_state_clear(state);

D
Daniel Vetter 已提交
237
	DRM_DEBUG_ATOMIC("Freeing atomic state %p\n", state);
D
Daniel Vetter 已提交
238

239 240 241 242 243 244
	if (config->funcs->atomic_state_free) {
		config->funcs->atomic_state_free(state);
	} else {
		drm_atomic_state_default_release(state);
		kfree(state);
	}
D
Daniel Vetter 已提交
245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266
}
EXPORT_SYMBOL(drm_atomic_state_free);

/**
 * drm_atomic_get_crtc_state - get crtc state
 * @state: global atomic state object
 * @crtc: crtc to get state object for
 *
 * This function returns the crtc state for the given crtc, allocating it if
 * needed. It will also grab the relevant crtc lock to make sure that the state
 * is consistent.
 *
 * Returns:
 *
 * Either the allocated state or the error code encoded into the pointer. When
 * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
 * entire atomic sequence must be restarted. All other errors are fatal.
 */
struct drm_crtc_state *
drm_atomic_get_crtc_state(struct drm_atomic_state *state,
			  struct drm_crtc *crtc)
{
267
	int ret, index = drm_crtc_index(crtc);
D
Daniel Vetter 已提交
268 269
	struct drm_crtc_state *crtc_state;

270 271
	WARN_ON(!state->acquire_ctx);

272 273 274
	crtc_state = drm_atomic_get_existing_crtc_state(state, crtc);
	if (crtc_state)
		return crtc_state;
D
Daniel Vetter 已提交
275 276 277 278 279 280 281 282 283

	ret = drm_modeset_lock(&crtc->mutex, state->acquire_ctx);
	if (ret)
		return ERR_PTR(ret);

	crtc_state = crtc->funcs->atomic_duplicate_state(crtc);
	if (!crtc_state)
		return ERR_PTR(-ENOMEM);

284 285
	state->crtcs[index].state = crtc_state;
	state->crtcs[index].ptr = crtc;
D
Daniel Vetter 已提交
286 287
	crtc_state->state = state;

288 289
	DRM_DEBUG_ATOMIC("Added [CRTC:%d:%s] %p state to %p\n",
			 crtc->base.id, crtc->name, crtc_state, state);
D
Daniel Vetter 已提交
290 291 292 293 294

	return crtc_state;
}
EXPORT_SYMBOL(drm_atomic_get_crtc_state);

295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
/**
 * drm_atomic_set_mode_for_crtc - set mode for CRTC
 * @state: the CRTC whose incoming state to update
 * @mode: kernel-internal mode to use for the CRTC, or NULL to disable
 *
 * Set a mode (originating from the kernel) on the desired CRTC state. Does
 * not change any other state properties, including enable, active, or
 * mode_changed.
 *
 * RETURNS:
 * Zero on success, error code on failure. Cannot return -EDEADLK.
 */
int drm_atomic_set_mode_for_crtc(struct drm_crtc_state *state,
				 struct drm_display_mode *mode)
{
310 311
	struct drm_mode_modeinfo umode;

312 313 314 315
	/* Early return for no change. */
	if (mode && memcmp(&state->mode, mode, sizeof(*mode)) == 0)
		return 0;

316
	drm_property_unreference_blob(state->mode_blob);
317 318
	state->mode_blob = NULL;

319
	if (mode) {
320 321 322 323 324 325 326 327
		drm_mode_convert_to_umode(&umode, mode);
		state->mode_blob =
			drm_property_create_blob(state->crtc->dev,
		                                 sizeof(umode),
		                                 &umode);
		if (IS_ERR(state->mode_blob))
			return PTR_ERR(state->mode_blob);

328 329 330 331 332 333 334 335 336 337 338 339 340 341 342
		drm_mode_copy(&state->mode, mode);
		state->enable = true;
		DRM_DEBUG_ATOMIC("Set [MODE:%s] for CRTC state %p\n",
				 mode->name, state);
	} else {
		memset(&state->mode, 0, sizeof(state->mode));
		state->enable = false;
		DRM_DEBUG_ATOMIC("Set [NOMODE] for CRTC state %p\n",
				 state);
	}

	return 0;
}
EXPORT_SYMBOL(drm_atomic_set_mode_for_crtc);

D
Daniel Stone 已提交
343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361
/**
 * drm_atomic_set_mode_prop_for_crtc - set mode for CRTC
 * @state: the CRTC whose incoming state to update
 * @blob: pointer to blob property to use for mode
 *
 * Set a mode (originating from a blob property) on the desired CRTC state.
 * This function will take a reference on the blob property for the CRTC state,
 * and release the reference held on the state's existing mode property, if any
 * was set.
 *
 * RETURNS:
 * Zero on success, error code on failure. Cannot return -EDEADLK.
 */
int drm_atomic_set_mode_prop_for_crtc(struct drm_crtc_state *state,
                                      struct drm_property_blob *blob)
{
	if (blob == state->mode_blob)
		return 0;

362
	drm_property_unreference_blob(state->mode_blob);
D
Daniel Stone 已提交
363 364
	state->mode_blob = NULL;

365 366
	memset(&state->mode, 0, sizeof(state->mode));

D
Daniel Stone 已提交
367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387
	if (blob) {
		if (blob->length != sizeof(struct drm_mode_modeinfo) ||
		    drm_mode_convert_umode(&state->mode,
		                           (const struct drm_mode_modeinfo *)
		                            blob->data))
			return -EINVAL;

		state->mode_blob = drm_property_reference_blob(blob);
		state->enable = true;
		DRM_DEBUG_ATOMIC("Set [MODE:%s] for CRTC state %p\n",
				 state->mode.name, state);
	} else {
		state->enable = false;
		DRM_DEBUG_ATOMIC("Set [NOMODE] for CRTC state %p\n",
				 state);
	}

	return 0;
}
EXPORT_SYMBOL(drm_atomic_set_mode_prop_for_crtc);

388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406
/**
 * drm_atomic_replace_property_blob - replace a blob property
 * @blob: a pointer to the member blob to be replaced
 * @new_blob: the new blob to replace with
 * @replaced: whether the blob has been replaced
 *
 * RETURNS:
 * Zero on success, error code on failure
 */
static void
drm_atomic_replace_property_blob(struct drm_property_blob **blob,
				 struct drm_property_blob *new_blob,
				 bool *replaced)
{
	struct drm_property_blob *old_blob = *blob;

	if (old_blob == new_blob)
		return;

407
	drm_property_unreference_blob(old_blob);
408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438
	if (new_blob)
		drm_property_reference_blob(new_blob);
	*blob = new_blob;
	*replaced = true;

	return;
}

static int
drm_atomic_replace_property_blob_from_id(struct drm_crtc *crtc,
					 struct drm_property_blob **blob,
					 uint64_t blob_id,
					 ssize_t expected_size,
					 bool *replaced)
{
	struct drm_device *dev = crtc->dev;
	struct drm_property_blob *new_blob = NULL;

	if (blob_id != 0) {
		new_blob = drm_property_lookup_blob(dev, blob_id);
		if (new_blob == NULL)
			return -EINVAL;
		if (expected_size > 0 && expected_size != new_blob->length)
			return -EINVAL;
	}

	drm_atomic_replace_property_blob(blob, new_blob, replaced);

	return 0;
}

R
Rob Clark 已提交
439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458
/**
 * drm_atomic_crtc_set_property - set property on CRTC
 * @crtc: the drm CRTC to set a property on
 * @state: the state object to update with the new property value
 * @property: the property to set
 * @val: the new property value
 *
 * Use this instead of calling crtc->atomic_set_property directly.
 * This function handles generic/core properties and calls out to
 * driver's ->atomic_set_property() for driver properties.  To ensure
 * consistent behavior you must call this function rather than the
 * driver hook directly.
 *
 * RETURNS:
 * Zero on success, error code on failure
 */
int drm_atomic_crtc_set_property(struct drm_crtc *crtc,
		struct drm_crtc_state *state, struct drm_property *property,
		uint64_t val)
{
459 460
	struct drm_device *dev = crtc->dev;
	struct drm_mode_config *config = &dev->mode_config;
461
	bool replaced = false;
D
Daniel Stone 已提交
462
	int ret;
463

464
	if (property == config->prop_active)
465
		state->active = val;
D
Daniel Stone 已提交
466 467 468 469
	else if (property == config->prop_mode_id) {
		struct drm_property_blob *mode =
			drm_property_lookup_blob(dev, val);
		ret = drm_atomic_set_mode_prop_for_crtc(state, mode);
470
		drm_property_unreference_blob(mode);
D
Daniel Stone 已提交
471
		return ret;
472 473 474 475 476 477
	} else if (property == config->degamma_lut_property) {
		ret = drm_atomic_replace_property_blob_from_id(crtc,
					&state->degamma_lut,
					val,
					-1,
					&replaced);
478
		state->color_mgmt_changed |= replaced;
479 480 481 482 483 484 485
		return ret;
	} else if (property == config->ctm_property) {
		ret = drm_atomic_replace_property_blob_from_id(crtc,
					&state->ctm,
					val,
					sizeof(struct drm_color_ctm),
					&replaced);
486
		state->color_mgmt_changed |= replaced;
487 488 489 490 491 492 493
		return ret;
	} else if (property == config->gamma_lut_property) {
		ret = drm_atomic_replace_property_blob_from_id(crtc,
					&state->gamma_lut,
					val,
					-1,
					&replaced);
494
		state->color_mgmt_changed |= replaced;
495 496
		return ret;
	} else if (crtc->funcs->atomic_set_property)
R
Rob Clark 已提交
497
		return crtc->funcs->atomic_set_property(crtc, state, property, val);
498 499 500 501
	else
		return -EINVAL;

	return 0;
R
Rob Clark 已提交
502 503 504
}
EXPORT_SYMBOL(drm_atomic_crtc_set_property);

505 506 507 508 509 510 511
/**
 * drm_atomic_crtc_get_property - get property value from CRTC state
 * @crtc: the drm CRTC to set a property on
 * @state: the state object to get the property value from
 * @property: the property to set
 * @val: return location for the property value
 *
R
Rob Clark 已提交
512 513 514 515
 * This function handles generic/core properties and calls out to
 * driver's ->atomic_get_property() for driver properties.  To ensure
 * consistent behavior you must call this function rather than the
 * driver hook directly.
516 517 518
 *
 * RETURNS:
 * Zero on success, error code on failure
R
Rob Clark 已提交
519
 */
520 521
static int
drm_atomic_crtc_get_property(struct drm_crtc *crtc,
R
Rob Clark 已提交
522 523 524
		const struct drm_crtc_state *state,
		struct drm_property *property, uint64_t *val)
{
525 526 527 528 529
	struct drm_device *dev = crtc->dev;
	struct drm_mode_config *config = &dev->mode_config;

	if (property == config->prop_active)
		*val = state->active;
D
Daniel Stone 已提交
530 531
	else if (property == config->prop_mode_id)
		*val = (state->mode_blob) ? state->mode_blob->base.id : 0;
532 533 534 535 536 537
	else if (property == config->degamma_lut_property)
		*val = (state->degamma_lut) ? state->degamma_lut->base.id : 0;
	else if (property == config->ctm_property)
		*val = (state->ctm) ? state->ctm->base.id : 0;
	else if (property == config->gamma_lut_property)
		*val = (state->gamma_lut) ? state->gamma_lut->base.id : 0;
538
	else if (crtc->funcs->atomic_get_property)
R
Rob Clark 已提交
539
		return crtc->funcs->atomic_get_property(crtc, state, property, val);
540 541 542 543
	else
		return -EINVAL;

	return 0;
R
Rob Clark 已提交
544 545
}

R
Rob Clark 已提交
546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565
/**
 * drm_atomic_crtc_check - check crtc state
 * @crtc: crtc to check
 * @state: crtc state to check
 *
 * Provides core sanity checks for crtc state.
 *
 * RETURNS:
 * Zero on success, error code on failure
 */
static int drm_atomic_crtc_check(struct drm_crtc *crtc,
		struct drm_crtc_state *state)
{
	/* NOTE: we explicitly don't enforce constraints such as primary
	 * layer covering entire screen, since that is something we want
	 * to allow (on hw that supports it).  For hw that does not, it
	 * should be checked in driver's crtc->atomic_check() vfunc.
	 *
	 * TODO: Add generic modeset state checks once we support those.
	 */
566 567

	if (state->active && !state->enable) {
568 569
		DRM_DEBUG_ATOMIC("[CRTC:%d:%s] active without enabled\n",
				 crtc->base.id, crtc->name);
570 571 572
		return -EINVAL;
	}

573 574 575 576 577
	/* The state->enable vs. state->mode_blob checks can be WARN_ON,
	 * as this is a kernel-internal detail that userspace should never
	 * be able to trigger. */
	if (drm_core_check_feature(crtc->dev, DRIVER_ATOMIC) &&
	    WARN_ON(state->enable && !state->mode_blob)) {
578 579
		DRM_DEBUG_ATOMIC("[CRTC:%d:%s] enabled without mode blob\n",
				 crtc->base.id, crtc->name);
580 581 582 583 584
		return -EINVAL;
	}

	if (drm_core_check_feature(crtc->dev, DRIVER_ATOMIC) &&
	    WARN_ON(!state->enable && state->mode_blob)) {
585 586
		DRM_DEBUG_ATOMIC("[CRTC:%d:%s] disabled with mode blob\n",
				 crtc->base.id, crtc->name);
587 588 589
		return -EINVAL;
	}

590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605
	/*
	 * Reject event generation for when a CRTC is off and stays off.
	 * It wouldn't be hard to implement this, but userspace has a track
	 * record of happily burning through 100% cpu (or worse, crash) when the
	 * display pipe is suspended. To avoid all that fun just reject updates
	 * that ask for events since likely that indicates a bug in the
	 * compositor's drawing loop. This is consistent with the vblank IOCTL
	 * and legacy page_flip IOCTL which also reject service on a disabled
	 * pipe.
	 */
	if (state->event && !state->active && !crtc->state->active) {
		DRM_DEBUG_ATOMIC("[CRTC:%d] requesting event but off\n",
				 crtc->base.id);
		return -EINVAL;
	}

R
Rob Clark 已提交
606 607 608
	return 0;
}

D
Daniel Vetter 已提交
609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627
/**
 * drm_atomic_get_plane_state - get plane state
 * @state: global atomic state object
 * @plane: plane to get state object for
 *
 * This function returns the plane state for the given plane, allocating it if
 * needed. It will also grab the relevant plane lock to make sure that the state
 * is consistent.
 *
 * Returns:
 *
 * Either the allocated state or the error code encoded into the pointer. When
 * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
 * entire atomic sequence must be restarted. All other errors are fatal.
 */
struct drm_plane_state *
drm_atomic_get_plane_state(struct drm_atomic_state *state,
			  struct drm_plane *plane)
{
628
	int ret, index = drm_plane_index(plane);
D
Daniel Vetter 已提交
629 630
	struct drm_plane_state *plane_state;

631 632
	WARN_ON(!state->acquire_ctx);

633 634 635
	plane_state = drm_atomic_get_existing_plane_state(state, plane);
	if (plane_state)
		return plane_state;
D
Daniel Vetter 已提交
636

D
Daniel Vetter 已提交
637
	ret = drm_modeset_lock(&plane->mutex, state->acquire_ctx);
D
Daniel Vetter 已提交
638 639 640 641 642 643 644
	if (ret)
		return ERR_PTR(ret);

	plane_state = plane->funcs->atomic_duplicate_state(plane);
	if (!plane_state)
		return ERR_PTR(-ENOMEM);

645 646
	state->planes[index].state = plane_state;
	state->planes[index].ptr = plane;
D
Daniel Vetter 已提交
647 648
	plane_state->state = state;

649 650
	DRM_DEBUG_ATOMIC("Added [PLANE:%d:%s] %p state to %p\n",
			 plane->base.id, plane->name, plane_state, state);
D
Daniel Vetter 已提交
651 652 653 654 655 656 657 658 659 660 661 662 663 664

	if (plane_state->crtc) {
		struct drm_crtc_state *crtc_state;

		crtc_state = drm_atomic_get_crtc_state(state,
						       plane_state->crtc);
		if (IS_ERR(crtc_state))
			return ERR_CAST(crtc_state);
	}

	return plane_state;
}
EXPORT_SYMBOL(drm_atomic_get_plane_state);

R
Rob Clark 已提交
665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684
/**
 * drm_atomic_plane_set_property - set property on plane
 * @plane: the drm plane to set a property on
 * @state: the state object to update with the new property value
 * @property: the property to set
 * @val: the new property value
 *
 * Use this instead of calling plane->atomic_set_property directly.
 * This function handles generic/core properties and calls out to
 * driver's ->atomic_set_property() for driver properties.  To ensure
 * consistent behavior you must call this function rather than the
 * driver hook directly.
 *
 * RETURNS:
 * Zero on success, error code on failure
 */
int drm_atomic_plane_set_property(struct drm_plane *plane,
		struct drm_plane_state *state, struct drm_property *property,
		uint64_t val)
{
R
Rob Clark 已提交
685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711
	struct drm_device *dev = plane->dev;
	struct drm_mode_config *config = &dev->mode_config;

	if (property == config->prop_fb_id) {
		struct drm_framebuffer *fb = drm_framebuffer_lookup(dev, val);
		drm_atomic_set_fb_for_plane(state, fb);
		if (fb)
			drm_framebuffer_unreference(fb);
	} else if (property == config->prop_crtc_id) {
		struct drm_crtc *crtc = drm_crtc_find(dev, val);
		return drm_atomic_set_crtc_for_plane(state, crtc);
	} else if (property == config->prop_crtc_x) {
		state->crtc_x = U642I64(val);
	} else if (property == config->prop_crtc_y) {
		state->crtc_y = U642I64(val);
	} else if (property == config->prop_crtc_w) {
		state->crtc_w = val;
	} else if (property == config->prop_crtc_h) {
		state->crtc_h = val;
	} else if (property == config->prop_src_x) {
		state->src_x = val;
	} else if (property == config->prop_src_y) {
		state->src_y = val;
	} else if (property == config->prop_src_w) {
		state->src_w = val;
	} else if (property == config->prop_src_h) {
		state->src_h = val;
712 713
	} else if (property == config->rotation_property) {
		state->rotation = val;
714 715
	} else if (property == plane->zpos_property) {
		state->zpos = val;
R
Rob Clark 已提交
716 717 718 719 720 721 722 723
	} else if (plane->funcs->atomic_set_property) {
		return plane->funcs->atomic_set_property(plane, state,
				property, val);
	} else {
		return -EINVAL;
	}

	return 0;
R
Rob Clark 已提交
724 725 726
}
EXPORT_SYMBOL(drm_atomic_plane_set_property);

727 728 729 730 731 732 733
/**
 * drm_atomic_plane_get_property - get property value from plane state
 * @plane: the drm plane to set a property on
 * @state: the state object to get the property value from
 * @property: the property to set
 * @val: return location for the property value
 *
R
Rob Clark 已提交
734 735 736 737
 * This function handles generic/core properties and calls out to
 * driver's ->atomic_get_property() for driver properties.  To ensure
 * consistent behavior you must call this function rather than the
 * driver hook directly.
738 739 740
 *
 * RETURNS:
 * Zero on success, error code on failure
R
Rob Clark 已提交
741
 */
742 743
static int
drm_atomic_plane_get_property(struct drm_plane *plane,
R
Rob Clark 已提交
744 745 746
		const struct drm_plane_state *state,
		struct drm_property *property, uint64_t *val)
{
R
Rob Clark 已提交
747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769
	struct drm_device *dev = plane->dev;
	struct drm_mode_config *config = &dev->mode_config;

	if (property == config->prop_fb_id) {
		*val = (state->fb) ? state->fb->base.id : 0;
	} else if (property == config->prop_crtc_id) {
		*val = (state->crtc) ? state->crtc->base.id : 0;
	} else if (property == config->prop_crtc_x) {
		*val = I642U64(state->crtc_x);
	} else if (property == config->prop_crtc_y) {
		*val = I642U64(state->crtc_y);
	} else if (property == config->prop_crtc_w) {
		*val = state->crtc_w;
	} else if (property == config->prop_crtc_h) {
		*val = state->crtc_h;
	} else if (property == config->prop_src_x) {
		*val = state->src_x;
	} else if (property == config->prop_src_y) {
		*val = state->src_y;
	} else if (property == config->prop_src_w) {
		*val = state->src_w;
	} else if (property == config->prop_src_h) {
		*val = state->src_h;
770 771
	} else if (property == config->rotation_property) {
		*val = state->rotation;
772 773
	} else if (property == plane->zpos_property) {
		*val = state->zpos;
R
Rob Clark 已提交
774
	} else if (plane->funcs->atomic_get_property) {
R
Rob Clark 已提交
775
		return plane->funcs->atomic_get_property(plane, state, property, val);
R
Rob Clark 已提交
776 777 778 779 780
	} else {
		return -EINVAL;
	}

	return 0;
R
Rob Clark 已提交
781 782
}

783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801
static bool
plane_switching_crtc(struct drm_atomic_state *state,
		     struct drm_plane *plane,
		     struct drm_plane_state *plane_state)
{
	if (!plane->state->crtc || !plane_state->crtc)
		return false;

	if (plane->state->crtc == plane_state->crtc)
		return false;

	/* This could be refined, but currently there's no helper or driver code
	 * to implement direct switching of active planes nor userspace to take
	 * advantage of more direct plane switching without the intermediate
	 * full OFF state.
	 */
	return true;
}

R
Rob Clark 已提交
802 803 804 805 806 807 808 809 810 811 812 813 814 815
/**
 * drm_atomic_plane_check - check plane state
 * @plane: plane to check
 * @state: plane state to check
 *
 * Provides core sanity checks for plane state.
 *
 * RETURNS:
 * Zero on success, error code on failure
 */
static int drm_atomic_plane_check(struct drm_plane *plane,
		struct drm_plane_state *state)
{
	unsigned int fb_width, fb_height;
816
	int ret;
R
Rob Clark 已提交
817 818 819

	/* either *both* CRTC and FB must be set, or neither */
	if (WARN_ON(state->crtc && !state->fb)) {
D
Daniel Vetter 已提交
820
		DRM_DEBUG_ATOMIC("CRTC set but no FB\n");
R
Rob Clark 已提交
821 822
		return -EINVAL;
	} else if (WARN_ON(state->fb && !state->crtc)) {
D
Daniel Vetter 已提交
823
		DRM_DEBUG_ATOMIC("FB set but no CRTC\n");
R
Rob Clark 已提交
824 825 826 827 828 829 830 831 832
		return -EINVAL;
	}

	/* if disabled, we don't care about the rest of the state: */
	if (!state->crtc)
		return 0;

	/* Check whether this plane is usable on this CRTC */
	if (!(plane->possible_crtcs & drm_crtc_mask(state->crtc))) {
D
Daniel Vetter 已提交
833
		DRM_DEBUG_ATOMIC("Invalid crtc for plane\n");
R
Rob Clark 已提交
834 835 836 837
		return -EINVAL;
	}

	/* Check whether this plane supports the fb pixel format. */
838 839
	ret = drm_plane_check_pixel_format(plane, state->fb->pixel_format);
	if (ret) {
840
		char *format_name = drm_get_format_name(state->fb->pixel_format);
841 842
		DRM_DEBUG_ATOMIC("Invalid pixel format %s\n", format_name);
		kfree(format_name);
843
		return ret;
R
Rob Clark 已提交
844 845 846 847 848 849 850
	}

	/* Give drivers some help against integer overflows */
	if (state->crtc_w > INT_MAX ||
	    state->crtc_x > INT_MAX - (int32_t) state->crtc_w ||
	    state->crtc_h > INT_MAX ||
	    state->crtc_y > INT_MAX - (int32_t) state->crtc_h) {
D
Daniel Vetter 已提交
851 852 853
		DRM_DEBUG_ATOMIC("Invalid CRTC coordinates %ux%u+%d+%d\n",
				 state->crtc_w, state->crtc_h,
				 state->crtc_x, state->crtc_y);
R
Rob Clark 已提交
854 855 856 857 858 859 860 861 862 863 864
		return -ERANGE;
	}

	fb_width = state->fb->width << 16;
	fb_height = state->fb->height << 16;

	/* Make sure source coordinates are inside the fb. */
	if (state->src_w > fb_width ||
	    state->src_x > fb_width - state->src_w ||
	    state->src_h > fb_height ||
	    state->src_y > fb_height - state->src_h) {
D
Daniel Vetter 已提交
865 866 867 868 869 870
		DRM_DEBUG_ATOMIC("Invalid source coordinates "
				 "%u.%06ux%u.%06u+%u.%06u+%u.%06u\n",
				 state->src_w >> 16, ((state->src_w & 0xffff) * 15625) >> 10,
				 state->src_h >> 16, ((state->src_h & 0xffff) * 15625) >> 10,
				 state->src_x >> 16, ((state->src_x & 0xffff) * 15625) >> 10,
				 state->src_y >> 16, ((state->src_y & 0xffff) * 15625) >> 10);
R
Rob Clark 已提交
871 872 873
		return -ENOSPC;
	}

874
	if (plane_switching_crtc(state->state, plane, state)) {
875 876
		DRM_DEBUG_ATOMIC("[PLANE:%d:%s] switching CRTC directly\n",
				 plane->base.id, plane->name);
877 878 879
		return -EINVAL;
	}

R
Rob Clark 已提交
880 881 882
	return 0;
}

D
Daniel Vetter 已提交
883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905
/**
 * drm_atomic_get_connector_state - get connector state
 * @state: global atomic state object
 * @connector: connector to get state object for
 *
 * This function returns the connector state for the given connector,
 * allocating it if needed. It will also grab the relevant connector lock to
 * make sure that the state is consistent.
 *
 * Returns:
 *
 * Either the allocated state or the error code encoded into the pointer. When
 * the error is EDEADLK then the w/w mutex code has detected a deadlock and the
 * entire atomic sequence must be restarted. All other errors are fatal.
 */
struct drm_connector_state *
drm_atomic_get_connector_state(struct drm_atomic_state *state,
			  struct drm_connector *connector)
{
	int ret, index;
	struct drm_mode_config *config = &connector->dev->mode_config;
	struct drm_connector_state *connector_state;

906 907
	WARN_ON(!state->acquire_ctx);

908 909 910 911
	ret = drm_modeset_lock(&config->connection_mutex, state->acquire_ctx);
	if (ret)
		return ERR_PTR(ret);

D
Daniel Vetter 已提交
912 913
	index = drm_connector_index(connector);

914
	if (index >= state->num_connector) {
915
		struct __drm_connnectors_state *c;
916 917 918 919 920 921 922 923 924 925 926
		int alloc = max(index + 1, config->num_connector);

		c = krealloc(state->connectors, alloc * sizeof(*state->connectors), GFP_KERNEL);
		if (!c)
			return ERR_PTR(-ENOMEM);

		state->connectors = c;
		memset(&state->connectors[state->num_connector], 0,
		       sizeof(*state->connectors) * (alloc - state->num_connector));

		state->num_connector = alloc;
927 928
	}

929 930
	if (state->connectors[index].state)
		return state->connectors[index].state;
D
Daniel Vetter 已提交
931 932 933 934 935

	connector_state = connector->funcs->atomic_duplicate_state(connector);
	if (!connector_state)
		return ERR_PTR(-ENOMEM);

936
	drm_connector_reference(connector);
937 938
	state->connectors[index].state = connector_state;
	state->connectors[index].ptr = connector;
D
Daniel Vetter 已提交
939 940
	connector_state->state = state;

D
Daniel Vetter 已提交
941 942
	DRM_DEBUG_ATOMIC("Added [CONNECTOR:%d] %p state to %p\n",
			 connector->base.id, connector_state, state);
D
Daniel Vetter 已提交
943 944 945 946 947 948 949 950 951 952 953 954 955 956

	if (connector_state->crtc) {
		struct drm_crtc_state *crtc_state;

		crtc_state = drm_atomic_get_crtc_state(state,
						       connector_state->crtc);
		if (IS_ERR(crtc_state))
			return ERR_CAST(crtc_state);
	}

	return connector_state;
}
EXPORT_SYMBOL(drm_atomic_get_connector_state);

R
Rob Clark 已提交
957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979
/**
 * drm_atomic_connector_set_property - set property on connector.
 * @connector: the drm connector to set a property on
 * @state: the state object to update with the new property value
 * @property: the property to set
 * @val: the new property value
 *
 * Use this instead of calling connector->atomic_set_property directly.
 * This function handles generic/core properties and calls out to
 * driver's ->atomic_set_property() for driver properties.  To ensure
 * consistent behavior you must call this function rather than the
 * driver hook directly.
 *
 * RETURNS:
 * Zero on success, error code on failure
 */
int drm_atomic_connector_set_property(struct drm_connector *connector,
		struct drm_connector_state *state, struct drm_property *property,
		uint64_t val)
{
	struct drm_device *dev = connector->dev;
	struct drm_mode_config *config = &dev->mode_config;

980 981 982 983
	if (property == config->prop_crtc_id) {
		struct drm_crtc *crtc = drm_crtc_find(dev, val);
		return drm_atomic_set_crtc_for_connector(state, crtc);
	} else if (property == config->dpms_property) {
R
Rob Clark 已提交
984 985 986 987 988 989 990 991 992 993 994 995 996 997
		/* setting DPMS property requires special handling, which
		 * is done in legacy setprop path for us.  Disallow (for
		 * now?) atomic writes to DPMS property:
		 */
		return -EINVAL;
	} else if (connector->funcs->atomic_set_property) {
		return connector->funcs->atomic_set_property(connector,
				state, property, val);
	} else {
		return -EINVAL;
	}
}
EXPORT_SYMBOL(drm_atomic_connector_set_property);

998 999 1000 1001 1002 1003 1004
/**
 * drm_atomic_connector_get_property - get property value from connector state
 * @connector: the drm connector to set a property on
 * @state: the state object to get the property value from
 * @property: the property to set
 * @val: return location for the property value
 *
R
Rob Clark 已提交
1005 1006 1007 1008
 * This function handles generic/core properties and calls out to
 * driver's ->atomic_get_property() for driver properties.  To ensure
 * consistent behavior you must call this function rather than the
 * driver hook directly.
1009 1010 1011
 *
 * RETURNS:
 * Zero on success, error code on failure
R
Rob Clark 已提交
1012
 */
1013 1014
static int
drm_atomic_connector_get_property(struct drm_connector *connector,
R
Rob Clark 已提交
1015 1016 1017 1018 1019 1020
		const struct drm_connector_state *state,
		struct drm_property *property, uint64_t *val)
{
	struct drm_device *dev = connector->dev;
	struct drm_mode_config *config = &dev->mode_config;

1021 1022 1023
	if (property == config->prop_crtc_id) {
		*val = (state->crtc) ? state->crtc->base.id : 0;
	} else if (property == config->dpms_property) {
R
Rob Clark 已提交
1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034
		*val = connector->dpms;
	} else if (connector->funcs->atomic_get_property) {
		return connector->funcs->atomic_get_property(connector,
				state, property, val);
	} else {
		return -EINVAL;
	}

	return 0;
}

R
Rob Clark 已提交
1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070
int drm_atomic_get_property(struct drm_mode_object *obj,
		struct drm_property *property, uint64_t *val)
{
	struct drm_device *dev = property->dev;
	int ret;

	switch (obj->type) {
	case DRM_MODE_OBJECT_CONNECTOR: {
		struct drm_connector *connector = obj_to_connector(obj);
		WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
		ret = drm_atomic_connector_get_property(connector,
				connector->state, property, val);
		break;
	}
	case DRM_MODE_OBJECT_CRTC: {
		struct drm_crtc *crtc = obj_to_crtc(obj);
		WARN_ON(!drm_modeset_is_locked(&crtc->mutex));
		ret = drm_atomic_crtc_get_property(crtc,
				crtc->state, property, val);
		break;
	}
	case DRM_MODE_OBJECT_PLANE: {
		struct drm_plane *plane = obj_to_plane(obj);
		WARN_ON(!drm_modeset_is_locked(&plane->mutex));
		ret = drm_atomic_plane_get_property(plane,
				plane->state, property, val);
		break;
	}
	default:
		ret = -EINVAL;
		break;
	}

	return ret;
}

D
Daniel Vetter 已提交
1071 1072
/**
 * drm_atomic_set_crtc_for_plane - set crtc for plane
1073
 * @plane_state: the plane whose incoming state to update
D
Daniel Vetter 已提交
1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085
 * @crtc: crtc to use for the plane
 *
 * Changing the assigned crtc for a plane requires us to grab the lock and state
 * for the new crtc, as needed. This function takes care of all these details
 * besides updating the pointer in the state object itself.
 *
 * Returns:
 * 0 on success or can fail with -EDEADLK or -ENOMEM. When the error is EDEADLK
 * then the w/w mutex code has detected a deadlock and the entire atomic
 * sequence must be restarted. All other errors are fatal.
 */
int
1086 1087
drm_atomic_set_crtc_for_plane(struct drm_plane_state *plane_state,
			      struct drm_crtc *crtc)
D
Daniel Vetter 已提交
1088
{
1089
	struct drm_plane *plane = plane_state->plane;
D
Daniel Vetter 已提交
1090 1091
	struct drm_crtc_state *crtc_state;

1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102
	if (plane_state->crtc) {
		crtc_state = drm_atomic_get_crtc_state(plane_state->state,
						       plane_state->crtc);
		if (WARN_ON(IS_ERR(crtc_state)))
			return PTR_ERR(crtc_state);

		crtc_state->plane_mask &= ~(1 << drm_plane_index(plane));
	}

	plane_state->crtc = crtc;

D
Daniel Vetter 已提交
1103 1104 1105 1106 1107
	if (crtc) {
		crtc_state = drm_atomic_get_crtc_state(plane_state->state,
						       crtc);
		if (IS_ERR(crtc_state))
			return PTR_ERR(crtc_state);
1108
		crtc_state->plane_mask |= (1 << drm_plane_index(plane));
D
Daniel Vetter 已提交
1109 1110 1111
	}

	if (crtc)
1112 1113
		DRM_DEBUG_ATOMIC("Link plane state %p to [CRTC:%d:%s]\n",
				 plane_state, crtc->base.id, crtc->name);
D
Daniel Vetter 已提交
1114
	else
D
Daniel Vetter 已提交
1115 1116
		DRM_DEBUG_ATOMIC("Link plane state %p to [NOCRTC]\n",
				 plane_state);
D
Daniel Vetter 已提交
1117 1118 1119 1120 1121

	return 0;
}
EXPORT_SYMBOL(drm_atomic_set_crtc_for_plane);

1122
/**
J
John Hunter 已提交
1123
 * drm_atomic_set_fb_for_plane - set framebuffer for plane
1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142
 * @plane_state: atomic state object for the plane
 * @fb: fb to use for the plane
 *
 * Changing the assigned framebuffer for a plane requires us to grab a reference
 * to the new fb and drop the reference to the old fb, if there is one. This
 * function takes care of all these details besides updating the pointer in the
 * state object itself.
 */
void
drm_atomic_set_fb_for_plane(struct drm_plane_state *plane_state,
			    struct drm_framebuffer *fb)
{
	if (plane_state->fb)
		drm_framebuffer_unreference(plane_state->fb);
	if (fb)
		drm_framebuffer_reference(fb);
	plane_state->fb = fb;

	if (fb)
D
Daniel Vetter 已提交
1143 1144
		DRM_DEBUG_ATOMIC("Set [FB:%d] for plane state %p\n",
				 fb->base.id, plane_state);
1145
	else
D
Daniel Vetter 已提交
1146 1147
		DRM_DEBUG_ATOMIC("Set [NOFB] for plane state %p\n",
				 plane_state);
1148 1149 1150
}
EXPORT_SYMBOL(drm_atomic_set_fb_for_plane);

D
Daniel Vetter 已提交
1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170
/**
 * drm_atomic_set_crtc_for_connector - set crtc for connector
 * @conn_state: atomic state object for the connector
 * @crtc: crtc to use for the connector
 *
 * Changing the assigned crtc for a connector requires us to grab the lock and
 * state for the new crtc, as needed. This function takes care of all these
 * details besides updating the pointer in the state object itself.
 *
 * Returns:
 * 0 on success or can fail with -EDEADLK or -ENOMEM. When the error is EDEADLK
 * then the w/w mutex code has detected a deadlock and the entire atomic
 * sequence must be restarted. All other errors are fatal.
 */
int
drm_atomic_set_crtc_for_connector(struct drm_connector_state *conn_state,
				  struct drm_crtc *crtc)
{
	struct drm_crtc_state *crtc_state;

1171 1172 1173 1174
	if (conn_state->crtc == crtc)
		return 0;

	if (conn_state->crtc) {
1175 1176 1177 1178 1179
		crtc_state = drm_atomic_get_existing_crtc_state(conn_state->state,
								conn_state->crtc);

		crtc_state->connector_mask &=
			~(1 << drm_connector_index(conn_state->connector));
1180 1181 1182

		drm_connector_unreference(conn_state->connector);
		conn_state->crtc = NULL;
1183 1184
	}

D
Daniel Vetter 已提交
1185 1186 1187 1188
	if (crtc) {
		crtc_state = drm_atomic_get_crtc_state(conn_state->state, crtc);
		if (IS_ERR(crtc_state))
			return PTR_ERR(crtc_state);
1189 1190 1191

		crtc_state->connector_mask |=
			1 << drm_connector_index(conn_state->connector);
D
Daniel Vetter 已提交
1192

1193 1194
		drm_connector_reference(conn_state->connector);
		conn_state->crtc = crtc;
D
Daniel Vetter 已提交
1195

1196 1197
		DRM_DEBUG_ATOMIC("Link connector state %p to [CRTC:%d:%s]\n",
				 conn_state, crtc->base.id, crtc->name);
1198
	} else {
D
Daniel Vetter 已提交
1199 1200
		DRM_DEBUG_ATOMIC("Link connector state %p to [NOCRTC]\n",
				 conn_state);
1201
	}
D
Daniel Vetter 已提交
1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236

	return 0;
}
EXPORT_SYMBOL(drm_atomic_set_crtc_for_connector);

/**
 * drm_atomic_add_affected_connectors - add connectors for crtc
 * @state: atomic state
 * @crtc: DRM crtc
 *
 * This function walks the current configuration and adds all connectors
 * currently using @crtc to the atomic configuration @state. Note that this
 * function must acquire the connection mutex. This can potentially cause
 * unneeded seralization if the update is just for the planes on one crtc. Hence
 * drivers and helpers should only call this when really needed (e.g. when a
 * full modeset needs to happen due to some change).
 *
 * Returns:
 * 0 on success or can fail with -EDEADLK or -ENOMEM. When the error is EDEADLK
 * then the w/w mutex code has detected a deadlock and the entire atomic
 * sequence must be restarted. All other errors are fatal.
 */
int
drm_atomic_add_affected_connectors(struct drm_atomic_state *state,
				   struct drm_crtc *crtc)
{
	struct drm_mode_config *config = &state->dev->mode_config;
	struct drm_connector *connector;
	struct drm_connector_state *conn_state;
	int ret;

	ret = drm_modeset_lock(&config->connection_mutex, state->acquire_ctx);
	if (ret)
		return ret;

1237 1238
	DRM_DEBUG_ATOMIC("Adding all current connectors for [CRTC:%d:%s] to %p\n",
			 crtc->base.id, crtc->name, state);
D
Daniel Vetter 已提交
1239 1240 1241 1242 1243

	/*
	 * Changed connectors are already in @state, so only need to look at the
	 * current configuration.
	 */
1244
	drm_for_each_connector(connector, state->dev) {
D
Daniel Vetter 已提交
1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256
		if (connector->state->crtc != crtc)
			continue;

		conn_state = drm_atomic_get_connector_state(state, connector);
		if (IS_ERR(conn_state))
			return PTR_ERR(conn_state);
	}

	return 0;
}
EXPORT_SYMBOL(drm_atomic_add_affected_connectors);

1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295
/**
 * drm_atomic_add_affected_planes - add planes for crtc
 * @state: atomic state
 * @crtc: DRM crtc
 *
 * This function walks the current configuration and adds all planes
 * currently used by @crtc to the atomic configuration @state. This is useful
 * when an atomic commit also needs to check all currently enabled plane on
 * @crtc, e.g. when changing the mode. It's also useful when re-enabling a CRTC
 * to avoid special code to force-enable all planes.
 *
 * Since acquiring a plane state will always also acquire the w/w mutex of the
 * current CRTC for that plane (if there is any) adding all the plane states for
 * a CRTC will not reduce parallism of atomic updates.
 *
 * Returns:
 * 0 on success or can fail with -EDEADLK or -ENOMEM. When the error is EDEADLK
 * then the w/w mutex code has detected a deadlock and the entire atomic
 * sequence must be restarted. All other errors are fatal.
 */
int
drm_atomic_add_affected_planes(struct drm_atomic_state *state,
			       struct drm_crtc *crtc)
{
	struct drm_plane *plane;

	WARN_ON(!drm_atomic_get_existing_crtc_state(state, crtc));

	drm_for_each_plane_mask(plane, state->dev, crtc->state->plane_mask) {
		struct drm_plane_state *plane_state =
			drm_atomic_get_plane_state(state, plane);

		if (IS_ERR(plane_state))
			return PTR_ERR(plane_state);
	}
	return 0;
}
EXPORT_SYMBOL(drm_atomic_add_affected_planes);

D
Daniel Vetter 已提交
1296 1297 1298 1299 1300 1301
/**
 * drm_atomic_legacy_backoff - locking backoff for legacy ioctls
 * @state: atomic state
 *
 * This function should be used by legacy entry points which don't understand
 * -EDEADLK semantics. For simplicity this one will grab all modeset locks after
J
John Hunter 已提交
1302
 * the slowpath completed.
D
Daniel Vetter 已提交
1303 1304 1305
 */
void drm_atomic_legacy_backoff(struct drm_atomic_state *state)
{
1306 1307 1308
	struct drm_device *dev = state->dev;
	unsigned crtc_mask = 0;
	struct drm_crtc *crtc;
D
Daniel Vetter 已提交
1309
	int ret;
1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324
	bool global = false;

	drm_for_each_crtc(crtc, dev) {
		if (crtc->acquire_ctx != state->acquire_ctx)
			continue;

		crtc_mask |= drm_crtc_mask(crtc);
		crtc->acquire_ctx = NULL;
	}

	if (WARN_ON(dev->mode_config.acquire_ctx == state->acquire_ctx)) {
		global = true;

		dev->mode_config.acquire_ctx = NULL;
	}
D
Daniel Vetter 已提交
1325 1326 1327 1328

retry:
	drm_modeset_backoff(state->acquire_ctx);

1329
	ret = drm_modeset_lock_all_ctx(dev, state->acquire_ctx);
D
Daniel Vetter 已提交
1330 1331
	if (ret)
		goto retry;
1332 1333 1334 1335 1336 1337 1338

	drm_for_each_crtc(crtc, dev)
		if (drm_crtc_mask(crtc) & crtc_mask)
			crtc->acquire_ctx = state->acquire_ctx;

	if (global)
		dev->mode_config.acquire_ctx = state->acquire_ctx;
D
Daniel Vetter 已提交
1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354
}
EXPORT_SYMBOL(drm_atomic_legacy_backoff);

/**
 * drm_atomic_check_only - check whether a given config would work
 * @state: atomic configuration to check
 *
 * Note that this function can return -EDEADLK if the driver needed to acquire
 * more locks but encountered a deadlock. The caller must then do the usual w/w
 * backoff dance and restart. All other errors are fatal.
 *
 * Returns:
 * 0 on success, negative error code on failure.
 */
int drm_atomic_check_only(struct drm_atomic_state *state)
{
R
Rob Clark 已提交
1355 1356
	struct drm_device *dev = state->dev;
	struct drm_mode_config *config = &dev->mode_config;
1357 1358 1359 1360
	struct drm_plane *plane;
	struct drm_plane_state *plane_state;
	struct drm_crtc *crtc;
	struct drm_crtc_state *crtc_state;
R
Rob Clark 已提交
1361
	int i, ret = 0;
D
Daniel Vetter 已提交
1362

D
Daniel Vetter 已提交
1363
	DRM_DEBUG_ATOMIC("checking %p\n", state);
D
Daniel Vetter 已提交
1364

1365 1366
	for_each_plane_in_state(state, plane, plane_state, i) {
		ret = drm_atomic_plane_check(plane, plane_state);
R
Rob Clark 已提交
1367
		if (ret) {
1368 1369
			DRM_DEBUG_ATOMIC("[PLANE:%d:%s] atomic core check failed\n",
					 plane->base.id, plane->name);
R
Rob Clark 已提交
1370 1371 1372 1373
			return ret;
		}
	}

1374 1375
	for_each_crtc_in_state(state, crtc, crtc_state, i) {
		ret = drm_atomic_crtc_check(crtc, crtc_state);
R
Rob Clark 已提交
1376
		if (ret) {
1377 1378
			DRM_DEBUG_ATOMIC("[CRTC:%d:%s] atomic core check failed\n",
					 crtc->base.id, crtc->name);
R
Rob Clark 已提交
1379 1380 1381 1382
			return ret;
		}
	}

D
Daniel Vetter 已提交
1383
	if (config->funcs->atomic_check)
R
Rob Clark 已提交
1384 1385
		ret = config->funcs->atomic_check(state->dev, state);

R
Rob Clark 已提交
1386
	if (!state->allow_modeset) {
1387
		for_each_crtc_in_state(state, crtc, crtc_state, i) {
1388
			if (drm_atomic_crtc_needs_modeset(crtc_state)) {
1389 1390
				DRM_DEBUG_ATOMIC("[CRTC:%d:%s] requires full modeset\n",
						 crtc->base.id, crtc->name);
R
Rob Clark 已提交
1391 1392 1393 1394 1395
				return -EINVAL;
			}
		}
	}

R
Rob Clark 已提交
1396
	return ret;
D
Daniel Vetter 已提交
1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424
}
EXPORT_SYMBOL(drm_atomic_check_only);

/**
 * drm_atomic_commit - commit configuration atomically
 * @state: atomic configuration to check
 *
 * Note that this function can return -EDEADLK if the driver needed to acquire
 * more locks but encountered a deadlock. The caller must then do the usual w/w
 * backoff dance and restart. All other errors are fatal.
 *
 * Also note that on successful execution ownership of @state is transferred
 * from the caller of this function to the function itself. The caller must not
 * free or in any other way access @state. If the function fails then the caller
 * must clean up @state itself.
 *
 * Returns:
 * 0 on success, negative error code on failure.
 */
int drm_atomic_commit(struct drm_atomic_state *state)
{
	struct drm_mode_config *config = &state->dev->mode_config;
	int ret;

	ret = drm_atomic_check_only(state);
	if (ret)
		return ret;

D
Daniel Vetter 已提交
1425
	DRM_DEBUG_ATOMIC("commiting %p\n", state);
D
Daniel Vetter 已提交
1426 1427 1428 1429 1430 1431

	return config->funcs->atomic_commit(state->dev, state, false);
}
EXPORT_SYMBOL(drm_atomic_commit);

/**
1432
 * drm_atomic_nonblocking_commit - atomic&nonblocking configuration commit
D
Daniel Vetter 已提交
1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446
 * @state: atomic configuration to check
 *
 * Note that this function can return -EDEADLK if the driver needed to acquire
 * more locks but encountered a deadlock. The caller must then do the usual w/w
 * backoff dance and restart. All other errors are fatal.
 *
 * Also note that on successful execution ownership of @state is transferred
 * from the caller of this function to the function itself. The caller must not
 * free or in any other way access @state. If the function fails then the caller
 * must clean up @state itself.
 *
 * Returns:
 * 0 on success, negative error code on failure.
 */
1447
int drm_atomic_nonblocking_commit(struct drm_atomic_state *state)
D
Daniel Vetter 已提交
1448 1449 1450 1451 1452 1453 1454 1455
{
	struct drm_mode_config *config = &state->dev->mode_config;
	int ret;

	ret = drm_atomic_check_only(state);
	if (ret)
		return ret;

1456
	DRM_DEBUG_ATOMIC("commiting %p nonblocking\n", state);
D
Daniel Vetter 已提交
1457 1458 1459

	return config->funcs->atomic_commit(state->dev, state, true);
}
1460
EXPORT_SYMBOL(drm_atomic_nonblocking_commit);
R
Rob Clark 已提交
1461 1462 1463 1464 1465 1466

/*
 * The big monstor ioctl
 */

static struct drm_pending_vblank_event *create_vblank_event(
1467 1468
		struct drm_device *dev, struct drm_file *file_priv,
		struct fence *fence, uint64_t user_data)
R
Rob Clark 已提交
1469 1470
{
	struct drm_pending_vblank_event *e = NULL;
1471
	int ret;
R
Rob Clark 已提交
1472 1473

	e = kzalloc(sizeof *e, GFP_KERNEL);
1474 1475
	if (!e)
		return NULL;
R
Rob Clark 已提交
1476 1477

	e->event.base.type = DRM_EVENT_FLIP_COMPLETE;
1478
	e->event.base.length = sizeof(e->event);
R
Rob Clark 已提交
1479 1480
	e->event.user_data = user_data;

1481 1482 1483 1484 1485 1486 1487
	if (file_priv) {
		ret = drm_event_reserve_init(dev, file_priv, &e->base,
					     &e->event.base);
		if (ret) {
			kfree(e);
			return NULL;
		}
1488
	}
R
Rob Clark 已提交
1489

1490 1491
	e->base.fence = fence;

1492
	return e;
R
Rob Clark 已提交
1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556
}

static int atomic_set_prop(struct drm_atomic_state *state,
		struct drm_mode_object *obj, struct drm_property *prop,
		uint64_t prop_value)
{
	struct drm_mode_object *ref;
	int ret;

	if (!drm_property_change_valid_get(prop, prop_value, &ref))
		return -EINVAL;

	switch (obj->type) {
	case DRM_MODE_OBJECT_CONNECTOR: {
		struct drm_connector *connector = obj_to_connector(obj);
		struct drm_connector_state *connector_state;

		connector_state = drm_atomic_get_connector_state(state, connector);
		if (IS_ERR(connector_state)) {
			ret = PTR_ERR(connector_state);
			break;
		}

		ret = drm_atomic_connector_set_property(connector,
				connector_state, prop, prop_value);
		break;
	}
	case DRM_MODE_OBJECT_CRTC: {
		struct drm_crtc *crtc = obj_to_crtc(obj);
		struct drm_crtc_state *crtc_state;

		crtc_state = drm_atomic_get_crtc_state(state, crtc);
		if (IS_ERR(crtc_state)) {
			ret = PTR_ERR(crtc_state);
			break;
		}

		ret = drm_atomic_crtc_set_property(crtc,
				crtc_state, prop, prop_value);
		break;
	}
	case DRM_MODE_OBJECT_PLANE: {
		struct drm_plane *plane = obj_to_plane(obj);
		struct drm_plane_state *plane_state;

		plane_state = drm_atomic_get_plane_state(state, plane);
		if (IS_ERR(plane_state)) {
			ret = PTR_ERR(plane_state);
			break;
		}

		ret = drm_atomic_plane_set_property(plane,
				plane_state, prop, prop_value);
		break;
	}
	default:
		ret = -EINVAL;
		break;
	}

	drm_property_change_valid_put(prop, ref);
	return ret;
}

1557
/**
1558
 * drm_atomic_clean_old_fb -- Unset old_fb pointers and set plane->fb pointers.
1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595
 *
 * @dev: drm device to check.
 * @plane_mask: plane mask for planes that were updated.
 * @ret: return value, can be -EDEADLK for a retry.
 *
 * Before doing an update plane->old_fb is set to plane->fb,
 * but before dropping the locks old_fb needs to be set to NULL
 * and plane->fb updated. This is a common operation for each
 * atomic update, so this call is split off as a helper.
 */
void drm_atomic_clean_old_fb(struct drm_device *dev,
			     unsigned plane_mask,
			     int ret)
{
	struct drm_plane *plane;

	/* if succeeded, fixup legacy plane crtc/fb ptrs before dropping
	 * locks (ie. while it is still safe to deref plane->state).  We
	 * need to do this here because the driver entry points cannot
	 * distinguish between legacy and atomic ioctls.
	 */
	drm_for_each_plane_mask(plane, dev, plane_mask) {
		if (ret == 0) {
			struct drm_framebuffer *new_fb = plane->state->fb;
			if (new_fb)
				drm_framebuffer_reference(new_fb);
			plane->fb = new_fb;
			plane->crtc = plane->state->crtc;

			if (plane->old_fb)
				drm_framebuffer_unreference(plane->old_fb);
		}
		plane->old_fb = NULL;
	}
}
EXPORT_SYMBOL(drm_atomic_clean_old_fb);

R
Rob Clark 已提交
1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607
int drm_mode_atomic_ioctl(struct drm_device *dev,
			  void *data, struct drm_file *file_priv)
{
	struct drm_mode_atomic *arg = data;
	uint32_t __user *objs_ptr = (uint32_t __user *)(unsigned long)(arg->objs_ptr);
	uint32_t __user *count_props_ptr = (uint32_t __user *)(unsigned long)(arg->count_props_ptr);
	uint32_t __user *props_ptr = (uint32_t __user *)(unsigned long)(arg->props_ptr);
	uint64_t __user *prop_values_ptr = (uint64_t __user *)(unsigned long)(arg->prop_values_ptr);
	unsigned int copied_objs, copied_props;
	struct drm_atomic_state *state;
	struct drm_modeset_acquire_ctx ctx;
	struct drm_plane *plane;
1608 1609
	struct drm_crtc *crtc;
	struct drm_crtc_state *crtc_state;
1610
	unsigned plane_mask;
R
Rob Clark 已提交
1611
	int ret = 0;
1612
	unsigned int i, j;
R
Rob Clark 已提交
1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649

	/* disallow for drivers not supporting atomic: */
	if (!drm_core_check_feature(dev, DRIVER_ATOMIC))
		return -EINVAL;

	/* disallow for userspace that has not enabled atomic cap (even
	 * though this may be a bit overkill, since legacy userspace
	 * wouldn't know how to call this ioctl)
	 */
	if (!file_priv->atomic)
		return -EINVAL;

	if (arg->flags & ~DRM_MODE_ATOMIC_FLAGS)
		return -EINVAL;

	if (arg->reserved)
		return -EINVAL;

	if ((arg->flags & DRM_MODE_PAGE_FLIP_ASYNC) &&
			!dev->mode_config.async_page_flip)
		return -EINVAL;

	/* can't test and expect an event at the same time. */
	if ((arg->flags & DRM_MODE_ATOMIC_TEST_ONLY) &&
			(arg->flags & DRM_MODE_PAGE_FLIP_EVENT))
		return -EINVAL;

	drm_modeset_acquire_init(&ctx, 0);

	state = drm_atomic_state_alloc(dev);
	if (!state)
		return -ENOMEM;

	state->acquire_ctx = &ctx;
	state->allow_modeset = !!(arg->flags & DRM_MODE_ATOMIC_ALLOW_MODESET);

retry:
1650
	plane_mask = 0;
R
Rob Clark 已提交
1651 1652 1653 1654 1655 1656 1657 1658 1659
	copied_objs = 0;
	copied_props = 0;

	for (i = 0; i < arg->count_objs; i++) {
		uint32_t obj_id, count_props;
		struct drm_mode_object *obj;

		if (get_user(obj_id, objs_ptr + copied_objs)) {
			ret = -EFAULT;
1660
			goto out;
R
Rob Clark 已提交
1661 1662 1663
		}

		obj = drm_mode_object_find(dev, obj_id, DRM_MODE_OBJECT_ANY);
1664 1665 1666 1667 1668 1669 1670
		if (!obj) {
			ret = -ENOENT;
			goto out;
		}

		if (!obj->properties) {
			drm_mode_object_unreference(obj);
R
Rob Clark 已提交
1671
			ret = -ENOENT;
1672
			goto out;
R
Rob Clark 已提交
1673 1674 1675
		}

		if (get_user(count_props, count_props_ptr + copied_objs)) {
1676
			drm_mode_object_unreference(obj);
R
Rob Clark 已提交
1677
			ret = -EFAULT;
1678
			goto out;
R
Rob Clark 已提交
1679 1680 1681 1682 1683 1684 1685 1686 1687 1688
		}

		copied_objs++;

		for (j = 0; j < count_props; j++) {
			uint32_t prop_id;
			uint64_t prop_value;
			struct drm_property *prop;

			if (get_user(prop_id, props_ptr + copied_props)) {
1689
				drm_mode_object_unreference(obj);
R
Rob Clark 已提交
1690
				ret = -EFAULT;
1691
				goto out;
R
Rob Clark 已提交
1692 1693
			}

1694
			prop = drm_mode_obj_find_prop_id(obj, prop_id);
R
Rob Clark 已提交
1695
			if (!prop) {
1696
				drm_mode_object_unreference(obj);
R
Rob Clark 已提交
1697
				ret = -ENOENT;
1698
				goto out;
R
Rob Clark 已提交
1699 1700
			}

1701 1702 1703
			if (copy_from_user(&prop_value,
					   prop_values_ptr + copied_props,
					   sizeof(prop_value))) {
1704
				drm_mode_object_unreference(obj);
R
Rob Clark 已提交
1705
				ret = -EFAULT;
1706
				goto out;
R
Rob Clark 已提交
1707 1708 1709
			}

			ret = atomic_set_prop(state, obj, prop, prop_value);
1710 1711
			if (ret) {
				drm_mode_object_unreference(obj);
1712
				goto out;
1713
			}
R
Rob Clark 已提交
1714 1715 1716

			copied_props++;
		}
1717

1718 1719
		if (obj->type == DRM_MODE_OBJECT_PLANE && count_props &&
		    !(arg->flags & DRM_MODE_ATOMIC_TEST_ONLY)) {
1720 1721 1722 1723
			plane = obj_to_plane(obj);
			plane_mask |= (1 << drm_plane_index(plane));
			plane->old_fb = plane->fb;
		}
1724
		drm_mode_object_unreference(obj);
R
Rob Clark 已提交
1725 1726 1727
	}

	if (arg->flags & DRM_MODE_PAGE_FLIP_EVENT) {
1728
		for_each_crtc_in_state(state, crtc, crtc_state, i) {
R
Rob Clark 已提交
1729 1730
			struct drm_pending_vblank_event *e;

1731 1732
			e = create_vblank_event(dev, file_priv, NULL,
						arg->user_data);
R
Rob Clark 已提交
1733 1734
			if (!e) {
				ret = -ENOMEM;
1735
				goto out;
R
Rob Clark 已提交
1736 1737 1738 1739 1740 1741 1742
			}

			crtc_state->event = e;
		}
	}

	if (arg->flags & DRM_MODE_ATOMIC_TEST_ONLY) {
1743 1744 1745 1746
		/*
		 * Unlike commit, check_only does not clean up state.
		 * Below we call drm_atomic_state_free for it.
		 */
R
Rob Clark 已提交
1747 1748
		ret = drm_atomic_check_only(state);
	} else if (arg->flags & DRM_MODE_ATOMIC_NONBLOCK) {
1749
		ret = drm_atomic_nonblocking_commit(state);
R
Rob Clark 已提交
1750 1751 1752 1753
	} else {
		ret = drm_atomic_commit(state);
	}

1754
out:
1755
	drm_atomic_clean_old_fb(dev, plane_mask, ret);
R
Rob Clark 已提交
1756

1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767
	if (ret && arg->flags & DRM_MODE_PAGE_FLIP_EVENT) {
		/*
		 * TEST_ONLY and PAGE_FLIP_EVENT are mutually exclusive,
		 * if they weren't, this code should be called on success
		 * for TEST_ONLY too.
		 */

		for_each_crtc_in_state(state, crtc, crtc_state, i) {
			if (!crtc_state->event)
				continue;

1768
			drm_event_cancel_free(dev, &crtc_state->event->base);
1769 1770 1771
		}
	}

1772 1773 1774 1775 1776
	if (ret == -EDEADLK) {
		drm_atomic_state_clear(state);
		drm_modeset_backoff(&ctx);
		goto retry;
	}
R
Rob Clark 已提交
1777

1778
	if (ret || arg->flags & DRM_MODE_ATOMIC_TEST_ONLY)
1779
		drm_atomic_state_free(state);
R
Rob Clark 已提交
1780 1781 1782 1783 1784 1785

	drm_modeset_drop_locks(&ctx);
	drm_modeset_acquire_fini(&ctx);

	return ret;
}