intel_sprite.c 31.8 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
/*
 * Copyright © 2011 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 *
 * Authors:
 *   Jesse Barnes <jbarnes@virtuousgeek.org>
 *
 * New plane/sprite handling.
 *
 * The older chips had a separate interface for programming plane related
 * registers; newer ones are much simpler and we can use the new DRM plane
 * support.
 */
32 33 34
#include <drm/drmP.h>
#include <drm/drm_crtc.h>
#include <drm/drm_fourcc.h>
35
#include <drm/drm_rect.h>
36
#include <drm/drm_atomic.h>
37
#include <drm/drm_plane_helper.h>
38
#include "intel_drv.h"
39
#include <drm/i915_drm.h>
40 41
#include "i915_drv.h"

42 43 44 45 46 47 48 49 50 51 52 53 54 55
static bool
format_is_yuv(uint32_t format)
{
	switch (format) {
	case DRM_FORMAT_YUYV:
	case DRM_FORMAT_UYVY:
	case DRM_FORMAT_VYUY:
	case DRM_FORMAT_YVYU:
		return true;
	default:
		return false;
	}
}

56 57 58 59 60 61 62 63 64
static int usecs_to_scanlines(const struct drm_display_mode *mode, int usecs)
{
	/* paranoia */
	if (!mode->crtc_htotal)
		return 1;

	return DIV_ROUND_UP(usecs * mode->crtc_clock, 1000 * mode->crtc_htotal);
}

65 66 67 68 69 70 71 72 73 74 75 76 77 78
/**
 * intel_pipe_update_start() - start update of a set of display registers
 * @crtc: the crtc of which the registers are going to be updated
 * @start_vbl_count: vblank counter return pointer used for error checking
 *
 * Mark the start of an update to pipe registers that should be updated
 * atomically regarding vblank. If the next vblank will happens within
 * the next 100 us, this function waits until the vblank passes.
 *
 * After a successful call to this function, interrupts will be disabled
 * until a subsequent call to intel_pipe_update_end(). That is done to
 * avoid random delays. The value written to @start_vbl_count should be
 * supplied to intel_pipe_update_end() for error checking.
 */
79
void intel_pipe_update_start(struct intel_crtc *crtc)
80 81
{
	struct drm_device *dev = crtc->base.dev;
82
	const struct drm_display_mode *mode = &crtc->config->base.adjusted_mode;
83 84 85
	enum pipe pipe = crtc->pipe;
	long timeout = msecs_to_jiffies_timeout(1);
	int scanline, min, max, vblank_start;
86
	wait_queue_head_t *wq = drm_crtc_vblank_waitqueue(&crtc->base);
87 88 89 90 91 92 93 94 95 96
	DEFINE_WAIT(wait);

	vblank_start = mode->crtc_vblank_start;
	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
		vblank_start = DIV_ROUND_UP(vblank_start, 2);

	/* FIXME needs to be calibrated sensibly */
	min = vblank_start - usecs_to_scanlines(mode, 100);
	max = vblank_start - 1;

97
	local_irq_disable();
98
	crtc->start_vbl_count = 0;
99

100
	if (min <= 0 || max <= 0)
101
		return;
102

103
	if (WARN_ON(drm_crtc_vblank_get(&crtc->base)))
104
		return;
105

106 107
	trace_i915_pipe_update_start(crtc, min, max);

108 109 110 111 112 113
	for (;;) {
		/*
		 * prepare_to_wait() has a memory barrier, which guarantees
		 * other CPUs can see the task state update by the time we
		 * read the scanline.
		 */
114
		prepare_to_wait(wq, &wait, TASK_UNINTERRUPTIBLE);
115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132

		scanline = intel_get_crtc_scanline(crtc);
		if (scanline < min || scanline > max)
			break;

		if (timeout <= 0) {
			DRM_ERROR("Potential atomic update failure on pipe %c\n",
				  pipe_name(crtc->pipe));
			break;
		}

		local_irq_enable();

		timeout = schedule_timeout(timeout);

		local_irq_disable();
	}

133
	finish_wait(wq, &wait);
134

135
	drm_crtc_vblank_put(&crtc->base);
136

137
	crtc->start_vbl_time = ktime_get();
138
	crtc->start_vbl_count = dev->driver->get_vblank_counter(dev, pipe);
139

140 141
	trace_i915_pipe_update_vblank_evaded(crtc, min, max,
					     crtc->start_vbl_count);
142 143
}

144 145 146 147 148 149 150 151 152
/**
 * intel_pipe_update_end() - end update of a set of display registers
 * @crtc: the crtc of which the registers were updated
 * @start_vbl_count: start vblank counter (used for error checking)
 *
 * Mark the end of an update started with intel_pipe_update_start(). This
 * re-enables interrupts and verifies the update was actually completed
 * before a vblank using the value of @start_vbl_count.
 */
153
void intel_pipe_update_end(struct intel_crtc *crtc)
154 155 156 157
{
	struct drm_device *dev = crtc->base.dev;
	enum pipe pipe = crtc->pipe;
	u32 end_vbl_count = dev->driver->get_vblank_counter(dev, pipe);
158
	ktime_t end_vbl_time = ktime_get();
159

160 161
	trace_i915_pipe_update_end(crtc, end_vbl_count);

162 163
	local_irq_enable();

164
	if (crtc->start_vbl_count && crtc->start_vbl_count != end_vbl_count)
165 166 167
		DRM_ERROR("Atomic update failure on pipe %c (start=%u end=%u) time %lld us\n",
			  pipe_name(pipe), crtc->start_vbl_count, end_vbl_count,
			  ktime_us_delta(end_vbl_time, crtc->start_vbl_time));
168 169
}

170 171 172
static void
skl_update_plane(struct drm_plane *drm_plane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
173
		 int crtc_x, int crtc_y,
174 175 176 177 178 179 180
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = drm_plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(drm_plane);
181
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
182 183
	const int pipe = intel_plane->pipe;
	const int plane = intel_plane->plane + 1;
184
	u32 plane_ctl, stride_div, stride;
185
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
186 187
	const struct drm_intel_sprite_colorkey *key =
		&to_intel_plane_state(drm_plane->state)->ckey;
188
	unsigned long surf_addr;
189 190 191
	u32 tile_height, plane_offset, plane_size;
	unsigned int rotation;
	int x_offset, y_offset;
192 193
	struct intel_crtc_state *crtc_state = to_intel_crtc(crtc)->config;
	int scaler_id;
194

195 196
	plane_ctl = PLANE_CTL_ENABLE |
		PLANE_CTL_PIPE_CSC_ENABLE;
197

198 199
	plane_ctl |= skl_plane_ctl_format(fb->pixel_format);
	plane_ctl |= skl_plane_ctl_tiling(fb->modifier[0]);
200

201
	rotation = drm_plane->state->rotation;
202
	plane_ctl |= skl_plane_ctl_rotation(rotation);
203 204 205 206 207

	intel_update_sprite_watermarks(drm_plane, crtc, src_w, src_h,
				       pixel_size, true,
				       src_w != crtc_w || src_h != crtc_h);

208 209 210
	stride_div = intel_fb_stride_alignment(dev, fb->modifier[0],
					       fb->pixel_format);

211 212
	scaler_id = to_intel_plane_state(drm_plane->state)->scaler_id;

213 214 215 216 217 218
	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

219 220 221 222 223 224 225 226 227 228 229
	if (key->flags) {
		I915_WRITE(PLANE_KEYVAL(pipe, plane), key->min_value);
		I915_WRITE(PLANE_KEYMAX(pipe, plane), key->max_value);
		I915_WRITE(PLANE_KEYMSK(pipe, plane), key->channel_mask);
	}

	if (key->flags & I915_SET_COLORKEY_DESTINATION)
		plane_ctl |= PLANE_CTL_KEY_ENABLE_DESTINATION;
	else if (key->flags & I915_SET_COLORKEY_SOURCE)
		plane_ctl |= PLANE_CTL_KEY_ENABLE_SOURCE;

230 231
	surf_addr = intel_plane_obj_offset(intel_plane, obj);

232 233
	if (intel_rotation_90_or_270(rotation)) {
		/* stride: Surface height in tiles */
234 235
		tile_height = intel_tile_height(dev, fb->pixel_format,
						fb->modifier[0]);
236 237 238 239 240 241 242 243 244 245 246 247 248 249 250
		stride = DIV_ROUND_UP(fb->height, tile_height);
		plane_size = (src_w << 16) | src_h;
		x_offset = stride * tile_height - y - (src_h + 1);
		y_offset = x;
	} else {
		stride = fb->pitches[0] / stride_div;
		plane_size = (src_h << 16) | src_w;
		x_offset = x;
		y_offset = y;
	}
	plane_offset = y_offset << 16 | x_offset;

	I915_WRITE(PLANE_OFFSET(pipe, plane), plane_offset);
	I915_WRITE(PLANE_STRIDE(pipe, plane), stride);
	I915_WRITE(PLANE_SIZE(pipe, plane), plane_size);
251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270

	/* program plane scaler */
	if (scaler_id >= 0) {
		uint32_t ps_ctrl = 0;

		DRM_DEBUG_KMS("plane = %d PS_PLANE_SEL(plane) = 0x%x\n", plane,
			PS_PLANE_SEL(plane));
		ps_ctrl = PS_SCALER_EN | PS_PLANE_SEL(plane) |
			crtc_state->scaler_state.scalers[scaler_id].mode;
		I915_WRITE(SKL_PS_CTRL(pipe, scaler_id), ps_ctrl);
		I915_WRITE(SKL_PS_PWR_GATE(pipe, scaler_id), 0);
		I915_WRITE(SKL_PS_WIN_POS(pipe, scaler_id), (crtc_x << 16) | crtc_y);
		I915_WRITE(SKL_PS_WIN_SZ(pipe, scaler_id),
			((crtc_w + 1) << 16)|(crtc_h + 1));

		I915_WRITE(PLANE_POS(pipe, plane), 0);
	} else {
		I915_WRITE(PLANE_POS(pipe, plane), (crtc_y << 16) | crtc_x);
	}

271
	I915_WRITE(PLANE_CTL(pipe, plane), plane_ctl);
272
	I915_WRITE(PLANE_SURF(pipe, plane), surf_addr);
273 274 275 276
	POSTING_READ(PLANE_SURF(pipe, plane));
}

static void
277
skl_disable_plane(struct drm_plane *dplane, struct drm_crtc *crtc)
278
{
279
	struct drm_device *dev = dplane->dev;
280
	struct drm_i915_private *dev_priv = dev->dev_private;
281
	struct intel_plane *intel_plane = to_intel_plane(dplane);
282 283 284
	const int pipe = intel_plane->pipe;
	const int plane = intel_plane->plane + 1;

285
	I915_WRITE(PLANE_CTL(pipe, plane), 0);
286

287 288
	I915_WRITE(PLANE_SURF(pipe, plane), 0);
	POSTING_READ(PLANE_SURF(pipe, plane));
289

290
	intel_update_sprite_watermarks(dplane, crtc, 0, 0, 0, false, false);
291 292
}

293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331
static void
chv_update_csc(struct intel_plane *intel_plane, uint32_t format)
{
	struct drm_i915_private *dev_priv = intel_plane->base.dev->dev_private;
	int plane = intel_plane->plane;

	/* Seems RGB data bypasses the CSC always */
	if (!format_is_yuv(format))
		return;

	/*
	 * BT.601 limited range YCbCr -> full range RGB
	 *
	 * |r|   | 6537 4769     0|   |cr  |
	 * |g| = |-3330 4769 -1605| x |y-64|
	 * |b|   |    0 4769  8263|   |cb  |
	 *
	 * Cb and Cr apparently come in as signed already, so no
	 * need for any offset. For Y we need to remove the offset.
	 */
	I915_WRITE(SPCSCYGOFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(-64));
	I915_WRITE(SPCSCCBOFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(0));
	I915_WRITE(SPCSCCROFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(0));

	I915_WRITE(SPCSCC01(plane), SPCSC_C1(4769) | SPCSC_C0(6537));
	I915_WRITE(SPCSCC23(plane), SPCSC_C1(-3330) | SPCSC_C0(0));
	I915_WRITE(SPCSCC45(plane), SPCSC_C1(-1605) | SPCSC_C0(4769));
	I915_WRITE(SPCSCC67(plane), SPCSC_C1(4769) | SPCSC_C0(0));
	I915_WRITE(SPCSCC8(plane), SPCSC_C0(8263));

	I915_WRITE(SPCSCYGICLAMP(plane), SPCSC_IMAX(940) | SPCSC_IMIN(64));
	I915_WRITE(SPCSCCBICLAMP(plane), SPCSC_IMAX(448) | SPCSC_IMIN(-448));
	I915_WRITE(SPCSCCRICLAMP(plane), SPCSC_IMAX(448) | SPCSC_IMIN(-448));

	I915_WRITE(SPCSCYGOCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
	I915_WRITE(SPCSCCBOCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
	I915_WRITE(SPCSCCROCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
}

332
static void
333 334
vlv_update_plane(struct drm_plane *dplane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
335
		 int crtc_x, int crtc_y,
336 337 338 339 340 341 342
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = dplane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(dplane);
343
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
344 345 346 347 348
	int pipe = intel_plane->pipe;
	int plane = intel_plane->plane;
	u32 sprctl;
	unsigned long sprsurf_offset, linear_offset;
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
349 350
	const struct drm_intel_sprite_colorkey *key =
		&to_intel_plane_state(dplane->state)->ckey;
351

352
	sprctl = SP_ENABLE;
353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396

	switch (fb->pixel_format) {
	case DRM_FORMAT_YUYV:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YUYV;
		break;
	case DRM_FORMAT_YVYU:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YVYU;
		break;
	case DRM_FORMAT_UYVY:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_UYVY;
		break;
	case DRM_FORMAT_VYUY:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_VYUY;
		break;
	case DRM_FORMAT_RGB565:
		sprctl |= SP_FORMAT_BGR565;
		break;
	case DRM_FORMAT_XRGB8888:
		sprctl |= SP_FORMAT_BGRX8888;
		break;
	case DRM_FORMAT_ARGB8888:
		sprctl |= SP_FORMAT_BGRA8888;
		break;
	case DRM_FORMAT_XBGR2101010:
		sprctl |= SP_FORMAT_RGBX1010102;
		break;
	case DRM_FORMAT_ABGR2101010:
		sprctl |= SP_FORMAT_RGBA1010102;
		break;
	case DRM_FORMAT_XBGR8888:
		sprctl |= SP_FORMAT_RGBX8888;
		break;
	case DRM_FORMAT_ABGR8888:
		sprctl |= SP_FORMAT_RGBA8888;
		break;
	default:
		/*
		 * If we get here one of the upper layers failed to filter
		 * out the unsupported plane formats
		 */
		BUG();
		break;
	}

397 398 399 400 401 402
	/*
	 * Enable gamma to match primary/cursor plane behaviour.
	 * FIXME should be user controllable via propertiesa.
	 */
	sprctl |= SP_GAMMA_ENABLE;

403 404 405 406 407 408 409 410 411 412
	if (obj->tiling_mode != I915_TILING_NONE)
		sprctl |= SP_TILED;

	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

	linear_offset = y * fb->pitches[0] + x * pixel_size;
413 414
	sprsurf_offset = intel_gen4_compute_page_offset(dev_priv,
							&x, &y,
415 416 417 418 419
							obj->tiling_mode,
							pixel_size,
							fb->pitches[0]);
	linear_offset -= sprsurf_offset;

420
	if (dplane->state->rotation == BIT(DRM_ROTATE_180)) {
421 422 423 424 425 426 427
		sprctl |= SP_ROTATE_180;

		x += src_w;
		y += src_h;
		linear_offset += src_h * fb->pitches[0] + src_w * pixel_size;
	}

428 429 430 431 432 433 434 435 436
	if (key->flags) {
		I915_WRITE(SPKEYMINVAL(pipe, plane), key->min_value);
		I915_WRITE(SPKEYMAXVAL(pipe, plane), key->max_value);
		I915_WRITE(SPKEYMSK(pipe, plane), key->channel_mask);
	}

	if (key->flags & I915_SET_COLORKEY_SOURCE)
		sprctl |= SP_SOURCE_KEY;

437 438 439
	if (IS_CHERRYVIEW(dev) && pipe == PIPE_B)
		chv_update_csc(intel_plane, fb->pixel_format);

440 441 442
	I915_WRITE(SPSTRIDE(pipe, plane), fb->pitches[0]);
	I915_WRITE(SPPOS(pipe, plane), (crtc_y << 16) | crtc_x);

443 444 445 446 447
	if (obj->tiling_mode != I915_TILING_NONE)
		I915_WRITE(SPTILEOFF(pipe, plane), (y << 16) | x);
	else
		I915_WRITE(SPLINOFF(pipe, plane), linear_offset);

448 449
	I915_WRITE(SPCONSTALPHA(pipe, plane), 0);

450 451
	I915_WRITE(SPSIZE(pipe, plane), (crtc_h << 16) | crtc_w);
	I915_WRITE(SPCNTR(pipe, plane), sprctl);
452 453
	I915_WRITE(SPSURF(pipe, plane), i915_gem_obj_ggtt_offset(obj) +
		   sprsurf_offset);
454
	POSTING_READ(SPSURF(pipe, plane));
455 456 457
}

static void
458
vlv_disable_plane(struct drm_plane *dplane, struct drm_crtc *crtc)
459 460 461 462 463 464 465
{
	struct drm_device *dev = dplane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(dplane);
	int pipe = intel_plane->pipe;
	int plane = intel_plane->plane;

466 467
	I915_WRITE(SPCNTR(pipe, plane), 0);

468
	I915_WRITE(SPSURF(pipe, plane), 0);
469
	POSTING_READ(SPSURF(pipe, plane));
470 471
}

472
static void
473 474
ivb_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
475
		 int crtc_x, int crtc_y,
476 477 478 479 480 481 482
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
483
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
484
	enum pipe pipe = intel_plane->pipe;
485
	u32 sprctl, sprscale = 0;
486
	unsigned long sprsurf_offset, linear_offset;
V
Ville Syrjälä 已提交
487
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
488 489
	const struct drm_intel_sprite_colorkey *key =
		&to_intel_plane_state(plane->state)->ckey;
490

491
	sprctl = SPRITE_ENABLE;
492 493 494

	switch (fb->pixel_format) {
	case DRM_FORMAT_XBGR8888:
495
		sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
496 497
		break;
	case DRM_FORMAT_XRGB8888:
498
		sprctl |= SPRITE_FORMAT_RGBX888;
499 500 501 502 503 504 505 506 507 508 509 510 511 512
		break;
	case DRM_FORMAT_YUYV:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YUYV;
		break;
	case DRM_FORMAT_YVYU:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YVYU;
		break;
	case DRM_FORMAT_UYVY:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_UYVY;
		break;
	case DRM_FORMAT_VYUY:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_VYUY;
		break;
	default:
513
		BUG();
514 515
	}

516 517 518 519 520 521
	/*
	 * Enable gamma to match primary/cursor plane behaviour.
	 * FIXME should be user controllable via propertiesa.
	 */
	sprctl |= SPRITE_GAMMA_ENABLE;

522 523 524
	if (obj->tiling_mode != I915_TILING_NONE)
		sprctl |= SPRITE_TILED;

525
	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
526 527 528 529
		sprctl &= ~SPRITE_TRICKLE_FEED_DISABLE;
	else
		sprctl |= SPRITE_TRICKLE_FEED_DISABLE;

530
	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
531 532
		sprctl |= SPRITE_PIPE_CSC_ENABLE;

533 534
	intel_update_sprite_watermarks(plane, crtc, src_w, src_h, pixel_size,
				       true,
535 536
				       src_w != crtc_w || src_h != crtc_h);

537 538 539 540 541 542
	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

543
	if (crtc_w != src_w || crtc_h != src_h)
544 545
		sprscale = SPRITE_SCALE_ENABLE | (src_w << 16) | src_h;

546
	linear_offset = y * fb->pitches[0] + x * pixel_size;
547
	sprsurf_offset =
548 549
		intel_gen4_compute_page_offset(dev_priv,
					       &x, &y, obj->tiling_mode,
550
					       pixel_size, fb->pitches[0]);
551 552
	linear_offset -= sprsurf_offset;

553
	if (plane->state->rotation == BIT(DRM_ROTATE_180)) {
554 555 556 557 558 559 560 561 562 563 564
		sprctl |= SPRITE_ROTATE_180;

		/* HSW and BDW does this automagically in hardware */
		if (!IS_HASWELL(dev) && !IS_BROADWELL(dev)) {
			x += src_w;
			y += src_h;
			linear_offset += src_h * fb->pitches[0] +
				src_w * pixel_size;
		}
	}

565 566 567 568 569 570 571 572 573 574 575
	if (key->flags) {
		I915_WRITE(SPRKEYVAL(pipe), key->min_value);
		I915_WRITE(SPRKEYMAX(pipe), key->max_value);
		I915_WRITE(SPRKEYMSK(pipe), key->channel_mask);
	}

	if (key->flags & I915_SET_COLORKEY_DESTINATION)
		sprctl |= SPRITE_DEST_KEY;
	else if (key->flags & I915_SET_COLORKEY_SOURCE)
		sprctl |= SPRITE_SOURCE_KEY;

576 577 578
	I915_WRITE(SPRSTRIDE(pipe), fb->pitches[0]);
	I915_WRITE(SPRPOS(pipe), (crtc_y << 16) | crtc_x);

579 580
	/* HSW consolidates SPRTILEOFF and SPRLINOFF into a single SPROFFSET
	 * register */
581
	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
582
		I915_WRITE(SPROFFSET(pipe), (y << 16) | x);
583
	else if (obj->tiling_mode != I915_TILING_NONE)
584
		I915_WRITE(SPRTILEOFF(pipe), (y << 16) | x);
585 586
	else
		I915_WRITE(SPRLINOFF(pipe), linear_offset);
587

588
	I915_WRITE(SPRSIZE(pipe), (crtc_h << 16) | crtc_w);
589 590
	if (intel_plane->can_scale)
		I915_WRITE(SPRSCALE(pipe), sprscale);
591
	I915_WRITE(SPRCTL(pipe), sprctl);
592 593
	I915_WRITE(SPRSURF(pipe),
		   i915_gem_obj_ggtt_offset(obj) + sprsurf_offset);
594
	POSTING_READ(SPRSURF(pipe));
595 596 597
}

static void
598
ivb_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
599 600 601 602 603 604 605 606
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
	int pipe = intel_plane->pipe;

	I915_WRITE(SPRCTL(pipe), I915_READ(SPRCTL(pipe)) & ~SPRITE_ENABLE);
	/* Can't leave the scaler enabled... */
607 608
	if (intel_plane->can_scale)
		I915_WRITE(SPRSCALE(pipe), 0);
609

610 611
	I915_WRITE(SPRSURF(pipe), 0);
	POSTING_READ(SPRSURF(pipe));
612 613 614
}

static void
615 616
ilk_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
617
		 int crtc_x, int crtc_y,
618 619 620 621 622 623 624
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
625
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
V
Ville Syrjälä 已提交
626
	int pipe = intel_plane->pipe;
627
	unsigned long dvssurf_offset, linear_offset;
628
	u32 dvscntr, dvsscale;
V
Ville Syrjälä 已提交
629
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
630 631
	const struct drm_intel_sprite_colorkey *key =
		&to_intel_plane_state(plane->state)->ckey;
632

633
	dvscntr = DVS_ENABLE;
634 635 636

	switch (fb->pixel_format) {
	case DRM_FORMAT_XBGR8888:
637
		dvscntr |= DVS_FORMAT_RGBX888 | DVS_RGB_ORDER_XBGR;
638 639
		break;
	case DRM_FORMAT_XRGB8888:
640
		dvscntr |= DVS_FORMAT_RGBX888;
641 642 643 644 645 646 647 648 649 650 651 652 653 654
		break;
	case DRM_FORMAT_YUYV:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YUYV;
		break;
	case DRM_FORMAT_YVYU:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YVYU;
		break;
	case DRM_FORMAT_UYVY:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_UYVY;
		break;
	case DRM_FORMAT_VYUY:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_VYUY;
		break;
	default:
655
		BUG();
656 657
	}

658 659 660 661 662 663
	/*
	 * Enable gamma to match primary/cursor plane behaviour.
	 * FIXME should be user controllable via propertiesa.
	 */
	dvscntr |= DVS_GAMMA_ENABLE;

664 665 666
	if (obj->tiling_mode != I915_TILING_NONE)
		dvscntr |= DVS_TILED;

667 668
	if (IS_GEN6(dev))
		dvscntr |= DVS_TRICKLE_FEED_DISABLE; /* must disable */
669

670 671
	intel_update_sprite_watermarks(plane, crtc, src_w, src_h,
				       pixel_size, true,
672 673
				       src_w != crtc_w || src_h != crtc_h);

674 675 676 677 678 679
	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

680
	dvsscale = 0;
681
	if (crtc_w != src_w || crtc_h != src_h)
682 683
		dvsscale = DVS_SCALE_ENABLE | (src_w << 16) | src_h;

684
	linear_offset = y * fb->pitches[0] + x * pixel_size;
685
	dvssurf_offset =
686 687
		intel_gen4_compute_page_offset(dev_priv,
					       &x, &y, obj->tiling_mode,
688
					       pixel_size, fb->pitches[0]);
689 690
	linear_offset -= dvssurf_offset;

691
	if (plane->state->rotation == BIT(DRM_ROTATE_180)) {
692 693 694 695 696 697 698
		dvscntr |= DVS_ROTATE_180;

		x += src_w;
		y += src_h;
		linear_offset += src_h * fb->pitches[0] + src_w * pixel_size;
	}

699 700 701 702 703 704 705 706 707 708 709
	if (key->flags) {
		I915_WRITE(DVSKEYVAL(pipe), key->min_value);
		I915_WRITE(DVSKEYMAX(pipe), key->max_value);
		I915_WRITE(DVSKEYMSK(pipe), key->channel_mask);
	}

	if (key->flags & I915_SET_COLORKEY_DESTINATION)
		dvscntr |= DVS_DEST_KEY;
	else if (key->flags & I915_SET_COLORKEY_SOURCE)
		dvscntr |= DVS_SOURCE_KEY;

710 711 712
	I915_WRITE(DVSSTRIDE(pipe), fb->pitches[0]);
	I915_WRITE(DVSPOS(pipe), (crtc_y << 16) | crtc_x);

713
	if (obj->tiling_mode != I915_TILING_NONE)
714
		I915_WRITE(DVSTILEOFF(pipe), (y << 16) | x);
715 716
	else
		I915_WRITE(DVSLINOFF(pipe), linear_offset);
717 718 719 720

	I915_WRITE(DVSSIZE(pipe), (crtc_h << 16) | crtc_w);
	I915_WRITE(DVSSCALE(pipe), dvsscale);
	I915_WRITE(DVSCNTR(pipe), dvscntr);
721 722
	I915_WRITE(DVSSURF(pipe),
		   i915_gem_obj_ggtt_offset(obj) + dvssurf_offset);
723
	POSTING_READ(DVSSURF(pipe));
724 725 726
}

static void
727
ilk_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
728 729 730 731 732 733
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
	int pipe = intel_plane->pipe;

734
	I915_WRITE(DVSCNTR(pipe), 0);
735 736
	/* Disable the scaler */
	I915_WRITE(DVSSCALE(pipe), 0);
737

738
	I915_WRITE(DVSSURF(pipe), 0);
739
	POSTING_READ(DVSSURF(pipe));
740 741 742
}

static int
743
intel_check_sprite_plane(struct drm_plane *plane,
744
			 struct intel_crtc_state *crtc_state,
745
			 struct intel_plane_state *state)
746
{
747
	struct drm_device *dev = plane->dev;
748 749
	struct drm_crtc *crtc = state->base.crtc;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
750
	struct intel_plane *intel_plane = to_intel_plane(plane);
751
	struct drm_framebuffer *fb = state->base.fb;
752 753 754 755 756 757
	int crtc_x, crtc_y;
	unsigned int crtc_w, crtc_h;
	uint32_t src_x, src_y, src_w, src_h;
	struct drm_rect *src = &state->src;
	struct drm_rect *dst = &state->dst;
	const struct drm_rect *clip = &state->clip;
758 759
	int hscale, vscale;
	int max_scale, min_scale;
760
	bool can_scale;
761 762 763 764
	int pixel_size;

	if (!fb) {
		state->visible = false;
765
		return 0;
766
	}
767

768 769 770
	/* Don't modify another pipe's plane */
	if (intel_plane->pipe != intel_crtc->pipe) {
		DRM_DEBUG_KMS("Wrong plane <-> crtc mapping\n");
771
		return -EINVAL;
772
	}
773

774 775 776
	/* FIXME check all gen limits */
	if (fb->width < 3 || fb->height < 3 || fb->pitches[0] > 16384) {
		DRM_DEBUG_KMS("Unsuitable framebuffer for plane\n");
777
		return -EINVAL;
778
	}
779

780 781 782
	/* setup can_scale, min_scale, max_scale */
	if (INTEL_INFO(dev)->gen >= 9) {
		/* use scaler when colorkey is not required */
783
		if (state->ckey.flags == I915_SET_COLORKEY_NONE) {
784 785 786 787 788 789 790 791 792 793 794 795 796 797
			can_scale = 1;
			min_scale = 1;
			max_scale = skl_max_scale(intel_crtc, crtc_state);
		} else {
			can_scale = 0;
			min_scale = DRM_PLANE_HELPER_NO_SCALING;
			max_scale = DRM_PLANE_HELPER_NO_SCALING;
		}
	} else {
		can_scale = intel_plane->can_scale;
		max_scale = intel_plane->max_downscale << 16;
		min_scale = intel_plane->can_scale ? 1 : (1 << 16);
	}

798 799 800 801 802
	/*
	 * FIXME the following code does a bunch of fuzzy adjustments to the
	 * coordinates and sizes. We probably need some way to decide whether
	 * more strict checking should be done instead.
	 */
803
	drm_rect_rotate(src, fb->width << 16, fb->height << 16,
804
			state->base.rotation);
805

806
	hscale = drm_rect_calc_hscale_relaxed(src, dst, min_scale, max_scale);
807
	BUG_ON(hscale < 0);
808

809
	vscale = drm_rect_calc_vscale_relaxed(src, dst, min_scale, max_scale);
810
	BUG_ON(vscale < 0);
811

812
	state->visible = drm_rect_clip_scaled(src, dst, clip, hscale, vscale);
813

814 815 816 817
	crtc_x = dst->x1;
	crtc_y = dst->y1;
	crtc_w = drm_rect_width(dst);
	crtc_h = drm_rect_height(dst);
818

819
	if (state->visible) {
820
		/* check again in case clipping clamped the results */
821
		hscale = drm_rect_calc_hscale(src, dst, min_scale, max_scale);
822 823
		if (hscale < 0) {
			DRM_DEBUG_KMS("Horizontal scaling factor out of limits\n");
824 825
			drm_rect_debug_print(src, true);
			drm_rect_debug_print(dst, false);
826 827 828 829

			return hscale;
		}

830
		vscale = drm_rect_calc_vscale(src, dst, min_scale, max_scale);
831 832
		if (vscale < 0) {
			DRM_DEBUG_KMS("Vertical scaling factor out of limits\n");
833 834
			drm_rect_debug_print(src, true);
			drm_rect_debug_print(dst, false);
835 836 837 838

			return vscale;
		}

839
		/* Make the source viewport size an exact multiple of the scaling factors. */
840 841 842
		drm_rect_adjust_size(src,
				     drm_rect_width(dst) * hscale - drm_rect_width(src),
				     drm_rect_height(dst) * vscale - drm_rect_height(src));
843

844
		drm_rect_rotate_inv(src, fb->width << 16, fb->height << 16,
845
				    state->base.rotation);
846

847
		/* sanity check to make sure the src viewport wasn't enlarged */
848 849 850 851
		WARN_ON(src->x1 < (int) state->base.src_x ||
			src->y1 < (int) state->base.src_y ||
			src->x2 > (int) state->base.src_x + state->base.src_w ||
			src->y2 > (int) state->base.src_y + state->base.src_h);
852 853 854 855 856 857 858

		/*
		 * Hardware doesn't handle subpixel coordinates.
		 * Adjust to (macro)pixel boundary, but be careful not to
		 * increase the source viewport size, because that could
		 * push the downscaling factor out of bounds.
		 */
859 860 861 862
		src_x = src->x1 >> 16;
		src_w = drm_rect_width(src) >> 16;
		src_y = src->y1 >> 16;
		src_h = drm_rect_height(src) >> 16;
863 864 865 866 867 868 869 870 871

		if (format_is_yuv(fb->pixel_format)) {
			src_x &= ~1;
			src_w &= ~1;

			/*
			 * Must keep src and dst the
			 * same if we can't scale.
			 */
872
			if (!can_scale)
873 874 875
				crtc_w &= ~1;

			if (crtc_w == 0)
876
				state->visible = false;
877 878 879 880
		}
	}

	/* Check size restrictions when scaling */
881
	if (state->visible && (src_w != crtc_w || src_h != crtc_h)) {
882 883
		unsigned int width_bytes;

884
		WARN_ON(!can_scale);
885 886 887 888

		/* FIXME interlacing min height is 6 */

		if (crtc_w < 3 || crtc_h < 3)
889
			state->visible = false;
890 891

		if (src_w < 3 || src_h < 3)
892
			state->visible = false;
893

894
		pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
895 896
		width_bytes = ((src_x * pixel_size) & 63) +
					src_w * pixel_size;
897

898 899
		if (INTEL_INFO(dev)->gen < 9 && (src_w > 2048 || src_h > 2048 ||
		    width_bytes > 4096 || fb->pitches[0] > 4096)) {
900 901 902 903 904
			DRM_DEBUG_KMS("Source dimensions exceed hardware limits\n");
			return -EINVAL;
		}
	}

905
	if (state->visible) {
906 907 908 909
		src->x1 = src_x << 16;
		src->x2 = (src_x + src_w) << 16;
		src->y1 = src_y << 16;
		src->y2 = (src_y + src_h) << 16;
910 911 912 913 914 915 916 917 918 919
	}

	dst->x1 = crtc_x;
	dst->x2 = crtc_x + crtc_w;
	dst->y1 = crtc_y;
	dst->y2 = crtc_y + crtc_h;

	return 0;
}

920 921 922 923
static void
intel_commit_sprite_plane(struct drm_plane *plane,
			  struct intel_plane_state *state)
{
924
	struct drm_crtc *crtc = state->base.crtc;
925
	struct intel_plane *intel_plane = to_intel_plane(plane);
926
	struct drm_framebuffer *fb = state->base.fb;
927

928 929
	crtc = crtc ? crtc : plane->crtc;

930
	if (!crtc->state->active)
931 932 933 934 935 936 937 938 939 940 941 942
		return;

	if (state->visible) {
		intel_plane->update_plane(plane, crtc, fb,
					  state->dst.x1, state->dst.y1,
					  drm_rect_width(&state->dst),
					  drm_rect_height(&state->dst),
					  state->src.x1 >> 16,
					  state->src.y1 >> 16,
					  drm_rect_width(&state->src) >> 16,
					  drm_rect_height(&state->src) >> 16);
	} else {
943
		intel_plane->disable_plane(plane, crtc);
944
	}
945 946
}

947 948 949 950 951
int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
			      struct drm_file *file_priv)
{
	struct drm_intel_sprite_colorkey *set = data;
	struct drm_plane *plane;
952 953 954
	struct drm_plane_state *plane_state;
	struct drm_atomic_state *state;
	struct drm_modeset_acquire_ctx ctx;
955 956 957 958 959 960
	int ret = 0;

	/* Make sure we don't try to enable both src & dest simultaneously */
	if ((set->flags & (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE)) == (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE))
		return -EINVAL;

961 962 963 964
	if (IS_VALLEYVIEW(dev) &&
	    set->flags & I915_SET_COLORKEY_DESTINATION)
		return -EINVAL;

R
Rob Clark 已提交
965
	plane = drm_plane_find(dev, set->plane_id);
966 967
	if (!plane || plane->type != DRM_PLANE_TYPE_OVERLAY)
		return -ENOENT;
968

969
	drm_modeset_acquire_init(&ctx, 0);
970

971 972 973 974
	state = drm_atomic_state_alloc(plane->dev);
	if (!state) {
		ret = -ENOMEM;
		goto out;
975
	}
976 977 978 979 980 981 982 983 984
	state->acquire_ctx = &ctx;

	while (1) {
		plane_state = drm_atomic_get_plane_state(state, plane);
		ret = PTR_ERR_OR_ZERO(plane_state);
		if (!ret) {
			to_intel_plane_state(plane_state)->ckey = *set;
			ret = drm_atomic_commit(state);
		}
985

986 987
		if (ret != -EDEADLK)
			break;
988

989 990 991
		drm_atomic_state_clear(state);
		drm_modeset_backoff(&ctx);
	}
992

993 994
	if (ret)
		drm_atomic_state_free(state);
995

996 997 998 999
out:
	drm_modeset_drop_locks(&ctx);
	drm_modeset_acquire_fini(&ctx);
	return ret;
1000 1001
}

1002
static const uint32_t ilk_plane_formats[] = {
1003 1004 1005 1006 1007 1008 1009
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1010
static const uint32_t snb_plane_formats[] = {
1011 1012 1013 1014 1015 1016 1017 1018
	DRM_FORMAT_XBGR8888,
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1019
static const uint32_t vlv_plane_formats[] = {
1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032
	DRM_FORMAT_RGB565,
	DRM_FORMAT_ABGR8888,
	DRM_FORMAT_ARGB8888,
	DRM_FORMAT_XBGR8888,
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_XBGR2101010,
	DRM_FORMAT_ABGR2101010,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044
static uint32_t skl_plane_formats[] = {
	DRM_FORMAT_RGB565,
	DRM_FORMAT_ABGR8888,
	DRM_FORMAT_ARGB8888,
	DRM_FORMAT_XBGR8888,
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1045
int
1046
intel_plane_init(struct drm_device *dev, enum pipe pipe, int plane)
1047 1048
{
	struct intel_plane *intel_plane;
1049
	struct intel_plane_state *state;
1050
	unsigned long possible_crtcs;
1051 1052
	const uint32_t *plane_formats;
	int num_plane_formats;
1053 1054
	int ret;

1055
	if (INTEL_INFO(dev)->gen < 5)
1056 1057
		return -ENODEV;

1058
	intel_plane = kzalloc(sizeof(*intel_plane), GFP_KERNEL);
1059 1060 1061
	if (!intel_plane)
		return -ENOMEM;

1062 1063
	state = intel_create_plane_state(&intel_plane->base);
	if (!state) {
1064 1065 1066
		kfree(intel_plane);
		return -ENOMEM;
	}
1067
	intel_plane->base.state = &state->base;
1068

1069 1070 1071
	switch (INTEL_INFO(dev)->gen) {
	case 5:
	case 6:
1072
		intel_plane->can_scale = true;
1073
		intel_plane->max_downscale = 16;
1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086
		intel_plane->update_plane = ilk_update_plane;
		intel_plane->disable_plane = ilk_disable_plane;

		if (IS_GEN6(dev)) {
			plane_formats = snb_plane_formats;
			num_plane_formats = ARRAY_SIZE(snb_plane_formats);
		} else {
			plane_formats = ilk_plane_formats;
			num_plane_formats = ARRAY_SIZE(ilk_plane_formats);
		}
		break;

	case 7:
B
Ben Widawsky 已提交
1087
	case 8:
1088
		if (IS_IVYBRIDGE(dev)) {
1089
			intel_plane->can_scale = true;
1090 1091 1092 1093 1094
			intel_plane->max_downscale = 2;
		} else {
			intel_plane->can_scale = false;
			intel_plane->max_downscale = 1;
		}
1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108

		if (IS_VALLEYVIEW(dev)) {
			intel_plane->update_plane = vlv_update_plane;
			intel_plane->disable_plane = vlv_disable_plane;

			plane_formats = vlv_plane_formats;
			num_plane_formats = ARRAY_SIZE(vlv_plane_formats);
		} else {
			intel_plane->update_plane = ivb_update_plane;
			intel_plane->disable_plane = ivb_disable_plane;

			plane_formats = snb_plane_formats;
			num_plane_formats = ARRAY_SIZE(snb_plane_formats);
		}
1109
		break;
1110
	case 9:
1111
		intel_plane->can_scale = true;
1112 1113
		intel_plane->update_plane = skl_update_plane;
		intel_plane->disable_plane = skl_disable_plane;
1114
		state->scaler_id = -1;
1115 1116 1117 1118

		plane_formats = skl_plane_formats;
		num_plane_formats = ARRAY_SIZE(skl_plane_formats);
		break;
1119
	default:
1120
		kfree(intel_plane);
1121
		return -ENODEV;
1122 1123 1124
	}

	intel_plane->pipe = pipe;
1125
	intel_plane->plane = plane;
1126
	intel_plane->frontbuffer_bit = INTEL_FRONTBUFFER_SPRITE(pipe, plane);
1127 1128
	intel_plane->check_plane = intel_check_sprite_plane;
	intel_plane->commit_plane = intel_commit_sprite_plane;
1129
	possible_crtcs = (1 << pipe);
1130
	ret = drm_universal_plane_init(dev, &intel_plane->base, possible_crtcs,
1131
				       &intel_plane_funcs,
1132 1133
				       plane_formats, num_plane_formats,
				       DRM_PLANE_TYPE_OVERLAY);
1134
	if (ret) {
1135
		kfree(intel_plane);
1136 1137 1138
		goto out;
	}

1139
	intel_create_rotation_property(dev, intel_plane);
1140

1141 1142
	drm_plane_helper_add(&intel_plane->base, &intel_plane_helper_funcs);

1143
out:
1144 1145
	return ret;
}