intel_sprite.c 47.1 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
/*
 * Copyright © 2011 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 *
 * Authors:
 *   Jesse Barnes <jbarnes@virtuousgeek.org>
 *
 * New plane/sprite handling.
 *
 * The older chips had a separate interface for programming plane related
 * registers; newer ones are much simpler and we can use the new DRM plane
 * support.
 */
32 33 34
#include <drm/drmP.h>
#include <drm/drm_crtc.h>
#include <drm/drm_fourcc.h>
35
#include <drm/drm_rect.h>
36
#include "intel_drv.h"
37
#include <drm/i915_drm.h>
38 39
#include "i915_drv.h"

40 41 42 43 44 45 46 47 48 49 50 51 52 53
static bool
format_is_yuv(uint32_t format)
{
	switch (format) {
	case DRM_FORMAT_YUYV:
	case DRM_FORMAT_UYVY:
	case DRM_FORMAT_VYUY:
	case DRM_FORMAT_YVYU:
		return true;
	default:
		return false;
	}
}

54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69
static int usecs_to_scanlines(const struct drm_display_mode *mode, int usecs)
{
	/* paranoia */
	if (!mode->crtc_htotal)
		return 1;

	return DIV_ROUND_UP(usecs * mode->crtc_clock, 1000 * mode->crtc_htotal);
}

static bool intel_pipe_update_start(struct intel_crtc *crtc, uint32_t *start_vbl_count)
{
	struct drm_device *dev = crtc->base.dev;
	const struct drm_display_mode *mode = &crtc->config.adjusted_mode;
	enum pipe pipe = crtc->pipe;
	long timeout = msecs_to_jiffies_timeout(1);
	int scanline, min, max, vblank_start;
70
	wait_queue_head_t *wq = drm_crtc_vblank_waitqueue(&crtc->base);
71 72
	DEFINE_WAIT(wait);

73
	WARN_ON(!drm_modeset_is_locked(&crtc->base.mutex));
74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90

	vblank_start = mode->crtc_vblank_start;
	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
		vblank_start = DIV_ROUND_UP(vblank_start, 2);

	/* FIXME needs to be calibrated sensibly */
	min = vblank_start - usecs_to_scanlines(mode, 100);
	max = vblank_start - 1;

	if (min <= 0 || max <= 0)
		return false;

	if (WARN_ON(drm_vblank_get(dev, pipe)))
		return false;

	local_irq_disable();

91 92
	trace_i915_pipe_update_start(crtc, min, max);

93 94 95 96 97 98
	for (;;) {
		/*
		 * prepare_to_wait() has a memory barrier, which guarantees
		 * other CPUs can see the task state update by the time we
		 * read the scanline.
		 */
99
		prepare_to_wait(wq, &wait, TASK_UNINTERRUPTIBLE);
100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117

		scanline = intel_get_crtc_scanline(crtc);
		if (scanline < min || scanline > max)
			break;

		if (timeout <= 0) {
			DRM_ERROR("Potential atomic update failure on pipe %c\n",
				  pipe_name(crtc->pipe));
			break;
		}

		local_irq_enable();

		timeout = schedule_timeout(timeout);

		local_irq_disable();
	}

118
	finish_wait(wq, &wait);
119 120 121 122 123

	drm_vblank_put(dev, pipe);

	*start_vbl_count = dev->driver->get_vblank_counter(dev, pipe);

124 125
	trace_i915_pipe_update_vblank_evaded(crtc, min, max, *start_vbl_count);

126 127 128 129 130 131 132 133 134
	return true;
}

static void intel_pipe_update_end(struct intel_crtc *crtc, u32 start_vbl_count)
{
	struct drm_device *dev = crtc->base.dev;
	enum pipe pipe = crtc->pipe;
	u32 end_vbl_count = dev->driver->get_vblank_counter(dev, pipe);

135 136
	trace_i915_pipe_update_end(crtc, end_vbl_count);

137 138 139 140 141 142 143
	local_irq_enable();

	if (start_vbl_count != end_vbl_count)
		DRM_ERROR("Atomic update failure on pipe %c (start=%u end=%u)\n",
			  pipe_name(pipe), start_vbl_count, end_vbl_count);
}

144 145 146 147 148 149 150 151 152 153 154
static void intel_update_primary_plane(struct intel_crtc *crtc)
{
	struct drm_i915_private *dev_priv = crtc->base.dev->dev_private;
	int reg = DSPCNTR(crtc->plane);

	if (crtc->primary_enabled)
		I915_WRITE(reg, I915_READ(reg) | DISPLAY_PLANE_ENABLE);
	else
		I915_WRITE(reg, I915_READ(reg) & ~DISPLAY_PLANE_ENABLE);
}

155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178
static void
skl_update_plane(struct drm_plane *drm_plane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
		 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = drm_plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(drm_plane);
	const int pipe = intel_plane->pipe;
	const int plane = intel_plane->plane + 1;
	u32 plane_ctl, stride;
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);

	plane_ctl = I915_READ(PLANE_CTL(pipe, plane));

	/* Mask out pixel format bits in case we change it */
	plane_ctl &= ~PLANE_CTL_FORMAT_MASK;
	plane_ctl &= ~PLANE_CTL_ORDER_RGBX;
	plane_ctl &= ~PLANE_CTL_YUV422_ORDER_MASK;
	plane_ctl &= ~PLANE_CTL_TILED_MASK;
	plane_ctl &= ~PLANE_CTL_ALPHA_MASK;
179
	plane_ctl &= ~PLANE_CTL_ROTATE_MASK;
180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234

	/* Trickle feed has to be enabled */
	plane_ctl &= ~PLANE_CTL_TRICKLE_FEED_DISABLE;

	switch (fb->pixel_format) {
	case DRM_FORMAT_RGB565:
		plane_ctl |= PLANE_CTL_FORMAT_RGB_565;
		break;
	case DRM_FORMAT_XBGR8888:
		plane_ctl |= PLANE_CTL_FORMAT_XRGB_8888 | PLANE_CTL_ORDER_RGBX;
		break;
	case DRM_FORMAT_XRGB8888:
		plane_ctl |= PLANE_CTL_FORMAT_XRGB_8888;
		break;
	/*
	 * XXX: For ARBG/ABGR formats we default to expecting scanout buffers
	 * to be already pre-multiplied. We need to add a knob (or a different
	 * DRM_FORMAT) for user-space to configure that.
	 */
	case DRM_FORMAT_ABGR8888:
		plane_ctl |= PLANE_CTL_FORMAT_XRGB_8888 |
			     PLANE_CTL_ORDER_RGBX |
			     PLANE_CTL_ALPHA_SW_PREMULTIPLY;
		break;
	case DRM_FORMAT_ARGB8888:
		plane_ctl |= PLANE_CTL_FORMAT_XRGB_8888 |
			     PLANE_CTL_ALPHA_SW_PREMULTIPLY;
		break;
	case DRM_FORMAT_YUYV:
		plane_ctl |= PLANE_CTL_FORMAT_YUV422 | PLANE_CTL_YUV422_YUYV;
		break;
	case DRM_FORMAT_YVYU:
		plane_ctl |= PLANE_CTL_FORMAT_YUV422 | PLANE_CTL_YUV422_YVYU;
		break;
	case DRM_FORMAT_UYVY:
		plane_ctl |= PLANE_CTL_FORMAT_YUV422 | PLANE_CTL_YUV422_UYVY;
		break;
	case DRM_FORMAT_VYUY:
		plane_ctl |= PLANE_CTL_FORMAT_YUV422 | PLANE_CTL_YUV422_VYUY;
		break;
	default:
		BUG();
	}

	switch (obj->tiling_mode) {
	case I915_TILING_NONE:
		stride = fb->pitches[0] >> 6;
		break;
	case I915_TILING_X:
		plane_ctl |= PLANE_CTL_TILED_X;
		stride = fb->pitches[0] >> 9;
		break;
	default:
		BUG();
	}
235 236
	if (intel_plane->rotation == BIT(DRM_ROTATE_180))
		plane_ctl |= PLANE_CTL_ROTATE_180;
237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335

	plane_ctl |= PLANE_CTL_ENABLE;
	plane_ctl |= PLANE_CTL_PIPE_CSC_ENABLE;

	intel_update_sprite_watermarks(drm_plane, crtc, src_w, src_h,
				       pixel_size, true,
				       src_w != crtc_w || src_h != crtc_h);

	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

	I915_WRITE(PLANE_OFFSET(pipe, plane), (y << 16) | x);
	I915_WRITE(PLANE_STRIDE(pipe, plane), stride);
	I915_WRITE(PLANE_POS(pipe, plane), (crtc_y << 16) | crtc_x);
	I915_WRITE(PLANE_SIZE(pipe, plane), (crtc_h << 16) | crtc_w);
	I915_WRITE(PLANE_CTL(pipe, plane), plane_ctl);
	I915_WRITE(PLANE_SURF(pipe, plane), i915_gem_obj_ggtt_offset(obj));
	POSTING_READ(PLANE_SURF(pipe, plane));
}

static void
skl_disable_plane(struct drm_plane *drm_plane, struct drm_crtc *crtc)
{
	struct drm_device *dev = drm_plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(drm_plane);
	const int pipe = intel_plane->pipe;
	const int plane = intel_plane->plane + 1;

	I915_WRITE(PLANE_CTL(pipe, plane),
		   I915_READ(PLANE_CTL(pipe, plane)) & ~PLANE_CTL_ENABLE);

	/* Activate double buffered register update */
	I915_WRITE(PLANE_CTL(pipe, plane), 0);
	POSTING_READ(PLANE_CTL(pipe, plane));

	intel_update_sprite_watermarks(drm_plane, crtc, 0, 0, 0, false, false);
}

static int
skl_update_colorkey(struct drm_plane *drm_plane,
		    struct drm_intel_sprite_colorkey *key)
{
	struct drm_device *dev = drm_plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(drm_plane);
	const int pipe = intel_plane->pipe;
	const int plane = intel_plane->plane;
	u32 plane_ctl;

	I915_WRITE(PLANE_KEYVAL(pipe, plane), key->min_value);
	I915_WRITE(PLANE_KEYMAX(pipe, plane), key->max_value);
	I915_WRITE(PLANE_KEYMSK(pipe, plane), key->channel_mask);

	plane_ctl = I915_READ(PLANE_CTL(pipe, plane));
	plane_ctl &= ~PLANE_CTL_KEY_ENABLE_MASK;
	if (key->flags & I915_SET_COLORKEY_DESTINATION)
		plane_ctl |= PLANE_CTL_KEY_ENABLE_DESTINATION;
	else if (key->flags & I915_SET_COLORKEY_SOURCE)
		plane_ctl |= PLANE_CTL_KEY_ENABLE_SOURCE;
	I915_WRITE(PLANE_CTL(pipe, plane), plane_ctl);

	POSTING_READ(PLANE_CTL(pipe, plane));

	return 0;
}

static void
skl_get_colorkey(struct drm_plane *drm_plane,
		 struct drm_intel_sprite_colorkey *key)
{
	struct drm_device *dev = drm_plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(drm_plane);
	const int pipe = intel_plane->pipe;
	const int plane = intel_plane->plane;
	u32 plane_ctl;

	key->min_value = I915_READ(PLANE_KEYVAL(pipe, plane));
	key->max_value = I915_READ(PLANE_KEYMAX(pipe, plane));
	key->channel_mask = I915_READ(PLANE_KEYMSK(pipe, plane));

	plane_ctl = I915_READ(PLANE_CTL(pipe, plane));

	switch (plane_ctl & PLANE_CTL_KEY_ENABLE_MASK) {
	case PLANE_CTL_KEY_ENABLE_DESTINATION:
		key->flags = I915_SET_COLORKEY_DESTINATION;
		break;
	case PLANE_CTL_KEY_ENABLE_SOURCE:
		key->flags = I915_SET_COLORKEY_SOURCE;
		break;
	default:
		key->flags = I915_SET_COLORKEY_NONE;
	}
}

336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374
static void
chv_update_csc(struct intel_plane *intel_plane, uint32_t format)
{
	struct drm_i915_private *dev_priv = intel_plane->base.dev->dev_private;
	int plane = intel_plane->plane;

	/* Seems RGB data bypasses the CSC always */
	if (!format_is_yuv(format))
		return;

	/*
	 * BT.601 limited range YCbCr -> full range RGB
	 *
	 * |r|   | 6537 4769     0|   |cr  |
	 * |g| = |-3330 4769 -1605| x |y-64|
	 * |b|   |    0 4769  8263|   |cb  |
	 *
	 * Cb and Cr apparently come in as signed already, so no
	 * need for any offset. For Y we need to remove the offset.
	 */
	I915_WRITE(SPCSCYGOFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(-64));
	I915_WRITE(SPCSCCBOFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(0));
	I915_WRITE(SPCSCCROFF(plane), SPCSC_OOFF(0) | SPCSC_IOFF(0));

	I915_WRITE(SPCSCC01(plane), SPCSC_C1(4769) | SPCSC_C0(6537));
	I915_WRITE(SPCSCC23(plane), SPCSC_C1(-3330) | SPCSC_C0(0));
	I915_WRITE(SPCSCC45(plane), SPCSC_C1(-1605) | SPCSC_C0(4769));
	I915_WRITE(SPCSCC67(plane), SPCSC_C1(4769) | SPCSC_C0(0));
	I915_WRITE(SPCSCC8(plane), SPCSC_C0(8263));

	I915_WRITE(SPCSCYGICLAMP(plane), SPCSC_IMAX(940) | SPCSC_IMIN(64));
	I915_WRITE(SPCSCCBICLAMP(plane), SPCSC_IMAX(448) | SPCSC_IMIN(-448));
	I915_WRITE(SPCSCCRICLAMP(plane), SPCSC_IMAX(448) | SPCSC_IMIN(-448));

	I915_WRITE(SPCSCYGOCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
	I915_WRITE(SPCSCCBOCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
	I915_WRITE(SPCSCCROCLAMP(plane), SPCSC_OMAX(1023) | SPCSC_OMIN(0));
}

375
static void
376 377
vlv_update_plane(struct drm_plane *dplane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
378 379 380 381 382 383 384 385
		 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = dplane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(dplane);
386
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
387 388 389 390 391
	int pipe = intel_plane->pipe;
	int plane = intel_plane->plane;
	u32 sprctl;
	unsigned long sprsurf_offset, linear_offset;
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
392 393
	u32 start_vbl_count;
	bool atomic_update;
394 395 396 397 398 399 400

	sprctl = I915_READ(SPCNTR(pipe, plane));

	/* Mask out pixel format bits in case we change it */
	sprctl &= ~SP_PIXFORMAT_MASK;
	sprctl &= ~SP_YUV_BYTE_ORDER_MASK;
	sprctl &= ~SP_TILED;
401
	sprctl &= ~SP_ROTATE_180;
402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445

	switch (fb->pixel_format) {
	case DRM_FORMAT_YUYV:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YUYV;
		break;
	case DRM_FORMAT_YVYU:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_YVYU;
		break;
	case DRM_FORMAT_UYVY:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_UYVY;
		break;
	case DRM_FORMAT_VYUY:
		sprctl |= SP_FORMAT_YUV422 | SP_YUV_ORDER_VYUY;
		break;
	case DRM_FORMAT_RGB565:
		sprctl |= SP_FORMAT_BGR565;
		break;
	case DRM_FORMAT_XRGB8888:
		sprctl |= SP_FORMAT_BGRX8888;
		break;
	case DRM_FORMAT_ARGB8888:
		sprctl |= SP_FORMAT_BGRA8888;
		break;
	case DRM_FORMAT_XBGR2101010:
		sprctl |= SP_FORMAT_RGBX1010102;
		break;
	case DRM_FORMAT_ABGR2101010:
		sprctl |= SP_FORMAT_RGBA1010102;
		break;
	case DRM_FORMAT_XBGR8888:
		sprctl |= SP_FORMAT_RGBX8888;
		break;
	case DRM_FORMAT_ABGR8888:
		sprctl |= SP_FORMAT_RGBA8888;
		break;
	default:
		/*
		 * If we get here one of the upper layers failed to filter
		 * out the unsupported plane formats
		 */
		BUG();
		break;
	}

446 447 448 449 450 451
	/*
	 * Enable gamma to match primary/cursor plane behaviour.
	 * FIXME should be user controllable via propertiesa.
	 */
	sprctl |= SP_GAMMA_ENABLE;

452 453 454 455 456
	if (obj->tiling_mode != I915_TILING_NONE)
		sprctl |= SP_TILED;

	sprctl |= SP_ENABLE;

457 458
	intel_update_sprite_watermarks(dplane, crtc, src_w, src_h,
				       pixel_size, true,
459 460
				       src_w != crtc_w || src_h != crtc_h);

461 462 463 464 465 466 467 468 469 470 471 472 473
	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

	linear_offset = y * fb->pitches[0] + x * pixel_size;
	sprsurf_offset = intel_gen4_compute_page_offset(&x, &y,
							obj->tiling_mode,
							pixel_size,
							fb->pitches[0]);
	linear_offset -= sprsurf_offset;

474 475 476 477 478 479 480 481
	if (intel_plane->rotation == BIT(DRM_ROTATE_180)) {
		sprctl |= SP_ROTATE_180;

		x += src_w;
		y += src_h;
		linear_offset += src_h * fb->pitches[0] + src_w * pixel_size;
	}

482 483
	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);

484 485
	intel_update_primary_plane(intel_crtc);

486 487 488
	if (IS_CHERRYVIEW(dev) && pipe == PIPE_B)
		chv_update_csc(intel_plane, fb->pixel_format);

489 490 491
	I915_WRITE(SPSTRIDE(pipe, plane), fb->pitches[0]);
	I915_WRITE(SPPOS(pipe, plane), (crtc_y << 16) | crtc_x);

492 493 494 495 496
	if (obj->tiling_mode != I915_TILING_NONE)
		I915_WRITE(SPTILEOFF(pipe, plane), (y << 16) | x);
	else
		I915_WRITE(SPLINOFF(pipe, plane), linear_offset);

497 498
	I915_WRITE(SPCONSTALPHA(pipe, plane), 0);

499 500
	I915_WRITE(SPSIZE(pipe, plane), (crtc_h << 16) | crtc_w);
	I915_WRITE(SPCNTR(pipe, plane), sprctl);
501 502
	I915_WRITE(SPSURF(pipe, plane), i915_gem_obj_ggtt_offset(obj) +
		   sprsurf_offset);
503 504

	intel_flush_primary_plane(dev_priv, intel_crtc->plane);
505 506 507

	if (atomic_update)
		intel_pipe_update_end(intel_crtc, start_vbl_count);
508 509 510
}

static void
511
vlv_disable_plane(struct drm_plane *dplane, struct drm_crtc *crtc)
512 513 514 515
{
	struct drm_device *dev = dplane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(dplane);
516
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
517 518
	int pipe = intel_plane->pipe;
	int plane = intel_plane->plane;
519 520 521 522
	u32 start_vbl_count;
	bool atomic_update;

	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
523

524 525
	intel_update_primary_plane(intel_crtc);

526 527 528
	I915_WRITE(SPCNTR(pipe, plane), I915_READ(SPCNTR(pipe, plane)) &
		   ~SP_ENABLE);
	/* Activate double buffered register update */
529
	I915_WRITE(SPSURF(pipe, plane), 0);
530 531

	intel_flush_primary_plane(dev_priv, intel_crtc->plane);
532

533 534 535
	if (atomic_update)
		intel_pipe_update_end(intel_crtc, start_vbl_count);

536
	intel_update_sprite_watermarks(dplane, crtc, 0, 0, 0, false, false);
537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589
}

static int
vlv_update_colorkey(struct drm_plane *dplane,
		    struct drm_intel_sprite_colorkey *key)
{
	struct drm_device *dev = dplane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(dplane);
	int pipe = intel_plane->pipe;
	int plane = intel_plane->plane;
	u32 sprctl;

	if (key->flags & I915_SET_COLORKEY_DESTINATION)
		return -EINVAL;

	I915_WRITE(SPKEYMINVAL(pipe, plane), key->min_value);
	I915_WRITE(SPKEYMAXVAL(pipe, plane), key->max_value);
	I915_WRITE(SPKEYMSK(pipe, plane), key->channel_mask);

	sprctl = I915_READ(SPCNTR(pipe, plane));
	sprctl &= ~SP_SOURCE_KEY;
	if (key->flags & I915_SET_COLORKEY_SOURCE)
		sprctl |= SP_SOURCE_KEY;
	I915_WRITE(SPCNTR(pipe, plane), sprctl);

	POSTING_READ(SPKEYMSK(pipe, plane));

	return 0;
}

static void
vlv_get_colorkey(struct drm_plane *dplane,
		 struct drm_intel_sprite_colorkey *key)
{
	struct drm_device *dev = dplane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(dplane);
	int pipe = intel_plane->pipe;
	int plane = intel_plane->plane;
	u32 sprctl;

	key->min_value = I915_READ(SPKEYMINVAL(pipe, plane));
	key->max_value = I915_READ(SPKEYMAXVAL(pipe, plane));
	key->channel_mask = I915_READ(SPKEYMSK(pipe, plane));

	sprctl = I915_READ(SPCNTR(pipe, plane));
	if (sprctl & SP_SOURCE_KEY)
		key->flags = I915_SET_COLORKEY_SOURCE;
	else
		key->flags = I915_SET_COLORKEY_NONE;
}

590
static void
591 592
ivb_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
593 594 595 596 597 598 599 600
		 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
601
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
602 603
	int pipe = intel_plane->pipe;
	u32 sprctl, sprscale = 0;
604
	unsigned long sprsurf_offset, linear_offset;
V
Ville Syrjälä 已提交
605
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
606 607
	u32 start_vbl_count;
	bool atomic_update;
608 609 610 611 612 613 614

	sprctl = I915_READ(SPRCTL(pipe));

	/* Mask out pixel format bits in case we change it */
	sprctl &= ~SPRITE_PIXFORMAT_MASK;
	sprctl &= ~SPRITE_RGB_ORDER_RGBX;
	sprctl &= ~SPRITE_YUV_BYTE_ORDER_MASK;
615
	sprctl &= ~SPRITE_TILED;
616
	sprctl &= ~SPRITE_ROTATE_180;
617 618 619

	switch (fb->pixel_format) {
	case DRM_FORMAT_XBGR8888:
620
		sprctl |= SPRITE_FORMAT_RGBX888 | SPRITE_RGB_ORDER_RGBX;
621 622
		break;
	case DRM_FORMAT_XRGB8888:
623
		sprctl |= SPRITE_FORMAT_RGBX888;
624 625 626 627 628 629 630 631 632 633 634 635 636 637
		break;
	case DRM_FORMAT_YUYV:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YUYV;
		break;
	case DRM_FORMAT_YVYU:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_YVYU;
		break;
	case DRM_FORMAT_UYVY:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_UYVY;
		break;
	case DRM_FORMAT_VYUY:
		sprctl |= SPRITE_FORMAT_YUV422 | SPRITE_YUV_ORDER_VYUY;
		break;
	default:
638
		BUG();
639 640
	}

641 642 643 644 645 646
	/*
	 * Enable gamma to match primary/cursor plane behaviour.
	 * FIXME should be user controllable via propertiesa.
	 */
	sprctl |= SPRITE_GAMMA_ENABLE;

647 648 649
	if (obj->tiling_mode != I915_TILING_NONE)
		sprctl |= SPRITE_TILED;

650
	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
651 652 653 654
		sprctl &= ~SPRITE_TRICKLE_FEED_DISABLE;
	else
		sprctl |= SPRITE_TRICKLE_FEED_DISABLE;

655 656
	sprctl |= SPRITE_ENABLE;

657
	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
658 659
		sprctl |= SPRITE_PIPE_CSC_ENABLE;

660 661
	intel_update_sprite_watermarks(plane, crtc, src_w, src_h, pixel_size,
				       true,
662 663
				       src_w != crtc_w || src_h != crtc_h);

664 665 666 667 668 669
	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

670
	if (crtc_w != src_w || crtc_h != src_h)
671 672
		sprscale = SPRITE_SCALE_ENABLE | (src_w << 16) | src_h;

673
	linear_offset = y * fb->pitches[0] + x * pixel_size;
674
	sprsurf_offset =
675 676
		intel_gen4_compute_page_offset(&x, &y, obj->tiling_mode,
					       pixel_size, fb->pitches[0]);
677 678
	linear_offset -= sprsurf_offset;

679 680 681 682 683 684 685 686 687 688 689 690
	if (intel_plane->rotation == BIT(DRM_ROTATE_180)) {
		sprctl |= SPRITE_ROTATE_180;

		/* HSW and BDW does this automagically in hardware */
		if (!IS_HASWELL(dev) && !IS_BROADWELL(dev)) {
			x += src_w;
			y += src_h;
			linear_offset += src_h * fb->pitches[0] +
				src_w * pixel_size;
		}
	}

691 692
	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);

693 694
	intel_update_primary_plane(intel_crtc);

695 696 697
	I915_WRITE(SPRSTRIDE(pipe), fb->pitches[0]);
	I915_WRITE(SPRPOS(pipe), (crtc_y << 16) | crtc_x);

698 699
	/* HSW consolidates SPRTILEOFF and SPRLINOFF into a single SPROFFSET
	 * register */
700
	if (IS_HASWELL(dev) || IS_BROADWELL(dev))
701
		I915_WRITE(SPROFFSET(pipe), (y << 16) | x);
702
	else if (obj->tiling_mode != I915_TILING_NONE)
703
		I915_WRITE(SPRTILEOFF(pipe), (y << 16) | x);
704 705
	else
		I915_WRITE(SPRLINOFF(pipe), linear_offset);
706

707
	I915_WRITE(SPRSIZE(pipe), (crtc_h << 16) | crtc_w);
708 709
	if (intel_plane->can_scale)
		I915_WRITE(SPRSCALE(pipe), sprscale);
710
	I915_WRITE(SPRCTL(pipe), sprctl);
711 712
	I915_WRITE(SPRSURF(pipe),
		   i915_gem_obj_ggtt_offset(obj) + sprsurf_offset);
713 714

	intel_flush_primary_plane(dev_priv, intel_crtc->plane);
715 716 717

	if (atomic_update)
		intel_pipe_update_end(intel_crtc, start_vbl_count);
718 719 720
}

static void
721
ivb_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
722 723 724 725
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
726
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
727
	int pipe = intel_plane->pipe;
728 729 730 731
	u32 start_vbl_count;
	bool atomic_update;

	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
732

733 734
	intel_update_primary_plane(intel_crtc);

735 736
	I915_WRITE(SPRCTL(pipe), I915_READ(SPRCTL(pipe)) & ~SPRITE_ENABLE);
	/* Can't leave the scaler enabled... */
737 738
	if (intel_plane->can_scale)
		I915_WRITE(SPRSCALE(pipe), 0);
739
	/* Activate double buffered register update */
740
	I915_WRITE(SPRSURF(pipe), 0);
741 742

	intel_flush_primary_plane(dev_priv, intel_crtc->plane);
743

744 745 746
	if (atomic_update)
		intel_pipe_update_end(intel_crtc, start_vbl_count);

747 748 749 750 751 752
	/*
	 * Avoid underruns when disabling the sprite.
	 * FIXME remove once watermark updates are done properly.
	 */
	intel_wait_for_vblank(dev, pipe);

753
	intel_update_sprite_watermarks(plane, crtc, 0, 0, 0, false, false);
754 755
}

756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809
static int
ivb_update_colorkey(struct drm_plane *plane,
		    struct drm_intel_sprite_colorkey *key)
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane;
	u32 sprctl;
	int ret = 0;

	intel_plane = to_intel_plane(plane);

	I915_WRITE(SPRKEYVAL(intel_plane->pipe), key->min_value);
	I915_WRITE(SPRKEYMAX(intel_plane->pipe), key->max_value);
	I915_WRITE(SPRKEYMSK(intel_plane->pipe), key->channel_mask);

	sprctl = I915_READ(SPRCTL(intel_plane->pipe));
	sprctl &= ~(SPRITE_SOURCE_KEY | SPRITE_DEST_KEY);
	if (key->flags & I915_SET_COLORKEY_DESTINATION)
		sprctl |= SPRITE_DEST_KEY;
	else if (key->flags & I915_SET_COLORKEY_SOURCE)
		sprctl |= SPRITE_SOURCE_KEY;
	I915_WRITE(SPRCTL(intel_plane->pipe), sprctl);

	POSTING_READ(SPRKEYMSK(intel_plane->pipe));

	return ret;
}

static void
ivb_get_colorkey(struct drm_plane *plane, struct drm_intel_sprite_colorkey *key)
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane;
	u32 sprctl;

	intel_plane = to_intel_plane(plane);

	key->min_value = I915_READ(SPRKEYVAL(intel_plane->pipe));
	key->max_value = I915_READ(SPRKEYMAX(intel_plane->pipe));
	key->channel_mask = I915_READ(SPRKEYMSK(intel_plane->pipe));
	key->flags = 0;

	sprctl = I915_READ(SPRCTL(intel_plane->pipe));

	if (sprctl & SPRITE_DEST_KEY)
		key->flags = I915_SET_COLORKEY_DESTINATION;
	else if (sprctl & SPRITE_SOURCE_KEY)
		key->flags = I915_SET_COLORKEY_SOURCE;
	else
		key->flags = I915_SET_COLORKEY_NONE;
}

810
static void
811 812
ilk_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
		 struct drm_framebuffer *fb,
813 814 815 816 817 818 819 820
		 struct drm_i915_gem_object *obj, int crtc_x, int crtc_y,
		 unsigned int crtc_w, unsigned int crtc_h,
		 uint32_t x, uint32_t y,
		 uint32_t src_w, uint32_t src_h)
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
821
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
V
Ville Syrjälä 已提交
822
	int pipe = intel_plane->pipe;
823
	unsigned long dvssurf_offset, linear_offset;
824
	u32 dvscntr, dvsscale;
V
Ville Syrjälä 已提交
825
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
826 827
	u32 start_vbl_count;
	bool atomic_update;
828 829 830 831 832

	dvscntr = I915_READ(DVSCNTR(pipe));

	/* Mask out pixel format bits in case we change it */
	dvscntr &= ~DVS_PIXFORMAT_MASK;
833
	dvscntr &= ~DVS_RGB_ORDER_XBGR;
834
	dvscntr &= ~DVS_YUV_BYTE_ORDER_MASK;
835
	dvscntr &= ~DVS_TILED;
836
	dvscntr &= ~DVS_ROTATE_180;
837 838 839

	switch (fb->pixel_format) {
	case DRM_FORMAT_XBGR8888:
840
		dvscntr |= DVS_FORMAT_RGBX888 | DVS_RGB_ORDER_XBGR;
841 842
		break;
	case DRM_FORMAT_XRGB8888:
843
		dvscntr |= DVS_FORMAT_RGBX888;
844 845 846 847 848 849 850 851 852 853 854 855 856 857
		break;
	case DRM_FORMAT_YUYV:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YUYV;
		break;
	case DRM_FORMAT_YVYU:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_YVYU;
		break;
	case DRM_FORMAT_UYVY:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_UYVY;
		break;
	case DRM_FORMAT_VYUY:
		dvscntr |= DVS_FORMAT_YUV422 | DVS_YUV_ORDER_VYUY;
		break;
	default:
858
		BUG();
859 860
	}

861 862 863 864 865 866
	/*
	 * Enable gamma to match primary/cursor plane behaviour.
	 * FIXME should be user controllable via propertiesa.
	 */
	dvscntr |= DVS_GAMMA_ENABLE;

867 868 869
	if (obj->tiling_mode != I915_TILING_NONE)
		dvscntr |= DVS_TILED;

870 871
	if (IS_GEN6(dev))
		dvscntr |= DVS_TRICKLE_FEED_DISABLE; /* must disable */
872 873
	dvscntr |= DVS_ENABLE;

874 875
	intel_update_sprite_watermarks(plane, crtc, src_w, src_h,
				       pixel_size, true,
876 877
				       src_w != crtc_w || src_h != crtc_h);

878 879 880 881 882 883
	/* Sizes are 0 based */
	src_w--;
	src_h--;
	crtc_w--;
	crtc_h--;

884
	dvsscale = 0;
885
	if (crtc_w != src_w || crtc_h != src_h)
886 887
		dvsscale = DVS_SCALE_ENABLE | (src_w << 16) | src_h;

888
	linear_offset = y * fb->pitches[0] + x * pixel_size;
889
	dvssurf_offset =
890 891
		intel_gen4_compute_page_offset(&x, &y, obj->tiling_mode,
					       pixel_size, fb->pitches[0]);
892 893
	linear_offset -= dvssurf_offset;

894 895 896 897 898 899 900 901
	if (intel_plane->rotation == BIT(DRM_ROTATE_180)) {
		dvscntr |= DVS_ROTATE_180;

		x += src_w;
		y += src_h;
		linear_offset += src_h * fb->pitches[0] + src_w * pixel_size;
	}

902 903
	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);

904 905
	intel_update_primary_plane(intel_crtc);

906 907 908
	I915_WRITE(DVSSTRIDE(pipe), fb->pitches[0]);
	I915_WRITE(DVSPOS(pipe), (crtc_y << 16) | crtc_x);

909
	if (obj->tiling_mode != I915_TILING_NONE)
910
		I915_WRITE(DVSTILEOFF(pipe), (y << 16) | x);
911 912
	else
		I915_WRITE(DVSLINOFF(pipe), linear_offset);
913 914 915 916

	I915_WRITE(DVSSIZE(pipe), (crtc_h << 16) | crtc_w);
	I915_WRITE(DVSSCALE(pipe), dvsscale);
	I915_WRITE(DVSCNTR(pipe), dvscntr);
917 918
	I915_WRITE(DVSSURF(pipe),
		   i915_gem_obj_ggtt_offset(obj) + dvssurf_offset);
919 920

	intel_flush_primary_plane(dev_priv, intel_crtc->plane);
921 922 923

	if (atomic_update)
		intel_pipe_update_end(intel_crtc, start_vbl_count);
924 925 926
}

static void
927
ilk_disable_plane(struct drm_plane *plane, struct drm_crtc *crtc)
928 929 930 931
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane = to_intel_plane(plane);
932
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
933
	int pipe = intel_plane->pipe;
934 935 936 937
	u32 start_vbl_count;
	bool atomic_update;

	atomic_update = intel_pipe_update_start(intel_crtc, &start_vbl_count);
938

939 940
	intel_update_primary_plane(intel_crtc);

941 942 943 944
	I915_WRITE(DVSCNTR(pipe), I915_READ(DVSCNTR(pipe)) & ~DVS_ENABLE);
	/* Disable the scaler */
	I915_WRITE(DVSSCALE(pipe), 0);
	/* Flush double buffered register updates */
945
	I915_WRITE(DVSSURF(pipe), 0);
946 947

	intel_flush_primary_plane(dev_priv, intel_crtc->plane);
948

949 950 951
	if (atomic_update)
		intel_pipe_update_end(intel_crtc, start_vbl_count);

952 953 954 955 956 957
	/*
	 * Avoid underruns when disabling the sprite.
	 * FIXME remove once watermark updates are done properly.
	 */
	intel_wait_for_vblank(dev, pipe);

958
	intel_update_sprite_watermarks(plane, crtc, 0, 0, 0, false, false);
959 960
}

961
static void
962
intel_post_enable_primary(struct drm_crtc *crtc)
963 964 965
{
	struct drm_device *dev = crtc->dev;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
966

967 968 969 970 971 972 973 974
	/*
	 * BDW signals flip done immediately if the plane
	 * is disabled, even if the plane enable is already
	 * armed to occur at the next vblank :(
	 */
	if (IS_BROADWELL(dev))
		intel_wait_for_vblank(dev, intel_crtc->pipe);

975 976 977 978 979 980
	/*
	 * FIXME IPS should be fine as long as one plane is
	 * enabled, but in practice it seems to have problems
	 * when going from primary only to sprite only and vice
	 * versa.
	 */
981
	hsw_enable_ips(intel_crtc);
982

983
	mutex_lock(&dev->struct_mutex);
984
	intel_update_fbc(dev);
985
	mutex_unlock(&dev->struct_mutex);
986 987 988
}

static void
989
intel_pre_disable_primary(struct drm_crtc *crtc)
990 991 992 993
{
	struct drm_device *dev = crtc->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
994 995

	mutex_lock(&dev->struct_mutex);
996 997
	if (dev_priv->fbc.plane == intel_crtc->plane)
		intel_disable_fbc(dev);
998
	mutex_unlock(&dev->struct_mutex);
999

1000 1001 1002 1003 1004 1005 1006
	/*
	 * FIXME IPS should be fine as long as one plane is
	 * enabled, but in practice it seems to have problems
	 * when going from primary only to sprite only and vice
	 * versa.
	 */
	hsw_disable_ips(intel_crtc);
1007 1008
}

1009
static int
1010
ilk_update_colorkey(struct drm_plane *plane,
1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038
		    struct drm_intel_sprite_colorkey *key)
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane;
	u32 dvscntr;
	int ret = 0;

	intel_plane = to_intel_plane(plane);

	I915_WRITE(DVSKEYVAL(intel_plane->pipe), key->min_value);
	I915_WRITE(DVSKEYMAX(intel_plane->pipe), key->max_value);
	I915_WRITE(DVSKEYMSK(intel_plane->pipe), key->channel_mask);

	dvscntr = I915_READ(DVSCNTR(intel_plane->pipe));
	dvscntr &= ~(DVS_SOURCE_KEY | DVS_DEST_KEY);
	if (key->flags & I915_SET_COLORKEY_DESTINATION)
		dvscntr |= DVS_DEST_KEY;
	else if (key->flags & I915_SET_COLORKEY_SOURCE)
		dvscntr |= DVS_SOURCE_KEY;
	I915_WRITE(DVSCNTR(intel_plane->pipe), dvscntr);

	POSTING_READ(DVSKEYMSK(intel_plane->pipe));

	return ret;
}

static void
1039
ilk_get_colorkey(struct drm_plane *plane, struct drm_intel_sprite_colorkey *key)
1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062
{
	struct drm_device *dev = plane->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	struct intel_plane *intel_plane;
	u32 dvscntr;

	intel_plane = to_intel_plane(plane);

	key->min_value = I915_READ(DVSKEYVAL(intel_plane->pipe));
	key->max_value = I915_READ(DVSKEYMAX(intel_plane->pipe));
	key->channel_mask = I915_READ(DVSKEYMSK(intel_plane->pipe));
	key->flags = 0;

	dvscntr = I915_READ(DVSCNTR(intel_plane->pipe));

	if (dvscntr & DVS_DEST_KEY)
		key->flags = I915_SET_COLORKEY_DESTINATION;
	else if (dvscntr & DVS_SOURCE_KEY)
		key->flags = I915_SET_COLORKEY_SOURCE;
	else
		key->flags = I915_SET_COLORKEY_NONE;
}

1063 1064 1065 1066 1067 1068 1069 1070 1071
static bool colorkey_enabled(struct intel_plane *intel_plane)
{
	struct drm_intel_sprite_colorkey key;

	intel_plane->get_colorkey(&intel_plane->base, &key);

	return key.flags != I915_SET_COLORKEY_NONE;
}

1072
static int
1073 1074
intel_check_sprite_plane(struct drm_plane *plane,
			 struct intel_plane_state *state)
1075
{
1076
	struct intel_crtc *intel_crtc = to_intel_crtc(state->crtc);
1077
	struct intel_plane *intel_plane = to_intel_plane(plane);
1078
	struct drm_framebuffer *fb = state->fb;
1079
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
1080 1081 1082 1083 1084 1085 1086
	int crtc_x, crtc_y;
	unsigned int crtc_w, crtc_h;
	uint32_t src_x, src_y, src_w, src_h;
	struct drm_rect *src = &state->src;
	struct drm_rect *dst = &state->dst;
	struct drm_rect *orig_src = &state->orig_src;
	const struct drm_rect *clip = &state->clip;
1087 1088 1089
	int hscale, vscale;
	int max_scale, min_scale;
	int pixel_size = drm_format_plane_cpp(fb->pixel_format, 0);
1090

1091 1092 1093
	/* Don't modify another pipe's plane */
	if (intel_plane->pipe != intel_crtc->pipe) {
		DRM_DEBUG_KMS("Wrong plane <-> crtc mapping\n");
1094
		return -EINVAL;
1095
	}
1096

1097 1098 1099
	/* FIXME check all gen limits */
	if (fb->width < 3 || fb->height < 3 || fb->pitches[0] > 16384) {
		DRM_DEBUG_KMS("Unsuitable framebuffer for plane\n");
1100
		return -EINVAL;
1101
	}
1102

1103 1104 1105 1106 1107 1108
	/* Sprite planes can be linear or x-tiled surfaces */
	switch (obj->tiling_mode) {
		case I915_TILING_NONE:
		case I915_TILING_X:
			break;
		default:
1109
			DRM_DEBUG_KMS("Unsupported tiling mode\n");
1110 1111 1112
			return -EINVAL;
	}

1113 1114 1115 1116 1117
	/*
	 * FIXME the following code does a bunch of fuzzy adjustments to the
	 * coordinates and sizes. We probably need some way to decide whether
	 * more strict checking should be done instead.
	 */
1118 1119 1120
	max_scale = intel_plane->max_downscale << 16;
	min_scale = intel_plane->can_scale ? 1 : (1 << 16);

1121
	drm_rect_rotate(src, fb->width << 16, fb->height << 16,
1122 1123
			intel_plane->rotation);

1124
	hscale = drm_rect_calc_hscale_relaxed(src, dst, min_scale, max_scale);
1125
	BUG_ON(hscale < 0);
1126

1127
	vscale = drm_rect_calc_vscale_relaxed(src, dst, min_scale, max_scale);
1128
	BUG_ON(vscale < 0);
1129

1130
	state->visible =  drm_rect_clip_scaled(src, dst, clip, hscale, vscale);
1131

1132 1133 1134 1135
	crtc_x = dst->x1;
	crtc_y = dst->y1;
	crtc_w = drm_rect_width(dst);
	crtc_h = drm_rect_height(dst);
1136

1137
	if (state->visible) {
1138
		/* check again in case clipping clamped the results */
1139
		hscale = drm_rect_calc_hscale(src, dst, min_scale, max_scale);
1140 1141
		if (hscale < 0) {
			DRM_DEBUG_KMS("Horizontal scaling factor out of limits\n");
1142 1143
			drm_rect_debug_print(src, true);
			drm_rect_debug_print(dst, false);
1144 1145 1146 1147

			return hscale;
		}

1148
		vscale = drm_rect_calc_vscale(src, dst, min_scale, max_scale);
1149 1150
		if (vscale < 0) {
			DRM_DEBUG_KMS("Vertical scaling factor out of limits\n");
1151 1152
			drm_rect_debug_print(src, true);
			drm_rect_debug_print(dst, false);
1153 1154 1155 1156

			return vscale;
		}

1157
		/* Make the source viewport size an exact multiple of the scaling factors. */
1158 1159 1160
		drm_rect_adjust_size(src,
				     drm_rect_width(dst) * hscale - drm_rect_width(src),
				     drm_rect_height(dst) * vscale - drm_rect_height(src));
1161

1162
		drm_rect_rotate_inv(src, fb->width << 16, fb->height << 16,
1163 1164
				    intel_plane->rotation);

1165
		/* sanity check to make sure the src viewport wasn't enlarged */
1166 1167 1168 1169
		WARN_ON(src->x1 < (int) orig_src->x1 ||
			src->y1 < (int) orig_src->y1 ||
			src->x2 > (int) orig_src->x2 ||
			src->y2 > (int) orig_src->y2);
1170 1171 1172 1173 1174 1175 1176

		/*
		 * Hardware doesn't handle subpixel coordinates.
		 * Adjust to (macro)pixel boundary, but be careful not to
		 * increase the source viewport size, because that could
		 * push the downscaling factor out of bounds.
		 */
1177 1178 1179 1180
		src_x = src->x1 >> 16;
		src_w = drm_rect_width(src) >> 16;
		src_y = src->y1 >> 16;
		src_h = drm_rect_height(src) >> 16;
1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193

		if (format_is_yuv(fb->pixel_format)) {
			src_x &= ~1;
			src_w &= ~1;

			/*
			 * Must keep src and dst the
			 * same if we can't scale.
			 */
			if (!intel_plane->can_scale)
				crtc_w &= ~1;

			if (crtc_w == 0)
1194
				state->visible = false;
1195 1196 1197 1198
		}
	}

	/* Check size restrictions when scaling */
1199
	if (state->visible && (src_w != crtc_w || src_h != crtc_h)) {
1200 1201 1202 1203 1204 1205 1206
		unsigned int width_bytes;

		WARN_ON(!intel_plane->can_scale);

		/* FIXME interlacing min height is 6 */

		if (crtc_w < 3 || crtc_h < 3)
1207
			state->visible = false;
1208 1209

		if (src_w < 3 || src_h < 3)
1210
			state->visible = false;
1211

1212 1213
		width_bytes = ((src_x * pixel_size) & 63) +
					src_w * pixel_size;
1214 1215 1216 1217 1218 1219 1220 1221

		if (src_w > 2048 || src_h > 2048 ||
		    width_bytes > 4096 || fb->pitches[0] > 4096) {
			DRM_DEBUG_KMS("Source dimensions exceed hardware limits\n");
			return -EINVAL;
		}
	}

1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237
	if (state->visible) {
		src->x1 = src_x;
		src->x2 = src_x + src_w;
		src->y1 = src_y;
		src->y2 = src_y + src_h;
	}

	dst->x1 = crtc_x;
	dst->x2 = crtc_x + crtc_w;
	dst->y1 = crtc_y;
	dst->y2 = crtc_y + crtc_h;

	return 0;
}

static int
1238 1239
intel_prepare_sprite_plane(struct drm_plane *plane,
			   struct intel_plane_state *state)
1240 1241 1242 1243 1244 1245
{
	struct drm_device *dev = plane->dev;
	struct drm_crtc *crtc = state->crtc;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
	enum pipe pipe = intel_crtc->pipe;
	struct drm_framebuffer *fb = state->fb;
1246 1247
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
	struct drm_i915_gem_object *old_obj = intel_fb_obj(plane->fb);
1248
	int ret;
1249

1250 1251
	if (old_obj != obj) {
		mutex_lock(&dev->struct_mutex);
1252

1253 1254 1255 1256 1257 1258
		/* Note that this will apply the VT-d workaround for scanouts,
		 * which is more restrictive than required for sprites. (The
		 * primary plane requires 256KiB alignment with 64 PTE padding,
		 * the sprite planes only require 128KiB alignment and 32 PTE
		 * padding.
		 */
1259
		ret = intel_pin_and_fence_fb_obj(plane, fb, NULL);
1260 1261 1262 1263 1264 1265 1266
		if (ret == 0)
			i915_gem_track_fb(old_obj, obj,
					  INTEL_FRONTBUFFER_SPRITE(pipe));
		mutex_unlock(&dev->struct_mutex);
		if (ret)
			return ret;
	}
1267

1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280
	return 0;
}

static void
intel_commit_sprite_plane(struct drm_plane *plane,
			  struct intel_plane_state *state)
{
	struct drm_device *dev = plane->dev;
	struct drm_crtc *crtc = state->crtc;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
	struct intel_plane *intel_plane = to_intel_plane(plane);
	enum pipe pipe = intel_crtc->pipe;
	struct drm_framebuffer *fb = state->fb;
1281 1282
	struct drm_i915_gem_object *obj = intel_fb_obj(fb);
	struct drm_i915_gem_object *old_obj = intel_fb_obj(plane->fb);
1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296
	int crtc_x, crtc_y;
	unsigned int crtc_w, crtc_h;
	uint32_t src_x, src_y, src_w, src_h;
	struct drm_rect *dst = &state->dst;
	const struct drm_rect *clip = &state->clip;
	bool primary_enabled;

	/*
	 * If the sprite is completely covering the primary plane,
	 * we can disable the primary and save power.
	 */
	primary_enabled = !drm_rect_equals(dst, clip) || colorkey_enabled(intel_plane);
	WARN_ON(!primary_enabled && !state->visible && intel_crtc->active);

1297 1298 1299 1300 1301 1302 1303 1304
	intel_plane->crtc_x = state->orig_dst.x1;
	intel_plane->crtc_y = state->orig_dst.y1;
	intel_plane->crtc_w = drm_rect_width(&state->orig_dst);
	intel_plane->crtc_h = drm_rect_height(&state->orig_dst);
	intel_plane->src_x = state->orig_src.x1;
	intel_plane->src_y = state->orig_src.y1;
	intel_plane->src_w = drm_rect_width(&state->orig_src);
	intel_plane->src_h = drm_rect_height(&state->orig_src);
1305 1306
	intel_plane->obj = obj;

1307
	if (intel_crtc->active) {
1308 1309 1310 1311
		bool primary_was_enabled = intel_crtc->primary_enabled;

		intel_crtc->primary_enabled = primary_enabled;

1312 1313 1314
		if (primary_was_enabled != primary_enabled)
			intel_crtc_wait_for_pending_flips(crtc);

1315 1316
		if (primary_was_enabled && !primary_enabled)
			intel_pre_disable_primary(crtc);
1317

1318 1319
		if (state->visible) {
			crtc_x = state->dst.x1;
1320
			crtc_y = state->dst.y1;
1321 1322 1323 1324 1325 1326
			crtc_w = drm_rect_width(&state->dst);
			crtc_h = drm_rect_height(&state->dst);
			src_x = state->src.x1;
			src_y = state->src.y1;
			src_w = drm_rect_width(&state->src);
			src_h = drm_rect_height(&state->src);
1327 1328 1329
			intel_plane->update_plane(plane, crtc, fb, obj,
						  crtc_x, crtc_y, crtc_w, crtc_h,
						  src_x, src_y, src_w, src_h);
1330
		} else {
1331
			intel_plane->disable_plane(plane, crtc);
1332 1333
		}

1334

1335 1336
		intel_frontbuffer_flip(dev, INTEL_FRONTBUFFER_SPRITE(pipe));

1337 1338
		if (!primary_was_enabled && primary_enabled)
			intel_post_enable_primary(crtc);
1339
	}
1340

1341
	/* Unpin old obj after new one is active to avoid ugliness */
1342 1343
	if (old_obj && old_obj != obj) {

1344 1345 1346 1347 1348 1349
		/*
		 * It's fairly common to simply update the position of
		 * an existing object.  In that case, we don't need to
		 * wait for vblank to avoid ugliness, we only need to
		 * do the pin & ref bookkeeping.
		 */
1350
		if (intel_crtc->active)
1351
			intel_wait_for_vblank(dev, intel_crtc->pipe);
1352 1353

		mutex_lock(&dev->struct_mutex);
1354
		intel_unpin_fb_obj(old_obj);
1355
		mutex_unlock(&dev->struct_mutex);
1356 1357 1358
	}
}

1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395
static int
intel_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
		   struct drm_framebuffer *fb, int crtc_x, int crtc_y,
		   unsigned int crtc_w, unsigned int crtc_h,
		   uint32_t src_x, uint32_t src_y,
		   uint32_t src_w, uint32_t src_h)
{
	struct intel_plane_state state;
	struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
	int ret;

	state.crtc = crtc;
	state.fb = fb;

	/* sample coordinates in 16.16 fixed point */
	state.src.x1 = src_x;
	state.src.x2 = src_x + src_w;
	state.src.y1 = src_y;
	state.src.y2 = src_y + src_h;

	/* integer pixels */
	state.dst.x1 = crtc_x;
	state.dst.x2 = crtc_x + crtc_w;
	state.dst.y1 = crtc_y;
	state.dst.y2 = crtc_y + crtc_h;

	state.clip.x1 = 0;
	state.clip.y1 = 0;
	state.clip.x2 = intel_crtc->active ? intel_crtc->config.pipe_src_w : 0;
	state.clip.y2 = intel_crtc->active ? intel_crtc->config.pipe_src_h : 0;
	state.orig_src = state.src;
	state.orig_dst = state.dst;

	ret = intel_check_sprite_plane(plane, &state);
	if (ret)
		return ret;

1396 1397 1398 1399 1400 1401
	ret = intel_prepare_sprite_plane(plane, &state);
	if (ret)
		return ret;

	intel_commit_sprite_plane(plane, &state);
	return 0;
1402 1403
}

1404 1405 1406 1407 1408
static int
intel_disable_plane(struct drm_plane *plane)
{
	struct drm_device *dev = plane->dev;
	struct intel_plane *intel_plane = to_intel_plane(plane);
1409
	struct intel_crtc *intel_crtc;
1410
	enum pipe pipe;
1411

1412 1413 1414 1415 1416 1417
	if (!plane->fb)
		return 0;

	if (WARN_ON(!plane->crtc))
		return -EINVAL;

1418
	intel_crtc = to_intel_crtc(plane->crtc);
1419
	pipe = intel_crtc->pipe;
1420 1421

	if (intel_crtc->active) {
1422 1423 1424 1425
		bool primary_was_enabled = intel_crtc->primary_enabled;

		intel_crtc->primary_enabled = true;

1426
		intel_plane->disable_plane(plane, plane->crtc);
1427 1428 1429

		if (!primary_was_enabled && intel_crtc->primary_enabled)
			intel_post_enable_primary(plane->crtc);
1430
	}
1431

1432 1433 1434
	if (intel_plane->obj) {
		if (intel_crtc->active)
			intel_wait_for_vblank(dev, intel_plane->pipe);
1435

1436 1437
		mutex_lock(&dev->struct_mutex);
		intel_unpin_fb_obj(intel_plane->obj);
1438 1439
		i915_gem_track_fb(intel_plane->obj, NULL,
				  INTEL_FRONTBUFFER_SPRITE(pipe));
1440
		mutex_unlock(&dev->struct_mutex);
1441

1442 1443
		intel_plane->obj = NULL;
	}
1444

1445
	return 0;
1446 1447 1448 1449 1450 1451 1452 1453 1454 1455
}

static void intel_destroy_plane(struct drm_plane *plane)
{
	struct intel_plane *intel_plane = to_intel_plane(plane);
	intel_disable_plane(plane);
	drm_plane_cleanup(plane);
	kfree(intel_plane);
}

1456 1457 1458 1459 1460 1461 1462 1463
int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
			      struct drm_file *file_priv)
{
	struct drm_intel_sprite_colorkey *set = data;
	struct drm_plane *plane;
	struct intel_plane *intel_plane;
	int ret = 0;

1464 1465
	if (!drm_core_check_feature(dev, DRIVER_MODESET))
		return -ENODEV;
1466 1467 1468 1469 1470

	/* Make sure we don't try to enable both src & dest simultaneously */
	if ((set->flags & (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE)) == (I915_SET_COLORKEY_DESTINATION | I915_SET_COLORKEY_SOURCE))
		return -EINVAL;

1471
	drm_modeset_lock_all(dev);
1472

R
Rob Clark 已提交
1473 1474
	plane = drm_plane_find(dev, set->plane_id);
	if (!plane) {
1475
		ret = -ENOENT;
1476 1477 1478 1479 1480 1481 1482
		goto out_unlock;
	}

	intel_plane = to_intel_plane(plane);
	ret = intel_plane->update_colorkey(plane, set);

out_unlock:
1483
	drm_modeset_unlock_all(dev);
1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494
	return ret;
}

int intel_sprite_get_colorkey(struct drm_device *dev, void *data,
			      struct drm_file *file_priv)
{
	struct drm_intel_sprite_colorkey *get = data;
	struct drm_plane *plane;
	struct intel_plane *intel_plane;
	int ret = 0;

1495 1496
	if (!drm_core_check_feature(dev, DRIVER_MODESET))
		return -ENODEV;
1497

1498
	drm_modeset_lock_all(dev);
1499

R
Rob Clark 已提交
1500 1501
	plane = drm_plane_find(dev, get->plane_id);
	if (!plane) {
1502
		ret = -ENOENT;
1503 1504 1505 1506 1507 1508 1509
		goto out_unlock;
	}

	intel_plane = to_intel_plane(plane);
	intel_plane->get_colorkey(plane, get);

out_unlock:
1510
	drm_modeset_unlock_all(dev);
1511 1512 1513
	return ret;
}

1514 1515 1516
int intel_plane_set_property(struct drm_plane *plane,
			     struct drm_property *prop,
			     uint64_t val)
1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527
{
	struct drm_device *dev = plane->dev;
	struct intel_plane *intel_plane = to_intel_plane(plane);
	uint64_t old_val;
	int ret = -ENOENT;

	if (prop == dev->mode_config.rotation_property) {
		/* exactly one rotation angle please */
		if (hweight32(val & 0xf) != 1)
			return -EINVAL;

1528 1529 1530
		if (intel_plane->rotation == val)
			return 0;

1531 1532 1533 1534 1535 1536 1537 1538 1539 1540
		old_val = intel_plane->rotation;
		intel_plane->rotation = val;
		ret = intel_plane_restore(plane);
		if (ret)
			intel_plane->rotation = old_val;
	}

	return ret;
}

1541
int intel_plane_restore(struct drm_plane *plane)
1542 1543 1544 1545
{
	struct intel_plane *intel_plane = to_intel_plane(plane);

	if (!plane->crtc || !plane->fb)
1546
		return 0;
1547

1548
	return plane->funcs->update_plane(plane, plane->crtc, plane->fb,
1549 1550 1551 1552
				  intel_plane->crtc_x, intel_plane->crtc_y,
				  intel_plane->crtc_w, intel_plane->crtc_h,
				  intel_plane->src_x, intel_plane->src_y,
				  intel_plane->src_w, intel_plane->src_h);
1553 1554
}

1555 1556 1557 1558 1559 1560 1561 1562
void intel_plane_disable(struct drm_plane *plane)
{
	if (!plane->crtc || !plane->fb)
		return;

	intel_disable_plane(plane);
}

1563 1564 1565 1566
static const struct drm_plane_funcs intel_plane_funcs = {
	.update_plane = intel_update_plane,
	.disable_plane = intel_disable_plane,
	.destroy = intel_destroy_plane,
1567
	.set_property = intel_plane_set_property,
1568 1569
};

1570 1571 1572 1573 1574 1575 1576 1577
static uint32_t ilk_plane_formats[] = {
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1578 1579 1580 1581 1582 1583 1584 1585 1586
static uint32_t snb_plane_formats[] = {
	DRM_FORMAT_XBGR8888,
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600
static uint32_t vlv_plane_formats[] = {
	DRM_FORMAT_RGB565,
	DRM_FORMAT_ABGR8888,
	DRM_FORMAT_ARGB8888,
	DRM_FORMAT_XBGR8888,
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_XBGR2101010,
	DRM_FORMAT_ABGR2101010,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612
static uint32_t skl_plane_formats[] = {
	DRM_FORMAT_RGB565,
	DRM_FORMAT_ABGR8888,
	DRM_FORMAT_ARGB8888,
	DRM_FORMAT_XBGR8888,
	DRM_FORMAT_XRGB8888,
	DRM_FORMAT_YUYV,
	DRM_FORMAT_YVYU,
	DRM_FORMAT_UYVY,
	DRM_FORMAT_VYUY,
};

1613
int
1614
intel_plane_init(struct drm_device *dev, enum pipe pipe, int plane)
1615 1616 1617
{
	struct intel_plane *intel_plane;
	unsigned long possible_crtcs;
1618 1619
	const uint32_t *plane_formats;
	int num_plane_formats;
1620 1621
	int ret;

1622
	if (INTEL_INFO(dev)->gen < 5)
1623 1624
		return -ENODEV;

1625
	intel_plane = kzalloc(sizeof(*intel_plane), GFP_KERNEL);
1626 1627 1628
	if (!intel_plane)
		return -ENOMEM;

1629 1630 1631
	switch (INTEL_INFO(dev)->gen) {
	case 5:
	case 6:
1632
		intel_plane->can_scale = true;
1633
		intel_plane->max_downscale = 16;
1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648
		intel_plane->update_plane = ilk_update_plane;
		intel_plane->disable_plane = ilk_disable_plane;
		intel_plane->update_colorkey = ilk_update_colorkey;
		intel_plane->get_colorkey = ilk_get_colorkey;

		if (IS_GEN6(dev)) {
			plane_formats = snb_plane_formats;
			num_plane_formats = ARRAY_SIZE(snb_plane_formats);
		} else {
			plane_formats = ilk_plane_formats;
			num_plane_formats = ARRAY_SIZE(ilk_plane_formats);
		}
		break;

	case 7:
B
Ben Widawsky 已提交
1649
	case 8:
1650
		if (IS_IVYBRIDGE(dev)) {
1651
			intel_plane->can_scale = true;
1652 1653 1654 1655 1656
			intel_plane->max_downscale = 2;
		} else {
			intel_plane->can_scale = false;
			intel_plane->max_downscale = 1;
		}
1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674

		if (IS_VALLEYVIEW(dev)) {
			intel_plane->update_plane = vlv_update_plane;
			intel_plane->disable_plane = vlv_disable_plane;
			intel_plane->update_colorkey = vlv_update_colorkey;
			intel_plane->get_colorkey = vlv_get_colorkey;

			plane_formats = vlv_plane_formats;
			num_plane_formats = ARRAY_SIZE(vlv_plane_formats);
		} else {
			intel_plane->update_plane = ivb_update_plane;
			intel_plane->disable_plane = ivb_disable_plane;
			intel_plane->update_colorkey = ivb_update_colorkey;
			intel_plane->get_colorkey = ivb_get_colorkey;

			plane_formats = snb_plane_formats;
			num_plane_formats = ARRAY_SIZE(snb_plane_formats);
		}
1675
		break;
1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690
	case 9:
		/*
		 * FIXME: Skylake planes can be scaled (with some restrictions),
		 * but this is for another time.
		 */
		intel_plane->can_scale = false;
		intel_plane->max_downscale = 1;
		intel_plane->update_plane = skl_update_plane;
		intel_plane->disable_plane = skl_disable_plane;
		intel_plane->update_colorkey = skl_update_colorkey;
		intel_plane->get_colorkey = skl_get_colorkey;

		plane_formats = skl_plane_formats;
		num_plane_formats = ARRAY_SIZE(skl_plane_formats);
		break;
1691
	default:
1692
		kfree(intel_plane);
1693
		return -ENODEV;
1694 1695 1696
	}

	intel_plane->pipe = pipe;
1697
	intel_plane->plane = plane;
1698
	intel_plane->rotation = BIT(DRM_ROTATE_0);
1699
	possible_crtcs = (1 << pipe);
1700 1701 1702 1703
	ret = drm_universal_plane_init(dev, &intel_plane->base, possible_crtcs,
				       &intel_plane_funcs,
				       plane_formats, num_plane_formats,
				       DRM_PLANE_TYPE_OVERLAY);
1704
	if (ret) {
1705
		kfree(intel_plane);
1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718
		goto out;
	}

	if (!dev->mode_config.rotation_property)
		dev->mode_config.rotation_property =
			drm_mode_create_rotation_property(dev,
							  BIT(DRM_ROTATE_0) |
							  BIT(DRM_ROTATE_180));

	if (dev->mode_config.rotation_property)
		drm_object_attach_property(&intel_plane->base.base,
					   dev->mode_config.rotation_property,
					   intel_plane->rotation);
1719

1720
 out:
1721 1722
	return ret;
}