[CP] destroy a successfully constructed dup ls member

src/storage/tx/ob_dup_table_base.h

@@ -998,6 +998,7 @@ public:
   {
     reset();
   }
+  ~ObDupTableLogOperator() { reset(); }
   void reuse();
   void reset();
 

src/storage/tx/ob_dup_table_lease.h

@@ -46,6 +46,7 @@ public:
 
 public:
   ObDupTableLSLeaseMgr() : lease_diag_info_log_buf_(nullptr) { reset(); }
+  ~ObDupTableLSLeaseMgr() { destroy(); }
 
   int init(ObDupTableLSHandler *dup_ls_handle);
   int offline();

src/storage/tx/ob_dup_table_tablets.h

@@ -605,6 +605,7 @@ public:
   {
     reset();
   }
+  ~ObLSDupTabletsMgr() { destroy(); }
   int init(ObDupTableLSHandler *dup_ls_handle);
   void destroy();
   void reset();

src/storage/tx/ob_dup_table_ts_sync.h

@@ -60,6 +60,7 @@ public:
   const int64_t TS_INFO_CACHE_REFRESH_INTERVAL = 1 * 1000 * 1000; // 1s
 public:
   ObDupTableLSTsSyncMgr() : ts_sync_diag_info_log_buf_(nullptr) {}
+  ~ObDupTableLSTsSyncMgr() { destroy(); }
   int init(ObDupTableLSHandler *dup_ls_handle);
   int offline();
 

src/storage/tx/ob_dup_table_util.cpp

@@ -308,6 +308,7 @@ int ObDupTabletScanTask::execute_for_dup_ls_()
 int ObDupTableLSHandler::init(bool is_dup_table)
 {
   int ret = OB_SUCCESS;
+  bool is_constructed_ = false;
   if (is_dup_table) {
     if (is_inited()) {
       ret = OB_INIT_TWICE;
@@ -338,6 +339,7 @@ int ObDupTableLSHandler::init(bool is_dup_table)
         new (tmp_log_operator)
             ObDupTableLogOperator(ls_id_, log_handler_, &dup_ls_ckpt_, tmp_lease_mgr_ptr,
                                   tmp_tablets_mgr_ptr, &interface_stat_);
+        is_constructed_ = true;
 
         if (OB_FAIL(tmp_lease_mgr_ptr->init(this))) {
           DUP_TABLE_LOG(WARN, "init lease_mgr failed", K(ret));
@@ -365,19 +367,27 @@ int ObDupTableLSHandler::init(bool is_dup_table)
         tablets_mgr_ptr_ = nullptr;
         log_operator_ = nullptr;
         if (OB_NOT_NULL(tmp_lease_mgr_ptr)) {
-          tmp_lease_mgr_ptr->destroy();
+          if (is_constructed_) {
+            tmp_lease_mgr_ptr->~ObDupTableLSLeaseMgr();
+          }
           ob_free(tmp_lease_mgr_ptr);
         }
         if (OB_NOT_NULL(tmp_ts_sync_mgr_ptr)) {
-          tmp_ts_sync_mgr_ptr->destroy();
+          if (is_constructed_) {
+            tmp_ts_sync_mgr_ptr->~ObDupTableLSTsSyncMgr();
+          }
           ob_free(tmp_ts_sync_mgr_ptr);
         }
         if (OB_NOT_NULL(tmp_tablets_mgr_ptr)) {
-          tmp_tablets_mgr_ptr->destroy();
+          if (is_constructed_) {
+            tmp_tablets_mgr_ptr->~ObLSDupTabletsMgr();
+          }
           ob_free(tmp_tablets_mgr_ptr);
         }
         if (OB_NOT_NULL(tmp_log_operator)) {
-          tmp_log_operator->reset();
+          if (is_constructed_) {
+            tmp_log_operator->~ObDupTableLogOperator();
+          }
           ob_free(tmp_log_operator);
         }
       }
@@ -520,28 +530,31 @@ void ObDupTableLSHandler::reset()
 {
   // ATOMIC_STORE(&is_inited_, false);
   SpinWLockGuard w_init_guard(init_rw_lock_);
-  is_inited_ = false;
   ls_state_helper_.reset();
 
   dup_ls_ckpt_.reset();
 
-  if (OB_NOT_NULL(lease_mgr_ptr_)) {
-    lease_mgr_ptr_->destroy();
-    ob_free(lease_mgr_ptr_);
-  }
-  if (OB_NOT_NULL(ts_sync_mgr_ptr_)) {
-    ts_sync_mgr_ptr_->destroy();
-    ob_free(ts_sync_mgr_ptr_);
-  }
-  if (OB_NOT_NULL(tablets_mgr_ptr_)) {
-    tablets_mgr_ptr_->destroy();
-    ob_free(tablets_mgr_ptr_);
-  }
-  if (OB_NOT_NULL(log_operator_)) {
-    log_operator_->reset();
-    share::mtl_free(log_operator_);
+  if (is_inited_) {
+    if (OB_NOT_NULL(lease_mgr_ptr_)) {
+      lease_mgr_ptr_->~ObDupTableLSLeaseMgr();
+      ob_free(lease_mgr_ptr_);
+    }
+    if (OB_NOT_NULL(ts_sync_mgr_ptr_)) {
+      ts_sync_mgr_ptr_->~ObDupTableLSTsSyncMgr();
+      ob_free(ts_sync_mgr_ptr_);
+    }
+    if (OB_NOT_NULL(tablets_mgr_ptr_)) {
+      tablets_mgr_ptr_->~ObLSDupTabletsMgr();
+      ob_free(tablets_mgr_ptr_);
+    }
+    if (OB_NOT_NULL(log_operator_)) {
+      log_operator_->~ObDupTableLogOperator();
+      share::mtl_free(log_operator_);
+    }
   }
 
+  is_inited_ = false;
+
   lease_mgr_ptr_ = nullptr;
   ts_sync_mgr_ptr_ = nullptr;
   tablets_mgr_ptr_ = nullptr;

src/storage/tx/ob_dup_table_util.h

@@ -127,6 +127,7 @@ public:
   {
     reset();
   }
+  ~ObDupTableLSHandler() { destroy(); }
   // init by ObDupTabletScanTask or replay
   int init(bool is_dup_table);