Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
oceanbase
oceanbase
提交
93676a18
O
oceanbase
项目概览
oceanbase
/
oceanbase
大约 1 年 前同步成功
通知
261
Star
6084
Fork
1301
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
O
oceanbase
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
93676a18
编写于
12月 06, 2021
作者:
B
br0
提交者:
LINGuanRen
12月 06, 2021
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix NAN related operator bugs in non-static typing engine
上级
42a62429
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
15 addition
and
9 deletion
+15
-9
src/share/object/ob_obj_cast.cpp
src/share/object/ob_obj_cast.cpp
+12
-0
src/sql/engine/expr/ob_expr_operator.cpp
src/sql/engine/expr/ob_expr_operator.cpp
+1
-1
src/sql/engine/expr/ob_expr_power.cpp
src/sql/engine/expr/ob_expr_power.cpp
+2
-8
未找到文件。
src/share/object/ob_obj_cast.cpp
浏览文件 @
93676a18
...
...
@@ -1603,6 +1603,12 @@ static int float_number(
if
(
OB_UNLIKELY
(
ObFloatTC
!=
in
.
get_type_class
()
||
ObNumberTC
!=
ob_obj_type_class
(
expect_type
)))
{
ret
=
OB_ERR_UNEXPECTED
;
LOG_ERROR
(
"invalid input type"
,
K
(
ret
),
K
(
in
),
K
(
expect_type
));
}
else
if
(
isnan
(
value
))
{
ret
=
OB_INVALID_NUMERIC
;
LOG_WARN
(
"float_number failed "
,
K
(
ret
),
K
(
value
));
}
else
if
(
isinf
(
value
))
{
ret
=
OB_NUMERIC_OVERFLOW
;
LOG_WARN
(
"float_number failed"
,
K
(
ret
),
K
(
value
));
}
else
if
(
ObUNumberType
==
expect_type
&&
CAST_FAIL
(
numeric_negative_check
(
value
)))
{
}
else
{
char
buf
[
MAX_DOUBLE_STRICT_PRINT_SIZE
];
...
...
@@ -1902,6 +1908,12 @@ static int double_number(
if
(
OB_UNLIKELY
(
ObDoubleTC
!=
in
.
get_type_class
()
||
ObNumberTC
!=
ob_obj_type_class
(
expect_type
)))
{
ret
=
OB_ERR_UNEXPECTED
;
LOG_ERROR
(
"invalid input type"
,
K
(
ret
),
K
(
in
),
K
(
expect_type
));
}
else
if
(
isnan
(
value
)
&&
lib
::
is_oracle_mode
())
{
ret
=
OB_INVALID_NUMERIC
;
LOG_WARN
(
"float_number failed "
,
K
(
ret
),
K
(
value
));
}
else
if
(
isinf
(
value
)
&&
lib
::
is_oracle_mode
())
{
ret
=
OB_NUMERIC_OVERFLOW
;
LOG_WARN
(
"float_number failed"
,
K
(
ret
),
K
(
value
));
}
else
if
(
ObUNumberType
==
expect_type
&&
CAST_FAIL
(
numeric_negative_check
(
value
)))
{
}
else
{
char
buf
[
MAX_DOUBLE_STRICT_PRINT_SIZE
];
...
...
src/sql/engine/expr/ob_expr_operator.cpp
浏览文件 @
93676a18
...
...
@@ -1841,7 +1841,7 @@ int ObRelationalExprOperator::calc_result2(
int
ret
=
OB_SUCCESS
;
// TODO:: raw
// bool need_cast = (share::is_oracle_mode() && obj1.get_collation_type() != obj2.get_collation_type());
bool
need_cast
=
false
;
bool
need_cast
=
(
share
::
is_oracle_mode
()
&&
obj1
.
get_type
()
!=
obj2
.
get_type
())
;
EXPR_DEFINE_CMP_CTX
(
result_type_
.
get_calc_meta
(),
is_null_safe
,
expr_ctx
);
/*
* FIX ME,please. It seems that we must check obj1 and obj2 are null or not here
...
...
src/sql/engine/expr/ob_expr_power.cpp
浏览文件 @
93676a18
...
...
@@ -70,14 +70,8 @@ int ObExprPower::calc(ObObj& result, const ObObj& obj1, const ObObj& obj2, ObExp
}
else
if
(
obj1
.
is_double
()
&&
obj2
.
is_double
())
{
// same as oracle behavior: if at least one of the arguments is
// binary_double, result type is double
double
double_base
=
obj1
.
get_double
();
double
double_exponent
=
obj2
.
get_double
();
double
result_double
=
std
::
pow
(
double_base
,
double_exponent
);
if
(
isinf
(
result_double
)
||
isnan
(
result_double
))
{
ret
=
OB_OPERATE_OVERFLOW
;
}
else
{
result
.
set_double
(
result_double
);
}
// keep same with static typing engine.
ret
=
ObExprPow
::
safe_set_double
(
result
,
std
::
pow
(
obj1
.
get_double
(),
obj2
.
get_double
()));
}
else
{
ret
=
OB_ERR_UNEXPECTED
;
LOG_WARN
(
"obj type should be number or double"
,
K
(
obj1
),
K
(
obj2
),
K
(
ret
));
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录