未验证 提交 fccca551 编写于 作者: J Jiquan Long 提交者: GitHub

Add log for Connect api (#24547)

Signed-off-by: Nlongjiquan <jiquan.long@zilliz.com>
上级 ee45c791
...@@ -41,7 +41,8 @@ func (c clientInfo) getLogger() []zap.Field { ...@@ -41,7 +41,8 @@ func (c clientInfo) getLogger() []zap.Field {
} }
func (c clientInfo) ctxLogRegister(ctx context.Context) { func (c clientInfo) ctxLogRegister(ctx context.Context) {
log.Ctx(ctx).Info("client register", c.getLogger()...) fields := append(c.getLogger(), zap.String("db", GetCurDBNameFromContextOrDefault(ctx)))
log.Ctx(ctx).Info("client register", fields...)
} }
func (c clientInfo) logDeregister() { func (c clientInfo) logDeregister() {
......
...@@ -5491,6 +5491,10 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest ...@@ -5491,6 +5491,10 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest
} }
db := GetCurDBNameFromContextOrDefault(ctx) db := GetCurDBNameFromContextOrDefault(ctx)
logsToBePrinted := append(getLoggerOfClientInfo(request.GetClientInfo()), zap.String("db", db))
log := log.Ctx(ctx).With(logsToBePrinted...)
log.Info("connect received")
// maybe an `API` like `HasDatabase` is better, `ListDatabases` is a little heavy. // maybe an `API` like `HasDatabase` is better, `ListDatabases` is a little heavy.
resp, err := node.rootCoord.ListDatabases(ctx, &milvuspb.ListDatabasesRequest{ resp, err := node.rootCoord.ListDatabases(ctx, &milvuspb.ListDatabasesRequest{
...@@ -5500,6 +5504,7 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest ...@@ -5500,6 +5504,7 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest
}) })
if err != nil { if err != nil {
log.Info("connect failed, failed to list databases", zap.Error(err))
return &milvuspb.ConnectResponse{ return &milvuspb.ConnectResponse{
Status: &commonpb.Status{ Status: &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError, ErrorCode: commonpb.ErrorCode_UnexpectedError,
...@@ -5509,12 +5514,16 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest ...@@ -5509,12 +5514,16 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest
} }
if resp.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success { if resp.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success {
log.Info("connect failed, failed to list databases",
zap.String("code", resp.GetStatus().GetErrorCode().String()),
zap.String("reason", resp.GetStatus().GetReason()))
return &milvuspb.ConnectResponse{ return &milvuspb.ConnectResponse{
Status: proto.Clone(resp.GetStatus()).(*commonpb.Status), Status: proto.Clone(resp.GetStatus()).(*commonpb.Status),
}, nil }, nil
} }
if !funcutil.SliceContain(resp.GetDbNames(), db) { if !funcutil.SliceContain(resp.GetDbNames(), db) {
log.Info("connect failed, target database not exist")
return &milvuspb.ConnectResponse{ return &milvuspb.ConnectResponse{
Status: &commonpb.Status{ Status: &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError, // DatabaseNotExist? ErrorCode: commonpb.ErrorCode_UnexpectedError, // DatabaseNotExist?
...@@ -5525,6 +5534,7 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest ...@@ -5525,6 +5534,7 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest
ts, err := node.tsoAllocator.AllocOne(ctx) ts, err := node.tsoAllocator.AllocOne(ctx)
if err != nil { if err != nil {
log.Info("connect failed, failed to allocate timestamp", zap.Error(err))
return &milvuspb.ConnectResponse{ return &milvuspb.ConnectResponse{
Status: &commonpb.Status{ Status: &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError, ErrorCode: commonpb.ErrorCode_UnexpectedError,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册