From fccca55128b6ae8e871aff7b1754c65b84c343c8 Mon Sep 17 00:00:00 2001 From: Jiquan Long Date: Wed, 31 May 2023 16:41:33 +0800 Subject: [PATCH] Add log for Connect api (#24547) Signed-off-by: longjiquan --- internal/proxy/client_info.go | 3 ++- internal/proxy/impl.go | 10 ++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/internal/proxy/client_info.go b/internal/proxy/client_info.go index 4e4f057cf..c75d28793 100644 --- a/internal/proxy/client_info.go +++ b/internal/proxy/client_info.go @@ -41,7 +41,8 @@ func (c clientInfo) getLogger() []zap.Field { } func (c clientInfo) ctxLogRegister(ctx context.Context) { - log.Ctx(ctx).Info("client register", c.getLogger()...) + fields := append(c.getLogger(), zap.String("db", GetCurDBNameFromContextOrDefault(ctx))) + log.Ctx(ctx).Info("client register", fields...) } func (c clientInfo) logDeregister() { diff --git a/internal/proxy/impl.go b/internal/proxy/impl.go index 67dbf6d04..1e2e2d560 100644 --- a/internal/proxy/impl.go +++ b/internal/proxy/impl.go @@ -5491,6 +5491,10 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest } db := GetCurDBNameFromContextOrDefault(ctx) + logsToBePrinted := append(getLoggerOfClientInfo(request.GetClientInfo()), zap.String("db", db)) + log := log.Ctx(ctx).With(logsToBePrinted...) + + log.Info("connect received") // maybe an `API` like `HasDatabase` is better, `ListDatabases` is a little heavy. resp, err := node.rootCoord.ListDatabases(ctx, &milvuspb.ListDatabasesRequest{ @@ -5500,6 +5504,7 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest }) if err != nil { + log.Info("connect failed, failed to list databases", zap.Error(err)) return &milvuspb.ConnectResponse{ Status: &commonpb.Status{ ErrorCode: commonpb.ErrorCode_UnexpectedError, @@ -5509,12 +5514,16 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest } if resp.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success { + log.Info("connect failed, failed to list databases", + zap.String("code", resp.GetStatus().GetErrorCode().String()), + zap.String("reason", resp.GetStatus().GetReason())) return &milvuspb.ConnectResponse{ Status: proto.Clone(resp.GetStatus()).(*commonpb.Status), }, nil } if !funcutil.SliceContain(resp.GetDbNames(), db) { + log.Info("connect failed, target database not exist") return &milvuspb.ConnectResponse{ Status: &commonpb.Status{ ErrorCode: commonpb.ErrorCode_UnexpectedError, // DatabaseNotExist? @@ -5525,6 +5534,7 @@ func (node *Proxy) Connect(ctx context.Context, request *milvuspb.ConnectRequest ts, err := node.tsoAllocator.AllocOne(ctx) if err != nil { + log.Info("connect failed, failed to allocate timestamp", zap.Error(err)) return &milvuspb.ConnectResponse{ Status: &commonpb.Status{ ErrorCode: commonpb.ErrorCode_UnexpectedError, -- GitLab