未验证 提交 61775122 编写于 作者: C cai.zhang 提交者: GitHub

Don't expose index params when error occurred (#20187)

Signed-off-by: Ncai.zhang <cai.zhang@zilliz.com>
Signed-off-by: Ncai.zhang <cai.zhang@zilliz.com>
上级 2ff21f0e
...@@ -450,9 +450,10 @@ func (mt *metaTable) CanCreateIndex(req *indexpb.CreateIndexRequest) (bool, erro ...@@ -450,9 +450,10 @@ func (mt *metaTable) CanCreateIndex(req *indexpb.CreateIndexRequest) (bool, erro
if mt.checkParams(index, req) { if mt.checkParams(index, req) {
return true, nil return true, nil
} }
errMsg := fmt.Sprintf("index already exist, but parameters are inconsistent. source index: %v current index: %v", errMsg := "at most one distinct index is allowed per field"
fmt.Sprintf("{index_name: %s, field_id: %d, index_params: %v, type_params: %v}", index.IndexName, index.FieldID, index.IndexParams, index.TypeParams), log.Warn(errMsg,
fmt.Sprintf("{index_name: %s, field_id: %d, index_params: %v, type_params: %v}", req.GetIndexName(), req.GetFieldID(), req.GetIndexParams(), req.GetTypeParams())) zap.String("source index", fmt.Sprintf("{index_name: %s, field_id: %d, index_params: %v, type_params: %v}", index.IndexName, index.FieldID, index.IndexParams, index.TypeParams)),
zap.String("current index", fmt.Sprintf("{index_name: %s, field_id: %d, index_params: %v, type_params: %v}", req.GetIndexName(), req.GetFieldID(), req.GetIndexParams(), req.GetTypeParams())))
return false, fmt.Errorf("CreateIndex failed: %s", errMsg) return false, fmt.Errorf("CreateIndex failed: %s", errMsg)
} }
if req.FieldID == index.FieldID { if req.FieldID == index.FieldID {
......
...@@ -6,7 +6,7 @@ from check.func_check import ResponseChecker ...@@ -6,7 +6,7 @@ from check.func_check import ResponseChecker
from utils.api_request import api_request from utils.api_request import api_request
TIMEOUT = 20 TIMEOUT = 20
INDEX_NAME = "_default_idx" INDEX_NAME = ""
class ApiIndexWrapper: class ApiIndexWrapper:
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册