From 61775122ea24a84486cd857f8eacbe23d9a7e4fe Mon Sep 17 00:00:00 2001 From: "cai.zhang" Date: Mon, 31 Oct 2022 12:11:33 +0800 Subject: [PATCH] Don't expose index params when error occurred (#20187) Signed-off-by: cai.zhang Signed-off-by: cai.zhang --- internal/indexcoord/meta_table.go | 7 ++++--- tests/python_client/base/index_wrapper.py | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/indexcoord/meta_table.go b/internal/indexcoord/meta_table.go index 54f0fcca9..961469e39 100644 --- a/internal/indexcoord/meta_table.go +++ b/internal/indexcoord/meta_table.go @@ -450,9 +450,10 @@ func (mt *metaTable) CanCreateIndex(req *indexpb.CreateIndexRequest) (bool, erro if mt.checkParams(index, req) { return true, nil } - errMsg := fmt.Sprintf("index already exist, but parameters are inconsistent. source index: %v current index: %v", - fmt.Sprintf("{index_name: %s, field_id: %d, index_params: %v, type_params: %v}", index.IndexName, index.FieldID, index.IndexParams, index.TypeParams), - fmt.Sprintf("{index_name: %s, field_id: %d, index_params: %v, type_params: %v}", req.GetIndexName(), req.GetFieldID(), req.GetIndexParams(), req.GetTypeParams())) + errMsg := "at most one distinct index is allowed per field" + log.Warn(errMsg, + zap.String("source index", fmt.Sprintf("{index_name: %s, field_id: %d, index_params: %v, type_params: %v}", index.IndexName, index.FieldID, index.IndexParams, index.TypeParams)), + zap.String("current index", fmt.Sprintf("{index_name: %s, field_id: %d, index_params: %v, type_params: %v}", req.GetIndexName(), req.GetFieldID(), req.GetIndexParams(), req.GetTypeParams()))) return false, fmt.Errorf("CreateIndex failed: %s", errMsg) } if req.FieldID == index.FieldID { diff --git a/tests/python_client/base/index_wrapper.py b/tests/python_client/base/index_wrapper.py index e44e089e2..301a0b7c0 100644 --- a/tests/python_client/base/index_wrapper.py +++ b/tests/python_client/base/index_wrapper.py @@ -6,7 +6,7 @@ from check.func_check import ResponseChecker from utils.api_request import api_request TIMEOUT = 20 -INDEX_NAME = "_default_idx" +INDEX_NAME = "" class ApiIndexWrapper: -- GitLab