1. 24 6月, 2019 1 次提交
  2. 22 6月, 2019 2 次提交
    • M
      Fix couple of false positives in Dispose analysis · b91e20e9
      Manish Vasani 提交于
      1. Make IDE0069 (DisposableFieldsShouldBeDisposed) conservative by bailing out on disposable types that don't have the Dispose implementation, but rely on base type implementing it and having virtual helper methods for dispose functionality
      
      2. Make IDE0067 (DisposeObjectsBeforeLosingScope) conservative by bailing out on disposable objects that are passed as arguments to methods in metadata.
      
      Requires updating to a new FlowAnalysisUtilities version.
      Fixes #36498
      b91e20e9
    • S
      Update to Roslyn.Diagnostics.Analyzers 2.9.3 · 6e539e9b
      Sam Harwell 提交于
      6e539e9b
  3. 20 6月, 2019 1 次提交
  4. 19 6月, 2019 2 次提交
  5. 13 6月, 2019 3 次提交
  6. 12 6月, 2019 1 次提交
  7. 11 6月, 2019 1 次提交
  8. 08 6月, 2019 1 次提交
  9. 05 6月, 2019 3 次提交
    • H
      mark NFW from OOP critical (#36156) · 30851719
      Heejae Chang 提交于
      * mark NFW from OOP critical
      
      currently, whenever OOP throws an exception, we show infobar saying "restart VS". whenever that happens, we report NFW. now those NFW will be marked as critical and we will stop reporting NFW after that in VS.
      
      basically making critical NFW behavior same as fatal watson in VS. and management will treat critical NFW same as fatal watson.
      
      also, now we will show callstack like code fix exception when info bar is shown
      
      * xml document fix
      
      * fix build break.
      
      * changed button to hyper-link to follow same pattern as other info bar (code fix)
      
      show remote exception in callstack view.
      
      * introduced enum for Watson Severity
      30851719
    • J
      Update ILAsm and ILDasm version to match expected SDK version (#36154) · 968fae55
      Joey Robichaud 提交于
      * Update ILAsm and ILDasm version to match expected SDK version
      
      * Fixed version numbers
      968fae55
    • J
      Update EditorFeatures.WPF dependencies (#35923) · e211e501
      Joey Robichaud 提交于
      * Add InteractiveHost as a NuGet package
      
      * Make InteractiveWindow a package dependency
      
      * Update InteractiveWindow version to 2.8.0
      
      * Add missing package dependencies
      e211e501
  10. 04 6月, 2019 1 次提交
  11. 03 6月, 2019 1 次提交
  12. 01 6月, 2019 5 次提交
    • M
      Upgrade Microsoft.CodeAnalysis.FlowAnalysis.Utilities to latest version · 06927469
      Manish Vasani 提交于
      Additionally, we do not mark the package reference to in Features.csproj as PrivateAsset as this leads to the assembly not getting included in the Features NuGet package and causes Omnisharp's analyzer execution to throw missing dependency assembly load errors.
      Also update ExpectedDependency in DevDivInsertionFiles.csproj
      06927469
    • M
      Upgrade Microsoft.CodeAnalysis.FlowAnalysis.Utilities to latest version · d3a7bb43
      Manish Vasani 提交于
      Additionally, we do not mark the package reference to in Features.csproj as PrivateAsset as this leads to the assembly not getting included in the Features NuGet package and causes Omnisharp's analyzer execution to throw missing dependency assembly load errors.
      Also update ExpectedDependency in DevDivInsertionFiles.csproj
      d3a7bb43
    • M
      Address PR feedback: remove static cache, make FlowAnalysis utilities assembly... · 55c72661
      Manish Vasani 提交于
      Address PR feedback: remove static cache, make FlowAnalysis utilities assembly load lazy and revert reference add to the FlowAnalysis assembly in Workspaces (only referenced in Features now).
      55c72661
    • M
      Port Dispose analyzers (DisposeObjectsBeforeLosingScope) and · 5c8ba043
      Manish Vasani 提交于
      (DisposableFieldsShouldBeDisposed)
      
      We will now flag disposable creations in methods that do not escape the
      method body (return value, out/ref params, assign to field/property, add
      to collection, etc.). Additionally, we also flag disposable fields of
      disposable types that are not disposed in the type's Dispose method.
      Ported analyzers share the core dataflow analysis computation with the
      analyzers in the roslyn-analyzers repo
      (Microsoft.CodeAnalysis.FlowAnalysis.Utilities). This PR does not add
      any code fixes. We already have a code
      refactoring that offers wrapping a disposable creation within a using
      statement. I am hoping to extend that to handle more cases and also
      possibly convert it to a code fix in follow-up PR(s).
      5c8ba043
    • C
      Update TestResources to 2.0.17 (#36011) · a2379e04
      Charles Stoner 提交于
      a2379e04
  13. 31 5月, 2019 3 次提交
  14. 25 5月, 2019 1 次提交
  15. 23 5月, 2019 2 次提交
    • H
      move StreamJsonRpc 1.xxx to 2.xxx (#34860) · 0427bb25
      Heejae Chang 提交于
      * Revert "Revert "move StreamJsonRpc to 2.x from 1.3.x (#33960)" (#34654)"
      
      This reverts commit 297aaf20.
      
      * fix streamJsonRpc version conflict errors
      
      * move stream json rpc to more recent version and remove unnecessary explicit dependency
      
      * fix nuget version conflict issue
      
      * json rpc array bug workaround
      
      * move ToArray fix to lower layer
      
      * underlying issue is fixed in stream json rpc already and inserted to VS before we going in.
      
      removed workaround.
      0427bb25
    • J
      01be580f
  16. 22 5月, 2019 1 次提交
  17. 10 5月, 2019 1 次提交
  18. 07 5月, 2019 1 次提交
  19. 04 5月, 2019 1 次提交
    • K
      Support TimeTravelTraceInterop in function resolver. (#35318) · 0094fecd
      kceiw 提交于
      * Support TimeTravelTraceInterop in function resolver.
      
      - The function resolver isn't loaded when the base monitor is
      TimeTravelTraceInterop, which needs it to resolve function for function
      breakpoint.
      - To add TimeTravelTraceInterop to the right vsdconfigxml file, I also
      need to update some package so that it can be built.
      
      * Address PR feedback.
      
      - PrivateVisualStudioPackage isn't necessary since I set PrivateAssets=true in the package reference.
      0094fecd
  20. 02 5月, 2019 1 次提交
    • T
      Project cleanup (#35403) · e051790e
      Tomáš Matoušek 提交于
      * Remove RoslynProjectType
      
      * Remove ToolsVersion, namespace from Project tags
      
      * Remove updating of MSBuildAllProjects
      
      * Update BuildBoss
      
      * Delete DeployTooolsetCompiler
      e051790e
  21. 01 5月, 2019 1 次提交
  22. 25 4月, 2019 2 次提交
    • D
      Update versions.props for 16.1 preview 4 · 924be416
      David Poeschl 提交于
      924be416
    • M
      Port Dispose analyzers (DisposeObjectsBeforeLosingScope) and · 1f329f7f
      Manish Vasani 提交于
      (DisposableFieldsShouldBeDisposed)
      
      We will now flag disposable creations in methods that do not escape the
      method body (return value, out/ref params, assign to field/property, add
      to collection, etc.). Additionally, we also flag disposable fields of
      disposable types that are not disposed in the type's Dispose method.
      Ported analyzers share the core dataflow analysis computation with the
      analyzers in the roslyn-analyzers repo
      (Microsoft.CodeAnalysis.FlowAnalysis.Utilities). This PR does not add
      any code fixes. We already have a code
      refactoring that offers wrapping a disposable creation within a using
      statement. I am hoping to extend that to handle more cases and also
      possibly convert it to a code fix in follow-up PR(s).
      1f329f7f
  23. 23 4月, 2019 1 次提交
  24. 10 4月, 2019 1 次提交
  25. 08 4月, 2019 1 次提交
  26. 03 4月, 2019 1 次提交