When we create skeleton assembly references, we back them by temporary
memory out of our ITemporaryStorage service. We used a
ConditionalWeakTable to ensure that if the reference was held alive
that the underlying memory wouldn't disappear. This was subtly
incorrect. If you had a PE symbol from such a compilation, the
compilation is not held alive, and the metadata reference could be freed
but the metadata (which is held by the symbol) could still be held.
This meant we'd free the memory too early and crash.

The fix is simple: root the memory by the metadata object, not the
metadata reference.

Fixes #13243.

We were previously realizing the workspace and then reading in all the
FunctionIds to see if we should log each of those. We can do that from
the global option service directory (avoiding having to touch the
Workspace) and also not doing that until we actually need to. In most
cases ETW is off so we shouldn't even be looking at all.

This reverts commit 7dd78ae8, reversing
changes made to 449f5586.