Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
b6e12e53
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b6e12e53
编写于
11月 06, 2016
作者:
C
CyrusNajmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Shave off hundreds of MB of allocations during FindReferences.
上级
bf475922
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
38 addition
and
11 deletion
+38
-11
src/Compilers/Core/Portable/MetadataReference/PortableExecutableReference.cs
...Portable/MetadataReference/PortableExecutableReference.cs
+13
-0
src/Compilers/Core/Portable/PublicAPI.Unshipped.txt
src/Compilers/Core/Portable/PublicAPI.Unshipped.txt
+1
-0
src/Workspaces/Core/Portable/FindSymbols/SymbolTree/SymbolTreeInfo_Metadata.cs
...ortable/FindSymbols/SymbolTree/SymbolTreeInfo_Metadata.cs
+24
-11
未找到文件。
src/Compilers/Core/Portable/MetadataReference/PortableExecutableReference.cs
浏览文件 @
b6e12e53
...
...
@@ -170,6 +170,19 @@ public Metadata GetMetadata()
return
GetMetadataNoCopy
().
Copy
();
}
/// <summary>
/// Returns the <see cref="MetadataId"/> for this reference's <see cref="Metadata"/>.
/// This will be equivalent to calling <see cref="GetMetadata()"/>.<see cref="Metadata.Id"/>,
/// but can be done more efficiently.
/// </summary>
/// <exception cref="BadImageFormatException">If the PE image format is invalid.</exception>
/// <exception cref="IOException">The metadata image content can't be read.</exception>
/// <exception cref="FileNotFoundException">The metadata image is stored in a file that can't be found.</exception>
public
MetadataId
GetMetadataId
()
{
return
GetMetadataNoCopy
().
Id
;
}
internal
static
Diagnostic
ExceptionToDiagnostic
(
Exception
e
,
CommonMessageProvider
messageProvider
,
Location
location
,
string
display
,
MetadataImageKind
kind
)
{
if
(
e
is
BadImageFormatException
)
...
...
src/Compilers/Core/Portable/PublicAPI.Unshipped.txt
浏览文件 @
b6e12e53
...
...
@@ -175,6 +175,7 @@ Microsoft.CodeAnalysis.OperationKind.VariableDeclarationStatement = 3 -> Microso
Microsoft.CodeAnalysis.OperationKind.WithStatement = 82 -> Microsoft.CodeAnalysis.OperationKind
Microsoft.CodeAnalysis.OperationKind.YieldBreakStatement = 12 -> Microsoft.CodeAnalysis.OperationKind
Microsoft.CodeAnalysis.OperationKind.YieldReturnStatement = 16 -> Microsoft.CodeAnalysis.OperationKind
Microsoft.CodeAnalysis.PortableExecutableReference.GetMetadataId() -> Microsoft.CodeAnalysis.MetadataId
Microsoft.CodeAnalysis.SemanticModel.GetOperation(Microsoft.CodeAnalysis.SyntaxNode node, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> Microsoft.CodeAnalysis.IOperation
Microsoft.CodeAnalysis.Semantics.ArgumentKind
Microsoft.CodeAnalysis.Semantics.ArgumentKind.DefaultValue = 4 -> Microsoft.CodeAnalysis.Semantics.ArgumentKind
...
...
src/Workspaces/Core/Portable/FindSymbols/SymbolTree/SymbolTreeInfo_Metadata.cs
浏览文件 @
b6e12e53
...
...
@@ -54,6 +54,18 @@ private static int IndexOfCharacter(BlobReader blobReader, char ch)
}
}
private
static
MetadataId
GetMetadataIdNoThrow
(
PortableExecutableReference
reference
)
{
try
{
return
reference
.
GetMetadataId
();
}
catch
(
Exception
e
)
when
(
e
is
BadImageFormatException
||
e
is
IOException
)
{
return
null
;
}
}
private
static
Metadata
GetMetadataNoThrow
(
PortableExecutableReference
reference
)
{
try
...
...
@@ -77,8 +89,8 @@ private static Metadata GetMetadataNoThrow(PortableExecutableReference reference
bool
loadOnly
,
CancellationToken
cancellationToken
)
{
var
metadata
=
GetMetadata
NoThrow
(
reference
);
if
(
metadata
==
null
)
var
metadata
Id
=
GetMetadataId
NoThrow
(
reference
);
if
(
metadata
Id
==
null
)
{
return
SpecializedTasks
.
Default
<
SymbolTreeInfo
>();
}
...
...
@@ -87,12 +99,17 @@ private static Metadata GetMetadataNoThrow(PortableExecutableReference reference
// allocations around acquiring the task for it. Note: once ValueTask is available
// (and enabled in the language), we'd likely want to use it here. (Presuming
// the lock is not being held most of the time).
Task
<
SymbolTreeInfo
>
infoTask
;
if
(
s_metadataIdToInfo
.
TryGetValue
(
metadata
.
Id
,
out
infoTask
))
if
(
s_metadataIdToInfo
.
TryGetValue
(
metadataId
,
out
var
infoTask
))
{
return
infoTask
;
}
var
metadata
=
GetMetadataNoThrow
(
reference
);
if
(
metadata
==
null
)
{
return
SpecializedTasks
.
Default
<
SymbolTreeInfo
>();
}
return
TryGetInfoForMetadataReferenceSlowAsync
(
solution
,
reference
,
loadOnly
,
metadata
,
cancellationToken
);
}
...
...
@@ -107,9 +124,7 @@ private static Metadata GetMetadataNoThrow(PortableExecutableReference reference
using
(
await
gate
.
DisposableWaitAsync
(
cancellationToken
).
ConfigureAwait
(
false
))
{
cancellationToken
.
ThrowIfCancellationRequested
();
Task
<
SymbolTreeInfo
>
infoTask
;
if
(
s_metadataIdToInfo
.
TryGetValue
(
metadata
.
Id
,
out
infoTask
))
if
(
s_metadataIdToInfo
.
TryGetValue
(
metadata
.
Id
,
out
var
infoTask
))
{
return
await
infoTask
.
ConfigureAwait
(
false
);
}
...
...
@@ -693,11 +708,9 @@ public MetadataDefinition(MetadataDefinitionKind kind, string name)
public
static
MetadataDefinition
Create
(
MetadataReader
reader
,
TypeDefinition
definition
)
{
string
typeName
=
GetMetadataNameWithoutBackticks
(
reader
,
definition
.
Name
);
var
typeName
=
GetMetadataNameWithoutBackticks
(
reader
,
definition
.
Name
);
return
new
MetadataDefinition
(
MetadataDefinitionKind
.
Type
,
typeName
)
return
new
MetadataDefinition
(
MetadataDefinitionKind
.
Type
,
typeName
)
{
Type
=
definition
};
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录