Fixes a couple options that were not being serialized to the registry and adds several OptionProviders to enumerate options in portable projects that are no longer exported, allowing us to properly reset all options to their default values during integration tests. (changeset 1353921)

Currently, we have a many to many mapping between diagnostics reported in a given span and code fixes available for these diagnostics. For example, it is legal for a code fix provider to return two fixes to handle three diagnostics in a given span and we currently have no way to map from the fixes returned from a provider back to the diagnostics that each fix is supposed to handle (the CodeAction for a fix doesn't know which diagnostic it is fixing)

The light bulb menu item (SuggestedAction) for a fix therefore doesn't have a definitive way to identify which diagnostic the menu item is fixing. Instead each SuggestedAction holds on to a collection of diagnostics and it could be fixing any diagnostic in the collection. In the preview pane header for a particular menu item, we currently display details about the 'first' diagnostic in the collection. Most of the time this works fine because most of the time we only have a single diagnostic in any given span. However this breaks anytime we have more than one diagnostic in a given span and we end up showing the wrong headers for our preview panes in such cases.

This fix changes code fix providers to always accept a single diagnostic as input (instead of a collection) and return a list of fixes for this single diagnostic (i.e. have one to many mapping from diagnostic to fixes). The host now passes one diagnostic at a time to each provider which returns set of fixes for each diagnostic. This allows the host to maintain a mapping from diagnostic to fixes and display this mapping to the end user (in the preview pane header) + also makes the API less confusing for the author of the fix provider. (changeset 1353855)

Fix for bug 1048368: Suppressing/escalating user diagnostics through project property pages isn't reflected in live errors

Fix assumptions about warnaserror and nowarn ID value being integers at bunch of places in Roslyn code. (changeset 1353758)

Move a few types back to the portable layer to allow a CustomWorkspace to be produced without needing the desktop layer.

As part of this, I split apart ITemporaryStorageService's ITemporaryStorage into two separate types, so it's clear whether you're storing text or storing binary streams. The merged implementation allowed some leakage of implementation details. (changeset 1353513)

1. The 'preview changes' feature in the light bulb preview pane had a bug which meant that it was only applying ApplyChangesOperations - other operations (such as opening and navigating to a document added as part of a fix etc.) were being skipped when the user clicked Apply in the preview dialog. This fix makes sure that we don't skip any operations and that the code fix is applied the same way regardless of whether the user clicks on the light bulb menu or the Apply button in the preview dialog.

2. Additionally, this change also disables check boxes in the preview changes dialog so that it is impossible select / deselect portions of a fix and apply the fix partially. Applying a partial fix can break assumptions in subsequent operations (for example, user could deselect changes to add a document that a subsequent OpenDocumentOperation is going to open and thereby cause this operation to fail).

3. This change also changes the order of suppression fixes so that the 'global' suppression fix (that adds SuppressMessageAttribute in a separate file) is always last in the list of suppression fixes. After this change the suppression menu will read as follows with the (separate file) fix showing up at the end instead of in the middle.

     Suppress CA1234 -> this instance
                                         with SuppressMessageAttribute
                                         with SuppressMessageAttribute (in separate file)

4. Also augment doc comment for batch fix all provider to clarify that only ApplyChangesOperations in the constituent fix occurances are batched and that other operations are ignored. (changeset 1353192)

DevDiv #995192 - VB: Set DkmClrCompilationResultFlags.ReadOnlyResult appropriately in the Watch window

Expose Binder.IsValidAssignmentTarget and Binder.AdjustAssignmentTarget and invoke them as in BindAssignmentStatement.

CR: ChuckS (changeset 1353140)

Expose Binder.CheckValueKind and check for Binder.BindValueKind.Assignment.

TODO: VB

CR: ChuckS, KevinH (changeset 1353049)

Provide serializable wrappers of DocumentId, ProjectId and VersionStamp. This mirrors the SerializableProjectReference that was already in Workspaces.Desktop (and public), and the serializable wrappers of various compiler types. (changeset 1352515)

Fix is to suppress duplicate analyzer exception diagnostics in each compilation. (changeset 1352343)

Avoid an InvalidCastException while calculating LocalSyntaxOffset within synthetic lambda. (changeset 1352239)

When our projects were last updated to a newer version of Microsoft.Net.ToolsetCompilers, NuGet didn't replace the old version--it just put the new version next to it. Every project ended up referencing both versions, and which set of compiler binaries "won" depended on the order they appeared in the project file. So different projects built with different compilers.

This change strips out all references to the old version. (changeset 1352054)

Remove type constraint on ReplaceNodes API that forces the type of the replacement node to be of the same type as the node to be replaced. (changeset 1352036)

C#: Report a use-site error if it could be a reason for failing to implement a member of an interface. (changeset 1352026)

Add a pre-build script to MicroBuild to have the build servers restore the NuGet packages before building. (changeset 1351423)

C#: Request use-site diagnostics while checking if type caught or thrown derives from System.Exception and report it (the use-site diagnostics) if the check failed. Fixes #132. (changeset 1351406)

This change captures a telemetry data point the first time the Analyzers node or a child analyzer node is expanded in Solution Explorer. The intent is to capture data on how many users interact with this part of Solution Explorer.

Note that for any given node we only capture a data point the first time it is expanded. Collapsing and re-opening the node will not cause further data points to be captured, nor will adding or removing analyzers.

The data point also captures data on the number of analyzers, and the number of diagnostics in an analyzer. (changeset 1351286)

MemberSemanticModel: Acquire nodeMapLock for the entire duration of binding with IncrementalBinder followed by the guardedNodeMap population. This ensures consistency between parent/child statement nodes stored in the map. (changeset 1351235)

changed to use formatedsymbol rather than putting specific error case in ConvertSymbolToString (changeset 1351207)

Rename hasn't yet been updated to handle universal projects/linked files.  This fixes one area where we were crashing when asserting that only a single project was being processed by rename when renaming private members. (changeset 1351196)

CR feedback on the allowing assigning to readonly properties in constructors change. (changeset 1351156)

added 104 as one of special case where we use fully qualified name for symbol in the error message (changeset 1350987)

     This is to help try to debug/log things happening on the TypeScript side.  The current VersionStamp.ToString
     is too coarse grain, and makes it hard to determine order when lots of VersionsStamps appear the same in the
     log (but are actually diferent).

***NO_CI***
 (changeset 1350565)

Fix relative path references to System.Collections.Immutable in CSharp and Basic portable workspaces. (changeset 1349685)

Previously the user had to pass both of these objects to CompilationOptions and the compiler had to call first the resolver to resolve the path specified in #r:

string ResolveReference(string reference, string baseFilePath)

and then the provider to create the reference:

PortableExecutableReference GetReference(string resolvedPath, MetadataReferenceProperties properties)

With this change the compiler simply calls on MetadataReferenceResolver:

ImmutableArray<PortableExecutableReference> ResolveReference(string reference, string baseFilePath, MetadataReferenceProperties properties)

Notice that now the resolver may return multiple references. This is needed to support #r of NuGet packages.

We used reference resolvers and providers in many ways for multiple purposes. I left behind the metadata file resolvers and providers to avoid making too many changes, but made them internal. In some cases the usage is legitimate, but still an implementation detail. More cleanup will also be possible once we remove the old scripting API. For now I have worked around all these dependencies.
 (changeset 1349333)