Fix for bug 1048368: Suppressing/escalating user diagnostics through project...

Fix for bug 1048368: Suppressing/escalating user diagnostics through project property pages isn't reflected in live errors

Fix assumptions about warnaserror and nowarn ID value being integers at bunch of places in Roslyn code. (changeset 1353758)

Src/Workspaces/CSharp/Desktop/MSBuild/CSharpProjectFileLoader.CSharpProjectFile.cs

@@ -482,6 +482,10 @@ private void SetWarnings(string warnings, ReportDiagnostic reportStyle)
                             {
                                 this.Warnings["CS" + warningId.ToString("0000")] = reportStyle;
                             }
+                            else
+                            {
+                                this.Warnings[warning] = reportStyle;
+                            }
                         }
                     }
                 }

Src/Workspaces/VisualBasic/Desktop/MSBuild/VisualBasicProjectFileLoader.vb

@@ -695,6 +695,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
                             Dim warningId As Integer
                             If Int32.TryParse(warning, warningId) Then
                                 Me._warnings("BC" + warningId.ToString("0000")) = reportStyle
+                            Else
+                                Me._warnings(warning) = reportStyle
                             End If
                         Next
                     End If