- 20 6月, 2018 1 次提交
-
-
由 Jared Parsons 提交于
-
- 18 5月, 2018 1 次提交
-
-
由 Tomáš Matoušek 提交于
Even though Roslyn can only every be deployed where at least net461 or netcoreapp2.0 is available Roslyn cannot depend on netstandard2.0 assemblies. This is due to the setup of Visual Studio which has a minimum target of net46 and hence only deploys netstandard1.3 facades. In order to prevent netstandard2.0 versions of NuGet references to deploy, at build or test, we must limit the desktop target framework used in our projects to net46. There is nothing functionally wrong with having our tests target net461. At the same time though it would mean our tests were running against the netstandard2.0 version of references, such as System.Collections.Immutable, which is not what we deploy against. Hence not testing what we ship which creates a small but real hole.
-
- 15 3月, 2018 1 次提交
-
-
由 Jared Parsons 提交于
-
- 09 3月, 2018 2 次提交
-
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
-
- 14 2月, 2018 1 次提交
-
-
由 Abhitej John 提交于
-
- 13 2月, 2018 1 次提交
-
-
由 Andy Gocke 提交于
-
- 03 2月, 2018 2 次提交
-
-
由 dotnet bot 提交于
* Remove duplicate lock DocumentState.s_syntaxTreeToIdMapLock This lock is only being used to protect access to an instance which contains internal synchronization. * Better handle surrounding directives when inlining a local variable. * Add tests. * Share code between VB and C#. * Reduce allocations in UnboundLambda Fixes #23463 * Restore ReturnInferenceCacheKey as the key for _returnInferenceCache * Update code to more closely follow patterns of the original code * Cleanup from code review * basic fix for intellisense in Immediate window * better comments and cleanup * Add basic integration tests * cleanup inproc Immediate window integration test helper * fix incorrect comment * address PR feedback * create Immediate window on ImmediateWindow_InProc.GetText() * Verify MSBuild version in Developer CMD prompt Roslyn is designed to have the simplest possible contribution story: clone then build. Every pre-req needed is either located on the machine or bootstrapped via NuGet. All the way down to using an xcopy MSBuild if needed. The one case which causes a problem is the VS command prompt. In this case MSBuild is pre-installed on the machine and may or may not be suitable for building Roslyn. Previously when building from a VS command prompt we just used whatever MSBuild was provided. The assumption being a developer command prompt was an explicit statement of whath MSBuild you wanted to use. Based on all of our customer reports though this does not seem to be the assumption that consumers of our repo have. The build gave them no explicit errors about the provided toolset and hence when the build failed they assigned flakiness to our repo. Going forward we are applying the same version validation to MSBuild when provided via a developer command prompt. If it doesn't match we will refuse to build asking the user to upgrade VS or build from a normal command prompt. * Remove unneeded debugging line * Comment about pre-release * Added minimum version * Add Omit If Default style option * Add space to be like test without the omit * Add/Remove without needing a property * Reformat * PR feedback * Fix VB diagnostic based on feedback * Handle case of NotApplicable modifier and field declaration list * Fix tests * PR feedback * PR feedback * PreviewCodeAction was overriding ComputeOperations but returning a post-processed operation from original action. This results in another PostProcess being called on the codeaction. If postprocess was overriden in originalaction that'll be ignored the second time (#23920) * Support negative null-check when we are suggesting to inline type checks Fixes #21097 Fixes #24286 * fix a case where persistent storage registration fails and some clean… (#24458) * fix a case where persistent storage registration fails and some clean up code around it. * added readonly * address PR feedback * removed comments no longer relevant * renamed lock name * moved waiter from diagnostics.dll to features.dll where all interfaces are defined. (#24512) * put listener change back in (https://github.com/dotnet/roslyn/pull/24120) * leave old types in legacy folder until partner teams move to new interface * added legacy waiter to support partner teams * Remove methods indirecting access to _metadataFileNameToConvertedProjectReference This field is documented as being written and read from any thread, but in practice all uses are guarded by an AssertIsForeground(). Thus we can get rid of the helper methods that are trying to "help" by locking before accessing the fields, making it really hard to track all the real uses of it. * Make method static that doesn't need state * add a comment to address PR feedback * Fix up tests of P2P to metadata reference conversion It turns out we had some tests, but the tests were disabled. This was because the tests weren't working properly anyways: they were calling into UpdateProjectBinPath which only updated some (but not all) of the project state. That was an internal helper method that shouldn't be used by tests. Updating the tests to use SetBinOutputPathAndRelatedData works better. * Delete debug-only reference validation This was some legacy code that tried to verify that the references we have from the project system match up to what DTE and other sources say. This was debug-only, and the actual asserts were commented out. This is deadweight at this point, so delete it. * added and cleaned up logs around build and live diagnostics. (#24551) also added RoslynActivityLogger that can be enabled through project-system-tool * Avoid closure allocations on the BindSyntaxTreeToId fast path * CS1628 error text mentions in parameters; fixes #24584 * Small cleanup of completion logic. * Move to xunit.console for CoreClr tests Previously we were using xunit.console for desktop tests and dotnet-xunit for our CoreClr tests. This change unifies us on top of xunit.console (now that it has a netcoreapp2.0 version available). * Move unix builds to xunit.runner.console as well * Get actual directory name, not file * Fix dir name issue * fixed build break
-
由 Jared Parsons 提交于
-
- 06 1月, 2018 3 次提交
-
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
Not all of our desktop tests have a target framework directory in their paths. Only the ones which also multi-target do. For the time being changing the set of DLLs that we run on Mono to be a hard coded list as it's only two. Will expand out as we increase our scope.
-
- 15 12月, 2017 1 次提交
-
-
由 Ashley Hauck 提交于
-
- 12 12月, 2017 1 次提交
-
-
由 Jared Parsons 提交于
The bash regex equality operator on Mac does not match an empty string to all input strings as it does for Linux. This was causing all of our tests to fail to run on Mac. Added an explicit check for the empty case.
-
- 29 11月, 2017 1 次提交
-
-
由 Ashley Hauck 提交于
It's gross, but we need to publish *something* until ILAsm is exposed as a normal assembly
-
- 03 11月, 2017 1 次提交
-
-
由 khyperia 提交于
Also remove osx RID version
-
- 26 9月, 2017 1 次提交
-
-
由 David Ben Knoble 提交于
Lack of quoting causes issues when files have spaces or are empty names. Additionally, some arrays (though single elements) were treated like simple variables. The careful reader will note that I have left BUILD_ARGS dotnet build "${ROOT_PATH}"/CrossPlatform.sln ${BUILD_ARGS} untouched, because it contains spaces meant to separate arguments. Word expansion is somewhat desired there (I believe) to ensure the arguments are properly parsed. Unfortunately, BUILD_ARGS may contains paths with spaces in them, causing this to still fail. Fix #22259
-
- 22 9月, 2017 1 次提交
-
-
由 Ashley Hauck 提交于
-
- 20 9月, 2017 1 次提交
-
-
由 Ashley Hauck 提交于
-
- 16 9月, 2017 1 次提交
-
-
由 Ashley Hauck 提交于
-
- 01 9月, 2017 6 次提交
-
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
This lets us avoid hard coding in version numbers for the core tools we use in our build.
-
由 Jared Parsons 提交于
This removes the hard coded version number for dotnet-xunit. It now uses awk to parse out the actual version in Packages.props.
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
This changes the unix legs to use the 2.0 SDK. They are likely to suffer from the same problem as the windows CoreClr leg in that they aren't producing XML files. But we should be able to fix both of those at the same time.
-
- 27 7月, 2017 1 次提交
-
-
由 Ashley Hauck 提交于
Also update a couple docs to reflect more modern information. Docs are very out of date at this point, and a review pass should probably be done.
-
- 28 2月, 2016 1 次提交
-
-
由 Andy Gocke 提交于
-
- 26 2月, 2016 2 次提交
-
-
由 Andy Gocke 提交于
This reverts commit 61a5ae49.
-
由 Andy Gocke 提交于
This reverts commit 57a34148.
-
- 17 2月, 2016 4 次提交
-
-
由 David Kean 提交于
This reverts commit e3c1ea08.
-
由 David Kean 提交于
This reverts commit ec2622b3.
-
由 Andy Gocke 提交于
-
由 Andy Gocke 提交于
This still only runs the tests on desktop (for now), but it makes it possible to run them on coreclr.
-
- 14 1月, 2016 1 次提交
-
-
由 Robin Sedlaczek 提交于
-
- 24 12月, 2015 2 次提交
-
-
由 Jared Parsons 提交于
The tests phase of the change was using the stock version of Mono instead of the toolset version.
-
由 Jared Parsons 提交于
-