- 15 9月, 2018 5 次提交
-
-
由 Jared Parsons 提交于
After working with the CoreClr team it turns out part of our CoreClr flakiness on Linux is due to bugs fixed in netcoreapp2.1. Given that and that our consumers are all on netcoreapp2.1 already I'm moving us to 2.1.
-
由 Jared Parsons 提交于
Doc update for Linux debugging
-
由 Jared Parsons 提交于
Disable VB semantic tests on Linux
-
由 Jared Parsons 提交于
-
由 Tomáš Matoušek 提交于
-
- 14 9月, 2018 13 次提交
-
-
由 Manish Vasani 提交于
Enable DeadCodeAnalysis rules and address design/review feedback.
-
由 Manish Vasani 提交于
-
由 Jared Parsons 提交于
Looks like that's not quite fixed yet. Disabling and seeing if I can get this failing locally. Issue #29660 continues to track this area
-
由 Jared Parsons 提交于
Fix race in SourceParameterSymbol
-
由 Sam Harwell 提交于
Log information about crashes during integration tests
-
由 Julien Couvreur 提交于
-
由 Manish Vasani 提交于
Address PR feedback (use static ctor and remove regions) and also fix an assert seen during dogfooding.
-
由 Manish Vasani 提交于
Primarily addresses https://github.com/dotnet/roslyn/issues/29519#issuecomment-420067012 ``` 1. Enable the rules be default 2. Remove all the workaround/hacks for disabling the rules for product and enabling for tests. 3. Address offline feedback from @sharwell about avoiding deriving the tests from `TestBase`. 4. Separate out the pending non-design related work items from first comment into separate issues. ``` For 4., I have repurposed https://github.com/dotnet/roslyn/issues/29519 to track the pending issues with checkboxes in the first issue comment.
-
由 Sam Harwell 提交于
Add codesstyle, fix and refactoring for "Use Expression/Block body for lambda".
-
由 Sam Harwell 提交于
Integrate elseless-if handling for 'invert-if' refactoring
-
由 Sam Harwell 提交于
Stop generating redundant this() when initializing struct property
-
由 Sam Harwell 提交于
We are not currently using this analyzer to its full extent since it requires repository-specific configuration which is not yet provided for Roslyn. Issue #29275 tracks configuring and enabling this analyzer.
-
由 Jared Parsons 提交于
Re-enable VB semantic / emit tests on Linux
-
- 13 9月, 2018 14 次提交
-
-
由 Sam Harwell 提交于
-
由 Sam Harwell 提交于
-
由 Tomáš Matoušek 提交于
* Move xunit package references to Roslyn.Toolsets.Xunit.targets * Remove dependency on Microsoft.NET.Test.Sdk
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
-
由 Jared Parsons 提交于
This type, and it's children, had the same race condition around attributes that `SourceEventSymbol` did. After some thought I decided to move this code back into `SourceCompletionState` with a new name to make it clear the completion is around attributes only. This is a follow up to #29807
-
由 Jared Parsons 提交于
Fix race in SourceEventSymbol.GetAttributesBag
-
由 Cheryl Borley 提交于
-
由 Sam Harwell 提交于
Add Make Field Readonly test for accessed fields
-
由 Sam Harwell 提交于
VB - fix broken code generated when converting to auto property
-
由 Julien Couvreur 提交于
-
由 Jinu 提交于
Prevent Format String analyzer from crashing on a local function named Format
-
由 Jared Parsons 提交于
There is a race condition around the setting of `CompletionPart.Attributes` in `SourceEventSymbol`. This can be exposed when the following execution pattern occurs: - Thread1: Calls `GetAttributesBag` and pauses execution on the line ` `DeclaringCompilation.SymbolDeclaredEvent(this)` - Thread2: Calls `ForceComplete` which will unconditionally call `state.NotePartComplete(CompletionPart.Attributes)` - Thread1: Resumes and hits an assert because `NotePartComplete` returns `false`. The root problem here is the unconditional call of `NotePartComplete` inside of `ForceComplete`. The pattern in all of our other symbols for `ForceComplete` is the following: - Call `GetAttributes` - Call `SpinWaitComplete(CompletionPart.Attributes, cancellationToken)` This ensures that `NotePartComplete` is executed on the thread which actually completes the loading of attributes. As a part of fixing this I looked through all other uses of `NotePartComplete(CompletionPart.Attributes)` to ensure they didn't have this problem. Checked VB as well and it doesn't seem to have this issue. Struggled to find a good way to test this as it's a race condition. Given the high number of bugs we've recently filed on this assert I'm confident we have the indirect coverage in our suites. closes #28954
-
由 Tomáš Matoušek 提交于
* Rename target GetBuildVersion to GetVsixVersion * Targets refactoring to align with Arcade SDK * Remove unused property * Use Arcade VSIX build targets * Upload Willow VSIXes directly from VSSetup directory * Add setup packages to Roslyn.sln * Remove swr validation from BuildBoss * Avoid copying CoreXT packages * Don't delete DevDivPackages\Roslyn dir * Upload vsixes even when the build fails * Clean up VSIX project files * Install VSIXes in specified order * Do not set TargetFrameworkVersion. * Fix parameter * DevDivInsertion better error message * Remove 'win' from target string * Fix dir name * Install Setup.Dependencies * Default values for insertion components * Make BuildBoss happy * Fix VSIX path * NGEN binaries that should have been NGEN'd * RoboCopy returns non-zero exit code on success * Pass OfficialBuild property to vsmanproj
-
- 12 9月, 2018 8 次提交
-
-
由 Sam Harwell 提交于
Closes #29746
-
由 Jonathon Marolf 提交于
fix publish assets to publish channels
-
由 Heejae Chang 提交于
-
由 Cheryl Borley 提交于
-
由 Ivan Basov 提交于
-
由 Joey Robichaud 提交于
Upgrade to .NET Core SDK version 2.1.401
-
由 Jonathon Marolf 提交于
-
由 Jared Parsons 提交于
The cause of the CoreClr crash appears to be VB expression trees. I've disabled all of the relevant tests util we can get a fix from the CoreClr team. I'm as confident as can be that this will be stable. I ran the test 100 times in a loop locally and got no failures. If more popup I'll dig further CoreClr tracking bug: https://github.com/dotnet/coreclr/issues/19862
-