Make sure we use the same CodeAnalysisRuleSet across all configurations of a project. (changeset 1387120)

Disabling a few suites which are exhibiting flaky behavior in the lab.  DevDiv 1095079 tracks re-enabling them. (changeset 1386998)

***NO_CI***
 (changeset 1386846)

- Group code fixes offered in the light bulb by the issue being fixed (as opposed to by the provider that supplied the fix). The order of the offered fixes should mostly remain the same as before - however, they will now be grouped differently - in most cases this will result in fewer groups in the overall list + this should make it easier to understand where fixes for one issue end and next one begins (in cases where we have fixes for more than one diagnostic on a given line)... (This addresses bug 1077181)

- Stop prioritizing fixes based on whether they are fixing a warning / error / hidden diagnostic. Fixes are already being ordered (based on ExtensionOrdering as well as based on proximity to cursor) - we shouldn't allow the priority setting to interfere with this ordering. We now use priority only for ordering fixes above refactorings and for ordering everything above the suppression fixes. This should also fix the issue where the rename tracking code fix would always show up at the bottom of the list below GFU fixes. (This addresses bugs 1090799 and 1074182) (changeset 1386745)

Ensure that GetSemanticInfo() returns the correct members for the LHS of a conditional access expression.

The syntax node for the LHS of a conditional access expression appears in two places:
- Inside its own BoundExpression, tracked by BoundConditionalAccess.Receiver
- Inside the BoundConditionalReceiver that is attached to the RHS of the conditional access expression, tracked by BoundConditionalAccess.AccessExpression

Or, diagramatically (let "SyntaxNode" be the syntax node for the LHS of the conditional access expression):

      BoundConditionalAccessExpression
      /                              \
BoundExpression                    .....
      |                              |
  SyntaxNode               BoundConditionalReceiver
                                     |
                                 SyntaxNode

This has the effect of confusing the semantic model when looking for symbol information for SyntaxNode: because the appearance of SyntaxNode in the RHS of the BoundConditionalAccessExpression is lower in the bound tree than the appearance of SyntaxNode in the LHS, the BoundConditionalReceiver associated with the RHS will be used to lookup symbols. The primary effect of this is a failure to return the actual method called in situations such as the following:

class C
{
    public int I;

    public static C M(long l) { return null; }
    public static C M(int i) { return null; }

    public static int Main()
    {
        return (int)(M(0)?.I);
    }
}

If semantic information is requested for "M" in the call to "M(0)", the returned information will contain both overloads of "M" instead of the actual overload chosen.

The actual fix is simple:
- Mark all BoundConditionalReceiver nodes as compiler generated, thus eliminating them from consideration for MemberSemanticModel.GetBoundNodes
- Stop digging through the syntax tree for conditional expressions when getting the bindable parent node of an expression

Unfortunately, the recommendation service took a dependency on seeing the BoundConditionalReceiver in the tree when requesting type information for the bound LHS of a member binding expression via SemanticModel.GetTypeInfo: if the type of the original receiver for the conditional access is T?, the type of the BoundConditionalReceiver is T. Instead of relying on this behavior, the recommendation service has been updated to perform this transformation manually.
***NO_CI***
 (changeset 1386679)

There are some warnings that we havent implemented in Roslyn but have kept around because someone could have done a /nowarn and we would have complained in the past if we didnt recognize that warning number.

However now that /nowarn doesnt complain about unrecognized warnings (because it needs to support userdiags) there's no point keeping them. (changeset 1386659)

VB Unstructured Exception Handling: Finish work to comply with requirement that IL shall only differ between Release and Debug. Enable/fix all Unstructured Exception Handling unit-tests.
***NO_CI***
 (changeset 1386638)

Fix for bug 1095705: The analyzer driver makes duplicate callbacks for FieldDeclarationSyntax nodes (https://roslyn.codeplex.com/workitem/462)

We ended up making duplicate callbacks for field declarations for syntax analyzers, as the declaring node for the decl is the variable declarator within the field declaration. Fix is to make sure that we compute the topmost node used for syntax analysis for declarations.

Fixes codeplex issue 462. (changeset 1386620)

This changeset introduces the concept of a "global" nuget package. The references to the NuGet packages are inserted into the Open VSL.Settings.targets file, which is imported into every project in Roslyn. This ensures that every project automatically gets these "global" packages. (changeset 1386548)

The expression compiler always allows unsafe code, so we introduce a global unsafe context into the binder chain.  Unfortunately, "await" is not allowed in unsafe contexts.  We specifically suppress the error (CS4004) because not introducing a global unsafe context would require the suppression of far more unsafe-region-required errors.

There is no corresponding issue in VB, which lacks unsafe contexts.

CR: chucks; ngafter; alekseyt (changeset 1386533)

Paul alerted me to a bug in the first change I made to VBCSCompiler.  I caused it to ignore its keepAlive value in certain situations.  This went unnoticed because there wasn't a test covering this and I fixed it, inadvertently, in a subsequent change.  This change adds a series of unit tests to track this scenario and other related ones.

     Additionally it changed the compiler to thread through the response file path.  The method of calculating the path in a static property using Assembly.GetEntryAssembly does not work in xUnit.  Now that the value is threaded through xUnit can pass in any directory it chooses.  Whether or not the file is on disk at that location is immaterial, compilers already have to handle the absence of this file.

***NO_CI***
 (changeset 1386527)

Mainly:
1.   disables some tests that fail in the OSS branch.
2.   Fakesigns the diagnostics implementation assemblies
3.   Fakesign the TestResourcesProprietary dll, which is deployed via nuget. (changeset 1386520)

Covers both ObsoleteAttribute and DeprecatedAttribute.

CR: chucks; ngafter; alekseyt (changeset 1386517)

Anonymous Type.ToString() implementation should use overload of String.Format that takes IFormatProvider. Also, C# implementation should explicitly call Object.ToString on each property value before passing it to the Format function, this ensures compatibility with code generated by native compiler.
***NO_CI***
 (changeset 1386476)

***NO_CI***
 (changeset 1386442)

EnC: Fixes synthesized member merging. The previous impl didn't handle case of adding non-syntheszed member after updating a method that generates a synthesized type (state machine). (changeset 1386078)

***NO_CI***
 (changeset 1385867)

When only a simple name is allowed in a context the expander shouldn't try to expand anything. Teach the expander that in C#, a MemberBindingExpression(the thing that follows ?) can only have a simplename after it. In VB, this is just a memberaccess and so the expander already knows what to do. (changeset 1385689)

This brings us back on par with Dev12.
***NO_CI***
 (changeset 1385660)

Updates System.Collections.Immutable and System.Metadata.Reader to versions 1.1.33-beta and 1.0.18-beta, respectively.
     Updates VSMEF to the latest build from VSPRO_1.

     A few code fixes:
     - ImmutableArrayInterop is gone
       - in product we used in a couple of places where we now just create a copy of the byte[] (MetadataWriter)
       - test infrastructure uses a workaround with explicitly laid out union to avoid copies of large metadata blobs
     - EditorTestApp class was incorrectly importing MEF components resulting in a cycle. The new VSMEF reports such errors. (changeset 1385613)

The Color Color handling in the binder originally used lookup to decide the meaning of an ambiguous identifier as a simple name or type name instead of binding. This was done for two reasons:
- Binding is more expensive than lookup
- Binding may have side effects that are undesirable depending on how the Color Color binding is ultimately resolved

Unfortunately, this is not correct: the meaning of an identifier as outlined in the spec is defined by binding. This caused the compiler to incorrectly fail to recognize Color Color in situations where a simple name or type name lookup is ambiguous but a bind of the same is not. This change replaces the lookups used in Color Color with binds, which brings Roslyn's behavior back in line with Dev12 and the spec in cases that fit such cases.

This change is likely to be slightly perf-positive in cases involving a simple name that does not bind to a symbol that qualifies for the Color Color rule: in this case, the old code performed a lookup followed by a bind, whereas the new code simply performs a bind and returns the result. There is likely to be a perf penalty in a true Color Color case, however, as the bound node is larger and the new code is unconditionally binding the type even in the case where the type will not be used (whereas the old code would simply look up the type).
***NO_CI***
 (changeset 1385215)

These projects were already consuming these packages in the project files, but didn't declare so in the packages.config. This brings stuff more up to sync. (changeset 1385208)

The IDE and the compiler didn't agree on the breakpoint span for VB let clauses. Fixes the IDE to match the compiler. (changeset 1385141)

This API was left in by accident from the portable MEF switch. It creates a container that is empty since it's looking for MEFv1 attributes in a MEFv2 assembly. Any use of the resulting HostServices will just fail.

CR: mavasani; jaredpar (changeset 1385133)

Change the hardcoded version style to include the full Roslyn semantic version, rather than just the major version number.
***NO_CI***
 (changeset 1385097)

***NO_CI***
 (changeset 1384854)

Fixes bug 1069237 - conflict resolution doesn't work inside expression bodied lambdas. (changeset 1384823)

Reword quoted overload resolution rule to align with proposed spec text. (Comment change only) (changeset 1384807)

Fix for bug 1094337: Remove /option switch in command line compilers and remove global options and culture on AnalyzerOptions

Remove "/option" command line switch added for custom key-value pair analyzer options. There is no way to specify these options in the msbuild project file, so we will just revert the command line support and add it back once the end-to-end scenario is implemented for analyzer options.

Additionally, also remove the Culture passed into the analyzer options. Diagnostic analyzer authors need not report localized diagnostics, just localizable diagnostics, which can be localized for any given culture by the analyzer host (IDE/command line compiler). (changeset 1384781)

Fix for bug 1089200: Previewless subclasses of CodeActionWithOptions should not require empty override of ComputeOperationsAsync(CancellationToken)

Override ComputeOperationsAsync(CancellationToken) in CodeActionWithOptions to return empty operations.
Additionally, add an internal virtual GetOperationsCoreAsync on CodeAction, which is overriden in CodeActionWithOptions to invoke GetOperations(options, cancellationToken). This avoids code action hosts to explicitly check for CodeAction's runtime type to get code action operations. (changeset 1384776)

C#: Do not bind constructor initializer for an “external” constructor, report an error if constructor initializer is present in code. This prevents unexpected diagnostics. Fixes #386.
***NO_CI***
 (changeset 1384736)

The documentation for PortableExecutableReference::CreateDocumentationProvider appears to be incorrect. It suggests the method can only be called once per instance which is inconsistent with the usage in the property DocumentationProvider. Updated documentation to match the usage behavior.
 (changeset 1384654)

Metadata: associate custom attributes with correct rows in generic parameters metadata table. Fixes #121. (changeset 1384436)