- 19 9月, 2018 1 次提交
-
-
由 Sam Harwell 提交于
-
- 15 9月, 2018 1 次提交
-
-
由 Manish Vasani 提交于
1. Bail out for explicit interface implementations for properties, we only did so for methods. 2. Bail out for types with StructLayoutAttribute 3. Conservatively handle member references inside DebuggerDisplayAttribute argument by doing a simple string contains check.
-
- 14 9月, 2018 1 次提交
-
-
由 Manish Vasani 提交于
It was initially implemented as a potential code style analyzer, but we have agreed on it being a code quality analyzer, with no special IDE options/preferences logic. I have switched the analyzer to be implemented just like a regular third party analyzer. This cleans up the implementation quite a bit, and also fixes the issue where we reported hidden diagnostics for this analyzer instead of suggestion diagnostics as the default code style diagnostic severity is hidden. I have also reverted AbstractCodeStyleDiagnosticAnalyzer.cs to the state before this analyzer was implemented.
-
- 29 8月, 2018 2 次提交
-
-
由 Ivan Basov 提交于
-
由 Manish Vasani 提交于
-
- 28 8月, 2018 1 次提交
-
-
由 Manish Vasani 提交于
1. Break the analyzer into two separate diagnostics for flagging unused and unread members. Latter rule has no code fix. 2. Remove all UI option elements for the added diagnostics and turn the rules off by default for now. 3. Bail out for invalid operations and syntax errors. 4. Handle doc comments and nameof - report unread member diagostics instead of unused member diagnostics if referenced in non-read/write context.
-
- 25 8月, 2018 2 次提交
-
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
Analyzer flags two cases: members with no read/writes and members with only writes. 1. Members with no read or writes: `Type '{0}' has an unused private member '{1}' which can be removed.` 2. Only writes: `Type '{0}' has a private member '{1}' which can be removed as the value assigned to it is never used.` Code fix removes the unused member declaration. Fixes #24225 Open questions: 1. Current analyzer design uses a single code style option for all members and both the above kinds of unused members. We can potentially have multiple options, but this should probably be done based on feedback. 2. Should the analyzer use different diagnostic IDs for the above two kinds of unused members? This will mean that the FixAll experience will need multiple iterations for removing unused members. 3. Should we update the code fix (or have an additional code fix) that also updates the write references for the case (2) above? Or is it better to leave the references to break the code so the user can analyze if the value being assigned can also be removed. The PR current chooses the latter approach as it is more conservative and unlikely to cause silent breaks.
-
- 21 8月, 2018 2 次提交
-
-
由 Manish Vasani 提交于
-
由 Manish Vasani 提交于
Add refactoring to convert foreach loop into linq invocations (Select, SelectMany and Where invocations) Adds one of the refactorings mentioned in #8953 ``` // // INPUT: // foreach (var n1 in c1) // foreach (var n2 in c2) // if (n1 > n2) // yield return n1 + n2; // // OUTPUT: // c1.SelectMany(n1 => c2.Where(n2 => n1 > n2).Select(n2 => n1 + n2)) // ```
-
- 17 8月, 2018 1 次提交
-
-
由 Tomáš Matoušek 提交于
-
- 07 8月, 2018 1 次提交
-
-
由 Julien Couvreur 提交于
-
- 21 7月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 17 7月, 2018 1 次提交
-
-
由 Zbyněk Sailer 提交于
-
- 14 7月, 2018 2 次提交
-
-
由 Zbyněk Sailer 提交于
These are missing languages which production team delivered today.
-
由 Zbyněk Sailer 提交于
-
- 12 7月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 08 7月, 2018 2 次提交
-
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
- 07 7月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 06 7月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 04 7月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 03 7月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 27 6月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 21 6月, 2018 3 次提交
-
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Ivan Basov 提交于
-
- 09 6月, 2018 1 次提交
-
-
由 Ivan Basov 提交于
-
- 08 6月, 2018 1 次提交
-
-
由 Zbyněk Sailer 提交于
-
- 24 5月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-
- 18 5月, 2018 1 次提交
-
-
由 Zbyněk Sailer 提交于
-
- 04 5月, 2018 1 次提交
-
-
由 CyrusNajmabadi 提交于
Add features to offer using conditional expressions ```?:``` over explicit if-statement flows. (#26236)
-
- 12 4月, 2018 2 次提交
-
-
由 Zbyněk Sailer 提交于
-
由 Zbyněk Sailer 提交于
-
- 06 4月, 2018 5 次提交
-
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
由 Cyrus Najmabadi 提交于
-
- 23 3月, 2018 1 次提交
-
-
由 Cyrus Najmabadi 提交于
-