- 14 9月, 2018 6 次提交
-
-
由 Sam Harwell 提交于
-
由 Sam Harwell 提交于
-
由 Sam Harwell 提交于
Add codesstyle, fix and refactoring for "Use Expression/Block body for lambda".
-
由 Sam Harwell 提交于
Integrate elseless-if handling for 'invert-if' refactoring
-
由 Sam Harwell 提交于
Stop generating redundant this() when initializing struct property
-
由 Jared Parsons 提交于
Re-enable VB semantic / emit tests on Linux
-
- 13 9月, 2018 9 次提交
-
-
由 Tomáš Matoušek 提交于
* Move xunit package references to Roslyn.Toolsets.Xunit.targets * Remove dependency on Microsoft.NET.Test.Sdk
-
由 Jared Parsons 提交于
Fix race in SourceEventSymbol.GetAttributesBag
-
由 Cheryl Borley 提交于
-
由 Sam Harwell 提交于
Add Make Field Readonly test for accessed fields
-
由 Sam Harwell 提交于
VB - fix broken code generated when converting to auto property
-
由 Julien Couvreur 提交于
-
由 Jinu 提交于
Prevent Format String analyzer from crashing on a local function named Format
-
由 Jared Parsons 提交于
There is a race condition around the setting of `CompletionPart.Attributes` in `SourceEventSymbol`. This can be exposed when the following execution pattern occurs: - Thread1: Calls `GetAttributesBag` and pauses execution on the line ` `DeclaringCompilation.SymbolDeclaredEvent(this)` - Thread2: Calls `ForceComplete` which will unconditionally call `state.NotePartComplete(CompletionPart.Attributes)` - Thread1: Resumes and hits an assert because `NotePartComplete` returns `false`. The root problem here is the unconditional call of `NotePartComplete` inside of `ForceComplete`. The pattern in all of our other symbols for `ForceComplete` is the following: - Call `GetAttributes` - Call `SpinWaitComplete(CompletionPart.Attributes, cancellationToken)` This ensures that `NotePartComplete` is executed on the thread which actually completes the loading of attributes. As a part of fixing this I looked through all other uses of `NotePartComplete(CompletionPart.Attributes)` to ensure they didn't have this problem. Checked VB as well and it doesn't seem to have this issue. Struggled to find a good way to test this as it's a race condition. Given the high number of bugs we've recently filed on this assert I'm confident we have the indirect coverage in our suites. closes #28954
-
由 Tomáš Matoušek 提交于
* Rename target GetBuildVersion to GetVsixVersion * Targets refactoring to align with Arcade SDK * Remove unused property * Use Arcade VSIX build targets * Upload Willow VSIXes directly from VSSetup directory * Add setup packages to Roslyn.sln * Remove swr validation from BuildBoss * Avoid copying CoreXT packages * Don't delete DevDivPackages\Roslyn dir * Upload vsixes even when the build fails * Clean up VSIX project files * Install VSIXes in specified order * Do not set TargetFrameworkVersion. * Fix parameter * DevDivInsertion better error message * Remove 'win' from target string * Fix dir name * Install Setup.Dependencies * Default values for insertion components * Make BuildBoss happy * Fix VSIX path * NGEN binaries that should have been NGEN'd * RoboCopy returns non-zero exit code on success * Pass OfficialBuild property to vsmanproj
-
- 12 9月, 2018 12 次提交
-
-
由 Sam Harwell 提交于
Closes #29746
-
由 Jonathon Marolf 提交于
fix publish assets to publish channels
-
由 Heejae Chang 提交于
-
由 Cheryl Borley 提交于
-
由 Ivan Basov 提交于
-
由 Joey Robichaud 提交于
Upgrade to .NET Core SDK version 2.1.401
-
由 Jonathon Marolf 提交于
-
由 Jared Parsons 提交于
The cause of the CoreClr crash appears to be VB expression trees. I've disabled all of the relevant tests util we can get a fix from the CoreClr team. I'm as confident as can be that this will be stable. I ran the test 100 times in a loop locally and got no failures. If more popup I'll dig further CoreClr tracking bug: https://github.com/dotnet/coreclr/issues/19862
-
由 Chris Sienkiewicz 提交于
Fix Tuple Crefs causing null exception: - fix the Cref binder so that we un-wrap any TupleTypeSymbols that get wrapped inside BindNamespaceOrTypeSymbol as crefs don't consider the higher order form tuples at all. - Add tests
-
由 Neal Gafter 提交于
* Document #6941 Also delete meeting notes that have already been moved to an appropriate repo.
-
由 Sam Harwell 提交于
Queue tasks rather than invoking them inline
-
由 Jared Parsons 提交于
YAML file for Azure Dev Ops validation
-
- 11 9月, 2018 7 次提交
-
-
由 Jared Parsons 提交于
Fix tests.sh so you can run a single assembly, add support for running a single test
-
由 Katelyn Gadd 提交于
Fix tests.sh support for running a single assembly and add argument passthrough so you can run a single test
-
由 Cheryl Borley 提交于
-
由 Joey Robichaud 提交于
-
由 Jared Parsons 提交于
-
由 Chris Sienkiewicz 提交于
* Fix compiler server mismatched version: - Ensure compiler server returns correct response when providing an incorrect protocol value - Add test to check - Fix tests that break * Check compiler sha as part of build server protocol: - Add the CommitHashAttribute to the needed assemblies - Bump the protocol version to 3 - Add a new CommitHash field to build request - Fill out the CommitHash from the CommitHashAttribute value when creating build requests - Check that the commitHash on a de-serialized build request matches the one compiled into the assembly - Return a new IncorrectHash response if hashes fail to match - Fail early on the client side if we can't get the hash
-
由 Jared Parsons 提交于
This is the YAML file for enabling VSTS validation of our PR process instead of Jenkins. This has already converted the majority of our jobs over. Once this is merged, and a few more VMs are available, we can fully move off of Jenkins.
-
- 10 9月, 2018 2 次提交
-
-
由 Jinu 提交于
Enable incremental updates of the dependency graph
-
由 Tomáš Matoušek 提交于
-
- 09 9月, 2018 1 次提交
-
-
由 Sam Harwell 提交于
Merge master-vs-deps to master
-
- 08 9月, 2018 3 次提交
-
-
由 Martin Strecker 提交于
Add parameter CodeFixProvider: Add support for `this` and `base` constructor initializers invocations. (#29061) * Add support for this and base constructor initializers invocations. * Add WorkItem attribute to tests. * Fix error comments on tests. * Added tests for VB. * Refactor RegisterCodeFixesAsync. * Change visibility of some methods from protected to private and make some methods static. * Remove Async prefix from synchronous methods. * Simplify method signatures of "GetDataForFix_" methods. * Incorporated code review. * Return empty fixData to exit the loop if a known but unfixable node is found. * Handle VBs Me.New() calls properly. * Move method to make the PR diff easier to read. * Unify removal of constructor candidates. * Used named args for bool. * Added copyright banner.
-
由 Shyam N 提交于
This will allow derived types to log exceptions that are handled before RunServiceAsync() can see them.
-
由 Sam Harwell 提交于
-