1. 14 9月, 2018 6 次提交
  2. 13 9月, 2018 9 次提交
    • T
      Move xunit package references to Roslyn.Toolsets.Xunit.targets (#29664) · 8edf4999
      Tomáš Matoušek 提交于
      * Move xunit package references to Roslyn.Toolsets.Xunit.targets
      
      * Remove dependency on Microsoft.NET.Test.Sdk
      8edf4999
    • J
      Merge pull request #29807 from jaredpar/fix-race · 6805b2e5
      Jared Parsons 提交于
      Fix race in SourceEventSymbol.GetAttributesBag
      6805b2e5
    • C
      cd069434
    • S
      Merge pull request #29803 from sharwell/readonly-access-tests · 1743628c
      Sam Harwell 提交于
      Add Make Field Readonly test for accessed fields
      1743628c
    • S
      Merge pull request #29686 from chborl/useautopropVBissue · 560acdcb
      Sam Harwell 提交于
      VB - fix broken code generated when converting to auto property
      560acdcb
    • J
      GenerateDeconstructMethod code fixer (#28286) · b289d608
      Julien Couvreur 提交于
      b289d608
    • J
      Merge pull request #29770 from chborl/formatstringlocalfunctionissue · 789d523e
      Jinu 提交于
      Prevent Format String analyzer from crashing on a local function named Format
      789d523e
    • J
      Fix race in SourceEventSymbol.GetAttributesBag · e2d95115
      Jared Parsons 提交于
      There is a race condition around the setting of
      `CompletionPart.Attributes` in `SourceEventSymbol`. This can be exposed
      when the following execution pattern occurs:
      
      - Thread1: Calls `GetAttributesBag` and pauses execution on the line `
      `DeclaringCompilation.SymbolDeclaredEvent(this)`
      - Thread2: Calls `ForceComplete` which will unconditionally call
      `state.NotePartComplete(CompletionPart.Attributes)`
      - Thread1: Resumes and hits an assert because `NotePartComplete` returns
      `false`.
      
      The root problem here is the unconditional call of `NotePartComplete`
      inside of `ForceComplete`. The pattern in all of our other symbols for
      `ForceComplete` is the following:
      
      - Call `GetAttributes`
      - Call `SpinWaitComplete(CompletionPart.Attributes, cancellationToken)`
      
      This ensures that `NotePartComplete` is executed on the thread which
      actually completes the loading of attributes.
      
      As a part of fixing this I looked through all other uses of
      `NotePartComplete(CompletionPart.Attributes)` to ensure they didn't have
      this problem. Checked VB as well and it doesn't seem to have this issue.
      
      Struggled to find a good way to test this as it's a race condition.
      Given the high number of bugs we've recently filed on this assert I'm
      confident we have the indirect coverage in our suites.
      
      closes #28954
      e2d95115
    • T
      Switch to Arcade targets for building VSIXes (#29590) · 515ff80d
      Tomáš Matoušek 提交于
      * Rename target GetBuildVersion to GetVsixVersion
      
      * Targets refactoring to align with Arcade SDK
      
      * Remove unused property
      
      * Use Arcade VSIX build targets
      
      * Upload Willow VSIXes directly from VSSetup directory
      
      * Add setup packages to Roslyn.sln
      
      * Remove swr validation from BuildBoss
      
      * Avoid copying CoreXT packages
      
      * Don't delete DevDivPackages\Roslyn dir
      
      * Upload vsixes even when the build fails
      
      * Clean up VSIX project files
      
      * Install VSIXes in specified order
      
      * Do not set TargetFrameworkVersion.
      
      * Fix parameter
      
      * DevDivInsertion better error message
      
      * Remove 'win' from target string
      
      * Fix dir name
      
      * Install Setup.Dependencies
      
      * Default values for insertion components
      
      * Make BuildBoss happy
      
      * Fix VSIX path
      
      * NGEN binaries that should have been NGEN'd
      
      * RoboCopy returns non-zero exit code on success
      
      * Pass OfficialBuild property to vsmanproj
      515ff80d
  3. 12 9月, 2018 12 次提交
  4. 11 9月, 2018 7 次提交
  5. 10 9月, 2018 2 次提交
  6. 09 9月, 2018 1 次提交
  7. 08 9月, 2018 3 次提交
    • M
      Add parameter CodeFixProvider: Add support for `this` and `base` constructor... · 150590ff
      Martin Strecker 提交于
      Add parameter CodeFixProvider: Add support for `this` and `base` constructor initializers invocations. (#29061)
      
      * Add support for this and base constructor initializers invocations.
      
      * Add WorkItem attribute to tests.
      
      * Fix error comments on tests.
      
      * Added tests for VB.
      
      * Refactor RegisterCodeFixesAsync.
      
      * Change visibility of some methods from protected to private and make some methods static.
      
      * Remove Async prefix from synchronous methods.
      
      * Simplify method signatures of "GetDataForFix_" methods.
      
      * Incorporated code review.
      
      * Return empty fixData to exit the loop if a known but unfixable node is found.
      
      * Handle VBs Me.New() calls properly.
      
      * Move method to make the PR diff easier to read.
      
      * Unify removal of constructor candidates.
      
      * Used named args for bool.
      
      * Added copyright banner.
      150590ff
    • S
      Add a protected helper for logging exceptions to servicehub log · d5f8faff
      Shyam N 提交于
      This will allow derived types to log exceptions that are handled before RunServiceAsync() can see them.
      d5f8faff
    • S