We were previously mistaking "<>" as identifier start characters in the debugger.  This prevented you from evaluating open generic types with a single type parameter.

Fixes internal issue #1138943.

In the SymbolFinder API, references to constructors are included as references to both the constructor method symbol and the related type symbol. Because reference locations are deduplicated across all results shown in Find References, we have to decide which definition node to use as the parent. Prior to this change the first related definition returned to us by the SymbolFinder won, but this ordering was not guaranteed to be consistent. This change introduces a precedence ordering for definitions returned by the SymbolFinder that currently guarantees that members will be preferred over types.

Additionally, this change removes the requirement that definitions shown in Find References have distinct locations. This allows us to meaningfully separate references between a type and its default constructor which has the same location.

1) Statically created LocalizableString instances by analyzers were holding onto instances of AnalyzerExecutor (which holds onto the compilation on which it executes) for exception reporting, causing us to leak compilations in command line builds. Fixed this by making sure that we unregister these exception handlers during analyzer cleanup in CommonCompiler, we already did so for VisualStudioAnalyzer created in IDE.

2) Switch all the state caches in AnalyzerManager to be keyed with analyzer, and clear all state for analyzer when host disposes it. Performance analysis showed that analyzers that capture the CompilationStartAnalysisContext in its RegisterCompilationStartAction via some lambda were rooting the compilation objects.

Above two changes got rid of all the static and dependent handles rooting compilations during command line builds, and I see a perceived reduction in memory used by VBCSCompiler during building Roslyn.

3) Fix the IDE onAnalyzerException delegate to not capture project instance, but instead use the projectId. Otherwise, VSIX analyzers that live for lifetime of VS instance would leak compilations.

While I was at it, I also got rid of functionality added to MetadataCache that was caching and re-using analyzer instances across AnalyzerFileReference instances, we had already decided to instead keep lifetime of analyzer instances bound by lifetime of owning AnalyzerFileReference.

Fix #1371 :  Make FileBasedXmlDocumentProvider not process DTD by
setting the correct DTDProcessing value in the XmlReaderSetting

Also fix XmlDocumentProvicer to return the string with the Tags and
Newlines when called GetDocumentForSymbol

This fixes a couple of build warnings:

- Bad hint path for MS.VS.Platform.VSEditor.Interop.dll
- Syntax.xml did not conform to the prescribed XML schema

I additionally modified VisualBasicSyntaxGenerator to exit with an error
code in the case the provided XML file did not match the schema.  That
will prevent future regressions on the second warning I fixed.

closes #1356
closes #1386

Respond to PR feedback

1. Compile them against Profile7.
   a. Swap out a few APIs (e.g. using GetTypeInfo for reflection).
   b. Introduce an abstraction layer so that we don't have to instantiate
   DkmDataItem (caused a VerificationException).
   c. Include WindowsProxy.winmd as an EmbeddedResource directly, rather
   than through a resx file.
2. Swap the output locations of the ResultProvider projects: Portable goes
to the main output directory and NetFX20 goes to a subdirectory (NetFX20).
3. Include the Portable ResultProvider assemblies in the EE vsix, rather
than the NetFX20 ones.

Fix IsDiagnosticAnalyzerSuppressed check for analyzers that have NotConfigurable diagnostics which are disabled by default.

Current logic didn't account for the fact that even though these descriptors are non-configurable, they might be turned off by default and hence be suppressed.

Reduce the size of PEMethodSymbol for both VB and C# by moving many fields into an auxiliary UncommonFields class

Create props file in the System.Runtime.Analyzers with CodeAnalysisOverrides so that the rules implemented by these analyzers are not run when FxCop runs for the project.

The previous name was easily confused with a boolean value.  Changed to
have the Path suffix to make the intent of the value clearer.

this is to disable expensive analyzer (UnusedDeclarationAnalyzer)

also undo an eager localization of a string

This adds a new supported MSBuild property BootstrapBuild.  The value of
this must point to a directory containing a functional version of csc
and vbc.  When specified these executables will be used to build the
product instead of the versions provided in NuGet.

This provides us a very simple way of enabling bootstrap builds.

Fix #1309 : The call to AddTableSource(), which adds the table to
the manager, happens the first time when calling the base constructor
hence a explicit call to the same method is unnecessary and results
in exception being thrown

This will be used by TypeScript so it can display FindRefernces result in a
tree form similar to how C#/VB does it.  i.e. it can show results like:

Decl1
|--Ref1
|--Ref2
Decl2
|--Ref3
|--Ref4

A simple typo is causing Type.GetType to fail when trying to load File.

Add a new switch '/errorlog:' to VB and C# command line compilers to log all the compiler diagnostics into a log file.
Add command line parsing tests and error log content validation tests.

Fixes #249: Fix IDE diagnostics test framework to use DiagnosticAnalyzerService to compute diagnostics rather than DiagnosticAnalyzerDriver.

This change serves multiple purposes:
1) Makes our test framework consistent with the IDE scenario in fetching diagnostics. We have missed out on multiple regressions where the core IDE DiagnosticAnalyzerDriver does the right thing and hence the tests pass, but the DiagnosticService in IDE does additional filtering and certain diagnostics are not reported in VS. This change should avoid such bugs.
2) Enable testing for diagnostics V2 engine work that JohnHamby is doing to merge IDE and compiler analyzer drivers. For this engine, there is no IDE driver and hence existing IDE diagnostics tests can't be run. This change should enable running IDE diagnostics on V2 engine.
3) Move a whole bunch of of test only code in DiagnosticAnalyzerService_Test.cs into the test layer.

Fix #1298 Add suppress operation to span of the property including the
Property along with Accessorlist if it contains an initializer in
addition to the supress operation that goes over the whole of the
Property Declaration Statement