Support "typeof(Action<>)" in debugger expressions...

We were previously mistaking "<>" as identifier start characters in the debugger.  This prevented you from evaluating open generic types with a single type parameter.

Make FileBasedXmlDocumentProvider not process DTDs

[EnC] Make it a rude edit to change the value of a constant field

Update toolset compiler and diagnostics nuget packages.

Change constructor ref node location in Find Refs

Fix memory leaks in AnalyzerManager: 

1) Statically created LocalizableString instances by analyzers were holding onto instances of AnalyzerExecutor (which holds onto the compilation on which it executes) for exception reporting, causing us to leak compilations in command line builds. Fixed this by making sure that we unregister these exception handlers during analyzer cleanup in CommonCompiler, we already did so for VisualStudioAnalyzer created in IDE.

2) Switch all the state caches in AnalyzerManager to be keyed with analyzer, and clear all state for analyzer when host disposes it. Performance analysis showed that analyzers that capture the CompilationStartAnalysisContext in its RegisterCompilationStartAction via some lambda were rooting the compilation objects.

Above two changes got rid of all the static and dependent handles rooting compilations during command line builds, and I see a perceived reduction in memory used by VBCSCompiler during building Roslyn.

3) Fix the IDE onAnalyzerException delegate to not capture project instance, but instead use the projectId. Otherwise, VSIX analyzers that live for lifetime of VS instance would leak compilations.

While I was at it, I also got rid of functionality added to MetadataCache that was caching and re-using analyzer instances across AnalyzerFileReference instances, we had already decided to instead keep lifetime of analyzer instances bound by lifetime of owning AnalyzerFileReference.

Fixes internal issue #1138943.

In the SymbolFinder API, references to constructors are included as references to both the constructor method symbol and the related type symbol. Because reference locations are deduplicated across all results shown in Find References, we have to decide which definition node to use as the parent. Prior to this change the first related definition returned to us by the SymbolFinder won, but this ordering was not guaranteed to be consistent. This change introduces a precedence ordering for definitions returned by the SymbolFinder that currently guarantees that members will be preferred over types.

Additionally, this change removes the requirement that definitions shown in Find References have distinct locations. This allows us to meaningfully separate references between a type and its default constructor which has the same location.

Reduce the size of PEMethodSymbol

1) Statically created LocalizableString instances by analyzers were holding onto instances of AnalyzerExecutor (which holds onto the compilation on which it executes) for exception reporting, causing us to leak compilations in command line builds. Fixed this by making sure that we unregister these exception handlers during analyzer cleanup in CommonCompiler, we already did so for VisualStudioAnalyzer created in IDE.

2) Switch all the state caches in AnalyzerManager to be keyed with analyzer, and clear all state for analyzer when host disposes it. Performance analysis showed that analyzers that capture the CompilationStartAnalysisContext in its RegisterCompilationStartAction via some lambda were rooting the compilation objects.

Above two changes got rid of all the static and dependent handles rooting compilations during command line builds, and I see a perceived reduction in memory used by VBCSCompiler during building Roslyn.

3) Fix the IDE onAnalyzerException delegate to not capture project instance, but instead use the projectId. Otherwise, VSIX analyzers that live for lifetime of VS instance would leak compilations.

While I was at it, I also got rid of functionality added to MetadataCache that was caching and re-using analyzer instances across AnalyzerFileReference instances, we had already decided to instead keep lifetime of analyzer instances bound by lifetime of owning AnalyzerFileReference.

Fix #1371 :  Make FileBasedXmlDocumentProvider not process DTD by
setting the correct DTDProcessing value in the XmlReaderSetting

Also fix XmlDocumentProvicer to return the string with the Tags and
Newlines when called GetDocumentForSymbol

Add ISymUnmanagedBinder interfaces to Microsoft.DiaSymReader

only try to do inline rename on documents that support it (e.g., not venus)

Avoid calling .Locations on namespaces

null check a token's parent to prevent a NullReferenceException

Add missing [PreserveSig] to a couple ISymUnmanagedScope members...

The SignVsixInputs target depends on the CopyFilesToOutputDirectory target.  This target logically exists on xbuild but is named DeployOutputFiles.  This descrepancy lead to numerous warnings on Linux during a compilation about missing targets.

After discussing with @jasonmalinowski we decided to move it to
AfterCompile.  This executes in the right place for SignVsixInputs and
is supported in both xbuild and msbuild.

closes #1370

This fixes a couple of build warnings:

- Bad hint path for MS.VS.Platform.VSEditor.Interop.dll
- Syntax.xml did not conform to the prescribed XML schema

I additionally modified VisualBasicSyntaxGenerator to exit with an error
code in the case the provided XML file did not match the schema.  That
will prevent future regressions on the second warning I fixed.

closes #1356
closes #1386

Respond to PR feedback

Dont re-add the same source table

Correct typos

Make the ExpressionCompiler assemblies portable

1. Compile them against Profile7.
   a. Swap out a few APIs (e.g. using GetTypeInfo for reflection).
   b. Introduce an abstraction layer so that we don't have to instantiate
   DkmDataItem (caused a VerificationException).
   c. Include WindowsProxy.winmd as an EmbeddedResource directly, rather
   than through a resx file.
2. Swap the output locations of the ResultProvider projects: Portable goes
to the main output directory and NetFX20 goes to a subdirectory (NetFX20).
3. Include the Portable ResultProvider assemblies in the EE vsix, rather
than the NetFX20 ones.

Fix IsDiagnosticAnalyzerSuppressed check for analyzers that have NotConfigurable diagnostics which are disabled by default.

Current logic didn't account for the fact that even though these descriptors are non-configurable, they might be turned off by default and hence be suppressed.

Fix IsDiagnosticAnalyzerSuppressed check for analyzers that have NotConfigurable diagnostics which are disabled by default.

Current logic didn't account for the fact that even though these descriptors are non-configurable, they might be turned off by default and hence be suppressed.

Reduce the size of PEMethodSymbol for both VB and C# by moving many fields into an auxiliary UncommonFields class

Code cleanup in the Microsoft.CodeAnalysis project

This adds a bootstrap build step to our Linux verification process.  The
CI test will now build csc and then use that result to rebuild csc.
This will give us verification that we can fully bootstrap our compiler
(on Linux!).

closes #1637

Allow INavigableItems to have child items.