- 01 2月, 2019 1 次提交
-
-
由 Tom Meschter 提交于
This is a reworked version of #32616 targeting the dev16.0-preview3 branch.
-
- 25 1月, 2019 3 次提交
-
-
由 David 提交于
Issue 27925 - Squiggle first line / entire parenthetical expression in remove unnecessary parentheses diagnostic (#32500) * Update unnecessary parentheses analyzer to squiggle the entire expression / first line. Resolves #27925
-
由 Heejae Chang 提交于
this is so that we don't get this kind of issue (https://github.com/dotnet/roslyn/issues/31928) by throwing argument exception invalid argument is given
-
由 Manish Vasani 提交于
Current implementation bailed out in symbol start action, which caused both analysis and reporting to be skipped for unused members in a type with StructLayout attribute. New implementation bails out in symbol end action, so we only skip reporting not analysis. Fixes #32727
-
- 24 1月, 2019 3 次提交
-
-
由 Alireza Habibi 提交于
-
由 Shen Chen 提交于
* Add tests, change the behavior of comparing paramters * remove virutal * Resolve commits, add tests for property * Resolve nits, naming and comments * Add comments, move method down, renaming * Fix typo * Change modifiers and move method down * Move helper methods into state and change them to static * change modifiers * Add a check
-
由 Alireza Habibi 提交于
-
- 23 1月, 2019 4 次提交
-
-
由 Alireza Habibi 提交于
-
由 Manish Vasani 提交于
Use an alternate approach to detect bail out case: presence of deconstruction info with null deconstruct method. The prior approach of bailing out on null type or converted type broke existing behavior (tests) that handle null type value.
-
由 Manish Vasani 提交于
1. Usages as an argument to `nameof`: We have multiple reports of these being false positives in presence of reflection based usages and in variour test frameworks. Fixes #32488. 2. Presence of 'dynamic' in C# - Conservatively bail out in presence of any dynamic operations. Fixes #32522.
-
由 Gen Lu 提交于
-
- 19 1月, 2019 6 次提交
-
-
由 Gen Lu 提交于
-
由 Tomáš Matoušek 提交于
-
由 Manish Vasani 提交于
Fixes #29718
-
由 Alireza Habibi 提交于
-
由 Alireza Habibi 提交于
-
由 Alireza Habibi 提交于
-
- 18 1月, 2019 2 次提交
-
-
由 Sam Harwell 提交于
This requirement was inherited from other dependencies, and does not introduce new requirements for downstream components. The dependency requirement is leveraged to simplify code on production code paths. Fixes #29278 Closes #29279
-
由 Heejae Chang 提交于
-
- 17 1月, 2019 1 次提交
-
-
由 Robin Sue 提交于
* Don't attach trivia to nodes that will be removed * Add tests with comments
-
- 15 1月, 2019 2 次提交
-
-
由 Manish Vasani 提交于
Port existing override [UseExpressionBodyForPropertiesHelper.GetDiagnosticLocation](http://source.roslyn.io/#Microsoft.CodeAnalysis.CSharp.Features/UseExpressionBody/Helpers/UseExpressionBodyForPropertiesHelper.cs,76) to `UseExpressionBodyForIndexersHelper` Fixes #31308
-
由 Manish Vasani 提交于
1. Bail out early if there is a reference to assigned local between the declaration and null check being replaced with pattern matching. 2. Remove assert for bail out in presence of errors/unhandled cases. Fixes #31388
-
- 12 1月, 2019 1 次提交
-
-
由 Shen Chen 提交于
* Add tests to catch bugs * Change analyzer to fix two bugs * Add test to make sure parentheses will be remove when conditional expression used as rhs, change the loop in ParenthesesExpressionExtension to break properly
-
- 11 1月, 2019 4 次提交
-
-
由 Gen Lu 提交于
Since ValueTuple type is not allowed in using alias
-
由 Julien Couvreur 提交于
-
由 David Barbet 提交于
-
由 AlekseyTs 提交于
-
- 10 1月, 2019 3 次提交
-
-
由 Gen Lu 提交于
-
由 Manish Vasani 提交于
https://github.com/dotnet/roslyn/commit/6224a5c2feb8c9096cf5765f3d8d2ded396e7e88#diff-b68aa1802251151217571a56d9bfd2b8R31 changed the semantics of `IDeclarationPatternOperation` to allow null `DeclaredSymbol`. Fix SymbolUsageAnalysis invoked by unused parameters/values analyzer to handle this case. Confirmed the NRE in the unit test prior to the fix. Fixes #32287
-
由 dotnet-bot 提交于
-
- 09 1月, 2019 3 次提交
-
-
由 Manish Vasani 提交于
Added unit tests for remove unused values analyzer/fix, which invokes this method, and was asserting with the repro in the issue. Fixes #32271
-
由 Gen Lu 提交于
-
由 Gen Lu 提交于
-
- 08 1月, 2019 3 次提交
- 05 1月, 2019 2 次提交
-
-
由 Jared Parsons 提交于
-
由 Joey Robichaud 提交于
- Stop classifying EndKeyword in EndUsingStatement - Begin classifying ToKeyword in ForStatement - Begin classifying IfKeyword in TernaryConditionalExpression
-
- 04 1月, 2019 2 次提交
-
-
由 Drew Noakes 提交于
Extract test from AbstractRemoveUnusedMembersDiagnosticAnalyzer for use in AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer via a new SerializationConstructorCheck utility struct. Fixes #32133
-
由 Drew Noakes 提交于
-