Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
8fa41dea
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
8fa41dea
编写于
1月 10, 2019
作者:
J
Julien Couvreur
提交者:
GitHub
1月 10, 2019
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Recommend keyword static for static local functions (#32187)
上级
f74016a7
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
36 addition
and
6 deletion
+36
-6
src/EditorFeatures/CSharpTest2/Recommendations/RecommenderTests.cs
...rFeatures/CSharpTest2/Recommendations/RecommenderTests.cs
+1
-1
src/EditorFeatures/CSharpTest2/Recommendations/StaticKeywordRecommenderTests.cs
...arpTest2/Recommendations/StaticKeywordRecommenderTests.cs
+34
-5
src/Features/CSharp/Portable/Completion/KeywordRecommenders/StaticKeywordRecommender.cs
...ompletion/KeywordRecommenders/StaticKeywordRecommender.cs
+1
-0
未找到文件。
src/EditorFeatures/CSharpTest2/Recommendations/RecommenderTests.cs
浏览文件 @
8fa41dea
...
...
@@ -81,7 +81,7 @@ private async Task CheckResultAsync(bool absent, int position, CSharpSyntaxConte
}
else
{
var
result
=
(
await
RecommendKeywordsAsync
(
position
,
context
)).
Single
();
var
result
=
(
await
RecommendKeywordsAsync
(
position
,
context
)).
Single
OrDefault
();
Assert
.
True
(
result
!=
null
,
"No recommended keywords"
);
Assert
.
Equal
(
keywordText
,
result
.
Keyword
);
if
(
matchPriority
!=
null
)
...
...
src/EditorFeatures/CSharpTest2/Recommendations/StaticKeywordRecommenderTests.cs
浏览文件 @
8fa41dea
...
...
@@ -48,9 +48,10 @@ public async Task TestNotInUsingAlias()
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
KeywordRecommending
)]
public
async
Task
TestNotInEmptyStatement
()
[
WorkItem
(
32174
,
"https://github.com/dotnet/roslyn/issues/32174"
)]
public
async
Task
TestInEmptyStatement
()
{
await
Verify
Absence
Async
(
AddInsideMethod
(
await
Verify
Keyword
Async
(
AddInsideMethod
(
@"$$"
));
}
...
...
@@ -276,12 +277,17 @@ public async Task TestNotAfterDelegate()
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
KeywordRecommending
)]
[
WorkItem
(
32214
,
"https://github.com/dotnet/roslyn/issues/32214"
)]
public
async
Task
TestNotBetweenUsings
()
{
await
VerifyAbsenceAsync
(
AddInsideMethod
(
@"using Goo;
var
source
=
@"using Goo;
$$
using Bar;"
));
using Bar;"
;
await
VerifyWorkerAsync
(
source
,
absent
:
true
);
// Recommendation in scripting is not stable. See https://github.com/dotnet/roslyn/issues/32214
//await VerifyWorkerAsync(source, absent: true, Options.Script);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
KeywordRecommending
)]
...
...
@@ -343,5 +349,28 @@ public async Task TestNotAfterUsingInMethodBody()
void M() {
using $$"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
KeywordRecommending
)]
[
WorkItem
(
32174
,
"https://github.com/dotnet/roslyn/issues/32174"
)]
public
async
Task
TestLocalFunction
()
{
await
VerifyKeywordAsync
(
AddInsideMethod
(
@" $$ void local() { }"
));
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
KeywordRecommending
)]
public
async
Task
TestInCase
()
{
await
VerifyKeywordAsync
(
AddInsideMethod
(
@"
switch (i)
{
case 0:
$$"
));
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
KeywordRecommending
)]
public
async
Task
TestInFor
()
{
await
VerifyAbsenceAsync
(
AddInsideMethod
(
@" for (int i = 0; i < 0; $$) "
));
}
}
}
src/Features/CSharp/Portable/Completion/KeywordRecommenders/StaticKeywordRecommender.cs
浏览文件 @
8fa41dea
...
...
@@ -55,6 +55,7 @@ protected override bool IsValidContext(int position, CSharpSyntaxContext context
return
context
.
IsGlobalStatementContext
||
context
.
TargetToken
.
IsUsingKeywordInUsingDirective
()
||
context
.
IsStatementContext
||
IsValidContextForType
(
context
,
cancellationToken
)
||
IsValidContextForMember
(
context
,
cancellationToken
);
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录