(Bug #774305) (changeset 1310427)

Convert short-lived synthesized local variables defined in bound sequences to long-lived spill variables during stack spilling.
The goal is to establish an invariant that short-lived synthesized locals are not hoisted to state machine fields.

In addition, synthesized local variables now capture the source file and line where they were created in debug builds, so that it's easier to track them thru bound tree rewriting. (changeset 1310349)

Switch the command line compilers to use the newly implemented event queue based AnalyzerDriver for executing diagnostic analyzers. This change primarily (a) Fixes AnalyzerDriver.AnalyzeDeclaringReference to correctly compute the syntax nodes to be analyzed by syntax and code block analyzers (b) Port all unit tests to use the new driver (c) Delete the current AnalyzerDriver. (changeset 1308719)

Refactor ObjectDisplay.FormatPrimitive boolean parameters into an options enum and add support for displaying Type suffix characters after numeric values that may optionally include them.
***NO_CI***
 (changeset 1307280)

     Example:
         static void Test<T>(T[] x) where T : IDisposable
         {
             x[0]?.Dispose();
         }

     note that T is not necessarily a class here!!
     The tricky part of this change is to make sure that sideeffects from the call are applied to the receiver. I.E. in the struct case we must not perform the call on a copy of the receiver.
     We should not be Disposing a copy in the example.

Also fixes #184 - null propagating operators should not be allowed in expression trees.
 (changeset 1310269)

Fix for bug 908658: DiagnosticAnalyzerDriver calls OnCodeBlockStarted/Ended on more Syntax/MethodKinds than AnalyzerDriver does

Ensure that the IDE and compiler analyzer driver execute code block analyzers for identical symbol kinds. (changeset 1310061)

The completion list should show instance members inside of static members when in a nameof expression (changeset 1310030)

PERF: Remove allocations coming from a string.Split call in VB's OptionsValidator.IsValidNamespaceName (changeset 1309815)

Disallow string literals in #pragma warnings directives and allow identifiers instead. Also stop validating warning ids supplied in #pragma warning directives. These were both decisions that were made at a design meeting a few weeks back. The corresponding VB changes (for #Disable) have already been implemented - this change implementss the same for C#.

Note: Parsing / lexing of identifiers inside #pragma warning directives is identical to that inside #define directives except for the following difference. Inside #define, very long identifiers are truncated to 128 characters to maintain backwards compatibility with previous versions of the compiler (Dev12-). Since support for identifiers inside #pragma warning directivess is new, we don't have any backwards compatibility constraints for this. So we preserve the identifier exactly as it appears in source. (changeset 1309687)

A new approach that replaces changesets #1306929 and #1306961.  Instead of forcing a new concept into the binder-proper, just accept that some symbols in the EE (specifically, lambdas, range variables, and labels) will have "incorrect" containing symbols in EE scenarios.  There do not seem to be any negative consequences to the "incorrectness".

Clean up the EE binders now that the new concept has been eliminated.

CR: chucks; ngafter (changeset 1309568)

Add an additional test for bug fix 914236. Shyam pointed out that this scenario did not work prior to the fix for this bug. (changeset 1309536)

A small enhancement to formatting accessor declarations inside Auto properties. We now format the whole accessor list, on semicolon after an accessor declaration, as long as the declaration is complete is in a single line. (changeset 1309519)

Fix for bug 914236: ISyntaxNodeAnalyzer.AnalyzerNode is never invoked in command line compiler, unless the syntax nodes of interest are within executable code blocks

Ensure that we execute syntax node analysis for global nodes which are not under any declarations (usings, assembly attributes, preprocessor statements, etc.) (changeset 1309366)

When a project is renamed, we need to fetch updated display names and file paths for it. We leave the project ID as is, with the debug path which is still the old string, since we have no good way to change that.

If this change works, DustinCa should get the credit since he wrote most of this. (changeset 1309226)

now cache size can be changed and dynamically configured if we want. (changeset 1308740)

Switch the command line compilers to use the newly implemented event queue based AnalyzerDriver for executing diagnostic analyzers. This change primarily (a) Fixes AnalyzerDriver.AnalyzeDeclaringReference to correctly compute the syntax nodes to be analyzed by syntax and code block analyzers (b) Port all unit tests to use the new driver (c) Delete the current AnalyzerDriver. (changeset 1308719)

CR: angocke; chucks (changeset 1308662)

When a property is generated inside an internal type but it's return type is protected, we were generating a public property which leads to inconsistent accessibility. While computing minimum accessibility, we were treating internal as more restrictive than protected which is not how the compiler sees it. I've changed it to this order of most restrictive to least restricitve : private > protectedandinternal > protected > internal > protectedorinternal > public. I've tests the matrix of combinartions and they all seem to produce compilable code now.  (changeset 1308601)

The changes needed to MSBuild to plumb through the additional files introduces a new method to the IAnalyzerHostObject interface in MSBuild. We implement that interface on the Roslyn side for our MSBuildWorkspace scenarios. I can only implement the new interface method after we update the base drop to include this method. I'm removing the interface implementation from Roslyn - this means that analyzers won't be understood from project files in MSBuildWorkspace scenarios but VS and command line builds will work fine. Once we update the base drop, I'll reenable this. (changeset 1307743)

The new native client is written in C++11 to be more maintainable and forward-looking. The native client is a static library, which is now linked into the csc2 and vbc2 projects instead of having a single csc2.cpp file which is shared between the two projects and built for each based on a preprocessor definition.

The MSBuildTask is also configured to use csc2/vbc2 and feature no extra code for Roslyn, which will prevent us from having to maintain both a native and a managed version of the client. (changeset 1307711)

CR feedback, mostly unifying the code for C# and VB
 (changeset 1307676)

Bug Fix 995986: show aliases for types and namespaces after Implements and Inherits clauses (changeset 1307367)

Rename the .Description properties on DiagnosticDescriptor and CodeAction to .Title. This makes it clearer that the supplied text should be a short description as opposed to a long one + this will also allow us to introduce new properties named Description for long descriptions in subsequent changes. (changeset 1306932)

Added virtual members to Binder to reduce dependencies on containing type/member when binding "this" and "base"
(new members: ThisType, IsScriptClass, and IsInstanceMemberContext) and changed LookupSymbolsInSingleBinder from protected to internal. (changeset 1306929)

any diagnostic with that custom tag will be used in VS to collect telemetry information around the diagnostic usages in VS. (changeset 1305633)

As in VB, explicitly generate the body of the constructor synthesized for the special TypeVariables type (the old code path generated an incomplete body and cluttered MethodCompiler). (changeset 1305212)