The changes needed to MSBuild to plumb through the additional files introduces...

The changes needed to MSBuild to plumb through the additional files introduces a new method to the IAnalyzerHostObject interface in MSBuild. We implement that interface on the Roslyn side for our MSBuildWorkspace scenarios. I can only implement the new interface method after we update the base drop to include this method. I'm removing the interface implementation from Roslyn - this means that analyzers won't be understood from project files in MSBuildWorkspace scenarios but VS and command line builds will work fine. Once we update the base drop, I'll reenable this. (changeset 1307743)

Src/Workspaces/CSharp/MSBuild/CSharpProjectFileLoader.CSharpProjectFile.cs

@@ -254,7 +254,9 @@ private void InitializeFromModel(CSharpCompilerInputs compilerInputs, MSB.Execut
 
             private class CSharpCompilerInputs :
 #if !MSBUILD12
-                MSB.Tasks.Hosting.ICscHostObject4, MSB.Tasks.Hosting.IAnalyzerHostObject
+                MSB.Tasks.Hosting.ICscHostObject4
+            //// ' TODO : Remove this after the next base drop update (once we get a new IAnalyzerHostObject interface)
+            //// , MSB.Tasks.Hosting.IAnalyzerHostObject
 #else
                 MSB.Tasks.Hosting.ICscHostObject4
 #endif

Src/Workspaces/CoreTest/WorkspaceTests/MSBuildWorkspaceTests.cs

@@ -1802,7 +1802,7 @@ public void TestOpenProject_LoadMetadataForReferenceProjects_NoMetadata()
         }
 
         [WorkItem(918072, "DevDiv")]
-        [Fact, Trait(Traits.Feature, Traits.Features.Workspace)]
+        [Fact(Skip = "996321"), Trait(Traits.Feature, Traits.Features.Workspace)]
         public void TestAnalyzerReferenceLoadStandalone()
         {
 #if !MSBUILD12

Src/Workspaces/VisualBasic/MSBuild/VisualBasicProjectFileLoader.vb

@@ -253,7 +253,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
             Private Class VisualBasicCompilerInputs
                 Implements MSB.Tasks.Hosting.IVbcHostObject5, MSB.Tasks.Hosting.IVbcHostObjectFreeThreaded
 #If Not MSBUILD12 Then
-                Implements MSB.Tasks.Hosting.IAnalyzerHostObject
+                ' TODO : Remove this after the next base drop update (once we get a new IAnalyzerHostObject interface)
+                ' Implements MSB.Tasks.Hosting.IAnalyzerHostObject
 #End If
                 Private _projectFile As VisualBasicProjectFile
                 Private _initialized As Boolean
@@ -583,7 +584,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
                 End Function
 
 #If Not MSBUILD12 Then
-                Public Function SetAnalyzers(analyzerReferences() As MSB.Framework.ITaskItem) As Boolean Implements MSB.Tasks.Hosting.IAnalyzerHostObject.SetAnalyzers
+                Public Function SetAnalyzers(analyzerReferences() As MSB.Framework.ITaskItem) As Boolean ' Implements MSB.Tasks.Hosting.IAnalyzerHostObject.SetAnalyzers
 #Else
                 Public Function SetAnalyzers(analyzerReferences() As MSB.Framework.ITaskItem) As Boolean
 #End If
@@ -643,7 +644,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
                 End Function
 
 #If Not MSBUILD12 Then
-                Public Function SetRuleSet(ruleSetFile As String) As Boolean Implements MSB.Tasks.Hosting.IAnalyzerHostObject.SetRuleSet
+                Public Function SetRuleSet(ruleSetFile As String) As Boolean ' Implements MSB.Tasks.Hosting.IAnalyzerHostObject.SetRuleSet
 #Else
                 Public Function SetRuleSet(ruleSetFile As String) As Boolean
 #End If