1. 15 3月, 2019 3 次提交
    • H
      added partial load mode feature flag and made extract method to handle partial load mode. (#33779) · 15599ef8
      Heejae Chang 提交于
      * added partial load mode feature flag and made extract method to handle partial load mode.
      
      when solution is opened in VS, currently we do not know when exactly solution is fully loaded or not. solution explorer might show all files but design time build might not have finished yet so, any semantic operation such as extract method or rename might do wrong thing since it doesn't know that it is dealing with missing information (solution).
      
      we are trying to address this issue with partial load mode, new API platform is working on. basically, we are planning to block most of semantic operations (except completion/quickinfo/goto definition/signature help and navigate to. we might include FAR here as well) during partial load state.
      
      also, for things like squiggle, LB and etc, we will disable those until solution is fully loaded since we don't actually know whether those data is correct or not during partial load state.
      
      this change add featureflag so that we can incrementally add support for each features while dogfooding behavior across partners. as a first attempt, extract method is choosen for new experience.
      
      other internal options are added so that we can try alternative behaviors and etc.
      
      test is not added yet.
      
      * fix merge break
      
      * update string
      
      * small tweak.
      
      * PR feedbacks
      
      * updated the title
      
      * updated after discussing about PR
      
      * do even cheaper version of getting text.
      
      addscope doesn't work with description with blank line when scope is nested. wait dialog seems supporting only 2 lines.
      
      until, I figure out this with platform team, making description one line.
      
      * following PR feedback
      15599ef8
    • N
      Simplify some names in the nullable reference types feature (#33976) · a3f6f8e1
      Neal Gafter 提交于
      * Simplify some names in the nullable reference types feature
      - Rename `TypeSymbolWithAnnotations` to `TypeWithAnnotations`
      - Rename its type field from `TypeSymbol` to `Type`
      - Fields of Symbols that are of type `TypeWithAnnotations` that are currently named `Type` would be renamed `TypeWithAnnotations`
      Fixes #33736
      
      * Further updates
      
      * Fix formatting
      
      * Add `Type` property in addition to `TypeWithAnnotations`
      e.g. `ReturnType`, `ElementType`, etc.
      
      * Post-merge fixup.
      a3f6f8e1
    • C
      Report nullability for attribute arguments: (#33816) · 32c9dc06
      Chris Sienkiewicz 提交于
      * Report nullability for attribute arguments:
      - Add an entry point to nullable walker for attribute analysis
      - Implement analyze attribute in the walker
      - Update MethodThisParameter to not throw
      - Add extra fields to BoundAttribute that are needed for nullable analysis
      - Add tests
      
      
      
      * PR Feedback:
      - Analyse attributes even when we don't bind a constructor
      
      - Add tests for when we don't bind constructor but still want to analyze what we have
      
      * PR Feedback:
      - fix typos
      - make no matching constructors use implicit constructors
      
      * Replace tabs with spaces
      
      * Fix failing test
      32c9dc06
  2. 14 3月, 2019 26 次提交
  3. 13 3月, 2019 11 次提交