PR Feedback

src/Compilers/CSharp/Portable/FlowAnalysis/NullableWalker.cs

@@ -295,7 +295,7 @@ protected override ImmutableArray<PendingBranch> Scan(ref bool badRegion)
         {
             if (compilation.LanguageVersion < MessageID.IDS_FeatureNullableReferenceTypes.RequiredVersion() ||
                 attribute.Constructor is null ||
-                !compilation.SyntaxTrees.Contains(attribute.SyntaxTree))
+                !compilation.SyntaxTrees.Contains(attribute.SyntaxTree)) // don't analyze speculative attributes
             {
                 return;
             }

src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs

@@ -4755,7 +4755,7 @@ class E { }
                 //     public MyAttribute(string s, string s2 = null) { } //1
                 Diagnostic(ErrorCode.WRN_NullAsNonNullable, "null").WithLocation(4, 46),
                 // (10,21): warning CS8625: Cannot convert null literal to non-nullable reference or unconstrained type parameter.
-                // [MyAttribute("str", null)] // 3
+                // [MyAttribute("str", null)] // 2
                 Diagnostic(ErrorCode.WRN_NullAsNonNullable, "null").WithLocation(10, 21)
                 );
         }