1. 09 2月, 2019 1 次提交
  2. 07 2月, 2019 2 次提交
  3. 06 2月, 2019 3 次提交
  4. 05 2月, 2019 5 次提交
  5. 02 2月, 2019 1 次提交
    • H
      don't retain fault result in task center if nuget info download failed. · b50dbcad
      HeeJae Chang 提交于
      to retain fault result in task center, we need to provide detail info UI so that user can click the fault task left in the task center, but right now we don't have one and we don't want to just show exception message in message box.
      
      we could think of using RetainAndNotifyFault so that we show exception message in the task center tip, but that would be annoying since most likely it is info user didn't ask for it.
      
      we can add UI later if user ever ask for it. for now, taking simple approach of just removing it from task center once download is done in any way (success, cancelled, failed)
      b50dbcad
  6. 01 2月, 2019 1 次提交
  7. 31 1月, 2019 2 次提交
  8. 30 1月, 2019 4 次提交
  9. 25 1月, 2019 2 次提交
  10. 24 1月, 2019 3 次提交
  11. 23 1月, 2019 4 次提交
  12. 19 1月, 2019 7 次提交
    • J
      Don't crash if we can't fetch the IVsOutputWindow · 107298ed
      Jason Malinowski 提交于
      We potentially run the creation of the output window pane during the
      shutdown of Visual Studio. This can happen because we're using
      InvokeBelowInputPriorityAsync, which queues the switch to the UI thread
      using IThreadingContext.JoinableTaskFactory.SwitchToMainThreadAsync().
      This resulting continuation can run during package shutdown when
      services are no longer available.
      
      Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/744155
      107298ed
    • J
      Fix bug where references didn't always have a file watcher · 441d055d
      Jason Malinowski 提交于
      When we created metadata references inside of VisualStudioProject,
      we ensured we created them with a file watcher so we would know about
      changes. When we created a metadata reference after we converted a
      project reference back to a metadata reference that was originally
      a metadata reference, we didn't do so since that conversion happens
      in VisualStudioWorkspaceImpl itself and it couldn't access the file
      watcher.
      
      This fixes this. The majority of the work here is just moving code
      around. Basically the watchers were per-project, which meant that
      it'd be forbidden to call into them the Workspace code because
      that would violate the lock hierarchy. To fix this, I move the file
      watching logic into it's own little type with a lock, and since no
      calls are made back into the workspace under that lock, it removes
      the deadlock concerns.
      
      Fixes dotnet/roslyn#32554.
      441d055d
    • T
      b03098e2
    • J
      Ensure we react to metadata reference adds and deletes too · c4bfc46c
      Jason Malinowski 提交于
      FileChangeWatcher wasn't specifying all the file watcher flags it should
      have been. Reuse the constant that already existed for FileChangeTracker
      so we get the same behavior.
      
      FileChangeTracker is eventually going to be retired, and so I'm moving
      over the constant to the long-term home.
      c4bfc46c
    • J
      Remove obsolete comment · 4608cb1f
      Jason Malinowski 提交于
      This is referencing a method that has long since been deleted.
      4608cb1f
    • J
      Delete VisualStudioMetadataReference, which was now an empty type · 73f1152e
      Jason Malinowski 提交于
      The actual work was a nested type called .Snapshot, which everything
      was using directly. The renames in here are:
      
      - VisualStudioMetadataReference.Snapshot to
        VisualStudioPortableExecutableReference
      - The _provider field in .Snapshot to _referenceManager
      - VisualStudioMetadataReferenceManager.CreateMetadataReferenceSnapshot
        to just .CreateMetadataReference, since it's always a snapshot.
      73f1152e
    • J
      Cleanup the fetching of IVsFileChangeEx for the FileChangeWatcherProvider · 67f30ecd
      Jason Malinowski 提交于
      The FileChangeWatcherProvider has to do some magic so we can hand
      out a FileChangeWatcher that fetches the IVsFileChangeEx from the shell,
      but not in a way that implicitly risks any marshal back to the UI thread
      in a way that might deadlock. The odd bit was we were doing some of
      that initialization in the VisualStudioWorkspace constructor itself
      which didn't really make sense.
      
      While I'm here, we can also remove the hack that was working around
      a shell bug where we might deadlock if we called into the async service
      provider from a background thread.
      67f30ecd
  13. 18 1月, 2019 2 次提交
  14. 17 1月, 2019 1 次提交
  15. 16 1月, 2019 1 次提交
  16. 15 1月, 2019 1 次提交