Merge pull request #19676 from sharwell/parse-none-silent

Allow 'none' to be the severity for options in .editorconfig

src/Workspaces/Core/Portable/CodeStyle/CodeStyleHelpers.cs

@@ -81,7 +81,11 @@ public static bool TryParseNotification(string value, out NotificationOption not
         {
             switch (value.Trim())
             {
-                case EditorConfigSeverityStrings.Silent: notification = NotificationOption.None; return true;
+                case EditorConfigSeverityStrings.None:
+                case EditorConfigSeverityStrings.Silent:
+                    notification = NotificationOption.None;
+                    return true;
+
                 case EditorConfigSeverityStrings.Suggestion: notification = NotificationOption.Suggestion; return true;
                 case EditorConfigSeverityStrings.Warning: notification = NotificationOption.Warning; return true;
                 case EditorConfigSeverityStrings.Error: notification = NotificationOption.Error; return true;

src/Workspaces/Core/Portable/NamingStyles/EditorConfig/EditorConfigNamingStyleParser_NamingRule.cs

@@ -49,7 +49,10 @@ private static DiagnosticSeverity ParseEnforcementLevel(string ruleSeverity)
         {
             switch (ruleSeverity)
             {
-                case EditorConfigSeverityStrings.Silent: return DiagnosticSeverity.Hidden;
+                case EditorConfigSeverityStrings.None:
+                case EditorConfigSeverityStrings.Silent:
+                    return DiagnosticSeverity.Hidden;
+
                 case EditorConfigSeverityStrings.Suggestion: return DiagnosticSeverity.Info;
                 case EditorConfigSeverityStrings.Warning: return DiagnosticSeverity.Warning;
                 case EditorConfigSeverityStrings.Error: return DiagnosticSeverity.Error;

src/Workspaces/Core/Portable/NamingStyles/EditorConfig/EditorConfigSeverityStrings.cs

@@ -4,6 +4,7 @@ namespace Microsoft.CodeAnalysis
 {
     internal static class EditorConfigSeverityStrings
     {
+        public const string None = "none";
         public const string Silent = "silent";
         public const string Suggestion = "suggestion";
         public const string Warning = "warning";

src/Workspaces/CoreTest/CodeStyle/EditorConfigCodeStyleParserTests.cs

@@ -11,11 +11,13 @@ namespace Microsoft.CodeAnalysis.UnitTests.CodeStyle
     public class EditorConfigCodeStyleParserTests
     {
         [Theory]
+        [InlineData("true:none", true, DiagnosticSeverity.Hidden)]
         [InlineData("true:silent", true, DiagnosticSeverity.Hidden)]
         [InlineData("true:suggestion", true, DiagnosticSeverity.Info)]
         [InlineData("true:warning", true, DiagnosticSeverity.Warning)]
         [InlineData("true:error", true, DiagnosticSeverity.Error)]
         [InlineData("true", false, DiagnosticSeverity.Hidden)]
+        [InlineData("false:none", false, DiagnosticSeverity.Hidden)]
         [InlineData("false:silent", false, DiagnosticSeverity.Hidden)]
         [InlineData("false:suggestion", false, DiagnosticSeverity.Info)]
         [InlineData("false:warning", false, DiagnosticSeverity.Warning)]