diff --git a/src/Workspaces/Core/Portable/CodeStyle/CodeStyleHelpers.cs b/src/Workspaces/Core/Portable/CodeStyle/CodeStyleHelpers.cs index ab704b0ab91b1419ab9f6b8917bf9b2a7f179132..fbec6da81806dba31c82f32024162980745b5c8f 100644 --- a/src/Workspaces/Core/Portable/CodeStyle/CodeStyleHelpers.cs +++ b/src/Workspaces/Core/Portable/CodeStyle/CodeStyleHelpers.cs @@ -81,7 +81,11 @@ public static bool TryParseNotification(string value, out NotificationOption not { switch (value.Trim()) { - case EditorConfigSeverityStrings.Silent: notification = NotificationOption.None; return true; + case EditorConfigSeverityStrings.None: + case EditorConfigSeverityStrings.Silent: + notification = NotificationOption.None; + return true; + case EditorConfigSeverityStrings.Suggestion: notification = NotificationOption.Suggestion; return true; case EditorConfigSeverityStrings.Warning: notification = NotificationOption.Warning; return true; case EditorConfigSeverityStrings.Error: notification = NotificationOption.Error; return true; diff --git a/src/Workspaces/Core/Portable/NamingStyles/EditorConfig/EditorConfigNamingStyleParser_NamingRule.cs b/src/Workspaces/Core/Portable/NamingStyles/EditorConfig/EditorConfigNamingStyleParser_NamingRule.cs index 4381a85f246de911a11dc94e9d24d19ac934afed..3ccb2814557a99ee13880e04859583b515cc3bf5 100644 --- a/src/Workspaces/Core/Portable/NamingStyles/EditorConfig/EditorConfigNamingStyleParser_NamingRule.cs +++ b/src/Workspaces/Core/Portable/NamingStyles/EditorConfig/EditorConfigNamingStyleParser_NamingRule.cs @@ -49,7 +49,10 @@ private static DiagnosticSeverity ParseEnforcementLevel(string ruleSeverity) { switch (ruleSeverity) { - case EditorConfigSeverityStrings.Silent: return DiagnosticSeverity.Hidden; + case EditorConfigSeverityStrings.None: + case EditorConfigSeverityStrings.Silent: + return DiagnosticSeverity.Hidden; + case EditorConfigSeverityStrings.Suggestion: return DiagnosticSeverity.Info; case EditorConfigSeverityStrings.Warning: return DiagnosticSeverity.Warning; case EditorConfigSeverityStrings.Error: return DiagnosticSeverity.Error; diff --git a/src/Workspaces/Core/Portable/NamingStyles/EditorConfig/EditorConfigSeverityStrings.cs b/src/Workspaces/Core/Portable/NamingStyles/EditorConfig/EditorConfigSeverityStrings.cs index 2349bd5985633aec6466ab363bd10619784d9596..8dc1d15dd0c96cbdd493b55de939eae6f866fa5f 100644 --- a/src/Workspaces/Core/Portable/NamingStyles/EditorConfig/EditorConfigSeverityStrings.cs +++ b/src/Workspaces/Core/Portable/NamingStyles/EditorConfig/EditorConfigSeverityStrings.cs @@ -4,6 +4,7 @@ namespace Microsoft.CodeAnalysis { internal static class EditorConfigSeverityStrings { + public const string None = "none"; public const string Silent = "silent"; public const string Suggestion = "suggestion"; public const string Warning = "warning"; diff --git a/src/Workspaces/CoreTest/CodeStyle/EditorConfigCodeStyleParserTests.cs b/src/Workspaces/CoreTest/CodeStyle/EditorConfigCodeStyleParserTests.cs index 19114c2abecac96110e3857535d3280ca26769fc..e1866b2d2c34f850856ad9bb86cdde6822f79315 100644 --- a/src/Workspaces/CoreTest/CodeStyle/EditorConfigCodeStyleParserTests.cs +++ b/src/Workspaces/CoreTest/CodeStyle/EditorConfigCodeStyleParserTests.cs @@ -11,11 +11,13 @@ namespace Microsoft.CodeAnalysis.UnitTests.CodeStyle public class EditorConfigCodeStyleParserTests { [Theory] + [InlineData("true:none", true, DiagnosticSeverity.Hidden)] [InlineData("true:silent", true, DiagnosticSeverity.Hidden)] [InlineData("true:suggestion", true, DiagnosticSeverity.Info)] [InlineData("true:warning", true, DiagnosticSeverity.Warning)] [InlineData("true:error", true, DiagnosticSeverity.Error)] [InlineData("true", false, DiagnosticSeverity.Hidden)] + [InlineData("false:none", false, DiagnosticSeverity.Hidden)] [InlineData("false:silent", false, DiagnosticSeverity.Hidden)] [InlineData("false:suggestion", false, DiagnosticSeverity.Info)] [InlineData("false:warning", false, DiagnosticSeverity.Warning)]