Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
65092b44
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
65092b44
编写于
9月 29, 2020
作者:
B
Brian Freeman
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
update to include comment on both get and set routine
上级
cbd1d12c
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
41 addition
and
5 deletion
+41
-5
src/EditorFeatures/CSharpTest/CodeActions/ReplaceMethodWithProperty/ReplaceMethodWithPropertyTests.cs
...placeMethodWithProperty/ReplaceMethodWithPropertyTests.cs
+32
-1
src/Features/Core/Portable/ReplaceMethodWithProperty/AbstractReplaceMethodWithPropertyService.cs
...dWithProperty/AbstractReplaceMethodWithPropertyService.cs
+9
-4
未找到文件。
src/EditorFeatures/CSharpTest/CodeActions/ReplaceMethodWithProperty/ReplaceMethodWithPropertyTests.cs
浏览文件 @
65092b44
...
...
@@ -2361,7 +2361,7 @@ int Goo1
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsReplaceMethodWithProperty
)]
[
WorkItem
(
42698
,
"https://github.com/dotnet/roslyn/issues/42698"
)]
public
async
Task
Test
RefactorRetainsComments
()
public
async
Task
Test
MethodWithTrivia_3
()
{
await
TestInRegularAndScript1Async
(
@"class C
...
...
@@ -2376,6 +2376,37 @@ public async Task TestRefactorRetainsComments()
//Vital Comment
int FooBar => 1;
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsReplaceMethodWithProperty
)]
[
WorkItem
(
42698
,
"https://github.com/dotnet/roslyn/issues/42698"
)]
public
async
Task
TestMethodWithTrivia_4
()
{
await
TestWithAllCodeStyleOff
(
@"class C
{
int [||]GetGoo() // Goo
{
}
void SetGoo(int i) // SetGoo
{
}
}"
,
@"class C
{
// Goo
// SetGoo
int Goo
{
get
{
}
set
{
}
}
}"
,
index
:
1
);
}
private
async
Task
TestWithAllCodeStyleOff
(
string
initialMarkup
,
string
expectedMarkup
,
...
...
src/Features/Core/Portable/ReplaceMethodWithProperty/AbstractReplaceMethodWithPropertyService.cs
浏览文件 @
65092b44
...
...
@@ -49,12 +49,13 @@ private static bool OverridesMetadataSymbol(IMethodSymbol method)
var
setMethodDeclaration
=
getAndSetMethods
.
SetMethodDeclaration
;
var
finalLeadingTrivia
=
getAndSetMethods
.
GetMethodDeclaration
.
GetLeadingTrivia
().
ToList
();
if
(
getMethodDeclaration
.
ChildNodes
().
Any
(
n
=>
n
.
RawKind
==
syntaxFacts
.
SyntaxKinds
.
ParameterList
&&
n
.
GetTrailingTrivia
().
Any
(
t
=>
!
syntaxFacts
.
IsWhitespaceOrEndOfLineTrivia
(
t
))))
{
finalLeadingTrivia
.
AddRange
(
getMethodDeclaration
.
ChildNodes
().
Where
(
n
=>
n
.
RawKind
==
syntaxFacts
.
SyntaxKinds
.
ParameterList
).
First
().
GetTrailingTrivia
());
}
if
(
setMethodDeclaration
==
null
)
{
if
(
getMethodDeclaration
.
ChildNodes
().
Any
(
n
=>
n
.
RawKind
==
syntaxFacts
.
SyntaxKinds
.
ParameterList
&&
n
.
GetTrailingTrivia
().
Any
(
t
=>
!
syntaxFacts
.
IsWhitespaceOrEndOfLineTrivia
(
t
))))
{
finalLeadingTrivia
.
AddRange
(
getMethodDeclaration
.
ChildNodes
().
Where
(
n
=>
n
.
RawKind
==
syntaxFacts
.
SyntaxKinds
.
ParameterList
).
First
().
GetTrailingTrivia
());
}
return
property
.
WithLeadingTrivia
(
finalLeadingTrivia
);
}
...
...
@@ -62,6 +63,10 @@ private static bool OverridesMetadataSymbol(IMethodSymbol method)
setMethodDeclaration
.
GetLeadingTrivia
()
.
SkipWhile
(
t
=>
syntaxFacts
.
IsEndOfLineTrivia
(
t
))
.
Where
(
t
=>
!
t
.
IsDirective
));
if
(
setMethodDeclaration
.
ChildNodes
().
Any
(
n
=>
n
.
RawKind
==
syntaxFacts
.
SyntaxKinds
.
ParameterList
&&
n
.
GetTrailingTrivia
().
Any
(
t
=>
!
syntaxFacts
.
IsWhitespaceOrEndOfLineTrivia
(
t
))))
{
finalLeadingTrivia
.
AddRange
(
setMethodDeclaration
.
ChildNodes
().
Where
(
n
=>
n
.
RawKind
==
syntaxFacts
.
SyntaxKinds
.
ParameterList
).
First
().
GetTrailingTrivia
());
}
return
property
.
WithLeadingTrivia
(
finalLeadingTrivia
);
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录