Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
cbd1d12c
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
cbd1d12c
编写于
9月 29, 2020
作者:
B
Brian Freeman
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Initial Fix retain in line comment
上级
050d32d8
变更
5
隐藏空白更改
内联
并排
Showing
5 changed file
with
28 addition
and
7 deletion
+28
-7
src/EditorFeatures/CSharpTest/CodeActions/ReplaceMethodWithProperty/ReplaceMethodWithPropertyTests.cs
...placeMethodWithProperty/ReplaceMethodWithPropertyTests.cs
+18
-1
src/Features/Core/Portable/ReplaceMethodWithProperty/AbstractReplaceMethodWithPropertyService.cs
...dWithProperty/AbstractReplaceMethodWithPropertyService.cs
+7
-3
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Services/SyntaxFacts/CSharpSyntaxKinds.cs
...Compiler/CSharp/Services/SyntaxFacts/CSharpSyntaxKinds.cs
+1
-1
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Services/SyntaxFacts/ISyntaxKinds.cs
...nsions/Compiler/Core/Services/SyntaxFacts/ISyntaxKinds.cs
+1
-1
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/VisualBasic/Services/SyntaxFacts/VisualBasicSyntaxKinds.vb
...isualBasic/Services/SyntaxFacts/VisualBasicSyntaxKinds.vb
+1
-1
未找到文件。
src/EditorFeatures/CSharpTest/CodeActions/ReplaceMethodWithProperty/ReplaceMethodWithPropertyTests.cs
浏览文件 @
cbd1d12c
...
...
@@ -2359,7 +2359,24 @@ int Goo1
}
}"
);
}
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsReplaceMethodWithProperty
)]
[
WorkItem
(
42698
,
"https://github.com/dotnet/roslyn/issues/42698"
)]
public
async
Task
TestRefactorRetainsComments
()
{
await
TestInRegularAndScript1Async
(
@"class C
{
[||]int FooBar() //Vital Comment
{
return 1;
}
}"
,
@"class C
{
//Vital Comment
int FooBar => 1;
}"
);
}
private
async
Task
TestWithAllCodeStyleOff
(
string
initialMarkup
,
string
expectedMarkup
,
ParseOptions
parseOptions
=
null
,
int
index
=
0
)
...
...
src/Features/Core/Portable/ReplaceMethodWithProperty/AbstractReplaceMethodWithPropertyService.cs
浏览文件 @
cbd1d12c
...
...
@@ -47,13 +47,17 @@ private static bool OverridesMetadataSymbol(IMethodSymbol method)
{
var
getMethodDeclaration
=
getAndSetMethods
.
GetMethodDeclaration
;
var
setMethodDeclaration
=
getAndSetMethods
.
SetMethodDeclaration
;
var
finalLeadingTrivia
=
getAndSetMethods
.
GetMethodDeclaration
.
GetLeadingTrivia
().
ToList
();
if
(
setMethodDeclaration
==
null
)
{
return
property
.
WithLeadingTrivia
(
getMethodDeclaration
.
GetLeadingTrivia
());
if
(
getMethodDeclaration
.
ChildNodes
().
Any
(
n
=>
n
.
RawKind
==
syntaxFacts
.
SyntaxKinds
.
ParameterList
&&
n
.
GetTrailingTrivia
().
Any
(
t
=>
!
syntaxFacts
.
IsWhitespaceOrEndOfLineTrivia
(
t
))))
{
finalLeadingTrivia
.
AddRange
(
getMethodDeclaration
.
ChildNodes
().
Where
(
n
=>
n
.
RawKind
==
syntaxFacts
.
SyntaxKinds
.
ParameterList
).
First
().
GetTrailingTrivia
());
}
return
property
.
WithLeadingTrivia
(
finalLeadingTrivia
);
}
var
finalLeadingTrivia
=
getAndSetMethods
.
GetMethodDeclaration
.
GetLeadingTrivia
().
ToList
();
finalLeadingTrivia
.
AddRange
(
setMethodDeclaration
.
GetLeadingTrivia
()
.
SkipWhile
(
t
=>
syntaxFacts
.
IsEndOfLineTrivia
(
t
))
...
...
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Services/SyntaxFacts/CSharpSyntaxKinds.cs
浏览文件 @
cbd1d12c
...
...
@@ -87,7 +87,7 @@ protected CSharpSyntaxKinds()
public
int
Parameter
=>
(
int
)
SyntaxKind
.
Parameter
;
public
int
TypeConstraint
=>
(
int
)
SyntaxKind
.
TypeConstraint
;
public
int
VariableDeclarator
=>
(
int
)
SyntaxKind
.
VariableDeclarator
;
public
int
ParameterList
=>
(
int
)
SyntaxKind
.
ParameterList
;
public
int
TypeArgumentList
=>
(
int
)
SyntaxKind
.
TypeArgumentList
;
public
int
?
GlobalStatement
=>
(
int
)
SyntaxKind
.
GlobalStatement
;
...
...
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Services/SyntaxFacts/ISyntaxKinds.cs
浏览文件 @
cbd1d12c
...
...
@@ -131,7 +131,7 @@ internal interface ISyntaxKinds
int
IncompleteMember
{
get
;
}
int
TypeArgumentList
{
get
;
}
int
ParameterList
{
get
;
}
#
endregion
#
region
other
...
...
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/VisualBasic/Services/SyntaxFacts/VisualBasicSyntaxKinds.vb
浏览文件 @
cbd1d12c
...
...
@@ -87,7 +87,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.LanguageServices
Public
ReadOnly
Property
Parameter
As
Integer
=
SyntaxKind
.
Parameter
Implements
ISyntaxKinds
.
Parameter
Public
ReadOnly
Property
TypeConstraint
As
Integer
=
SyntaxKind
.
TypeConstraint
Implements
ISyntaxKinds
.
TypeConstraint
Public
ReadOnly
Property
VariableDeclarator
As
Integer
=
SyntaxKind
.
VariableDeclarator
Implements
ISyntaxKinds
.
VariableDeclarator
Public
ReadOnly
Property
ParameterList
As
Integer
=
SyntaxKind
.
ParameterList
Implements
ISyntaxKinds
.
ParameterList
Public
ReadOnly
Property
TypeArgumentList
As
Integer
=
SyntaxKind
.
TypeArgumentList
Implements
ISyntaxKinds
.
TypeArgumentList
Public
ReadOnly
Property
GlobalStatement
As
Integer
?
=
Nothing
Implements
ISyntaxKinds
.
GlobalStatement
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录