Merge pull request #42542 from mavasani/PortUseCoalesceExpressionAnalyzers

Move UseCoalesceExpression analyzers/fixers/tests to shared layer

src/Analyzers/CSharp/Analyzers/CSharpAnalyzers.projitems

@@ -25,6 +25,8 @@
     <Compile Include="$(MSBuildThisFileDirectory)OrderModifiers\CSharpOrderModifiersHelper.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)PopulateSwitch\CSharpPopulateSwitchExpressionDiagnosticAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)PopulateSwitch\CSharpPopulateSwitchStatementDiagnosticAnalyzer.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\CSharpUseCoalesceExpressionDiagnosticAnalyzer.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\CSharpUseCoalesceExpressionForNullableDiagnosticAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseExpressionBody\Helpers\UseExpressionBodyForAccessorsHelper.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseExpressionBody\Helpers\UseExpressionBodyForConstructorsHelper.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseExpressionBody\Helpers\UseExpressionBodyForConversionOperatorsHelper.cs" />

src/Analyzers/CSharp/Tests/CSharpAnalyzers.UnitTests.projitems

@@ -15,6 +15,8 @@
     <Compile Include="$(MSBuildThisFileDirectory)MakeFieldReadonly\MakeFieldReadonlyTests.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)OrderModifiers\OrderModifiersCompilerErrorTests.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)OrderModifiers\OrderModifiersTests.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionForNullableTests.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionTests.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseExpressionBody\UseExpressionBodyForAccessorsAnalyzerTests.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseExpressionBody\UseExpressionBodyForConstructorsAnalyzerTests.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseExpressionBody\UseExpressionBodyForConversionOperatorsAnalyzerTests.cs" />

src/Analyzers/Core/Analyzers/Analyzers.projitems

@@ -42,6 +42,8 @@
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer.SymbolStartAnalyzer.BlockAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer.SymbolStartAnalyzer.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\AbstractUseCoalesceExpressionDiagnosticAnalyzer.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\AbstractUseCoalesceExpressionForNullableDiagnosticAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\AbstractObjectCreationExpressionAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\AbstractUseCollectionInitializerDiagnosticAnalyzer.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\ObjectCreationExpressionAnalyzer.cs" />

src/Analyzers/Core/Analyzers/AnalyzersResources.resx

@@ -238,4 +238,10 @@
   <data name="Accessibility_modifiers_required" xml:space="preserve">
     <value>Accessibility modifiers required</value>
   </data>
+  <data name="Use_coalesce_expression" xml:space="preserve">
+    <value>Use coalesce expression</value>
+  </data>
+  <data name="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime" xml:space="preserve">
+    <value>Changes to expression trees may result in behavior changes at runtime</value>
+  </data>
 </root>
\ No newline at end of file

src/Features/Core/Portable/UseCoalesceExpression/AbstractUseCoalesceExpressionDiagnosticAnalyzer.cs → src/Analyzers/Core/Analyzers/UseCoalesceExpression/AbstractUseCoalesceExpressionDiagnosticAnalyzer.cs

@@ -9,6 +9,10 @@
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.LanguageServices;
 
+#if CODE_STYLE
+using Microsoft.CodeAnalysis.Internal.Options;
+#endif
+
 namespace Microsoft.CodeAnalysis.UseCoalesceExpression
 {
     /// <summary>
@@ -27,7 +31,7 @@ internal abstract class AbstractUseCoalesceExpressionDiagnosticAnalyzer<
         protected AbstractUseCoalesceExpressionDiagnosticAnalyzer()
             : base(IDEDiagnosticIds.UseCoalesceExpressionDiagnosticId,
                    CodeStyleOptions.PreferCoalesceExpression,
-                   new LocalizableResourceString(nameof(FeaturesResources.Use_coalesce_expression), FeaturesResources.ResourceManager, typeof(FeaturesResources)),
+                   new LocalizableResourceString(nameof(AnalyzersResources.Use_coalesce_expression), AnalyzersResources.ResourceManager, typeof(AnalyzersResources)),
                    new LocalizableResourceString(nameof(AnalyzersResources.Null_check_can_be_simplified), AnalyzersResources.ResourceManager, typeof(AnalyzersResources)))
         {
         }

src/Features/Core/Portable/UseCoalesceExpression/AbstractUseCoalesceExpressionForNullableDiagnosticAnalyzer.cs → src/Analyzers/Core/Analyzers/UseCoalesceExpression/AbstractUseCoalesceExpressionForNullableDiagnosticAnalyzer.cs

@@ -10,6 +10,10 @@
 using Microsoft.CodeAnalysis.Diagnostics;
 using Microsoft.CodeAnalysis.LanguageServices;
 
+#if CODE_STYLE
+using Microsoft.CodeAnalysis.Internal.Options;
+#endif
+
 namespace Microsoft.CodeAnalysis.UseCoalesceExpression
 {
     internal abstract class AbstractUseCoalesceExpressionForNullableDiagnosticAnalyzer<
@@ -29,7 +33,7 @@ internal abstract class AbstractUseCoalesceExpressionForNullableDiagnosticAnalyz
         protected AbstractUseCoalesceExpressionForNullableDiagnosticAnalyzer()
             : base(IDEDiagnosticIds.UseCoalesceExpressionForNullableDiagnosticId,
                    CodeStyleOptions.PreferCoalesceExpression,
-                   new LocalizableResourceString(nameof(FeaturesResources.Use_coalesce_expression), FeaturesResources.ResourceManager, typeof(FeaturesResources)))
+                   new LocalizableResourceString(nameof(AnalyzersResources.Use_coalesce_expression), AnalyzersResources.ResourceManager, typeof(AnalyzersResources)))
         {
         }
 

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.cs.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.de.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.es.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.fr.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.it.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.ja.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.ko.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.pl.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.pt-BR.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.ru.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.tr.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.zh-Hans.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.zh-Hant.xlf

@@ -42,6 +42,11 @@
         <target state="new">Avoid unused parameters in your code. If the parameter cannot be removed, then change its name so it starts with an underscore and is optionally followed by an integer, such as '_', '_1', '_2', etc. These are treated as special discard symbol names.</target>
         <note />
       </trans-unit>
+      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
+        <source>Changes to expression trees may result in behavior changes at runtime</source>
+        <target state="new">Changes to expression trees may result in behavior changes at runtime</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Expression_value_is_never_used">
         <source>Expression value is never used</source>
         <target state="new">Expression value is never used</target>
@@ -197,6 +202,11 @@
         <target state="new">Unnecessary assignment of a value to '{0}'</target>
         <note />
       </trans-unit>
+      <trans-unit id="Use_coalesce_expression">
+        <source>Use coalesce expression</source>
+        <target state="new">Use coalesce expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="Use_throw_expression">
         <source>Use 'throw' expression</source>
         <target state="new">Use 'throw' expression</target>

src/Analyzers/Core/CodeFixes/CodeFixes.projitems

@@ -26,6 +26,8 @@
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnnecessaryImports\AbstractRemoveUnnecessaryImportsCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedMembers\AbstractRemoveUnusedMembersCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\AbstractRemoveUnusedValuesCodeFixProvider.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionCodeFixProvider.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionForNullableCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\AbstractUseCollectionInitializerCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseObjectInitializer\AbstractUseObjectInitializerCodeFixProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)UseThrowExpression\UseThrowExpressionCodeFixProvider.cs" />

src/Features/Core/Portable/UseCoalesceExpression/UseCoalesceExpressionCodeFixProvider.cs → src/Analyzers/Core/CodeFixes/UseCoalesceExpression/UseCoalesceExpressionCodeFixProvider.cs

@@ -90,7 +90,7 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
                             semanticModel, conditionalExpression, expressionTypeOpt, cancellationToken))
                     {
                         coalesceExpression = coalesceExpression.WithAdditionalAnnotations(
-                            WarningAnnotation.Create(FeaturesResources.Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime));
+                            WarningAnnotation.Create(AnalyzersResources.Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime));
                     }
 
                     return coalesceExpression.WithAdditionalAnnotations(Formatter.Annotation);
@@ -108,10 +108,10 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
                 : generator.CoalesceExpression(conditionalPartLow, syntaxFacts.WalkDownParentheses(currentWhenFalse));
         }
 
-        private class MyCodeAction : CodeAction.DocumentChangeAction
+        private class MyCodeAction : CustomCodeActions.DocumentChangeAction
         {
             public MyCodeAction(Func<CancellationToken, Task<Document>> createChangedDocument)
-                : base(FeaturesResources.Use_coalesce_expression, createChangedDocument)
+                : base(AnalyzersResources.Use_coalesce_expression, createChangedDocument)
             {
 
             }

src/Features/Core/Portable/UseCoalesceExpression/UseCoalesceExpressionForNullableCodeFixProvider.cs → src/Analyzers/Core/CodeFixes/UseCoalesceExpression/UseCoalesceExpressionForNullableCodeFixProvider.cs

@@ -76,7 +76,7 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
                                 semanticModel, conditionalExpression, expressionTypeOpt, cancellationToken))
                         {
                             coalesceExpression = coalesceExpression.WithAdditionalAnnotations(
-                                WarningAnnotation.Create(FeaturesResources.Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime));
+                                WarningAnnotation.Create(AnalyzersResources.Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime));
                         }
 
                         return coalesceExpression;
@@ -84,10 +84,10 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context)
             }
         }
 
-        private class MyCodeAction : CodeAction.DocumentChangeAction
+        private class MyCodeAction : CustomCodeActions.DocumentChangeAction
         {
             public MyCodeAction(Func<CancellationToken, Task<Document>> createChangedDocument)
-                : base(FeaturesResources.Use_coalesce_expression, createChangedDocument)
+                : base(AnalyzersResources.Use_coalesce_expression, createChangedDocument)
             {
 
             }

src/Analyzers/VisualBasic/Analyzers/VisualBasicAnalyzers.projitems

@@ -25,6 +25,8 @@
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnnecessaryImports\VisualBasicRemoveUnnecessaryImportsDiagnosticAnalyzer.vb" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedMembers\VisualBasicRemoveUnusedMembersDiagnosticAnalyzer.vb" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\VisualBasicRemoveUnusedParametersAndValuesDiagnosticAnalyzer.vb" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\VisualBasicUseCoalesceExpressionDiagnosticAnalyzer.vb" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\VisualBasicUseCoalesceExpressionForNullableDiagnosticAnalyzer.vb" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\VisualBasicUseCollectionInitializerDiagnosticAnalyzer.vb" />
     <Compile Include="$(MSBuildThisFileDirectory)UseObjectInitializer\VisualBasicUseObjectInitializerDiagnosticAnalyzer.vb" />
   </ItemGroup>

src/Analyzers/VisualBasic/Tests/VisualBasicAnalyzers.UnitTests.projitems

@@ -27,6 +27,8 @@
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\RemoveUnusedValueAssignmentTests.vb" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\RemoveUnusedValueExpressionStatementTests.vb" />
     <Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\RemoveUnusedValuesTestsBase.vb" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionForNullableTests.vb" />
+    <Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionTests.vb" />
     <Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\UseCollectionInitializerTests.vb" />
     <Compile Include="$(MSBuildThisFileDirectory)UseObjectInitializer\UseObjectInitializerTests.vb" />
   </ItemGroup>

src/Features/Core/Portable/FeaturesResources.resx

@@ -1021,9 +1021,6 @@ This version used in: {2}</value>
   <data name="Pascal_Case" xml:space="preserve">
     <value>Pascal Case</value>
   </data>
-  <data name="Use_coalesce_expression" xml:space="preserve">
-    <value>Use coalesce expression</value>
-  </data>
   <data name="Use_null_propagation" xml:space="preserve">
     <value>Use null propagation</value>
   </data>
@@ -1105,9 +1102,6 @@ This version used in: {2}</value>
   <data name="Pick_members_to_be_used_in_Equals_GetHashCode" xml:space="preserve">
     <value>Pick members to be used in Equals/GetHashCode</value>
   </data>
-  <data name="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime" xml:space="preserve">
-    <value>Changes to expression trees may result in behavior changes at runtime</value>
-  </data>
   <data name="Generate_overrides" xml:space="preserve">
     <value>Generate overrides...</value>
   </data>

src/Features/Core/Portable/xlf/FeaturesResources.cs.xlf

@@ -2075,11 +2075,6 @@ Tato verze se používá zde: {2}.</target>
         <target state="translated">PascalCase</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">Použít slučovací výraz</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">Použít šíření hodnot null</target>
@@ -2195,11 +2190,6 @@ Tato verze se používá zde: {2}.</target>
         <target state="translated">Vyberte členy, kteří se mají použít v Equals/GetHashCode.</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">Změny ve stromech výrazů můžou způsobit změny chování za běhu.</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">Generovat přepsání...</target>

src/Features/Core/Portable/xlf/FeaturesResources.de.xlf

@@ -2075,11 +2075,6 @@ Diese Version wird verwendet in: {2}</target>
         <target state="translated">Pascal-Schreibweise</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">COALESCE-Ausdruck verwenden</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">NULL-Weitergabe verwenden</target>
@@ -2195,11 +2190,6 @@ Diese Version wird verwendet in: {2}</target>
         <target state="translated">Member auswählen, die in "Equals"/"GetHashCode" verwendet werden sollen</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">Änderungen an Ausdrucksstrukturen führen unter Umständen zu Verhaltensänderungen zur Laufzeit</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">Überschreibungen generieren…</target>

src/Features/Core/Portable/xlf/FeaturesResources.es.xlf

@@ -2075,11 +2075,6 @@ Esta versión se utiliza en: {2}</target>
         <target state="translated">Pascal Case</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">Usar expresión coalesce</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">Usar propagación de null</target>
@@ -2195,11 +2190,6 @@ Esta versión se utiliza en: {2}</target>
         <target state="translated">Seleccionar miembros para usar en Equals/GetHashCode</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">Los cambios en los árboles de expresión pueden originar cambios de comportamiento en tiempo de ejecución</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">Generar invalidaciones...</target>

src/Features/Core/Portable/xlf/FeaturesResources.fr.xlf

@@ -2075,11 +2075,6 @@ Version utilisée dans : {2}</target>
         <target state="translated">Casse Pascal</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">Utiliser l'expression de fusion</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">Utiliser la propagation nulle</target>
@@ -2195,11 +2190,6 @@ Version utilisée dans : {2}</target>
         <target state="translated">Choisir les membres à utiliser dans Equals/GetHashCode</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">Les changements apportés aux arborescences d'expression peuvent entraîner des changements de comportement au moment de l'exécution</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">Générer les substitutions...</target>

src/Features/Core/Portable/xlf/FeaturesResources.it.xlf

@@ -2075,11 +2075,6 @@ Questa versione è usata {2}</target>
         <target state="translated">Notazione Pascal</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">Usa l'espressione COALESCE</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">Usa la propagazione di valori Null</target>
@@ -2195,11 +2190,6 @@ Questa versione è usata {2}</target>
         <target state="translated">Selezionare i membri da usare in Equals/GetHashCode</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">Le modifiche apportate agli alberi delle espressioni possono causare modifiche di comportamento in fase di esecuzione</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">Genera gli override...</target>

src/Features/Core/Portable/xlf/FeaturesResources.ja.xlf

@@ -2075,11 +2075,6 @@ This version used in: {2}</source>
         <target state="translated">パスカル ケース</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">coalesce 式を使用します</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">null 値の反映を使用します</target>
@@ -2195,11 +2190,6 @@ This version used in: {2}</source>
         <target state="translated">Equals/GetHashCode で使用するメンバーを選択する</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">式ツリーを変更すると、実行時の動作が変わる可能性があります</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">上書きを生成する...</target>

src/Features/Core/Portable/xlf/FeaturesResources.ko.xlf

@@ -2075,11 +2075,6 @@ This version used in: {2}</source>
         <target state="translated">파스칼식 대/소문자</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">COALESCE 식 사용</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">Null 전파 사용</target>
@@ -2195,11 +2190,6 @@ This version used in: {2}</source>
         <target state="translated">Equals/GetHashCode에 사용할 멤버 선택</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">식 트리를 변경하면 런타임에 동작이 변경될 수 있습니다.</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">재정의 생성...</target>

src/Features/Core/Portable/xlf/FeaturesResources.pl.xlf

@@ -2075,11 +2075,6 @@ Ta wersja jest używana wersja: {2}</target>
         <target state="translated">PascalCase</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">Użyj wyrażenia łączącego</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">Użyj propagacji wartości null</target>
@@ -2195,11 +2190,6 @@ Ta wersja jest używana wersja: {2}</target>
         <target state="translated">Wybierz składowe, które zostaną użyte w elementach Equals/GetHashCode</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">Wprowadzenie zmian w drzewach wyrażeń może spowodować zmiany zachowania w czasie wykonywania</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">Generuj zastąpienia...</target>

src/Features/Core/Portable/xlf/FeaturesResources.pt-BR.xlf

@@ -2075,11 +2075,6 @@ Essa versão é usada no: {2}</target>
         <target state="translated">Pascal Case</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">Usar a expressão de união</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">Usar tratamento simplificado de nulo</target>
@@ -2195,11 +2190,6 @@ Essa versão é usada no: {2}</target>
         <target state="translated">Escolher membros para que sejam usados em Equals/GetHashCode</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">Alterações nas árvores de expressão podem resultar em alterações de comportamento no tempo de execução</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">Gerar substituições...</target>

src/Features/Core/Portable/xlf/FeaturesResources.ru.xlf

@@ -2075,11 +2075,6 @@ This version used in: {2}</source>
         <target state="translated">ВсеЧастиСПрописнойБуквы</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">Используйте выражение объединения</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">Используйте распространение значения NULL</target>
@@ -2195,11 +2190,6 @@ This version used in: {2}</source>
         <target state="translated">Выберите члены, которые будут использоваться в Equals/GetHashCode</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">Изменения в деревьях выражений могут привести к изменениям поведения во время выполнения.</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">Создать переопределения...</target>

src/Features/Core/Portable/xlf/FeaturesResources.tr.xlf

@@ -2075,11 +2075,6 @@ Bu sürüm şurada kullanılır: {2}</target>
         <target state="translated">Baş Harfleri Büyük Olmak Üzere Bitişik</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">Birleştirme ifadesi kullan</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">Null yayılması kullan</target>
@@ -2195,11 +2190,6 @@ Bu sürüm şurada kullanılır: {2}</target>
         <target state="translated">Equals/GetHashCode içinde kullanılacak üyeleri seçin</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">İfade ağaçlarında yapılan değişiklikler çalışma zamanında davranış değişikliklerine neden olabilir</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">Geçersiz kılmaları oluştur...</target>

src/Features/Core/Portable/xlf/FeaturesResources.zh-Hans.xlf

@@ -2075,11 +2075,6 @@ This version used in: {2}</source>
         <target state="translated">帕斯卡拼写法</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">使用 COALESCE 表达式</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">使用 null 传播</target>
@@ -2195,11 +2190,6 @@ This version used in: {2}</source>
         <target state="translated">选择成员用于 Equals/GetHashCode</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">对表达式树的更改可能导致运行时的行为改变</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">生成重写...</target>

src/Features/Core/Portable/xlf/FeaturesResources.zh-Hant.xlf

@@ -2075,11 +2075,6 @@ This version used in: {2}</source>
         <target state="translated">Pascal 命名法的大小寫</target>
         <note />
       </trans-unit>
-      <trans-unit id="Use_coalesce_expression">
-        <source>Use coalesce expression</source>
-        <target state="translated">使用 coalesce 運算式</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Use_null_propagation">
         <source>Use null propagation</source>
         <target state="translated">使用 null 傳播</target>
@@ -2195,11 +2190,6 @@ This version used in: {2}</source>
         <target state="translated">選取要用於 Equals/GetHashCode 中的成員</target>
         <note />
       </trans-unit>
-      <trans-unit id="Changes_to_expression_trees_may_result_in_behavior_changes_at_runtime">
-        <source>Changes to expression trees may result in behavior changes at runtime</source>
-        <target state="translated">變更運算式樹狀架構可能會導致執行階段的行為變更</target>
-        <note />
-      </trans-unit>
       <trans-unit id="Generate_overrides">
         <source>Generate overrides...</source>
         <target state="translated">產生覆寫...</target>