上级 7f752b46
...@@ -168,11 +168,16 @@ public int ReportError(string bstrErrorMessage, string bstrErrorId, [ComAliasNam ...@@ -168,11 +168,16 @@ public int ReportError(string bstrErrorMessage, string bstrErrorId, [ComAliasNam
// TODO: Use PreserveSig instead of throwing these exceptions for common cases. // TODO: Use PreserveSig instead of throwing these exceptions for common cases.
public void ReportError2(string bstrErrorMessage, string bstrErrorId, [ComAliasName("VsShell.VSTASKPRIORITY")]VSTASKPRIORITY nPriority, int iStartLine, int iStartColumn, int iEndLine, int iEndColumn, string bstrFileName) public void ReportError2(string bstrErrorMessage, string bstrErrorId, [ComAliasName("VsShell.VSTASKPRIORITY")]VSTASKPRIORITY nPriority, int iStartLine, int iStartColumn, int iEndLine, int iEndColumn, string bstrFileName)
{ {
// first we check whether given error is something we can take care. // This is showing up in our NetCore tests for brief periods of time due to the following issue
if (!CanHandle(bstrErrorId)) // https://github.com/dotnet/cli/issues/10989
if (bstrErrorId != "NETSDK1005")
{ {
// it is not, let project system takes care. // first we check whether given error is something we can take care.
throw new NotImplementedException(); if (!CanHandle(bstrErrorId))
{
// it is not, let project system takes care.
throw new NotImplementedException();
}
} }
if ((iEndLine >= 0 && iEndColumn >= 0) && if ((iEndLine >= 0 && iEndColumn >= 0) &&
......
...@@ -30,7 +30,7 @@ public override void ErrorLevelWarning() ...@@ -30,7 +30,7 @@ public override void ErrorLevelWarning()
base.ErrorLevelWarning(); base.ErrorLevelWarning();
} }
[WpfFact, Trait(Traits.Feature, Traits.Features.ErrorList)] [WpfFact(Skip = "https://github.com/dotnet/roslyn/issues/34211"), Trait(Traits.Feature, Traits.Features.ErrorList)]
[Trait(Traits.Feature, Traits.Features.NetCore)] [Trait(Traits.Feature, Traits.Features.NetCore)]
public override void ErrorsDuringMethodBodyEditing() public override void ErrorsDuringMethodBodyEditing()
{ {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册