diff --git a/src/VisualStudio/Core/Def/Implementation/TaskList/ProjectExternalErrorReporter.cs b/src/VisualStudio/Core/Def/Implementation/TaskList/ProjectExternalErrorReporter.cs index ac832c420c5c6b9ba307d078fef28337829482b9..0f937d6d29eca52d0001ca5d228d0cdab65e9d84 100644 --- a/src/VisualStudio/Core/Def/Implementation/TaskList/ProjectExternalErrorReporter.cs +++ b/src/VisualStudio/Core/Def/Implementation/TaskList/ProjectExternalErrorReporter.cs @@ -168,11 +168,16 @@ public int ReportError(string bstrErrorMessage, string bstrErrorId, [ComAliasNam // TODO: Use PreserveSig instead of throwing these exceptions for common cases. public void ReportError2(string bstrErrorMessage, string bstrErrorId, [ComAliasName("VsShell.VSTASKPRIORITY")]VSTASKPRIORITY nPriority, int iStartLine, int iStartColumn, int iEndLine, int iEndColumn, string bstrFileName) { - // first we check whether given error is something we can take care. - if (!CanHandle(bstrErrorId)) + // This is showing up in our NetCore tests for brief periods of time due to the following issue + // https://github.com/dotnet/cli/issues/10989 + if (bstrErrorId != "NETSDK1005") { - // it is not, let project system takes care. - throw new NotImplementedException(); + // first we check whether given error is something we can take care. + if (!CanHandle(bstrErrorId)) + { + // it is not, let project system takes care. + throw new NotImplementedException(); + } } if ((iEndLine >= 0 && iEndColumn >= 0) && diff --git a/src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpErrorListNetCore.cs b/src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpErrorListNetCore.cs index d913773982016c31dd76b668db9974db4cb8e99f..afccc92325c1569d678cf8f1616e75c044901d5f 100644 --- a/src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpErrorListNetCore.cs +++ b/src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpErrorListNetCore.cs @@ -30,7 +30,7 @@ public override void ErrorLevelWarning() base.ErrorLevelWarning(); } - [WpfFact, Trait(Traits.Feature, Traits.Features.ErrorList)] + [WpfFact(Skip = "https://github.com/dotnet/roslyn/issues/34211"), Trait(Traits.Feature, Traits.Features.ErrorList)] [Trait(Traits.Feature, Traits.Features.NetCore)] public override void ErrorsDuringMethodBodyEditing() {