PR feedback

build/Targets/Imports.targets

@@ -541,7 +541,7 @@
     <PathMap Condition="'$(DeterministicSourceRoot)' != ''">$(RepoRoot)=$(DeterministicSourceRoot)</PathMap>
   </PropertyGroup>
 
-  <Target Name="_CheckForSpaces"
+  <Target Name="_CheckForSpacesInPathMap"
           BeforeTargets="CoreCompile">
     <Error Text="PathMap, DeterministicSourceRoot and RepoRoot shall not contain spaces (https://github.com/dotnet/roslyn/issues/22835)" 
            Condition="$(PathMap.Contains(' '))" />

build/Targets/RepoToolset/GitHash.props

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright (c)  Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information. -->
+
+<!--
+Copied from RepoToolset. Might be slightly modified to adjust for the current Roslyn build system specifics if necessary.
+
+Limit Roslyn specific changes to minumum.
+
+If a fix not specific to Roslyn is needed create a PR against https://github.com/dotnet/roslyn-tools repo updating the toolset.
+Update this file only if the change to RepoToolset gets approved and merged.
+-->
+
 <Project>
   <!--
 

build/Targets/RepoToolset/Readme.md

-Files in this directory are copied from RepoToolset. They might be slightly modified to adjust for the current Roslyn build system specifics if necessary.
-
-Limit Roslyn specific changes to minumum.
-
-If a fix not specific to Roslyn is needed create a PR against https://github.com/dotnet/roslyn-tools repo updating the toolset. Update files in this directory only if the change to RepoToolset gets approved and merged.
- 
\ No newline at end of file

build/Targets/RepoToolset/SourceLink.targets

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright (c)  Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information. -->
+
+<!--
+Copied from RepoToolset. Might be slightly modified to adjust for the current Roslyn build system specifics if necessary.
+
+Limit Roslyn specific changes to minumum.
+
+If a fix not specific to Roslyn is needed create a PR against https://github.com/dotnet/roslyn-tools repo updating the toolset.
+Update this file only if the change to RepoToolset gets approved and merged.
+-->
+
 <Project>
 
   <PropertyGroup>

build/Targets/RepoToolset/SymStore.targets

 <!-- Copyright (c)  Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information. -->
+
+<!--
+Copied from RepoToolset. Might be slightly modified to adjust for the current Roslyn build system specifics if necessary.
+
+Limit Roslyn specific changes to minumum.
+
+If a fix not specific to Roslyn is needed create a PR against https://github.com/dotnet/roslyn-tools repo updating the toolset.
+Update this file only if the change to RepoToolset gets approved and merged.
+-->
+
 <Project>
 
   <PropertyGroup>
@@ -68,7 +78,9 @@
 
   <!-- 
     The current MicroBuild symbol indexing task doesn't support specifying list of files to index.
-    Therefore we create hardlinks to the files in output directory, which will get signed.
+    Therefore we create hardlinks to the files in output directory, where DLLs and EXEs are signed.
+    These targets are executed after the signing phase so that we publish signed binaries to the
+    symbol store even if the files are copies and not hardlinked.
   -->
   <Target Name="_DeployWindowsSymbolsToSymStore"
           AfterTargets="_InnerDeployToSymStore"

build/Targets/Settings.props

@@ -21,6 +21,7 @@
     <DeveloperBuild>false</DeveloperBuild>
     <DeveloperBuild Condition="'$(OfficialBuild)' != 'true' AND '$(JenkinsBuild)' != 'true'">true</DeveloperBuild>
 
+    <ArtifactsSymStoreDirectory Condition="'$(DeveloperBuild)' != 'true' and '$(OS)' == 'Windows_NT'">$(BaseOutputPath)$(Configuration)\SymStore\</ArtifactsSymStoreDirectory>
     <NuGetToolPath>$(RepoRoot)nuget.exe</NuGetToolPath>
     <ToolsetPackagesDir>$(RepoRoot)build\ToolsetPackages\</ToolsetPackagesDir>
     <VSIXExpInstallerPackageName>RoslynTools.Microsoft.VSIXExpInstaller</VSIXExpInstallerPackageName>
@@ -33,6 +34,7 @@
     <RoslynPortableTargetFrameworks46>net46;netcoreapp2.0</RoslynPortableTargetFrameworks46>
     <RoslynPortableRuntimeIdentifiers>win7;win7-x64</RoslynPortableRuntimeIdentifiers>
  
+    <UsingToolPdbConverter>true</UsingToolPdbConverter>
     <Features>strict, IOperation</Features>
     <ProduceReferenceAssembly>true</ProduceReferenceAssembly>
     <Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>

src/Test/Perf/Runner/Perf.Runner.csproj

@@ -12,7 +12,7 @@
     <RuntimeIdentifiers>win7;ubuntu.14.04;osx.10.10</RuntimeIdentifiers>
     <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
     <SignAssembly>false</SignAssembly>
-    <Nonshipping>Perf.Runner.csproj</Nonshipping>
+    <Nonshipping>true</Nonshipping>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'" />
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU'" />