From 28652de7a1dcd8ba1b4ea1a3d348cae5f1f026d4 Mon Sep 17 00:00:00 2001
From: Tomas Matousek <tomat@microsoft.com>
Date: Mon, 30 Oct 2017 10:01:00 -0700
Subject: [PATCH] PR feedback

---
 build/Targets/Imports.targets                |  2 +-
 build/Targets/RepoToolset/GitHash.props      | 10 ++++++++++
 build/Targets/RepoToolset/Readme.md          |  6 ------
 build/Targets/RepoToolset/SourceLink.targets | 10 ++++++++++
 build/Targets/RepoToolset/SymStore.targets   | 14 +++++++++++++-
 build/Targets/Settings.props                 |  2 ++
 src/Test/Perf/Runner/Perf.Runner.csproj      |  2 +-
 7 files changed, 37 insertions(+), 9 deletions(-)
 delete mode 100644 build/Targets/RepoToolset/Readme.md

diff --git a/build/Targets/Imports.targets b/build/Targets/Imports.targets
index 02d0146b214..80ed1706ee5 100644
--- a/build/Targets/Imports.targets
+++ b/build/Targets/Imports.targets
@@ -541,7 +541,7 @@
     <PathMap Condition="'$(DeterministicSourceRoot)' != ''">$(RepoRoot)=$(DeterministicSourceRoot)</PathMap>
   </PropertyGroup>
 
-  <Target Name="_CheckForSpaces"
+  <Target Name="_CheckForSpacesInPathMap"
           BeforeTargets="CoreCompile">
     <Error Text="PathMap, DeterministicSourceRoot and RepoRoot shall not contain spaces (https://github.com/dotnet/roslyn/issues/22835)" 
            Condition="$(PathMap.Contains(' '))" />
diff --git a/build/Targets/RepoToolset/GitHash.props b/build/Targets/RepoToolset/GitHash.props
index aa4c9e3df3e..2382ed52978 100644
--- a/build/Targets/RepoToolset/GitHash.props
+++ b/build/Targets/RepoToolset/GitHash.props
@@ -1,5 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright (c)  Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information. -->
+
+<!--
+Copied from RepoToolset. Might be slightly modified to adjust for the current Roslyn build system specifics if necessary.
+
+Limit Roslyn specific changes to minumum.
+
+If a fix not specific to Roslyn is needed create a PR against https://github.com/dotnet/roslyn-tools repo updating the toolset.
+Update this file only if the change to RepoToolset gets approved and merged.
+-->
+
 <Project>
   <!--
 
diff --git a/build/Targets/RepoToolset/Readme.md b/build/Targets/RepoToolset/Readme.md
deleted file mode 100644
index 1132da138b9..00000000000
--- a/build/Targets/RepoToolset/Readme.md
+++ /dev/null
@@ -1,6 +0,0 @@
-Files in this directory are copied from RepoToolset. They might be slightly modified to adjust for the current Roslyn build system specifics if necessary.
-
-Limit Roslyn specific changes to minumum.
-
-If a fix not specific to Roslyn is needed create a PR against https://github.com/dotnet/roslyn-tools repo updating the toolset. Update files in this directory only if the change to RepoToolset gets approved and merged.
- 
\ No newline at end of file
diff --git a/build/Targets/RepoToolset/SourceLink.targets b/build/Targets/RepoToolset/SourceLink.targets
index 7a393195fdd..fef3f86d6c0 100644
--- a/build/Targets/RepoToolset/SourceLink.targets
+++ b/build/Targets/RepoToolset/SourceLink.targets
@@ -1,5 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright (c)  Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information. -->
+
+<!--
+Copied from RepoToolset. Might be slightly modified to adjust for the current Roslyn build system specifics if necessary.
+
+Limit Roslyn specific changes to minumum.
+
+If a fix not specific to Roslyn is needed create a PR against https://github.com/dotnet/roslyn-tools repo updating the toolset.
+Update this file only if the change to RepoToolset gets approved and merged.
+-->
+
 <Project>
 
   <PropertyGroup>
diff --git a/build/Targets/RepoToolset/SymStore.targets b/build/Targets/RepoToolset/SymStore.targets
index 5df6d61c7b6..fd5996b4806 100644
--- a/build/Targets/RepoToolset/SymStore.targets
+++ b/build/Targets/RepoToolset/SymStore.targets
@@ -1,4 +1,14 @@
 <!-- Copyright (c)  Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information. -->
+
+<!--
+Copied from RepoToolset. Might be slightly modified to adjust for the current Roslyn build system specifics if necessary.
+
+Limit Roslyn specific changes to minumum.
+
+If a fix not specific to Roslyn is needed create a PR against https://github.com/dotnet/roslyn-tools repo updating the toolset.
+Update this file only if the change to RepoToolset gets approved and merged.
+-->
+
 <Project>
 
   <PropertyGroup>
@@ -68,7 +78,9 @@
 
   <!-- 
     The current MicroBuild symbol indexing task doesn't support specifying list of files to index.
-    Therefore we create hardlinks to the files in output directory, which will get signed.
+    Therefore we create hardlinks to the files in output directory, where DLLs and EXEs are signed.
+    These targets are executed after the signing phase so that we publish signed binaries to the
+    symbol store even if the files are copies and not hardlinked.
   -->
   <Target Name="_DeployWindowsSymbolsToSymStore"
           AfterTargets="_InnerDeployToSymStore"
diff --git a/build/Targets/Settings.props b/build/Targets/Settings.props
index eaa2b0fd2a1..55435596310 100644
--- a/build/Targets/Settings.props
+++ b/build/Targets/Settings.props
@@ -21,6 +21,7 @@
     <DeveloperBuild>false</DeveloperBuild>
     <DeveloperBuild Condition="'$(OfficialBuild)' != 'true' AND '$(JenkinsBuild)' != 'true'">true</DeveloperBuild>
 
+    <ArtifactsSymStoreDirectory Condition="'$(DeveloperBuild)' != 'true' and '$(OS)' == 'Windows_NT'">$(BaseOutputPath)$(Configuration)\SymStore\</ArtifactsSymStoreDirectory>
     <NuGetToolPath>$(RepoRoot)nuget.exe</NuGetToolPath>
     <ToolsetPackagesDir>$(RepoRoot)build\ToolsetPackages\</ToolsetPackagesDir>
     <VSIXExpInstallerPackageName>RoslynTools.Microsoft.VSIXExpInstaller</VSIXExpInstallerPackageName>
@@ -33,6 +34,7 @@
     <RoslynPortableTargetFrameworks46>net46;netcoreapp2.0</RoslynPortableTargetFrameworks46>
     <RoslynPortableRuntimeIdentifiers>win7;win7-x64</RoslynPortableRuntimeIdentifiers>
  
+    <UsingToolPdbConverter>true</UsingToolPdbConverter>
     <Features>strict, IOperation</Features>
     <ProduceReferenceAssembly>true</ProduceReferenceAssembly>
     <Configuration Condition="'$(Configuration)' == ''">Debug</Configuration>
diff --git a/src/Test/Perf/Runner/Perf.Runner.csproj b/src/Test/Perf/Runner/Perf.Runner.csproj
index a9f39333855..fa2542fed66 100644
--- a/src/Test/Perf/Runner/Perf.Runner.csproj
+++ b/src/Test/Perf/Runner/Perf.Runner.csproj
@@ -12,7 +12,7 @@
     <RuntimeIdentifiers>win7;ubuntu.14.04;osx.10.10</RuntimeIdentifiers>
     <AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
     <SignAssembly>false</SignAssembly>
-    <Nonshipping>Perf.Runner.csproj</Nonshipping>
+    <Nonshipping>true</Nonshipping>
   </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|AnyCPU'" />
   <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Release|AnyCPU'" />
-- 
GitLab