Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
0f8eda3d
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
0f8eda3d
编写于
4月 06, 2020
作者:
M
Manish Vasani
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Port UseAutoProperty analyzer and tests to shared layer.
Porting the code fix is blocked by #43091
上级
1875bd78
变更
13
隐藏空白更改
内联
并排
Showing
13 changed file
with
21 addition
and
7 deletion
+21
-7
src/Analyzers/CSharp/Analyzers/CSharpAnalyzers.projitems
src/Analyzers/CSharp/Analyzers/CSharpAnalyzers.projitems
+1
-0
src/Analyzers/CSharp/Analyzers/UseAutoProperty/CSharpUseAutoPropertyAnalyzer.cs
...nalyzers/UseAutoProperty/CSharpUseAutoPropertyAnalyzer.cs
+0
-0
src/Analyzers/CSharp/Tests/CSharpAnalyzers.UnitTests.projitems
...nalyzers/CSharp/Tests/CSharpAnalyzers.UnitTests.projitems
+1
-0
src/Analyzers/CSharp/Tests/UseAutoProperty/UseAutoPropertyTests.cs
...zers/CSharp/Tests/UseAutoProperty/UseAutoPropertyTests.cs
+1
-1
src/Analyzers/Core/Analyzers/Analyzers.projitems
src/Analyzers/Core/Analyzers/Analyzers.projitems
+1
-0
src/Analyzers/Core/Analyzers/UseAutoProperty/AbstractUseAutoPropertyAnalyzer.cs
...lyzers/UseAutoProperty/AbstractUseAutoPropertyAnalyzer.cs
+2
-2
src/Analyzers/VisualBasic/Analyzers/UseAutoProperty/Utilities.vb
...lyzers/VisualBasic/Analyzers/UseAutoProperty/Utilities.vb
+0
-0
src/Analyzers/VisualBasic/Analyzers/UseAutoProperty/VisualBasicUseAutoPropertyAnalyzer.vb
...ers/UseAutoProperty/VisualBasicUseAutoPropertyAnalyzer.vb
+1
-1
src/Analyzers/VisualBasic/Analyzers/VisualBasicAnalyzers.projitems
...zers/VisualBasic/Analyzers/VisualBasicAnalyzers.projitems
+2
-0
src/Analyzers/VisualBasic/Tests/UseAutoProperty/UseAutoPropertyTests.vb
...VisualBasic/Tests/UseAutoProperty/UseAutoPropertyTests.vb
+1
-1
src/Analyzers/VisualBasic/Tests/VisualBasicAnalyzers.UnitTests.projitems
...isualBasic/Tests/VisualBasicAnalyzers.UnitTests.projitems
+1
-0
src/EditorFeatures/DiagnosticsTestUtilities/Diagnostics/AbstractDiagnosticProviderBasedUserDiagnosticTest.cs
...tics/AbstractDiagnosticProviderBasedUserDiagnosticTest.cs
+8
-0
src/Features/Core/Portable/UseAutoProperty/AbstractUseAutoPropertyCodeFixProvider.cs
...UseAutoProperty/AbstractUseAutoPropertyCodeFixProvider.cs
+2
-2
未找到文件。
src/Analyzers/CSharp/Analyzers/CSharpAnalyzers.projitems
浏览文件 @
0f8eda3d
...
...
@@ -35,6 +35,7 @@
<Compile
Include=
"$(MSBuildThisFileDirectory)PopulateSwitch\CSharpPopulateSwitchStatementDiagnosticAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnreachableCode\CSharpRemoveUnreachableCodeDiagnosticAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnreachableCode\RemoveUnreachableCodeHelpers.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseAutoProperty\CSharpUseAutoPropertyAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCoalesceExpression\CSharpUseCoalesceExpressionDiagnosticAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCoalesceExpression\CSharpUseCoalesceExpressionForNullableDiagnosticAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCompoundAssignment\CSharpUseCompoundAssignmentDiagnosticAnalyzer.cs"
/>
...
...
src/
Features/CSharp/Portable
/UseAutoProperty/CSharpUseAutoPropertyAnalyzer.cs
→
src/
Analyzers/CSharp/Analyzers
/UseAutoProperty/CSharpUseAutoPropertyAnalyzer.cs
浏览文件 @
0f8eda3d
文件已移动
src/Analyzers/CSharp/Tests/CSharpAnalyzers.UnitTests.projitems
浏览文件 @
0f8eda3d
...
...
@@ -21,6 +21,7 @@
<Compile
Include=
"$(MSBuildThisFileDirectory)OrderModifiers\OrderModifiersCompilerErrorTests.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)OrderModifiers\OrderModifiersTests.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnreachableCode\RemoveUnreachableCodeTests.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseAutoProperty\UseAutoPropertyTests.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionForNullableTests.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionTests.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCompoundAssignment\UseCompoundAssignmentTests.cs"
/>
...
...
src/
EditorFeatures/CSharpTest
/UseAutoProperty/UseAutoPropertyTests.cs
→
src/
Analyzers/CSharp/Tests
/UseAutoProperty/UseAutoPropertyTests.cs
浏览文件 @
0f8eda3d
...
...
@@ -18,7 +18,7 @@ namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.UseAutoProperty
public
class
UseAutoPropertyTests
:
AbstractCSharpDiagnosticProviderBasedUserDiagnosticTest
{
internal
override
(
DiagnosticAnalyzer
,
CodeFixProvider
)
CreateDiagnosticProviderAndFixer
(
Workspace
workspace
)
=>
(
new
CSharpUseAutoPropertyAnalyzer
(),
new
CSharpUseAutoPropertyCodeFixProvider
());
=>
(
new
CSharpUseAutoPropertyAnalyzer
(),
Get
CSharpUseAutoPropertyCodeFixProvider
());
[
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsUseAutoProperty
)]
public
async
Task
TestSingleGetterFromField
()
...
...
src/Analyzers/Core/Analyzers/Analyzers.projitems
浏览文件 @
0f8eda3d
...
...
@@ -47,6 +47,7 @@
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer.SymbolStartAnalyzer.BlockAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\AbstractRemoveUnusedParametersAndValuesDiagnosticAnalyzer.SymbolStartAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseAutoProperty\AbstractUseAutoPropertyAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCoalesceExpression\AbstractUseCoalesceExpressionDiagnosticAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCoalesceExpression\AbstractUseCoalesceExpressionForNullableDiagnosticAnalyzer.cs"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCollectionInitializer\AbstractObjectCreationExpressionAnalyzer.cs"
/>
...
...
src/
Features/Core/Portable
/UseAutoProperty/AbstractUseAutoPropertyAnalyzer.cs
→
src/
Analyzers/Core/Analyzers
/UseAutoProperty/AbstractUseAutoPropertyAnalyzer.cs
浏览文件 @
0f8eda3d
...
...
@@ -20,8 +20,8 @@ internal abstract class AbstractUseAutoPropertyAnalyzer<
where
TExpression
:
SyntaxNode
{
private
static
readonly
LocalizableString
s_title
=
new
LocalizableResourceString
(
nameof
(
Feature
sResources
.
Use_auto_property
),
FeaturesResources
.
ResourceManager
,
typeof
(
Feature
sResources
));
new
LocalizableResourceString
(
nameof
(
Analyzer
sResources
.
Use_auto_property
),
AnalyzersResources
.
ResourceManager
,
typeof
(
Analyzer
sResources
));
protected
AbstractUseAutoPropertyAnalyzer
()
:
base
(
IDEDiagnosticIds
.
UseAutoPropertyDiagnosticId
,
CodeStyleOptions2
.
PreferAutoProperties
,
s_title
,
s_title
)
...
...
src/
Features/VisualBasic/Portable
/UseAutoProperty/Utilities.vb
→
src/
Analyzers/VisualBasic/Analyzers
/UseAutoProperty/Utilities.vb
浏览文件 @
0f8eda3d
文件已移动
src/
Features/VisualBasic/Portable
/UseAutoProperty/VisualBasicUseAutoPropertyAnalyzer.vb
→
src/
Analyzers/VisualBasic/Analyzers
/UseAutoProperty/VisualBasicUseAutoPropertyAnalyzer.vb
浏览文件 @
0f8eda3d
...
...
@@ -203,7 +203,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.UseAutoProperty
If
node
.
Kind
()
=
SyntaxKind
.
IdentifierName
Then
Dim
symbolInfo
=
semanticModel
.
GetSymbolInfo
(
node
)
If
field
.
Equals
(
symbolInfo
.
Symbol
)
Then
If
VisualBasicSemanticFactsService
.
Instance
.
IsWrittenTo
(
semanticModel
,
node
,
cancellationToken
)
Then
If
DirectCast
(
node
,
ExpressionSyntax
).
IsWrittenTo
(
semanticModel
,
cancellationToken
)
Then
Return
True
End
If
End
If
...
...
src/Analyzers/VisualBasic/Analyzers/VisualBasicAnalyzers.projitems
浏览文件 @
0f8eda3d
...
...
@@ -28,6 +28,8 @@
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnnecessaryParentheses\VisualBasicRemoveUnnecessaryParenthesesDiagnosticAnalyzer.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnusedMembers\VisualBasicRemoveUnusedMembersDiagnosticAnalyzer.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\VisualBasicRemoveUnusedParametersAndValuesDiagnosticAnalyzer.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseAutoProperty\Utilities.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseAutoProperty\VisualBasicUseAutoPropertyAnalyzer.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCoalesceExpression\VisualBasicUseCoalesceExpressionDiagnosticAnalyzer.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCoalesceExpression\VisualBasicUseCoalesceExpressionForNullableDiagnosticAnalyzer.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCollectionInitializer\VisualBasicUseCollectionInitializerDiagnosticAnalyzer.vb"
/>
...
...
src/
EditorFeatures/VisualBasicTest
/UseAutoProperty/UseAutoPropertyTests.vb
→
src/
Analyzers/VisualBasic/Tests
/UseAutoProperty/UseAutoPropertyTests.vb
浏览文件 @
0f8eda3d
...
...
@@ -13,7 +13,7 @@ Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.UseAutoProperty
Inherits
AbstractVisualBasicDiagnosticProviderBasedUserDiagnosticTest
Friend
Overrides
Function
CreateDiagnosticProviderAndFixer
(
workspace
As
Workspace
)
As
(
DiagnosticAnalyzer
,
CodeFixProvider
)
Return
(
New
VisualBasicUseAutoPropertyAnalyzer
(),
New
VisualBasicUseAutoPropertyCodeFixProvider
())
Return
(
New
VisualBasicUseAutoPropertyAnalyzer
(),
Get
VisualBasicUseAutoPropertyCodeFixProvider
())
End
Function
<
Fact
,
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsUseAutoProperty
)
>
...
...
src/Analyzers/VisualBasic/Tests/VisualBasicAnalyzers.UnitTests.projitems
浏览文件 @
0f8eda3d
...
...
@@ -30,6 +30,7 @@
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\RemoveUnusedValueAssignmentTests.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\RemoveUnusedValueExpressionStatementTests.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\RemoveUnusedValuesTestsBase.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseAutoProperty\UseAutoPropertyTests.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionForNullableTests.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionTests.vb"
/>
<Compile
Include=
"$(MSBuildThisFileDirectory)UseCollectionInitializer\UseCollectionInitializerTests.vb"
/>
...
...
src/EditorFeatures/DiagnosticsTestUtilities/Diagnostics/AbstractDiagnosticProviderBasedUserDiagnosticTest.cs
浏览文件 @
0f8eda3d
...
...
@@ -10,11 +10,13 @@
using
Microsoft.CodeAnalysis.CodeActions
;
using
Microsoft.CodeAnalysis.CodeFixes
;
using
Microsoft.CodeAnalysis.CSharp.MakeLocalFunctionStatic
;
using
Microsoft.CodeAnalysis.CSharp.UseAutoProperty
;
using
Microsoft.CodeAnalysis.Diagnostics
;
using
Microsoft.CodeAnalysis.Editor.UnitTests.CodeActions
;
using
Microsoft.CodeAnalysis.Editor.UnitTests.Workspaces
;
using
Microsoft.CodeAnalysis.Text
;
using
Microsoft.CodeAnalysis.UnitTests.Diagnostics
;
using
Microsoft.CodeAnalysis.VisualBasic.UseAutoProperty
;
using
Roslyn.Test.Utilities
;
using
Roslyn.Utilities
;
using
Xunit
;
...
...
@@ -238,6 +240,12 @@ private void AssertNoAnalyzerExceptionDiagnostics(IEnumerable<Diagnostic> diagno
// https://github.com/dotnet/roslyn/issues/43056 blocks porting the fixer to CodeStyle layer.
protected
static
CodeFixProvider
GetMakeLocalFunctionStaticCodeFixProvider
()
=>
new
MakeLocalFunctionStaticCodeFixProvider
();
// https://github.com/dotnet/roslyn/issues/43091 blocks porting the fixer to CodeStyle layer.
protected
static
CodeFixProvider
GetCSharpUseAutoPropertyCodeFixProvider
()
=>
new
CSharpUseAutoPropertyCodeFixProvider
();
// https://github.com/dotnet/roslyn/issues/43091 blocks porting the fixer to CodeStyle layer.
protected
static
CodeFixProvider
GetVisualBasicUseAutoPropertyCodeFixProvider
()
=>
new
VisualBasicUseAutoPropertyCodeFixProvider
();
#
endregion
}
}
src/Features/Core/Portable/UseAutoProperty/AbstractUseAutoPropertyCodeFixProvider.cs
浏览文件 @
0f8eda3d
...
...
@@ -55,7 +55,7 @@ public sealed override Task RegisterCodeFixesAsync(CodeFixContext context)
context
.
RegisterCodeFix
(
new
UseAutoPropertyCodeAction
(
Feature
sResources
.
Use_auto_property
,
Analyzer
sResources
.
Use_auto_property
,
c
=>
ProcessResultAsync
(
context
,
diagnostic
,
c
),
priority
),
diagnostic
);
...
...
@@ -334,7 +334,7 @@ private async Task<SyntaxNode> FormatAsync(SyntaxNode newRoot, Document document
return
true
;
}
private
class
UseAutoPropertyCodeAction
:
C
odeAction
.
SolutionChangeAction
private
class
UseAutoPropertyCodeAction
:
C
ustomCodeActions
.
SolutionChangeAction
{
public
UseAutoPropertyCodeAction
(
string
title
,
Func
<
CancellationToken
,
Task
<
Solution
>>
createChangedSolution
,
CodeActionPriority
priority
)
:
base
(
title
,
createChangedSolution
,
title
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录