Move extension methods down to shared analyzer layer

src/Workspaces/SharedUtilitiesAndExtensions/Compiler/VisualBasic/Extensions/ExpressionSyntaxExtensions.vb

@@ -219,5 +219,127 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Extensions
                     Return OperatorPrecedence.PrecedenceNone
             End Select
         End Function
+
+        <Extension()>
+        Public Function IsInOutContext(expression As ExpressionSyntax) As Boolean
+            ' NOTE(cyrusn): VB has no concept of an out context.  Even when a parameter has an
+            ' '<Out>' attribute on it, it's still treated as ref by VB.  So we always return false
+            ' here.
+            Return False
+        End Function
+
+        <Extension()>
+        Public Function IsInRefContext(expression As ExpressionSyntax, semanticModel As SemanticModel, cancellationToken As CancellationToken) As Boolean
+            Dim simpleArgument = TryCast(expression?.Parent, SimpleArgumentSyntax)
+
+            If simpleArgument Is Nothing Then
+                Return False
+            ElseIf simpleArgument.IsNamed Then
+                Dim info = semanticModel.GetSymbolInfo(simpleArgument.NameColonEquals.Name, cancellationToken)
+
+                Dim parameter = TryCast(info.GetAnySymbol(), IParameterSymbol)
+                Return parameter IsNot Nothing AndAlso parameter.RefKind <> RefKind.None
+
+            Else
+                Dim argumentList = TryCast(simpleArgument.Parent, ArgumentListSyntax)
+
+                If argumentList IsNot Nothing Then
+                    Dim parent = argumentList.Parent
+                    Dim index = argumentList.Arguments.IndexOf(simpleArgument)
+
+                    Dim info = semanticModel.GetSymbolInfo(parent, cancellationToken)
+                    Dim symbol = info.GetAnySymbol()
+
+                    If TypeOf symbol Is IMethodSymbol Then
+                        Dim method = DirectCast(symbol, IMethodSymbol)
+                        If index < method.Parameters.Length Then
+                            Return method.Parameters(index).RefKind <> RefKind.None
+                        End If
+                    ElseIf TypeOf symbol Is IPropertySymbol Then
+                        Dim prop = DirectCast(symbol, IPropertySymbol)
+                        If index < prop.Parameters.Length Then
+                            Return prop.Parameters(index).RefKind <> RefKind.None
+                        End If
+                    End If
+                End If
+
+            End If
+
+            Return False
+        End Function
+
+        <Extension()>
+        Public Function IsInInContext(expression As ExpressionSyntax) As Boolean
+            ' NOTE: VB does not support in parameters. Always return False here.
+            Return False
+        End Function
+
+        <Extension()>
+        Public Function IsOnlyWrittenTo(expression As ExpressionSyntax) As Boolean
+            If expression.IsRightSideOfDot() Then
+                expression = TryCast(expression.Parent, ExpressionSyntax)
+            End If
+
+            If expression IsNot Nothing Then
+                If expression.IsInOutContext() Then
+                    Return True
+                End If
+
+                If expression.IsParentKind(SyntaxKind.SimpleAssignmentStatement) Then
+                    Dim assignmentStatement = DirectCast(expression.Parent, AssignmentStatementSyntax)
+                    If expression Is assignmentStatement.Left Then
+                        Return True
+                    End If
+                End If
+
+                If expression.IsParentKind(SyntaxKind.NameColonEquals) AndAlso
+                   expression.Parent.IsParentKind(SyntaxKind.SimpleArgument) Then
+
+                    ' <C(Prop:=1)>
+                    ' this is only a write to Prop
+                    Return True
+                End If
+
+                If expression.IsChildNode(Of NamedFieldInitializerSyntax)(Function(n) n.Name) Then
+                    Return True
+                End If
+
+                Return False
+            End If
+
+            Return False
+        End Function
+
+        <Extension()>
+        Public Function IsWrittenTo(expression As ExpressionSyntax, semanticModel As SemanticModel, cancellationToken As CancellationToken) As Boolean
+            If IsOnlyWrittenTo(expression) Then
+                Return True
+            End If
+
+            If expression.IsRightSideOfDot() Then
+                expression = TryCast(expression.Parent, ExpressionSyntax)
+            End If
+
+            If expression IsNot Nothing Then
+                If expression.IsInRefContext(semanticModel, cancellationToken) Then
+                    Return True
+                End If
+
+                If TypeOf expression.Parent Is AssignmentStatementSyntax Then
+                    Dim assignmentStatement = DirectCast(expression.Parent, AssignmentStatementSyntax)
+                    If expression Is assignmentStatement.Left Then
+                        Return True
+                    End If
+                End If
+
+                If expression.IsChildNode(Of NamedFieldInitializerSyntax)(Function(n) n.Name) Then
+                    Return True
+                End If
+
+                Return False
+            End If
+
+            Return False
+        End Function
     End Module
 End Namespace

src/Workspaces/SharedUtilitiesAndExtensions/Workspace/VisualBasic/Extensions/ExpressionSyntaxExtensions.vb

@@ -213,128 +213,6 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Extensions
                 DirectCast(expression, ObjectCreationExpressionSyntax).ArgumentList Is Nothing
         End Function
 
-        <Extension()>
-        Public Function IsInOutContext(expression As ExpressionSyntax) As Boolean
-            ' NOTE(cyrusn): VB has no concept of an out context.  Even when a parameter has an
-            ' '<Out>' attribute on it, it's still treated as ref by VB.  So we always return false
-            ' here.
-            Return False
-        End Function
-
-        <Extension()>
-        Public Function IsInRefContext(expression As ExpressionSyntax, semanticModel As SemanticModel, cancellationToken As CancellationToken) As Boolean
-            Dim simpleArgument = TryCast(expression?.Parent, SimpleArgumentSyntax)
-
-            If simpleArgument Is Nothing Then
-                Return False
-            ElseIf simpleArgument.IsNamed Then
-                Dim info = semanticModel.GetSymbolInfo(simpleArgument.NameColonEquals.Name, cancellationToken)
-
-                Dim parameter = TryCast(info.GetAnySymbol(), IParameterSymbol)
-                Return parameter IsNot Nothing AndAlso parameter.RefKind <> RefKind.None
-
-            Else
-                Dim argumentList = TryCast(simpleArgument.Parent, ArgumentListSyntax)
-
-                If argumentList IsNot Nothing Then
-                    Dim parent = argumentList.Parent
-                    Dim index = argumentList.Arguments.IndexOf(simpleArgument)
-
-                    Dim info = semanticModel.GetSymbolInfo(parent, cancellationToken)
-                    Dim symbol = info.GetAnySymbol()
-
-                    If TypeOf symbol Is IMethodSymbol Then
-                        Dim method = DirectCast(symbol, IMethodSymbol)
-                        If index < method.Parameters.Length Then
-                            Return method.Parameters(index).RefKind <> RefKind.None
-                        End If
-                    ElseIf TypeOf symbol Is IPropertySymbol Then
-                        Dim prop = DirectCast(symbol, IPropertySymbol)
-                        If index < prop.Parameters.Length Then
-                            Return prop.Parameters(index).RefKind <> RefKind.None
-                        End If
-                    End If
-                End If
-
-            End If
-
-            Return False
-        End Function
-
-        <Extension()>
-        Public Function IsInInContext(expression As ExpressionSyntax) As Boolean
-            ' NOTE: VB does not support in parameters. Always return False here.
-            Return False
-        End Function
-
-        <Extension()>
-        Public Function IsOnlyWrittenTo(expression As ExpressionSyntax) As Boolean
-            If expression.IsRightSideOfDot() Then
-                expression = TryCast(expression.Parent, ExpressionSyntax)
-            End If
-
-            If expression IsNot Nothing Then
-                If expression.IsInOutContext() Then
-                    Return True
-                End If
-
-                If expression.IsParentKind(SyntaxKind.SimpleAssignmentStatement) Then
-                    Dim assignmentStatement = DirectCast(expression.Parent, AssignmentStatementSyntax)
-                    If expression Is assignmentStatement.Left Then
-                        Return True
-                    End If
-                End If
-
-                If expression.IsParentKind(SyntaxKind.NameColonEquals) AndAlso
-                   expression.Parent.IsParentKind(SyntaxKind.SimpleArgument) Then
-
-                    ' <C(Prop:=1)>
-                    ' this is only a write to Prop
-                    Return True
-                End If
-
-                If expression.IsChildNode(Of NamedFieldInitializerSyntax)(Function(n) n.Name) Then
-                    Return True
-                End If
-
-                Return False
-            End If
-
-            Return False
-        End Function
-
-        <Extension()>
-        Public Function IsWrittenTo(expression As ExpressionSyntax, semanticModel As SemanticModel, cancellationToken As CancellationToken) As Boolean
-            If IsOnlyWrittenTo(expression) Then
-                Return True
-            End If
-
-            If expression.IsRightSideOfDot() Then
-                expression = TryCast(expression.Parent, ExpressionSyntax)
-            End If
-
-            If expression IsNot Nothing Then
-                If expression.IsInRefContext(semanticModel, cancellationToken) Then
-                    Return True
-                End If
-
-                If TypeOf expression.Parent Is AssignmentStatementSyntax Then
-                    Dim assignmentStatement = DirectCast(expression.Parent, AssignmentStatementSyntax)
-                    If expression Is assignmentStatement.Left Then
-                        Return True
-                    End If
-                End If
-
-                If expression.IsChildNode(Of NamedFieldInitializerSyntax)(Function(n) n.Name) Then
-                    Return True
-                End If
-
-                Return False
-            End If
-
-            Return False
-        End Function
-
         <Extension()>
         Public Function IsMeMyBaseOrMyClass(expression As ExpressionSyntax) As Boolean
             If expression Is Nothing Then