- 29 4月, 2019 31 次提交
-
-
由 Stan Hu 提交于
-
由 Stan Hu 提交于
In Rails 5, including `ActionView::Context` can have a significant and hidden performance penalty because this module also includes `ActionView::CompiledTemplates`. This means that any module that includes ActionView::Context becomes a descendant of `CompiledTemplates`. When a partial is rendered for the first time, it runs `ActionView::CompiledTemplates#module_eval`, which will evaluate a string that defines a new method for that partial. For example, the source of partial might be this string: ``` def _app_views_project_show_html_haml___12345(local_assigns, output) "hello world" end ``` When this string is evaluated, the Ruby interpreter will define the method and clear the global method cache for all descendants of `ActionView::CompiledTemplates`. Previous to this change, we inadvertently made a number of modules fall into this category: * GroupChildEntity * NoteUserEntity * Notify * MergeRequestUserEntity * AnalyticsCommitEntity * CommitEntity * UserEntity * Kaminari::Helpers::Paginator * CurrentUserEntity * ActionView::Base * ActionDispatch::DebugExceptions::DebugView * MarkupHelper * MergeRequestPresenter After this change: * Kaminari::Helpers::Paginator * ActionView::Base * ActionDispatch::DebugExceptions::DebugView Each time a partial is rendered for the first time, all methods for those modules will have to be redefined. This can exact a significant performance penalty. How bad is this penalty? Using the following benchmark script, we can use DTrace to sample the Ruby interpreter: ``` Benchmark.bm do |x| x.report do 1000.times do ActionView::CompiledTemplates.module_eval("def testme\nend") end end end ``` This revealed a 11x jump in the time spent in `core#define_method` alone. Rails 6 fixes this behavior by moving the `include CompiledTemplates` into ActionView::Base so that including `ActionView::Context` doesn't quietly affect other modules in this way. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11198
-
由 Marcia Ramos 提交于
Fix text based on example See merge request gitlab-org/gitlab-ce!27787
-
由 Evan Read 提交于
-
由 James Lopez 提交于
Fix links to wiki pages with subdirectories in search Closes #56234 See merge request gitlab-org/gitlab-ce!27400
-
由 khm 提交于
This commit contains the patch suggested by @fjsanpedro in the issue covering broken links in wiki search results. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/56234
-
由 Kushal Pandya 提交于
Upgrade CI images to use Chrome V73 See merge request gitlab-org/gitlab-ce!27762
-
由 Douwe Maan 提交于
Port changes for design management to CE See merge request gitlab-org/gitlab-ce!27555
-
由 Douwe Maan 提交于
Resolve "Deployment jobs broken as of 11.10.0" Closes #60821 See merge request gitlab-org/gitlab-ce!27687
-
由 Sanad Liaquat 提交于
Fix GitHub oAuth test Closes gitlab-org/quality/nightly#98 See merge request gitlab-org/gitlab-ce!27736
-
由 Douwe Maan 提交于
Load environment metrics only for JSON endpoint See merge request gitlab-org/gitlab-ce!27743
-
由 Peter Leitzen 提交于
When showing the HTML version of the environment metrics we don't need to fetch their metrics because we don't use them anymore on the HTML version. We use additional_metrics.json endpoint now.
-
由 Marcia Ramos 提交于
Avoid links requiring permissions Closes #59653 See merge request gitlab-org/gitlab-ce!27797
-
由 Evan Read 提交于
-
由 Filipa Lacerda 提交于
Init MR Popovers on system note mounted Closes #60855 See merge request gitlab-org/gitlab-ce!27747
-
由 Sean McGivern 提交于
Fix Profiler to work with Rails 5.1 Closes #61051 See merge request gitlab-org/gitlab-ce!27774
-
由 Ash McKenzie 提交于
Add gitaly session id & catfile-cache feature flag See merge request gitlab-org/gitlab-ce!27472
-
由 John Cai 提交于
-
由 Ash McKenzie 提交于
Quarantine failing test See merge request gitlab-org/gitlab-ce!27799
-
由 Bob Van Landuyt 提交于
This ports the changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10462/ to CE
-
由 Mark Lapierre 提交于
-
由 Heinrich Lee Yu 提交于
-
由 Evan Read 提交于
Add email clarification See merge request gitlab-org/gitlab-ce!27645
-
由 Cynthia Ng 提交于
-
由 Evan Read 提交于
Add clarification on namespace creation See merge request gitlab-org/gitlab-ce!27772
-
由 Evan Read 提交于
fix include example See merge request gitlab-org/gitlab-ce!27571
-
由 Evan Read 提交于
Docs: Environments Documentation review See merge request gitlab-org/gitlab-ce!27215
-
由 Marcel Amirault 提交于
-
由 Evan Read 提交于
Merge branch 'docs/60785-docs-feedback-masked-variables-is-not-clear-what-unescaped-characters-means' into 'master' Clarify masked variables docs Closes #60785 See merge request gitlab-org/gitlab-ce!27580
-
由 Steve Azzopardi 提交于
- Add note that must contain only letters, numbers, underscore - Add example of escape characters - Add regex used for validation closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60785
-
- 28 4月, 2019 4 次提交
-
-
由 Kamil Trzciński 提交于
Resolve "Masked Variable still printed in log output on gitlab.com" Closes #60945 See merge request gitlab-org/gitlab-ce!27768
-
由 Stan Hu 提交于
-
由 Stan Hu 提交于
Attempt to solve issues such as https://gitlab.com/gitlab-org/gitlab-ce/issues/60953.
-
由 Grzegorz Bizon 提交于
Create dashboards endpoint & setup dashboard post-processing Closes #60383 See merge request gitlab-org/gitlab-ce!27405
-
- 27 4月, 2019 5 次提交
-
-
由 Ramya Authappan 提交于
Refactor quarantine helper See merge request gitlab-org/gitlab-ce!27766
-
由 Stan Hu 提交于
Admin instance level settings for pages Let's Encrypt See merge request gitlab-org/gitlab-ce!27361
-
由 Vladimir Shushlin 提交于
Store Let's Encrypt account email in application settings Also add explicit terms of service consent
-
由 Stan Hu 提交于
Ruby 5.1 now requires keyword arguments to pass along parameters and headers for ActionDispatch::Integration::RequestHelpers. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61051
-
Deployment Chat Notifications See merge request gitlab-org/gitlab-ce!27338
-