Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
fad99d93
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
fad99d93
编写于
4月 27, 2019
作者:
S
Stan Hu
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Add Rubocop rule to ban include ActionView::Context
上级
b02458ef
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
77 addition
and
0 deletion
+77
-0
rubocop/cop/include_action_view_context.rb
rubocop/cop/include_action_view_context.rb
+31
-0
rubocop/rubocop.rb
rubocop/rubocop.rb
+1
-0
spec/rubocop/cop/include_action_view_context_spec.rb
spec/rubocop/cop/include_action_view_context_spec.rb
+45
-0
未找到文件。
rubocop/cop/include_action_view_context.rb
0 → 100644
浏览文件 @
fad99d93
# frozen_string_literal: true
require_relative
'../spec_helpers'
module
RuboCop
module
Cop
# Cop that makes sure workers include `::Gitlab::ActionViewOutput::Context`, not `ActionView::Context`.
class
IncludeActionViewContext
<
RuboCop
::
Cop
::
Cop
include
SpecHelpers
MSG
=
'Include `::Gitlab::ActionViewOutput::Context`, not `ActionView::Context`, for Rails 5.'
.
freeze
def_node_matcher
:includes_action_view_context?
,
<<~
PATTERN
(send nil? :include (const (const nil? :ActionView) :Context))
PATTERN
def
on_send
(
node
)
return
if
in_spec?
(
node
)
return
unless
includes_action_view_context?
(
node
)
add_offense
(
node
.
arguments
.
first
,
location: :expression
)
end
def
autocorrect
(
node
)
lambda
do
|
corrector
|
corrector
.
replace
(
node
.
source_range
,
'::Gitlab::ActionViewOutput::Context'
)
end
end
end
end
end
rubocop/rubocop.rb
浏览文件 @
fad99d93
...
...
@@ -4,6 +4,7 @@ require_relative 'cop/gitlab/predicate_memoization'
require_relative
'cop/gitlab/httparty'
require_relative
'cop/gitlab/finder_with_find_by'
require_relative
'cop/gitlab/union'
require_relative
'cop/include_action_view_context'
require_relative
'cop/include_sidekiq_worker'
require_relative
'cop/safe_params'
require_relative
'cop/active_record_association_reload'
...
...
spec/rubocop/cop/include_action_view_context_spec.rb
0 → 100644
浏览文件 @
fad99d93
# frozen_string_literal: true
require
'spec_helper'
require
'rubocop'
require
'rubocop/rspec/support'
require_relative
'../../../rubocop/cop/include_action_view_context'
describe
RuboCop
::
Cop
::
IncludeActionViewContext
do
include
CopHelper
subject
(
:cop
)
{
described_class
.
new
}
context
'when `ActionView::Context` is included'
do
let
(
:source
)
{
'include ActionView::Context'
}
let
(
:correct_source
)
{
'include ::Gitlab::ActionViewOutput::Context'
}
it
'registers an offense'
do
inspect_source
(
source
)
aggregate_failures
do
expect
(
cop
.
offenses
.
size
).
to
eq
(
1
)
expect
(
cop
.
offenses
.
map
(
&
:line
)).
to
eq
([
1
])
expect
(
cop
.
highlights
).
to
eq
([
'ActionView::Context'
])
end
end
it
'autocorrects to the right version'
do
autocorrected
=
autocorrect_source
(
source
)
expect
(
autocorrected
).
to
eq
(
correct_source
)
end
end
context
'when `ActionView::Context` is not included'
do
it
'registers no offense'
do
inspect_source
(
'include Context'
)
aggregate_failures
do
expect
(
cop
.
offenses
.
size
).
to
eq
(
0
)
end
end
end
end
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录