1. 07 8月, 2016 1 次提交
  2. 29 7月, 2016 2 次提交
    • T
      Use `Gitlab::Access` to protected branch access levels. · 0a8aeb46
      Timothy Andrew 提交于
      1. It makes sense to reuse these constants since we had them duplicated
         in the previous enum implementation. This also simplifies our
         `check_access` implementation, because we can use
         `project.team.max_member_access` directly.
      
      2. Use `accepts_nested_attributes_for` to create push/merge access
         levels. This was a bit fiddly to set up, but this simplifies our code
         by quite a large amount. We can even get rid of
         `ProtectedBranches::BaseService`.
      
      3. Move API handling back into the API (previously in
         `ProtectedBranches::BaseService#translate_api_params`.
      
      4. The protected branch services now return a `ProtectedBranch` rather
         than `true/false`.
      
      5. Run `load_protected_branches` on-demand in the `create` action, to
         prevent it being called unneccessarily.
      
      6. "Masters" is pre-selected as the default option for "Allowed to Push"
         and "Allowed to Merge".
      
      7. These changes were based on a review from @rymai in !5081.
      0a8aeb46
    • T
      Have the `branches` API work with the new protected branches data model. · 01d190a8
      Timothy Andrew 提交于
      1. The new data model moves from `developers_can_{push,merge}` to
         `allowed_to_{push,merge}`.
      
      2. The API interface has not been changed. It still accepts
         `developers_can_push` and `developers_can_merge` as options. These
         attributes are inferred from the new data model.
      
      3. Modify the protected branch create/update services to translate from
         the API interface to our current data model.
      01d190a8
  3. 28 7月, 2016 1 次提交
  4. 19 7月, 2016 5 次提交
  5. 13 7月, 2016 1 次提交
  6. 12 7月, 2016 9 次提交
  7. 11 7月, 2016 1 次提交
  8. 08 7月, 2016 4 次提交
  9. 07 7月, 2016 2 次提交
  10. 06 7月, 2016 1 次提交
  11. 01 7月, 2016 5 次提交
  12. 30 6月, 2016 1 次提交
  13. 21 6月, 2016 2 次提交
  14. 18 6月, 2016 1 次提交
  15. 17 6月, 2016 1 次提交
  16. 16 6月, 2016 2 次提交
  17. 14 6月, 2016 1 次提交
    • R
      UI and copywriting improvements · 515205d3
      Rémy Coutable 提交于
      + Move 'Edit Project/Group' out of membership-related partial
      + Show the access request buttons only to logged-in users
      + Put the request access buttons out of in a more visible button
      + Improve the copy in the #remove_member_message helper
      Signed-off-by: NRémy Coutable <remy@rymai.me>
      515205d3