Skip to content

G
gitlab-foss

李少辉-开发者 / gitlab-foss

通知 15
Star 0
Fork 0
G
gitlab-foss

体验新版 GitCode，发现更多精彩内容 >>

切换分支/标签
  1. 10 8月, 2016 1 次提交
    • Y
      Remove trigram indexes for "ci_runners" · 17dd3e89
      由 Yorick Peterse 提交于 
      These indexes are only used when you search for runners in the admin
interface. This operation is so rarely used that it does not make sense
to slow down every update in order to update the GIN trigram indexes.

Removing these indexes should speed up queries such as those used for
updating the last contact time of CI runners. Locally the timings of
this query were reduced from ~50 ms to ~25 ms:

    UPDATE ci_runners SET updated_at = now(), contacted_at = now();
      17dd3e89
  3. 04 8月, 2016 2 次提交
  5. 29 7月, 2016 4 次提交
    • Z
      Incorporate feedback · 76e9b684
      由 Z.J. van de Weg 提交于
      76e9b684
    • Z
      Add an URL field to Environments · be9aa7f1
      由 Z.J. van de Weg 提交于 
      This MR adds a string (thus max 255 chars) field to the enviroments
table to expose it later in other features.
      be9aa7f1
    • T
      Use `Gitlab::Access` to protected branch access levels. · 0a8aeb46
      由 Timothy Andrew 提交于 
      1. It makes sense to reuse these constants since we had them duplicated
   in the previous enum implementation. This also simplifies our
   `check_access` implementation, because we can use
   `project.team.max_member_access` directly.

2. Use `accepts_nested_attributes_for` to create push/merge access
   levels. This was a bit fiddly to set up, but this simplifies our code
   by quite a large amount. We can even get rid of
   `ProtectedBranches::BaseService`.

3. Move API handling back into the API (previously in
   `ProtectedBranches::BaseService#translate_api_params`.

4. The protected branch services now return a `ProtectedBranch` rather
   than `true/false`.

5. Run `load_protected_branches` on-demand in the `create` action, to
   prevent it being called unneccessarily.

6. "Masters" is pre-selected as the default option for "Allowed to Push"
   and "Allowed to Merge".

7. These changes were based on a review from @rymai in !5081.
      0a8aeb46
    • T
      Add a series of migrations changing the model-level design of protected branch access levels. · f1e46d1e
      由 Timothy Andrew 提交于 
      1. Remove the `developers_can_push` and `developers_can_merge` boolean
   columns.

2. Add two new tables, `protected_branches_push_access`, and
   `protected_branches_merge_access`. Each row of these 'access' tables is
   linked to a protected branch, and uses a `access_level` column to
   figure out settings for the protected branch.

3. The `access_level` column is intended to be used with rails' `enum`,
   with `:masters` at index 0 and `:developers` at index 1.

4. Doing it this way has a few advantages:

   - Cleaner path to planned EE features where a protected branch is
     accessible only by certain users or groups.

   - Rails' `enum` doesn't allow a declaration like this due to the
     duplicates. This approach doesn't have this problem.

       enum can_be_pushed_by: [:masters, :developers]
       enum can_be_merged_by: [:masters, :developers]
      f1e46d1e
  7. 27 7月, 2016 1 次提交
  9. 21 7月, 2016 1 次提交
  11. 20 7月, 2016 4 次提交
  13. 19 7月, 2016 3 次提交
  15. 18 7月, 2016 2 次提交
  17. 17 7月, 2016 1 次提交
  19. 15 7月, 2016 2 次提交
  21. 14 7月, 2016 2 次提交
  23. 13 7月, 2016 4 次提交
  25. 08 7月, 2016 1 次提交
    • D
      Added setting to set new users by default as external · a0a9494e
      由 Dravere 提交于 
      As requested by the issue #14508 this adds an option in the application
settings to set newly registered users by default as external. The
default setting is set to false to stay backward compatible.
      a0a9494e
  27. 07 7月, 2016 1 次提交
  29. 06 7月, 2016 3 次提交
  31. 05 7月, 2016 1 次提交
  33. 30 6月, 2016 2 次提交
  35. 28 6月, 2016 1 次提交
  37. 20 6月, 2016 3 次提交
  39. 16 6月, 2016 1 次提交