1. 02 9月, 2019 1 次提交
  2. 27 8月, 2019 1 次提交
    • O
      Avoid exposing unaccessible repo data upon GFM processing · 9dde7259
      Oswaldo Ferreira 提交于
      When post-processing relative links to absolute links
      RelativeLinkFilter didn't take into consideration that
      internal repository data could be exposed for users
      that do not have repository access to the project.
      
      This commit solves that by checking whether the user
      can `download_code` at this repository, avoiding any
      processing of this filter if the user can't.
      
      Additionally, if we're processing for a group (
      no project was given), we check if the user can
      read it in order to expand the href as an extra.
      That doesn't seem necessarily a breach now,
      but an extra check doesn't hurt as after all
      the user needs to be able to `read_group`.
      9dde7259
  3. 29 6月, 2019 1 次提交
    • S
      Fix attachments using the wrong URLs in e-mails · 0e341a6e
      Stan Hu 提交于
      Prior to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29889,
      only the project context were set for the Markdown renderer. For a note
      on an issuable, the group context was set to `nil` because
      `note.noteable.try(:group)` attempted to get the issuable's group, which
      doesn't exist.
      
      To make group notifications work, now both the project and group context
      are set. The context gets passed to `RelativeLinkFilter`, which
      previously assumed that it wasn't possible to have both a group and a
      project in the Markdown context. However, if a group were defined, it
      would take precedence, and the URL rendered for uploads would be
      `/group/-/uploads` instead of `/group/project/uploads/`. This led to
      404s in e-mails.
      
      However, now that we have both project and group in the context, we
      render the Markdown giving priority to the project context if is set.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63910
      0e341a6e
  4. 21 6月, 2019 1 次提交
  5. 14 6月, 2019 1 次提交
  6. 09 4月, 2019 1 次提交
  7. 22 2月, 2019 1 次提交
    • Z
      Only allow 30 RPCs per test case to Gitaly · c00a1ec0
      Zeger-Jan van de Weg 提交于
      Prior to this change, 35 Gitaly RPCs were allowed. But recently there's
      been a renewed interest in performance. By lowering the number of
      calls new N + 1's will pop up.
      
      Later commits will add blocks to ignore the raised errors, followed by
      an issue for each to be fixed.
      c00a1ec0
  8. 23 1月, 2019 1 次提交
  9. 29 9月, 2018 1 次提交
  10. 23 7月, 2018 1 次提交
    • S
      Enable frozen strings in lib/banzai/filter/*.rb · 8b4154b5
      Stan Hu 提交于
      Excludes a few filters that require more work:
      
      * lib/banzai/filter/image_lazy_load_filter_spec.rb
      * lib/banzai/filter/syntax_highlight_filter_spec.rb
      * lib/banzai/filter/table_of_contents_filter_spec.rb
      
      Part of #47424
      8b4154b5
  11. 12 3月, 2018 1 次提交
  12. 19 1月, 2018 1 次提交
  13. 11 1月, 2018 1 次提交
  14. 23 12月, 2017 1 次提交
    • S
      Gracefully handle garbled URIs in Markdown · 0faf772b
      Stan Hu 提交于
      There are certain inputs that look like valid URIs that are accepted by URI
      but not Addressable::URI. Handle the case where the latter fails.
      
      Closes #41442
      0faf772b
  15. 22 12月, 2017 1 次提交
  16. 01 8月, 2017 1 次提交
  17. 25 7月, 2017 1 次提交
  18. 12 12月, 2016 1 次提交
  19. 25 10月, 2016 1 次提交
  20. 05 8月, 2016 1 次提交
  21. 03 8月, 2016 1 次提交
  22. 02 8月, 2016 1 次提交
  23. 26 7月, 2016 1 次提交
  24. 20 7月, 2016 1 次提交
  25. 21 6月, 2016 1 次提交
    • A
      Optimize Banzai::Filter::RelativeLinkFilter · ca696175
      Alejandro Rodríguez 提交于
          A lot of git operations were being repeated, for example, to build a url
          you would ask if the path was a Tree, which would call a recursive routine
          in Gitlab::Git::Tree#where, then ask if the path was a Blob, which would
          call a recursive routine at Gitlab::Git::Blob#find, making reference to
          the same git objects several times. Now we call Rugged::Tree#path, which
          allows us to determine the type of the path in one pass.
      
          Some other minor improvement added, like saving commonly used references
          instead of calculating them each time.
      ca696175
  26. 25 3月, 2016 1 次提交
  27. 14 1月, 2016 1 次提交
  28. 31 12月, 2015 1 次提交
  29. 15 12月, 2015 1 次提交
  30. 19 11月, 2015 1 次提交
  31. 15 11月, 2015 1 次提交
  32. 15 10月, 2015 1 次提交
  33. 21 9月, 2015 1 次提交
  34. 19 9月, 2015 1 次提交
  35. 28 8月, 2015 1 次提交
  36. 31 7月, 2015 1 次提交
  37. 27 7月, 2015 1 次提交
  38. 14 5月, 2015 1 次提交
  39. 12 5月, 2015 1 次提交
  40. 11 5月, 2015 1 次提交