1. 02 9月, 2019 1 次提交
  2. 30 8月, 2019 2 次提交
    • S
      Merge branch 'fix-migration-helper' into 'master' · bb58d4cd
      Stan Hu 提交于
      Add helpers to exactly undo cleanup_concurrent_column_rename
      
      See merge request gitlab-org/gitlab-ce!32183
      
      (cherry picked from commit fc08d48c)
      
      9b592a59 Add helper to exactly undo cleanup_concurrent_column_rename
      61777843 Add spec for undo_rename_column_concurrently
      d28ad870 Add spec for when default is false
      bb58d4cd
    • M
      Merge branch 'sh-fix-nplusone-issues' into 'master' · d074658a
      Mayra Cabrera 提交于
      Fix N+1 Gitaly calls in /api/v4/projects/:id/issues
      
      See merge request gitlab-org/gitlab-ce!32171
      
      (cherry picked from commit bbd39021)
      
      44063501 Fix N+1 Gitaly calls in /api/v4/projects/:id/issues
      d074658a
  3. 27 8月, 2019 1 次提交
    • O
      Avoid exposing unaccessible repo data upon GFM processing · 9dde7259
      Oswaldo Ferreira 提交于
      When post-processing relative links to absolute links
      RelativeLinkFilter didn't take into consideration that
      internal repository data could be exposed for users
      that do not have repository access to the project.
      
      This commit solves that by checking whether the user
      can `download_code` at this repository, avoiding any
      processing of this filter if the user can't.
      
      Additionally, if we're processing for a group (
      no project was given), we check if the user can
      read it in order to expand the href as an extra.
      That doesn't seem necessarily a breach now,
      but an extra check doesn't hurt as after all
      the user needs to be able to `read_group`.
      9dde7259
  4. 26 8月, 2019 1 次提交
  5. 23 8月, 2019 3 次提交
  6. 22 8月, 2019 1 次提交
  7. 21 8月, 2019 2 次提交
    • M
      Add captcha if there are multiple failed login attempts · 46e55735
      Małgorzata Ksionek 提交于
      Add method to store session ids by ip
      
      Add new specs for storing session ids
      
      Add cleaning up records after login
      
      Add retrieving anonymous sessions
      
      Add login recaptcha setting
      
      Add new setting to sessions controller
      
      Add conditions for showing captcha
      
      Add sessions controller specs
      
      Add admin settings specs for login protection
      
      Add new settings to api
      
      Add stub to devise spec
      
      Add new translation key
      
      Add cr remarks
      
      Rename class call
      
      Add cr remarks
      
      Change if-clause for consistency
      
      Add cr remarks
      
      Add code review remarks
      
      Refactor AnonymousSession class
      
      Add changelog entry
      
      Move AnonymousSession class to lib
      
      Move store unauthenticated sessions to sessions controller
      
      Move link to recaptcha info
      
      Regenerate text file
      
      Improve copy on the spam page
      
      Change action filter for storing anonymous sessions
      
      Fix rubocop offences
      
      Add code review remarks
      46e55735
    • F
      Add active_jobs_limit to plans table · f8edf116
      Fabio Pitino 提交于
      This is a port from EE changes where
      we introduce a new limit for Plan model.
      
      https://dev.gitlab.org/gitlab/gitlab-ee/merge_requests/1182
      f8edf116
  8. 20 8月, 2019 1 次提交
  9. 19 8月, 2019 3 次提交
  10. 17 8月, 2019 3 次提交
  11. 16 8月, 2019 5 次提交
  12. 15 8月, 2019 8 次提交
  13. 14 8月, 2019 5 次提交
  14. 13 8月, 2019 4 次提交
    • K
      Require `needs:` to be present · 93e95182
      Kamil Trzciński 提交于
      This changes the `needs:` logic to require
      that all jobs to be present. Instead of skipping
      do fail the pipeline creation if `needs:` dependency
      is not found.
      93e95182
    • K
      Require `stage:` to be set with `needs:` · 583544d0
      Kamil Trzciński 提交于
      Since we are unsure what would be the behavior of `stage:`
      when we work on DAG. Let's make `stage:` to be required
      today with `needs:`.
      583544d0
    • G
      Upgrade Gitaly to v1.59.0 · 3c5647bd
      GitalyBot 提交于
      3c5647bd
    • S
      Reduce Gitaly calls in PostReceive · 4e2bb4e5
      Stan Hu 提交于
      This commit reduces I/O load and memory utilization during PostReceive
      for the common case when no project hooks or services are set up.
      
      We saw a Gitaly N+1 issue in `CommitDelta` when many tags or branches
      are pushed. We can reduce this overhead in the common case because we
      observe that most new projects do not have any Web hooks or services,
      especially when they are first created. Previously, `BaseHooksService`
      unconditionally iterated through the last 20 commits of each ref to
      build the `push_data` structure. The `push_data` structured was used in
      numerous places:
      
      1. Building the push payload in `EventCreateService`
      2. Creating a CI pipeline
      3. Executing project Web or system hooks
      4. Executing project services
      5. As the return value of `BaseHooksService#execute`
      6. `BranchHooksService#invalidated_file_types`
      
      We only need to generate the full `push_data` for items 3, 4, and 6.
      
      Item 1: `EventCreateService` only needs the last commit and doesn't
      actually need the commit deltas.
      
      Item 2: In addition, `Ci::CreatePipelineService` only needed a subset of
      the parameters.
      
      Item 5: The return value of `BaseHooksService#execute` also wasn't being
      used anywhere.
      
      Item 6: This is only used when pushing to the default branch, so if
      many tags are pushed we can save significant I/O here.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65878
      
      Fic
      4e2bb4e5