- 19 7月, 2016 3 次提交
-
-
由 Kamil Trzcinski 提交于
-
由 James Lopez 提交于
WIP - trying to replicate UTF-8 error fix spec fixing encoding issue and another spec, to do with MR diffs fix issue and spec failure Add changelog and bumped up I/E version fix spec based on feedback - omitted target project
-
由 Valery Sizov 提交于
-
- 18 7月, 2016 10 次提交
-
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
Manual actions are accessible from: - Pipelines - Builds - Environments - Deployments
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
由 ubudzisz 提交于
add git-commit-title-method into tests
-
由 Rémy Coutable 提交于
This reverts commit 530f5158. See !4892. Signed-off-by: NRémy Coutable <remy@rymai.me>
-
由 James Lopez 提交于
-
由 Stan Hu 提交于
preventing settings from being saved
-
- 17 7月, 2016 1 次提交
-
-
由 Kamil Trzcinski 提交于
-
- 16 7月, 2016 6 次提交
-
-
由 Kamil Trzcinski 提交于
-
由 Felipe Artur 提交于
-
由 Douwe Maan 提交于
-
由 Douwe Maan 提交于
-
-
-
- 15 7月, 2016 2 次提交
-
-
由 Kamil Trzcinski 提交于
-
由 Kamil Trzcinski 提交于
-
- 14 7月, 2016 4 次提交
-
-
由 dixpac 提交于
* There where path where +1 was stored as +1 not as thumbsup that was causing problems such as showing thumbsup icon 2 time. I fixed this to always normalize and store +1 as tumbsup
-
-
由 Robert Speicher 提交于
This reverts commit 9ca633eb, reversing changes made to fb229bbf.
-
- 13 7月, 2016 14 次提交
-
-
-
-
-
-
由 James Lopez 提交于
-
由 James Lopez 提交于
-
由 Timothy Andrew 提交于
1. If they are a developer with "Developers can Merge" switched on.
-
由 Timothy Andrew 提交于
1. Don't use case statements for dispatch anymore. This leads to a lot of duplication, and makes the logic harder to follow. 2. Remove duplicated logic. - For example, the `can_push_to_branch?` exists, but we also have a different way of checking the same condition within `change_access_check`. - This kind of duplication is removed, and the `can_push_to_branch?` method is used in both places. 3. Move checks returning true/false to `UserAccess`. - All public methods in `GitAccess` now return an instance of `GitAccessStatus`. Previously, some methods would return true/false as well, which was confusing. - It makes sense for these kinds of checks to be at the level of a user, so the `UserAccess` class was repurposed for this. The prior `UserAccess.allowed?` classmethod is converted into an instance method. - All external uses of these checks have been migrated to use the `UserAccess` class 4. Move the "change_access_check" into a separate class. - Create the `GitAccess::ChangeAccessCheck` class to run these checks, which are quite substantial. - `ChangeAccessCheck` returns an instance of `GitAccessStatus` as well. 5. Break out the boolean logic in `ChangeAccessCheck` into `if/else` chains - this seems more readable. 6. I can understand that this might look like overkill for !4892, but I think this is a good opportunity to clean it up. - http://martinfowler.com/bliki/OpportunisticRefactoring.html
-
由 Timothy Andrew 提交于
1. When a merge request is being merged, save the merge commit SHA in the `in_progress_merge_commit_sha` database column. 2. The `pre-receive` hook looks for any locked (in progress) merge request with `in_progress_merge_commit_sha` matching the `newrev` it is passed. 3. If it finds a matching MR, the merge is legitimate. 4. Update `git_access_spec` to test the behaviour we added here. Also refactored this spec a bit to make it easier to add more contexts / conditions.
-
由 Mathias Vestergaard 提交于
- Cherry-picked from `mvestergaard:branch-protection-dev-merge` - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4220
-
由 James Lopez 提交于
-
由 Sean McGivern 提交于
-
由 Sean McGivern 提交于
-
由 Valery Sizov 提交于
-