issuable_base_service.rb 10.2 KB
Newer Older
1 2 3 4
class IssuableBaseService < BaseService
  private

  def create_milestone_note(issuable)
5
    SystemNoteService.change_milestone(
6
      issuable, issuable.project, current_user, issuable.milestone)
7
  end
N
Nikita Verkhovin 已提交
8

9 10 11 12
  def create_labels_note(issuable, old_labels)
    added_labels = issuable.labels - old_labels
    removed_labels = old_labels - issuable.labels

13
    SystemNoteService.change_label(
N
Nikita Verkhovin 已提交
14 15
      issuable, issuable.project, current_user, added_labels, removed_labels)
  end
16 17 18 19 20

  def create_title_change_note(issuable, old_title)
    SystemNoteService.change_title(
      issuable, issuable.project, current_user, old_title)
  end
21

22 23 24 25
  def create_description_change_note(issuable)
    SystemNoteService.change_description(issuable, issuable.project, current_user)
  end

26 27 28 29 30
  def create_branch_change_note(issuable, branch_type, old_branch, new_branch)
    SystemNoteService.change_branch(
      issuable, issuable.project, current_user, branch_type,
      old_branch, new_branch)
  end
31

32 33 34 35 36 37
  def create_task_status_note(issuable)
    issuable.updated_tasks.each do |task|
      SystemNoteService.change_task_status(issuable, issuable.project, current_user, task)
    end
  end

38 39 40 41 42 43 44 45
  def create_time_estimate_note(issuable)
    SystemNoteService.change_time_estimate(issuable, issuable.project, current_user)
  end

  def create_time_spent_note(issuable)
    SystemNoteService.change_time_spent(issuable, issuable.project, current_user)
  end

46 47
  def filter_params(issuable)
    ability_name = :"admin_#{issuable.to_ability_name}"
48

49
    unless can?(current_user, ability_name, project)
50
      params.delete(:milestone_id)
51
      params.delete(:labels)
52 53
      params.delete(:add_label_ids)
      params.delete(:remove_label_ids)
54
      params.delete(:label_ids)
55
      params.delete(:assignee_ids)
56
      params.delete(:assignee_id)
57
      params.delete(:due_date)
58
      params.delete(:canonical_issue_id)
59
    end
60 61 62 63

    filter_assignee(issuable)
    filter_milestone
    filter_labels
64
  end
65

66 67 68 69 70 71 72 73 74
  def filter_assignee(issuable)
    return unless params[:assignee_id].present?

    assignee_id = params[:assignee_id]

    if assignee_id.to_s == IssuableFinder::NONE
      params[:assignee_id] = ""
    else
      params.delete(:assignee_id) unless assignee_can_read?(issuable, assignee_id)
75 76 77
    end
  end

78 79 80
  def assignee_can_read?(issuable, assignee_id)
    new_assignee = User.find_by_id(assignee_id)

81
    return false unless new_assignee
82 83 84 85 86 87 88

    ability_name = :"read_#{issuable.to_ability_name}"
    resource     = issuable.persisted? ? issuable : project

    can?(new_assignee, ability_name, resource)
  end

89
  def filter_milestone
90 91
    milestone_id = params[:milestone_id]
    return unless milestone_id
92

F
Felipe Artur 已提交
93 94 95 96 97 98
    params[:milestone_id] = '' if milestone_id == IssuableFinder::NONE

    milestone =
      Milestone.for_projects_and_groups([project.id], [project.group&.id]).find_by_id(milestone_id)

    params[:milestone_id] = '' unless milestone
99 100 101
  end

  def filter_labels
102 103 104
    filter_labels_in_param(:add_label_ids)
    filter_labels_in_param(:remove_label_ids)
    filter_labels_in_param(:label_ids)
105
    find_or_create_label_ids
106 107
  end

108 109
  def filter_labels_in_param(key)
    return if params[key].to_a.empty?
110

111
    params[key] = available_labels.where(id: params[key]).pluck(:id)
112 113
  end

114 115
  def find_or_create_label_ids
    labels = params.delete(:labels)
116

117 118
    return unless labels

119
    params[:label_ids] = labels.split(",").map do |label_name|
120
      service = Labels::FindOrCreateService.new(current_user, project, title: label_name.strip)
121
      label   = service.execute
122

123 124
      label.try(:id)
    end.compact
125 126
  end

127
  def process_label_ids(attributes, existing_label_ids: nil)
128 129 130
    label_ids = attributes.delete(:label_ids)
    add_label_ids = attributes.delete(:add_label_ids)
    remove_label_ids = attributes.delete(:remove_label_ids)
131

132
    new_label_ids = existing_label_ids || label_ids || []
133

134 135 136 137 138 139
    if add_label_ids.blank? && remove_label_ids.blank?
      new_label_ids = label_ids if label_ids
    else
      new_label_ids |= add_label_ids if add_label_ids
      new_label_ids -= remove_label_ids if remove_label_ids
    end
140 141 142 143

    new_label_ids
  end

144 145 146 147
  def available_labels
    LabelsFinder.new(current_user, project_id: @project.id).execute
  end

148
  def merge_quick_actions_into_params!(issuable)
D
Douwe Maan 已提交
149
    description, command_params =
150 151
      QuickActions::InterpretService.new(project, current_user)
        .execute(params[:description], issuable)
152

153
    # Avoid a description already set on an issuable to be overwritten by a nil
154
    params[:description] = description if params.key?(:description)
D
Douwe Maan 已提交
155 156

    params.merge!(command_params)
157 158
  end

159
  def create_issuable(issuable, attributes, label_ids:)
160
    issuable.with_transaction_returning_status do
161 162 163 164 165
      if issuable.save
        issuable.update_attributes(label_ids: label_ids)
      end
    end
  end
166

167
  def create(issuable)
168
    merge_quick_actions_into_params!(issuable)
169
    filter_params(issuable)
170

171 172
    params.delete(:state_event)
    params[:author] ||= current_user
173

174 175 176 177 178 179 180 181
    label_ids = process_label_ids(params)

    issuable.assign_attributes(params)

    before_create(issuable)

    if params.present? && create_issuable(issuable, params, label_ids: label_ids)
      after_create(issuable)
182
      execute_hooks(issuable)
183
      invalidate_cache_counts(issuable, users: issuable.assignees)
184 185 186 187
    end

    issuable
  end
188

189 190 191 192 193 194 195
  def before_create(issuable)
    # To be overridden by subclasses
  end

  def after_create(issuable)
    # To be overridden by subclasses
  end
196

197
  def before_update(issuable)
198 199 200
    # To be overridden by subclasses
  end

201 202
  def after_update(issuable)
    # To be overridden by subclasses
203 204
  end

205 206
  def update(issuable)
    change_state(issuable)
207
    change_subscription(issuable)
208
    change_todo(issuable)
M
mhasbini 已提交
209
    toggle_award(issuable)
210
    filter_params(issuable)
211
    old_labels = issuable.labels.to_a
212
    old_mentioned_users = issuable.mentioned_users.to_a
213
    old_assignees = issuable.assignees.to_a
214

215 216
    label_ids = process_label_ids(params, existing_label_ids: issuable.label_ids)
    params[:label_ids] = label_ids if labels_changing?(issuable.label_ids, label_ids)
217

218
    if issuable.changed? || params.present?
219 220
      issuable.assign_attributes(params.merge(updated_by: current_user))

221
      if has_title_or_description_changed?(issuable)
222
        issuable.assign_attributes(last_edited_at: Time.now, last_edited_by: current_user)
223 224
      end

225
      before_update(issuable)
226

227 228 229 230 231 232
      if issuable.with_transaction_returning_status { issuable.save }
        # We do not touch as it will affect a update on updated_at field
        ActiveRecord::Base.no_touching do
          handle_common_system_notes(issuable, old_labels: old_labels)
        end

233 234 235 236 237 238 239
        handle_changes(
          issuable,
          old_labels: old_labels,
          old_mentioned_users: old_mentioned_users,
          old_assignees: old_assignees
        )

240 241
        new_assignees = issuable.assignees.to_a
        affected_assignees = (old_assignees + new_assignees) - (old_assignees & new_assignees)
242

243 244 245
        # Don't clear the project cache, because it will be handled by the
        # appropriate service (close / reopen / merge / etc.).
        invalidate_cache_counts(issuable, users: affected_assignees.compact, skip_project_cache: true)
246 247 248 249
        after_update(issuable)
        issuable.create_new_cross_references!(current_user)
        execute_hooks(issuable, 'update')
      end
250 251 252 253 254
    end

    issuable
  end

255 256 257 258
  def labels_changing?(old_label_ids, new_label_ids)
    old_label_ids.sort != new_label_ids.sort
  end

259 260 261 262
  def has_title_or_description_changed?(issuable)
    issuable.title_changed? || issuable.description_changed?
  end

263 264 265 266 267 268 269 270
  def change_state(issuable)
    case params.delete(:state_event)
    when 'reopen'
      reopen_service.new(project, current_user, {}).execute(issuable)
    when 'close'
      close_service.new(project, current_user, {}).execute(issuable)
    end
  end
271

272 273 274
  def change_subscription(issuable)
    case params.delete(:subscription_event)
    when 'subscribe'
275
      issuable.subscribe(current_user, project)
276
    when 'unsubscribe'
277
      issuable.unsubscribe(current_user, project)
278 279 280
    end
  end

281 282
  def change_todo(issuable)
    case params.delete(:todo_event)
283
    when 'add'
284 285 286
      todo_service.mark_todo(issuable, current_user)
    when 'done'
      todo = TodosFinder.new(current_user).execute.find_by(target: issuable)
287
      todo_service.mark_todos_as_done_by_ids(todo, current_user) if todo
288 289 290
    end
  end

M
mhasbini 已提交
291 292 293 294 295 296 297 298
  def toggle_award(issuable)
    award = params.delete(:emoji_award)
    if award
      todo_service.new_award_emoji(issuable, current_user)
      issuable.toggle_award_emoji(award, current_user)
    end
  end

299
  def has_changes?(issuable, old_labels: [], old_assignees: [])
300 301 302 303 304 305
    valid_attrs = [:title, :description, :assignee_id, :milestone_id, :target_branch]

    attrs_changed = valid_attrs.any? do |attr|
      issuable.previous_changes.include?(attr.to_s)
    end

306
    labels_changed = issuable.labels != old_labels
307

308 309 310
    assignees_changed = issuable.assignees != old_assignees

    attrs_changed || labels_changed || assignees_changed
311 312
  end

313
  def handle_common_system_notes(issuable, old_labels: [])
314 315 316 317
    if issuable.previous_changes.include?('title')
      create_title_change_note(issuable, issuable.previous_changes['title'].first)
    end

318
    if issuable.previous_changes.include?('description')
319 320 321 322 323 324 325
      if issuable.tasks? && issuable.updated_tasks.any?
        create_task_status_note(issuable)
      else
        # TODO: Show this note if non-task content was modified.
        # https://gitlab.com/gitlab-org/gitlab-ce/issues/33577
        create_description_change_note(issuable)
      end
326
    end
327

328 329 330 331 332 333 334 335
    if issuable.previous_changes.include?('time_estimate')
      create_time_estimate_note(issuable)
    end

    if issuable.time_spent?
      create_time_spent_note(issuable)
    end

336
    create_labels_note(issuable, old_labels) if issuable.labels != old_labels
337
  end
338

339
  def invalidate_cache_counts(issuable, users: [], skip_project_cache: false)
340 341 342
    users.each do |user|
      user.public_send("invalidate_#{issuable.model_name.singular}_cache_counts")
    end
343 344 345 346 347 348 349 350 351

    unless skip_project_cache
      case issuable
      when Issue
        IssuesFinder.new(nil, project_id: issuable.project_id).clear_caches!
      when MergeRequest
        MergeRequestsFinder.new(nil, project_id: issuable.target_project_id).clear_caches!
      end
    end
352
  end
353
end