issuable_base_service.rb 10.3 KB
Newer Older
1 2 3 4
class IssuableBaseService < BaseService
  private

  def create_milestone_note(issuable)
F
Felipe Artur 已提交
5 6 7
    milestone = issuable.milestone
    return if milestone && milestone.is_group_milestone?

8
    SystemNoteService.change_milestone(
F
Felipe Artur 已提交
9
      issuable, issuable.project, current_user, milestone)
10
  end
N
Nikita Verkhovin 已提交
11

12 13 14 15
  def create_labels_note(issuable, old_labels)
    added_labels = issuable.labels - old_labels
    removed_labels = old_labels - issuable.labels

16
    SystemNoteService.change_label(
N
Nikita Verkhovin 已提交
17 18
      issuable, issuable.project, current_user, added_labels, removed_labels)
  end
19 20 21 22 23

  def create_title_change_note(issuable, old_title)
    SystemNoteService.change_title(
      issuable, issuable.project, current_user, old_title)
  end
24

25 26 27 28
  def create_description_change_note(issuable)
    SystemNoteService.change_description(issuable, issuable.project, current_user)
  end

29 30 31 32 33
  def create_branch_change_note(issuable, branch_type, old_branch, new_branch)
    SystemNoteService.change_branch(
      issuable, issuable.project, current_user, branch_type,
      old_branch, new_branch)
  end
34

35 36 37 38 39 40
  def create_task_status_note(issuable)
    issuable.updated_tasks.each do |task|
      SystemNoteService.change_task_status(issuable, issuable.project, current_user, task)
    end
  end

41 42 43 44 45 46 47 48
  def create_time_estimate_note(issuable)
    SystemNoteService.change_time_estimate(issuable, issuable.project, current_user)
  end

  def create_time_spent_note(issuable)
    SystemNoteService.change_time_spent(issuable, issuable.project, current_user)
  end

49 50
  def filter_params(issuable)
    ability_name = :"admin_#{issuable.to_ability_name}"
51

52
    unless can?(current_user, ability_name, project)
53
      params.delete(:milestone_id)
54
      params.delete(:labels)
55 56
      params.delete(:add_label_ids)
      params.delete(:remove_label_ids)
57
      params.delete(:label_ids)
58
      params.delete(:assignee_ids)
59
      params.delete(:assignee_id)
60
      params.delete(:due_date)
61
      params.delete(:canonical_issue_id)
62
    end
63 64 65 66

    filter_assignee(issuable)
    filter_milestone
    filter_labels
67
  end
68

69 70 71 72 73 74 75 76 77
  def filter_assignee(issuable)
    return unless params[:assignee_id].present?

    assignee_id = params[:assignee_id]

    if assignee_id.to_s == IssuableFinder::NONE
      params[:assignee_id] = ""
    else
      params.delete(:assignee_id) unless assignee_can_read?(issuable, assignee_id)
78 79 80
    end
  end

81 82 83
  def assignee_can_read?(issuable, assignee_id)
    new_assignee = User.find_by_id(assignee_id)

84
    return false unless new_assignee
85 86 87 88 89 90 91

    ability_name = :"read_#{issuable.to_ability_name}"
    resource     = issuable.persisted? ? issuable : project

    can?(new_assignee, ability_name, resource)
  end

92
  def filter_milestone
93 94
    milestone_id = params[:milestone_id]
    return unless milestone_id
95

F
Felipe Artur 已提交
96 97 98 99 100 101
    params[:milestone_id] = '' if milestone_id == IssuableFinder::NONE

    milestone =
      Milestone.for_projects_and_groups([project.id], [project.group&.id]).find_by_id(milestone_id)

    params[:milestone_id] = '' unless milestone
102 103 104
  end

  def filter_labels
105 106 107
    filter_labels_in_param(:add_label_ids)
    filter_labels_in_param(:remove_label_ids)
    filter_labels_in_param(:label_ids)
108
    find_or_create_label_ids
109 110
  end

111 112
  def filter_labels_in_param(key)
    return if params[key].to_a.empty?
113

114
    params[key] = available_labels.where(id: params[key]).pluck(:id)
115 116
  end

117 118
  def find_or_create_label_ids
    labels = params.delete(:labels)
119

120 121
    return unless labels

122
    params[:label_ids] = labels.split(",").map do |label_name|
123
      service = Labels::FindOrCreateService.new(current_user, project, title: label_name.strip)
124
      label   = service.execute
125

126 127
      label.try(:id)
    end.compact
128 129
  end

130
  def process_label_ids(attributes, existing_label_ids: nil)
131 132 133
    label_ids = attributes.delete(:label_ids)
    add_label_ids = attributes.delete(:add_label_ids)
    remove_label_ids = attributes.delete(:remove_label_ids)
134

135
    new_label_ids = existing_label_ids || label_ids || []
136

137 138 139 140 141 142
    if add_label_ids.blank? && remove_label_ids.blank?
      new_label_ids = label_ids if label_ids
    else
      new_label_ids |= add_label_ids if add_label_ids
      new_label_ids -= remove_label_ids if remove_label_ids
    end
143 144 145 146

    new_label_ids
  end

147 148 149 150
  def available_labels
    LabelsFinder.new(current_user, project_id: @project.id).execute
  end

151
  def merge_quick_actions_into_params!(issuable)
D
Douwe Maan 已提交
152
    description, command_params =
153 154
      QuickActions::InterpretService.new(project, current_user)
        .execute(params[:description], issuable)
155

156
    # Avoid a description already set on an issuable to be overwritten by a nil
157
    params[:description] = description if params.key?(:description)
D
Douwe Maan 已提交
158 159

    params.merge!(command_params)
160 161
  end

162
  def create_issuable(issuable, attributes, label_ids:)
163
    issuable.with_transaction_returning_status do
164 165 166 167 168
      if issuable.save
        issuable.update_attributes(label_ids: label_ids)
      end
    end
  end
169

170
  def create(issuable)
171
    merge_quick_actions_into_params!(issuable)
172
    filter_params(issuable)
173

174 175
    params.delete(:state_event)
    params[:author] ||= current_user
176

177 178 179 180 181 182 183 184
    label_ids = process_label_ids(params)

    issuable.assign_attributes(params)

    before_create(issuable)

    if params.present? && create_issuable(issuable, params, label_ids: label_ids)
      after_create(issuable)
185 186
      issuable.create_cross_references!(current_user)
      execute_hooks(issuable)
187
      invalidate_cache_counts(issuable, users: issuable.assignees)
188 189 190 191
    end

    issuable
  end
192

193 194 195 196 197 198 199
  def before_create(issuable)
    # To be overridden by subclasses
  end

  def after_create(issuable)
    # To be overridden by subclasses
  end
200

201
  def before_update(issuable)
202 203 204
    # To be overridden by subclasses
  end

205 206
  def after_update(issuable)
    # To be overridden by subclasses
207 208
  end

209 210
  def update(issuable)
    change_state(issuable)
211
    change_subscription(issuable)
212
    change_todo(issuable)
M
mhasbini 已提交
213
    toggle_award(issuable)
214
    filter_params(issuable)
215
    old_labels = issuable.labels.to_a
216
    old_mentioned_users = issuable.mentioned_users.to_a
217
    old_assignees = issuable.assignees.to_a
218

219 220
    label_ids = process_label_ids(params, existing_label_ids: issuable.label_ids)
    params[:label_ids] = label_ids if labels_changing?(issuable.label_ids, label_ids)
221

222
    if issuable.changed? || params.present?
223 224
      issuable.assign_attributes(params.merge(updated_by: current_user))

225
      if has_title_or_description_changed?(issuable)
226
        issuable.assign_attributes(last_edited_at: Time.now, last_edited_by: current_user)
227 228
      end

229
      before_update(issuable)
230

231 232 233 234 235 236
      if issuable.with_transaction_returning_status { issuable.save }
        # We do not touch as it will affect a update on updated_at field
        ActiveRecord::Base.no_touching do
          handle_common_system_notes(issuable, old_labels: old_labels)
        end

237 238 239 240 241 242 243
        handle_changes(
          issuable,
          old_labels: old_labels,
          old_mentioned_users: old_mentioned_users,
          old_assignees: old_assignees
        )

244 245
        new_assignees = issuable.assignees.to_a
        affected_assignees = (old_assignees + new_assignees) - (old_assignees & new_assignees)
246

247 248 249
        # Don't clear the project cache, because it will be handled by the
        # appropriate service (close / reopen / merge / etc.).
        invalidate_cache_counts(issuable, users: affected_assignees.compact, skip_project_cache: true)
250 251 252 253
        after_update(issuable)
        issuable.create_new_cross_references!(current_user)
        execute_hooks(issuable, 'update')
      end
254 255 256 257 258
    end

    issuable
  end

259 260 261 262
  def labels_changing?(old_label_ids, new_label_ids)
    old_label_ids.sort != new_label_ids.sort
  end

263 264 265 266
  def has_title_or_description_changed?(issuable)
    issuable.title_changed? || issuable.description_changed?
  end

267 268 269 270 271 272 273 274
  def change_state(issuable)
    case params.delete(:state_event)
    when 'reopen'
      reopen_service.new(project, current_user, {}).execute(issuable)
    when 'close'
      close_service.new(project, current_user, {}).execute(issuable)
    end
  end
275

276 277 278
  def change_subscription(issuable)
    case params.delete(:subscription_event)
    when 'subscribe'
279
      issuable.subscribe(current_user, project)
280
    when 'unsubscribe'
281
      issuable.unsubscribe(current_user, project)
282 283 284
    end
  end

285 286
  def change_todo(issuable)
    case params.delete(:todo_event)
287
    when 'add'
288 289 290
      todo_service.mark_todo(issuable, current_user)
    when 'done'
      todo = TodosFinder.new(current_user).execute.find_by(target: issuable)
291
      todo_service.mark_todos_as_done_by_ids(todo, current_user) if todo
292 293 294
    end
  end

M
mhasbini 已提交
295 296 297 298 299 300 301 302
  def toggle_award(issuable)
    award = params.delete(:emoji_award)
    if award
      todo_service.new_award_emoji(issuable, current_user)
      issuable.toggle_award_emoji(award, current_user)
    end
  end

303
  def has_changes?(issuable, old_labels: [], old_assignees: [])
304 305 306 307 308 309
    valid_attrs = [:title, :description, :assignee_id, :milestone_id, :target_branch]

    attrs_changed = valid_attrs.any? do |attr|
      issuable.previous_changes.include?(attr.to_s)
    end

310
    labels_changed = issuable.labels != old_labels
311

312 313 314
    assignees_changed = issuable.assignees != old_assignees

    attrs_changed || labels_changed || assignees_changed
315 316
  end

317
  def handle_common_system_notes(issuable, old_labels: [])
318 319 320 321
    if issuable.previous_changes.include?('title')
      create_title_change_note(issuable, issuable.previous_changes['title'].first)
    end

322
    if issuable.previous_changes.include?('description')
323 324 325 326 327 328 329
      if issuable.tasks? && issuable.updated_tasks.any?
        create_task_status_note(issuable)
      else
        # TODO: Show this note if non-task content was modified.
        # https://gitlab.com/gitlab-org/gitlab-ce/issues/33577
        create_description_change_note(issuable)
      end
330
    end
331

332 333 334 335 336 337 338 339
    if issuable.previous_changes.include?('time_estimate')
      create_time_estimate_note(issuable)
    end

    if issuable.time_spent?
      create_time_spent_note(issuable)
    end

340
    create_labels_note(issuable, old_labels) if issuable.labels != old_labels
341
  end
342

343
  def invalidate_cache_counts(issuable, users: [], skip_project_cache: false)
344 345 346
    users.each do |user|
      user.public_send("invalidate_#{issuable.model_name.singular}_cache_counts")
    end
347 348 349 350 351 352 353 354 355

    unless skip_project_cache
      case issuable
      when Issue
        IssuesFinder.new(nil, project_id: issuable.project_id).clear_caches!
      when MergeRequest
        MergeRequestsFinder.new(nil, project_id: issuable.target_project_id).clear_caches!
      end
    end
356
  end
357
end