pipeline_spec.rb 15.4 KB
Newer Older
D
Douwe Maan 已提交
1 2
require 'spec_helper'

3
describe Ci::Pipeline, models: true do
K
Kamil Trzcinski 已提交
4
  let(:project) { FactoryGirl.create :empty_project }
5
  let(:pipeline) { FactoryGirl.create :ci_empty_pipeline, status: 'created', project: project }
D
Douwe Maan 已提交
6

K
Kamil Trzcinski 已提交
7
  it { is_expected.to belong_to(:project) }
8 9
  it { is_expected.to belong_to(:user) }

10
  it { is_expected.to have_many(:statuses) }
K
Kamil Trzcinski 已提交
11
  it { is_expected.to have_many(:trigger_requests) }
D
Dmitriy Zaporozhets 已提交
12
  it { is_expected.to have_many(:builds) }
13

D
Dmitriy Zaporozhets 已提交
14
  it { is_expected.to validate_presence_of :sha }
K
Kamil Trzcinski 已提交
15
  it { is_expected.to validate_presence_of :status }
D
Douwe Maan 已提交
16

D
Dmitriy Zaporozhets 已提交
17 18 19
  it { is_expected.to respond_to :git_author_name }
  it { is_expected.to respond_to :git_author_email }
  it { is_expected.to respond_to :short_sha }
D
Douwe Maan 已提交
20

21 22
  it { is_expected.to delegate_method(:stages).to(:statuses) }

23
  describe '#valid_commit_sha' do
D
Douwe Maan 已提交
24 25
    context 'commit.sha can not start with 00000000' do
      before do
26 27
        pipeline.sha = '0' * 40
        pipeline.valid_commit_sha
D
Douwe Maan 已提交
28 29
      end

30
      it('commit errors should not be empty') { expect(pipeline.errors).not_to be_empty }
D
Douwe Maan 已提交
31 32 33
    end
  end

34
  describe '#short_sha' do
35
    subject { pipeline.short_sha }
D
Douwe Maan 已提交
36

D
Dmitriy Zaporozhets 已提交
37 38 39
    it 'has 8 items' do
      expect(subject.size).to eq(8)
    end
40
    it { expect(pipeline.sha).to start_with(subject) }
D
Douwe Maan 已提交
41 42
  end

43
  describe '#retried' do
44
    subject { pipeline.retried }
K
Kamil Trzcinski 已提交
45 46

    before do
47 48
      @build1 = FactoryGirl.create :ci_build, pipeline: pipeline, name: 'deploy'
      @build2 = FactoryGirl.create :ci_build, pipeline: pipeline, name: 'deploy'
K
Kamil Trzcinski 已提交
49 50 51
    end

    it 'returns old builds' do
52
      is_expected.to contain_exactly(@build1)
K
Kamil Trzcinski 已提交
53 54 55
    end
  end

D
Douwe Maan 已提交
56
  describe "coverage" do
K
Kamil Trzcinski 已提交
57
    let(:project) { FactoryGirl.create :empty_project, build_coverage_regex: "/.*/" }
58
    let(:pipeline) { FactoryGirl.create :ci_empty_pipeline, project: project }
D
Douwe Maan 已提交
59 60

    it "calculates average when there are two builds with coverage" do
61 62 63
      FactoryGirl.create :ci_build, name: "rspec", coverage: 30, pipeline: pipeline
      FactoryGirl.create :ci_build, name: "rubocop", coverage: 40, pipeline: pipeline
      expect(pipeline.coverage).to eq("35.00")
D
Douwe Maan 已提交
64 65 66
    end

    it "calculates average when there are two builds with coverage and one with nil" do
67 68 69 70
      FactoryGirl.create :ci_build, name: "rspec", coverage: 30, pipeline: pipeline
      FactoryGirl.create :ci_build, name: "rubocop", coverage: 40, pipeline: pipeline
      FactoryGirl.create :ci_build, pipeline: pipeline
      expect(pipeline.coverage).to eq("35.00")
D
Douwe Maan 已提交
71 72 73
    end

    it "calculates average when there are two builds with coverage and one is retried" do
74 75 76 77
      FactoryGirl.create :ci_build, name: "rspec", coverage: 30, pipeline: pipeline
      FactoryGirl.create :ci_build, name: "rubocop", coverage: 30, pipeline: pipeline
      FactoryGirl.create :ci_build, name: "rubocop", coverage: 40, pipeline: pipeline
      expect(pipeline.coverage).to eq("35.00")
D
Douwe Maan 已提交
78 79 80
    end

    it "calculates average when there is one build without coverage" do
81 82
      FactoryGirl.create :ci_build, pipeline: pipeline
      expect(pipeline.coverage).to be_nil
D
Douwe Maan 已提交
83 84
    end
  end
K
Kamil Trzcinski 已提交
85 86

  describe '#retryable?' do
87
    subject { pipeline.retryable? }
K
Kamil Trzcinski 已提交
88 89 90

    context 'no failed builds' do
      before do
91
        create_build('rspec', 'success')
K
Kamil Trzcinski 已提交
92 93
      end

94
      it 'is not retryable' do
K
Kamil Trzcinski 已提交
95 96
        is_expected.to be_falsey
      end
97 98 99 100 101 102 103 104 105 106

      context 'one canceled job' do
        before do
          create_build('rubocop', 'canceled')
        end

        it 'is retryable' do
          is_expected.to be_truthy
        end
      end
K
Kamil Trzcinski 已提交
107 108 109 110
    end

    context 'with failed builds' do
      before do
111 112
        create_build('rspec', 'running')
        create_build('rubocop', 'failed')
K
Kamil Trzcinski 已提交
113 114
      end

115
      it 'is retryable' do
K
Kamil Trzcinski 已提交
116 117 118
        is_expected.to be_truthy
      end
    end
119 120 121 122

    def create_build(name, status)
      create(:ci_build, name: name, status: status, pipeline: pipeline)
    end
K
Kamil Trzcinski 已提交
123 124 125
  end

  describe '#stages' do
126 127
    let(:pipeline2) { FactoryGirl.create :ci_pipeline, project: project }
    subject { CommitStatus.where(pipeline: [pipeline, pipeline2]).stages }
K
Kamil Trzcinski 已提交
128 129

    before do
130 131
      FactoryGirl.create :ci_build, pipeline: pipeline2, stage: 'test', stage_idx: 1
      FactoryGirl.create :ci_build, pipeline: pipeline, stage: 'build', stage_idx: 0
K
Kamil Trzcinski 已提交
132 133 134 135 136 137 138
    end

    it 'return all stages' do
      is_expected.to eq(%w(build test))
    end
  end

139
  describe 'state machine' do
140
    let(:current) { Time.now.change(usec: 0) }
K
Kamil Trzcinski 已提交
141 142 143
    let(:build) { create_build('build1', 0) }
    let(:build_b) { create_build('build2', 0) }
    let(:build_c) { create_build('build3', 0) }
K
Kamil Trzcinski 已提交
144

145 146
    describe '#duration' do
      before do
147
        travel_to(current + 30) do
K
Kamil Trzcinski 已提交
148 149 150 151
          build.run!
          build.success!
          build_b.run!
          build_c.run!
L
Lin Jen-Shin 已提交
152 153
        end

154
        travel_to(current + 40) do
K
Kamil Trzcinski 已提交
155
          build_b.drop!
156
        end
157

158
        travel_to(current + 70) do
K
Kamil Trzcinski 已提交
159
          build_c.success!
160
        end
161 162 163
      end

      it 'matches sum of builds duration' do
164 165
        pipeline.reload

166
        expect(pipeline.duration).to eq(40)
167
      end
K
Kamil Trzcinski 已提交
168 169
    end

170 171 172
    describe '#started_at' do
      it 'updates on transitioning to running' do
        build.run
K
Kamil Trzcinski 已提交
173

174 175 176
        expect(pipeline.reload.started_at).not_to be_nil
      end

177
      it 'does not update on transitioning to success' do
178 179 180
        build.success

        expect(pipeline.reload.started_at).to be_nil
K
Kamil Trzcinski 已提交
181 182 183
      end
    end

184 185 186
    describe '#finished_at' do
      it 'updates on transitioning to success' do
        build.success
K
Kamil Trzcinski 已提交
187

188
        expect(pipeline.reload.finished_at).not_to be_nil
K
Kamil Trzcinski 已提交
189 190
      end

191
      it 'does not update on transitioning to running' do
192 193 194
        build.run

        expect(pipeline.reload.finished_at).to be_nil
K
Kamil Trzcinski 已提交
195 196
      end
    end
197

198
    describe 'merge request metrics' do
199 200 201 202
      let(:project) { FactoryGirl.create :project }
      let(:pipeline) { FactoryGirl.create(:ci_empty_pipeline, status: 'created', project: project, ref: 'master', sha: project.repository.commit('master').id) }
      let!(:merge_request) { create(:merge_request, source_project: project, source_branch: pipeline.ref) }

203 204 205
      before do
        expect(PipelineMetricsWorker).to receive(:perform_async).with(pipeline.id)
      end
206

207 208 209
      context 'when transitioning to running' do
        it 'schedules metrics workers' do
          pipeline.run
210 211 212 213
        end
      end

      context 'when transitioning to success' do
214 215
        it 'schedules metrics workers' do
          pipeline.succeed
216 217 218
        end
      end
    end
219

220
    def create_build(name, queued_at = current, started_from = 0)
L
Lin Jen-Shin 已提交
221 222 223
      create(:ci_build,
             name: name,
             pipeline: pipeline,
224 225
             queued_at: queued_at,
             started_at: queued_at + started_from)
L
Lin Jen-Shin 已提交
226
    end
K
Kamil Trzcinski 已提交
227
  end
K
Kamil Trzcinski 已提交
228 229

  describe '#branch?' do
230
    subject { pipeline.branch? }
K
Kamil Trzcinski 已提交
231 232 233

    context 'is not a tag' do
      before do
234
        pipeline.tag = false
K
Kamil Trzcinski 已提交
235 236 237 238 239 240 241 242 243
      end

      it 'return true when tag is set to false' do
        is_expected.to be_truthy
      end
    end

    context 'is not a tag' do
      before do
244
        pipeline.tag = true
K
Kamil Trzcinski 已提交
245 246 247 248 249 250 251
      end

      it 'return false when tag is set to true' do
        is_expected.to be_falsey
      end
    end
  end
252

253 254
  context 'with non-empty project' do
    let(:project) { create(:project) }
255 256 257 258 259 260 261

    let(:pipeline) do
      create(:ci_pipeline,
             project: project,
             ref: project.default_branch,
             sha: project.commit.sha)
    end
262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282

    describe '#latest?' do
      context 'with latest sha' do
        it 'returns true' do
          expect(pipeline).to be_latest
        end
      end

      context 'with not latest sha' do
        before do
          pipeline.update(
            sha: project.commit("#{project.default_branch}~1").sha)
        end

        it 'returns false' do
          expect(pipeline).not_to be_latest
        end
      end
    end
  end

283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
  describe '#manual_actions' do
    subject { pipeline.manual_actions }

    it 'when none defined' do
      is_expected.to be_empty
    end

    context 'when action defined' do
      let!(:manual) { create(:ci_build, :manual, pipeline: pipeline, name: 'deploy') }

      it 'returns one action' do
        is_expected.to contain_exactly(manual)
      end

      context 'there are multiple of the same name' do
        let!(:manual2) { create(:ci_build, :manual, pipeline: pipeline, name: 'deploy') }

        it 'returns latest one' do
          is_expected.to contain_exactly(manual2)
        end
      end
    end
  end
306

C
Connor Shea 已提交
307 308
  describe '#has_warnings?' do
    subject { pipeline.has_warnings? }
309 310 311

    context 'build which is allowed to fail fails' do
      before do
C
Connor Shea 已提交
312 313
        create :ci_build, :success, pipeline: pipeline, name: 'rspec'
        create :ci_build, :allowed_to_fail, :failed, pipeline: pipeline, name: 'rubocop'
314
      end
315

316 317 318 319 320 321 322
      it 'returns true' do
        is_expected.to be_truthy
      end
    end

    context 'build which is allowed to fail succeeds' do
      before do
C
Connor Shea 已提交
323 324
        create :ci_build, :success, pipeline: pipeline, name: 'rspec'
        create :ci_build, :allowed_to_fail, :success, pipeline: pipeline, name: 'rubocop'
325
      end
326

327 328 329 330
      it 'returns false' do
        is_expected.to be_falsey
      end
    end
C
Connor Shea 已提交
331 332 333 334 335 336 337 338 339 340 341 342

    context 'build is retried and succeeds' do
      before do
        create :ci_build, :success, pipeline: pipeline, name: 'rubocop'
        create :ci_build, :failed, pipeline: pipeline, name: 'rspec'
        create :ci_build, :success, pipeline: pipeline, name: 'rspec'
      end

      it 'returns false' do
        is_expected.to be_falsey
      end
    end
343
  end
344 345 346 347 348 349 350

  describe '#status' do
    let!(:build) { create(:ci_build, :created, pipeline: pipeline, name: 'test') }

    subject { pipeline.reload.status }

    context 'on queuing' do
351 352 353
      before do
        build.enqueue
      end
354 355 356 357 358 359

      it { is_expected.to eq('pending') }
    end

    context 'on run' do
      before do
360
        build.enqueue
361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
        build.run
      end

      it { is_expected.to eq('running') }
    end

    context 'on drop' do
      before do
        build.drop
      end

      it { is_expected.to eq('failed') }
    end

    context 'on success' do
      before do
        build.success
      end

      it { is_expected.to eq('success') }
    end

    context 'on cancel' do
      before do
        build.cancel
      end

      it { is_expected.to eq('canceled') }
    end
390 391 392 393 394 395 396 397 398 399 400 401 402

    context 'on failure and build retry' do
      before do
        build.drop
        Ci::Build.retry(build)
      end

      # We are changing a state: created > failed > running
      # Instead of: created > failed > pending
      # Since the pipeline already run, so it should not be pending anymore

      it { is_expected.to eq('running') }
    end
403
  end
404

405
  describe '#execute_hooks' do
L
Lin Jen-Shin 已提交
406 407
    let!(:build_a) { create_build('a', 0) }
    let!(:build_b) { create_build('b', 1) }
K
Kamil Trzcinski 已提交
408

409 410 411 412 413 414 415 416 417 418 419
    let!(:hook) do
      create(:project_hook, project: project, pipeline_events: enabled)
    end

    before do
      ProjectWebHookWorker.drain
    end

    context 'with pipeline hooks enabled' do
      let(:enabled) { true }

K
Kamil Trzcinski 已提交
420 421 422 423
      before do
        WebMock.stub_request(:post, hook.url)
      end

424
      context 'with multiple builds' do
K
Kamil Trzcinski 已提交
425 426
        context 'when build is queued' do
          before do
427 428
            build_a.enqueue
            build_b.enqueue
K
Kamil Trzcinski 已提交
429
          end
430

L
Lin Jen-Shin 已提交
431
          it 'receives a pending event once' do
432
            expect(WebMock).to have_requested_pipeline_hook('pending').once
K
Kamil Trzcinski 已提交
433 434
          end
        end
435

K
Kamil Trzcinski 已提交
436 437
        context 'when build is run' do
          before do
438
            build_a.enqueue
K
Kamil Trzcinski 已提交
439
            build_a.run
440
            build_b.enqueue
K
Kamil Trzcinski 已提交
441 442
            build_b.run
          end
443

L
Lin Jen-Shin 已提交
444
          it 'receives a running event once' do
445
            expect(WebMock).to have_requested_pipeline_hook('running').once
K
Kamil Trzcinski 已提交
446
          end
447 448
        end

K
Kamil Trzcinski 已提交
449 450 451
        context 'when all builds succeed' do
          before do
            build_a.success
K
Kamil Trzcinski 已提交
452 453 454

            # We have to reload build_b as this is in next stage and it gets triggered by PipelineProcessWorker
            build_b.reload.success
K
Kamil Trzcinski 已提交
455 456
          end

L
Lin Jen-Shin 已提交
457
          it 'receives a success event once' do
458
            expect(WebMock).to have_requested_pipeline_hook('success').once
K
Kamil Trzcinski 已提交
459
          end
460 461
        end

L
Lin Jen-Shin 已提交
462 463 464 465 466
        context 'when stage one failed' do
          before do
            build_a.drop
          end

L
Lin Jen-Shin 已提交
467
          it 'receives a failed event once' do
L
Lin Jen-Shin 已提交
468 469 470 471
            expect(WebMock).to have_requested_pipeline_hook('failed').once
          end
        end

472
        def have_requested_pipeline_hook(status)
K
Kamil Trzcinski 已提交
473
          have_requested(:post, hook.url).with do |req|
474 475 476 477
            json_body = JSON.parse(req.body)
            json_body['object_attributes']['status'] == status &&
              json_body['builds'].length == 2
          end
478
        end
479
      end
480 481 482 483 484
    end

    context 'with pipeline hooks disabled' do
      let(:enabled) { false }

K
Kamil Trzcinski 已提交
485
      before do
486 487
        build_a.enqueue
        build_b.enqueue
K
Kamil Trzcinski 已提交
488 489
      end

490 491 492 493
      it 'did not execute pipeline_hook after touched' do
        expect(WebMock).not_to have_requested(:post, hook.url)
      end
    end
K
Kamil Trzcinski 已提交
494

L
Lin Jen-Shin 已提交
495 496 497 498 499 500
    def create_build(name, stage_idx)
      create(:ci_build,
             :created,
             pipeline: pipeline,
             name: name,
             stage_idx: stage_idx)
K
Kamil Trzcinski 已提交
501
    end
502
  end
503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526

  describe "#merge_requests" do
    let(:project) { FactoryGirl.create :project }
    let(:pipeline) { FactoryGirl.create(:ci_empty_pipeline, status: 'created', project: project, ref: 'master', sha: project.repository.commit('master').id) }

    it "returns merge requests whose `diff_head_sha` matches the pipeline's SHA" do
      merge_request = create(:merge_request, source_project: project, source_branch: pipeline.ref)

      expect(pipeline.merge_requests).to eq([merge_request])
    end

    it "doesn't return merge requests whose source branch doesn't match the pipeline's ref" do
      create(:merge_request, source_project: project, source_branch: 'feature', target_branch: 'master')

      expect(pipeline.merge_requests).to be_empty
    end

    it "doesn't return merge requests whose `diff_head_sha` doesn't match the pipeline's SHA" do
      create(:merge_request, source_project: project, source_branch: pipeline.ref)
      allow_any_instance_of(MergeRequest).to receive(:diff_head_sha) { '97de212e80737a608d939f648d959671fb0a0142b' }

      expect(pipeline.merge_requests).to be_empty
    end
  end
527 528

  describe 'notifications when pipeline success or failed' do
L
Lin Jen-Shin 已提交
529 530 531 532 533 534 535 536 537
    let(:project) { create(:project) }

    let(:pipeline) do
      create(:ci_pipeline,
             project: project,
             sha: project.commit('master').sha,
             user: create(:user))
    end

538
    before do
539
      reset_delivered_emails!
540

541 542
      project.team << [pipeline.user, Gitlab::Access::DEVELOPER]

543 544 545 546
      perform_enqueued_jobs do
        pipeline.enqueue
        pipeline.run
      end
547 548 549 550
    end

    shared_examples 'sending a notification' do
      it 'sends an email' do
551
        should_only_email(pipeline.user, kind: :bcc)
552 553 554 555 556
      end
    end

    shared_examples 'not sending any notification' do
      it 'does not send any email' do
557
        should_not_email_anyone
558 559 560 561 562 563
      end
    end

    context 'with success pipeline' do
      before do
        perform_enqueued_jobs do
L
Lin Jen-Shin 已提交
564
          pipeline.succeed
565 566
        end
      end
L
Lin Jen-Shin 已提交
567 568

      it_behaves_like 'sending a notification'
569 570 571 572 573 574 575 576
    end

    context 'with failed pipeline' do
      before do
        perform_enqueued_jobs do
          pipeline.drop
        end
      end
L
Lin Jen-Shin 已提交
577 578

      it_behaves_like 'sending a notification'
579 580 581 582 583 584 585 586
    end

    context 'with skipped pipeline' do
      before do
        perform_enqueued_jobs do
          pipeline.skip
        end
      end
L
Lin Jen-Shin 已提交
587 588

      it_behaves_like 'not sending any notification'
589 590 591 592 593 594 595 596
    end

    context 'with cancelled pipeline' do
      before do
        perform_enqueued_jobs do
          pipeline.cancel
        end
      end
L
Lin Jen-Shin 已提交
597 598

      it_behaves_like 'not sending any notification'
599 600
    end
  end
D
Douwe Maan 已提交
601
end