issues_controller.rb 8.4 KB
Newer Older
1
class Projects::IssuesController < Projects::ApplicationController
D
Douwe Maan 已提交
2
  include RendersNotes
3
  include ToggleSubscriptionAction
4
  include IssuableActions
5
  include ToggleAwardEmoji
6
  include IssuableCollections
7
  include SpammableActions
8

9 10
  prepend_before_action :authenticate_user!, only: [:new]

11
  before_action :redirect_to_external_issue_tracker, only: [:index, :new]
12
  before_action :check_issues_available!
13
  before_action :issue, except: [:index, :new, :create, :bulk_update]
D
Dmitriy Zaporozhets 已提交
14 15

  # Allow write(create) issue
D
Dmitriy Zaporozhets 已提交
16
  before_action :authorize_create_issue!, only: [:new, :create]
D
Dmitriy Zaporozhets 已提交
17 18

  # Allow modify issue
D
Dmitriy Zaporozhets 已提交
19
  before_action :authorize_update_issue!, only: [:edit, :update]
D
Dmitriy Zaporozhets 已提交
20

21 22 23
  # Allow create a new branch and empty WIP merge request from current issue
  before_action :authorize_create_merge_request!, only: [:create_merge_request]

D
Dmitriy Zaporozhets 已提交
24
  respond_to :html
G
gitlabhq 已提交
25 26

  def index
27 28 29
    @collection_type    = "Issue"
    @issues             = issues_collection
    @issues             = @issues.page(params[:page])
30
    @issuable_meta_data = issuable_meta_data(@issues, @collection_type)
31

32
    if @issues.out_of_range? && @issues.total_pages != 0
33
      return redirect_to url_for(params.merge(page: @issues.total_pages, only_path: true))
34
    end
35

36
    if params[:label_name].present?
37 38
      @labels = LabelsFinder.new(current_user, project_id: @project.id, title: params[:label_name]).execute
    end
G
gitlabhq 已提交
39

40 41 42 43 44 45 46 47 48 49 50 51
    @users = []

    if params[:assignee_id].present?
      assignee = User.find_by_id(params[:assignee_id])
      @users.push(assignee) if assignee
    end

    if params[:author_id].present?
      author = User.find_by_id(params[:author_id])
      @users.push(author) if author
    end

G
gitlabhq 已提交
52
    respond_to do |format|
D
Dmitriy Zaporozhets 已提交
53
      format.html
54
      format.atom { render layout: 'xml.atom' }
D
Dmitriy Zaporozhets 已提交
55 56
      format.json do
        render json: {
57
          html: view_to_html_string("projects/issues/_issues"),
P
Phil Hughes 已提交
58
          labels: @labels.as_json(methods: :text_color)
D
Dmitriy Zaporozhets 已提交
59 60
        }
      end
G
gitlabhq 已提交
61 62 63 64
    end
  end

  def new
65
    params[:issue] ||= ActionController::Parameters.new(
66
      assignee_ids: ""
67
    )
68
    build_params = issue_params.merge(
B
Bob Van Landuyt 已提交
69
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
70
      discussion_to_resolve: params[:discussion_to_resolve]
71
    )
72
    service = Issues::BuildService.new(project, current_user, build_params)
73

74
    @issue = @noteable = service.execute
B
Bob Van Landuyt 已提交
75
    @merge_request_to_resolve_discussions_of = service.merge_request_to_resolve_discussions_of
76
    @discussion_to_resolve = service.discussions_to_resolve.first if params[:discussion_to_resolve]
77

G
gitlabhq 已提交
78 79 80 81 82 83 84 85
    respond_with(@issue)
  end

  def edit
    respond_with(@issue)
  end

  def show
86
    @noteable = @issue
87
    @note     = @project.notes.new(noteable: @issue)
G
gitlabhq 已提交
88

89 90
    @discussions = @issue.discussions
    @notes = prepare_notes_for_rendering(@discussions.flat_map(&:notes))
91

92 93 94
    respond_to do |format|
      format.html
      format.json do
95
        render json: IssueSerializer.new.represent(@issue)
96 97
      end
    end
G
gitlabhq 已提交
98 99 100
  end

  def create
101
    create_params = issue_params.merge(spammable_params).merge(
B
Bob Van Landuyt 已提交
102
      merge_request_to_resolve_discussions_of: params[:merge_request_to_resolve_discussions_of],
103 104 105
      discussion_to_resolve: params[:discussion_to_resolve]
    )

106 107 108
    service = Issues::CreateService.new(project, current_user, create_params)
    @issue = service.execute

109
    if service.discussions_to_resolve.count(&:resolved?) > 0
110
      flash[:notice] = if service.discussion_to_resolve_id
111 112 113 114
                         "Resolved 1 discussion."
                       else
                         "Resolved all discussions."
                       end
115
    end
G
gitlabhq 已提交
116

117
    respond_to do |format|
118
      format.html do
119
        recaptcha_check_with_fallback { render :new }
120
      end
121
      format.js do
122 123
        @link = @issue.attachment.url.to_js
      end
124
    end
G
gitlabhq 已提交
125 126 127
  end

  def update
128 129 130
    update_params = issue_params.merge(spammable_params)

    @issue = Issues::UpdateService.new(project, current_user, update_params).execute(issue)
G
gitlabhq 已提交
131

132 133
    if params[:move_to_project_id].to_i > 0
      new_project = Project.find(params[:move_to_project_id])
134 135
      return render_404 unless issue.can_move?(current_user, new_project)

136
      move_service = Issues::MoveService.new(project, current_user)
137
      @issue = move_service.execute(@issue, new_project)
138
    end
G
gitlabhq 已提交
139 140

    respond_to do |format|
141
      format.html do
142
        recaptcha_check_with_fallback { render :edit }
143
      end
144

145
      format.json do
146
        if @issue.valid?
147
          render json: IssueSerializer.new.represent(@issue)
148 149 150
        else
          render json: { errors: @issue.errors.full_messages }, status: :unprocessable_entity
        end
151
      end
G
gitlabhq 已提交
152
    end
153 154

  rescue ActiveRecord::StaleObjectError
155
    render_conflict_response
G
gitlabhq 已提交
156 157
  end

158 159 160 161 162 163 164 165 166 167 168 169 170 171
  def referenced_merge_requests
    @merge_requests = @issue.referenced_merge_requests(current_user)
    @closed_by_merge_requests = @issue.closed_by_merge_requests(current_user)

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_merge_requests')
        }
      end
    end
  end

  def related_branches
172
    @related_branches = @issue.related_branches(current_user)
173 174 175 176 177 178 179 180 181 182

    respond_to do |format|
      format.json do
        render json: {
          html: view_to_html_string('projects/issues/_related_branches')
        }
      end
    end
  end

183 184 185 186 187 188 189
  def can_create_branch
    can_create = current_user &&
      can?(current_user, :push_code, @project) &&
      @issue.can_be_worked_on?(current_user)

    respond_to do |format|
      format.json do
190
        render json: { can_create_branch: can_create, has_related_branch: @issue.has_related_branch? }
191 192 193 194
      end
    end
  end

195
  def realtime_changes
R
Regis Boudinot 已提交
196
    Gitlab::PollingInterval.set_header(response, interval: 3_000)
R
Regis 已提交
197

198
    response = {
199
      title: view_context.markdown_field(@issue, :title),
R
Regis 已提交
200
      title_text: @issue.title,
201 202
      description: view_context.markdown_field(@issue, :description),
      description_text: @issue.description,
203
      task_status: @issue.task_status
204
    }
205 206 207 208 209 210 211 212

    if @issue.is_edited?
      response[:updated_at] = @issue.updated_at
      response[:updated_by_name] = @issue.last_edited_by.name
      response[:updated_by_path] = user_path(@issue.last_edited_by)
    end

    render json: response
R
Regis Boudinot 已提交
213 214
  end

215 216 217 218 219 220 221 222 223 224
  def create_merge_request
    result = MergeRequests::CreateFromIssueService.new(project, current_user, issue_iid: issue.iid).execute

    if result[:status] == :success
      render json: MergeRequestCreateSerializer.new.represent(result[:merge_request])
    else
      render json: result[:messsage], status: :unprocessable_entity
    end
  end

N
Nihad Abbasov 已提交
225
  protected
G
gitlabhq 已提交
226 227

  def issue
228
    return @issue if defined?(@issue)
229
    # The Sortable default scope causes performance issues when used with find_by
230
    @noteable = @issue ||= @project.issues.where(iid: params[:id]).reorder(nil).take!
231 232 233 234

    return render_404 unless can?(current_user, :read_issue, @issue)

    @issue
G
gitlabhq 已提交
235
  end
236
  alias_method :subscribable_resource, :issue
237
  alias_method :issuable, :issue
238
  alias_method :awardable, :issue
239
  alias_method :spammable, :issue
D
Dmitriy Zaporozhets 已提交
240

241 242 243 244
  def spammable_path
    project_issue_path(@project, @issue)
  end

D
Dmitriy Zaporozhets 已提交
245
  def authorize_update_issue!
246
    return render_404 unless can?(current_user, :update_issue, @issue)
D
Dmitriy Zaporozhets 已提交
247 248
  end

D
Dmitriy Zaporozhets 已提交
249 250
  def authorize_admin_issues!
    return render_404 unless can?(current_user, :admin_issue, @project)
D
Dmitriy Zaporozhets 已提交
251
  end
252

253 254 255 256
  def authorize_create_merge_request!
    return render_404 unless can?(current_user, :push_code, @project) && @issue.can_be_worked_on?(current_user)
  end

257
  def check_issues_available!
F
Felipe Artur 已提交
258
    return render_404 unless @project.feature_available?(:issues, current_user) && @project.default_issues_tracker?
259
  end
260

261
  def redirect_to_external_issue_tracker
262
    external = @project.external_issue_tracker
263

264 265 266 267 268
    return unless external

    if action_name == 'new'
      redirect_to external.new_issue_path
    else
269
      redirect_to external.project_path
270
    end
271 272
  end

273
  def issue_params
274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289
    params.require(:issue).permit(*issue_params_attributes)
  end

  def issue_params_attributes
    %i[
      title
      assignee_id
      position
      description
      confidential
      milestone_id
      due_date
      state_event
      task_num
      lock_version
    ] + [{ label_ids: [], assignee_ids: [] }]
290
  end
291 292 293 294 295 296

  def authenticate_user!
    return if current_user

    notice = "Please sign in to create the new issue."

297 298 299 300
    if request.get? && !request.xhr?
      store_location_for :user, request.fullpath
    end

301 302
    redirect_to new_user_session_path, notice: notice
  end
G
gitlabhq 已提交
303
end